dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4770 Commits

Author SHA1 Message Date
Dan Rubel c2d88d024f Improve class implements/with recovery 
Change-Id: I32beebbb9cc5ecec188a5a1557a2ae510d7ba214
Reviewed-on: https://dart-review.googlesource.com/54602
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-10 20:41:34 +00:00
Dan Rubel 04af8ace52 Improve top level const/final/var name recovery 
Change-Id: Ie07ca020a5f5a6c3abbe2ee48bd83c4e3ea4075c
Reviewed-on: https://dart-review.googlesource.com/54600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-10 20:07:25 +00:00
Dan Rubel 17c50d45fa Remove most uses of kernel.Expression 
I'm landing Peter's change:
https://dart-review.googlesource.com/c/sdk/+/54460

Change-Id: I2228d0a0156f67e41515c41788c0b855f1a2a437
Reviewed-on: https://dart-review.googlesource.com/54544
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-10 14:55:50 +00:00
Dan Rubel 6b5361c334 Improve recovery of enum declaration 
Change-Id: I8709e76c38d778d97673e11a8d89d424611a292b
Reviewed-on: https://dart-review.googlesource.com/54543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-10 13:57:51 +00:00
Jenny Messerly e998c56a72 fix #32980, better error messages for type errors at runtime 
Change-Id: I4666c82b706dcaa963f4acf1c1c5d770e0ab1c6a
Reviewed-on: https://dart-review.googlesource.com/54101
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
 2018-05-10 00:13:27 +00:00
Dan Rubel 5951f1e4f1 Improve enum declaration identifier recovery 
Change-Id: Ib0646fdd405dbe4fe0bd6cb788c0cbfe4d20fc1b
Reviewed-on: https://dart-review.googlesource.com/54542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-09 20:58:28 +00:00
Dan Rubel 1860096702 Use correct type arguments for Forest. 
I'm landing Peter's change:
https://dart-review.googlesource.com/c/sdk/+/54400

Change-Id: I337d4b63a085fbf06f5d5cf93b13b60f70e7cb4f
Reviewed-on: https://dart-review.googlesource.com/54541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-09 20:57:07 +00:00
Dan Rubel a4772ea629 Refer to Expression and Statement via prefix 
I'm landing Peter's change:
https://dart-review.googlesource.com/c/sdk/+/54388

Change-Id: Ia3c842d56fb2ea628351cba09180bc351d4b5b4b
Reviewed-on: https://dart-review.googlesource.com/54540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-09 19:58:27 +00:00
Brian Wilkerson bedf640eca Address review comments from previous CLs 
Change-Id: I07faabb0f59fc716175ab6abfbbc76c09beffef2
Reviewed-on: https://dart-review.googlesource.com/54302
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-09 18:49:37 +00:00
Kevin Millikin 8dbe716085 Remove the unused GenericCovariantInterface bit 
None of the back ends are using it and it imposes a cost to have to
compute it and try to preserve it.

Change-Id: I217e1191b535829021fa11f2698cadd8d4baf1c8
Reviewed-on: https://dart-review.googlesource.com/54383
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-09 15:04:43 +00:00
Samir Jindel b5154dd01e Revert "[vm/kernel] Expression execution through Kernel. 
This reverts commit afd0a52a5a.

Reason for revert: Breaks kernel-a32 and kernel-rbc bots

Original change's description:
> [vm/kernel] Expression execution through Kernel.
> 
> Change-Id: Id90c91cb3b71f9ce703e21fe48147b86a7764d34
> Reviewed-on: https://dart-review.googlesource.com/42562
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Alexander Aprelev <aam@google.com>
> Commit-Queue: Samir Jindel <sjindel@google.com>

TBR=aam@google.com,rmacnak@google.com,sjindel@google.com

Change-Id: If1ecad6145aeab81d5d3581798a628ead0265c38
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/54420
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-05-09 12:41:00 +00:00
Dmitry Stefantsov b25e12ddc6 [fasta] Remove BuiltTypeBuilder 
Change-Id: I8a3678e37ef0c51023c5c52f1fc8e7d11d005c86
Reviewed-on: https://dart-review.googlesource.com/54382
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-09 10:36:12 +00:00
Samir Jindel afd0a52a5a [vm/kernel] Expression execution through Kernel. 
Change-Id: Id90c91cb3b71f9ce703e21fe48147b86a7764d34
Reviewed-on: https://dart-review.googlesource.com/42562
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-05-09 10:27:52 +00:00
Peter von der Ahé ee0a2cd8bc Restore type arguments on Forest 
Change-Id: I3bdce8f470e31e4b95a028842a3f188102b74ba4
Reviewed-on: https://dart-review.googlesource.com/54386
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-05-09 10:01:47 +00:00
Dmitry Stefantsov fe3f87f192 [fasta] Reland "Handle annotations on formals and variables" 
The original CL: https://dart-review.googlesource.com/c/sdk/+/51840

Bug: http://dartbug.com/28434
Change-Id: I0812ef4223337f5bf72218dfac0f26f76a6b9df1
Reviewed-on: https://dart-review.googlesource.com/52449
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2018-05-09 09:53:42 +00:00
Martin Kustermann 039e8a1755 [vm/kernel] Enable kernel2kernel "constants" transformation in AOT mode (after running TFA) 
This CL also uses the newer `onProblem` error reporting mechanism, which supports contexts.

The errors by the constant evaluator are formatted e.g. like this:

    .../language_2/compile_time_constant_o_test_01.dart:14:8: Error: Duplicate keys are not allowed in constant maps (found duplicate key "StringConstant(foo)").
      "foo": 499
       ^
    .../language_2/compile_time_constant_o_test_01.dart:32:24: Context: While analyzing:
      Expect.identical(m1, m3);

Change-Id: I463416e14686e218b0f08903bd6aa0bca7392260
Reviewed-on: https://dart-review.googlesource.com/53021
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-05-09 09:00:02 +00:00
danrubel ebcf5bec30 Update Analyzer/CFE type resolution test to use AstBuildingForest 
This updates the BodyBuilder to accept a Forest for either Kernel or Analyzer.
More work needs to be done to update the Forest type arguments specified in BodyBuilder.

Change-Id: I595535dc05572515a0b7cca5621de35146944ed3
Reviewed-on: https://dart-review.googlesource.com/54180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-08 16:08:52 +00:00
danrubel 1d8620044a Call computeTypeVar rather than parseTypeArguments when parsing expressions 
Change-Id: I4423d1fc4941d7e7fc93c02d89ab81ade46ecf1d
Reviewed-on: https://dart-review.googlesource.com/52720
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-08 15:17:02 +00:00
Kevin Millikin 8f6c6c2a8e Implement some missing override checking 
Detect the following conflicts:

  - declaring a method and inheriting a setter or getter with the same
    name

  - declaring a getter or setter and inheriting a method with the same
    name

  - inheriting both a method and a getter or setter (or both) with the
    same name

Declaring a method and a getter with the same name is already
detected.  Declaring a method and a setter with the same name is not
yet detected, because it should be done in the same way as
method/getter declaration conflicts.

Bug: https://github.com/dart-lang/sdk/issues/32613
Change-Id: I2d168894453d7032372388faa0872d3fc7aa9ef7
Reviewed-on: https://dart-review.googlesource.com/53803
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-05-08 13:40:51 +00:00
Samir Jindel 2296f9d637 Run transformations on expression compilation. 
Change-Id: Ie0107d908f9e83050e83fbcf1384818100f334b9
Reviewed-on: https://dart-review.googlesource.com/44427
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-05-08 13:35:52 +00:00
Brian Wilkerson c9cd32fb58 Clean up Forest.literalList and Forest.literalMap 
Change-Id: Iba64ae132a98297466962f0ed8e4bfbe8535611b
Reviewed-on: https://dart-review.googlesource.com/54161
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-08 13:23:21 +00:00
Samir Jindel 03abbc73d2 CFE support for expression evaluation, refactored. 
Change-Id: I7eac1020b7aa11ea0276f909d7b11ee6388b1aa7
Reviewed-on: https://dart-review.googlesource.com/53209
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-08 11:20:35 +00:00
Samir Jindel 054559c5f3 Revert "CFE support for compiling individual expressions in a context." 
This reverts commit 9038b8f45f.

Revert "Refactoring to allow compilation inside a library loaded from Dill."

This reverts commit 12d697b2ea.

Change-Id: Ia617e464d0c34a6685d351b73abf20def75021ad
Reviewed-on: https://dart-review.googlesource.com/53420
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-08 11:20:35 +00:00
Dmitry Stefantsov 9c6c3dcd89 [fasta] Store calculated bounds of type variables as their defaults 
Change-Id: I92336a3dfbd4e0079680f5cb1df3f3e974200618
Reviewed-on: https://dart-review.googlesource.com/50941
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-08 10:53:47 +00:00
Brian Wilkerson 446668e95c Add required information for three more cases 
Change-Id: I3c7093f14eb0164bf8a282f21f2917f1cb3f36a2
Reviewed-on: https://dart-review.googlesource.com/54069
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-07 23:55:03 +00:00
Brian Wilkerson 3192d0052c Start adding parameters needed by analyzer 
Change-Id: I4cf4ab4fb10cc7e323d9bb1007474673d6b0d52b
Reviewed-on: https://dart-review.googlesource.com/52526
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-05-07 17:30:02 +00:00
Dmitry Stefantsov 89e43b4141 [fasta] Normalize type arguments as in Dart 1 when not in strong mode 
Change-Id: Id25ed6580726610e9e0a108bc42eafe9d88bfc11
Reviewed-on: https://dart-review.googlesource.com/51600
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-07 13:27:50 +00:00
Dan Rubel 64754764b1 Update computeType to call computeTypeParamOrArg 
This is another step to replacing parseType with computeType
and improving recovery when parsing types and type arguments.

This adds a new computeTypeParamOrArg utility which returns
one of a couple constants for common situations or an instance
of ComplexTypeParamOrArg. The computeType function and
some places in ComplexTypeInfo class have been updated to use
this new method, but there are additional places that will be
tackled in subsequent methods.

Change-Id: I7012b65580e9dbc74b9424456262aa3c0367f48b
Reviewed-on: https://dart-review.googlesource.com/53641
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-04 13:38:07 +00:00
Dmitry Stefantsov 31597f1cd7 [fasta] Add more nodes to the Forest API 
Change-Id: I8fa411533a2458cb099fd424b47d3fca8a2a4aad
Reviewed-on: https://dart-review.googlesource.com/53660
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-04 11:35:05 +00:00
Dan Rubel 73768a5342 General TypeInfo and IdentifierContext cleanup 
* Assert computeType and TypeInfo.skipType do not modify the token stream
* Rename TokenInfoTest to TypeInfoTest
* Move skipMetadata to util.dart
* Address comments in https://dart-review.googlesource.com/c/sdk/+/53300

Change-Id: Id2dbe54c5bc688db268e18b0a491367115f7b091
Reviewed-on: https://dart-review.googlesource.com/53640
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-05-03 16:38:24 +00:00
danrubel e93b2ee250 Improve typedef identifier recovery 
... and also address comment in
https://dart-review.googlesource.com/c/sdk/+/53140

Change-Id: I915fe4433102bfcbdac95bb63416587b03b98680
Reviewed-on: https://dart-review.googlesource.com/53300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-03 15:14:43 +00:00
Dmitry Stefantsov 0c839cf3f8 [fasta] Add 'as' expressions to the Forest API 
Change-Id: Id023f24c9e115e15ed81b93625e39230649b7822
Reviewed-on: https://dart-review.googlesource.com/53600
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-03 11:21:23 +00:00
Alexander Aprelev 2765fcf2ae Revert "Revert "Revert "Fix incorrect handling of NSM forwarders and pull all logic into CFE.""" 
This reverts commit 9a7e1f64a2 as it
breaks mockito tests and commit 0bc6e7217a as being done for
9a7e1f64a2.

Bug: https://github.com/dart-lang/sdk/issues/33031
Change-Id: Id20a83c8a7a62ec73446180ecb37e9200f3a92b6
Reviewed-on: https://dart-review.googlesource.com/53540
Reviewed-by: Alexander Aprelev <aam@google.com>
 2018-05-03 06:01:08 +00:00
Alexander Aprelev 9a7e1f64a2 Revert "Revert "Fix incorrect handling of NSM forwarders and pull all logic into CFE."" 
This reverts commit 24dd9b4176 as it broke
the presubmit buildbots.

Change-Id: If225ad7c5728413860ce7b5493e8a7fcd92f54e8
Reviewed-on: https://dart-review.googlesource.com/53461
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2018-05-02 19:48:25 +00:00
Samir Jindel 24dd9b4176 Revert "Fix incorrect handling of NSM forwarders and pull all logic into CFE." 
This reverts commit 7d5025e814.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Fix incorrect handling of NSM forwarders and pull all logic into CFE.
> 
> The original implementation was designed around a shared misunderstanding
> of optional parameter handling in the spec. (which was also ambiguous about type parameters).
> 
> The correct behavior for optional/type parameters is to fill them in with their default values/bounds.
> This behavior can be implemented without any backend support, as is done in this CL.
> 
> Change-Id: Ib81f17ead2d2920e755703e244db5afc328d0315
> Reviewed-on: https://dart-review.googlesource.com/52802
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>

TBR=dmitryas@google.com,sjindel@google.com

Change-Id: Ice6cd36cc62772e013bded83e0f589fe4b5e9d53
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/53400
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-05-02 16:05:26 +00:00
Samir Jindel 9038b8f45f CFE support for compiling individual expressions in a context. 
Change-Id: I6469fb16e8846eccaeca3f8585872f4b69dd3f1e
Reviewed-on: https://dart-review.googlesource.com/38123
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-05-02 12:45:03 +00:00
Samir Jindel 7d5025e814 Fix incorrect handling of NSM forwarders and pull all logic into CFE. 
The original implementation was designed around a shared misunderstanding
of optional parameter handling in the spec. (which was also ambiguous about type parameters).

The correct behavior for optional/type parameters is to fill them in with their default values/bounds.
This behavior can be implemented without any backend support, as is done in this CL.

Change-Id: Ib81f17ead2d2920e755703e244db5afc328d0315
Reviewed-on: https://dart-review.googlesource.com/52802
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-05-02 12:18:30 +00:00
Aske Simon Christensen 011676641a Ignore forwarding stubs when checking for missing implementations. 
Fixes https://github.com/dart-lang/sdk/issues/33009

Change-Id: If131193014d99430a0b1934d2f8890cd4f123934
Reviewed-on: https://dart-review.googlesource.com/53203
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-05-01 15:44:24 +00:00
Samir Jindel 12d697b2ea Refactoring to allow compilation inside a library loaded from Dill. 
Change-Id: I128e9d171354fbfe3cc1a742f83567a1eb1cb7fe
Reviewed-on: https://dart-review.googlesource.com/51324
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-05-01 14:10:16 +00:00
danrubel bf91621857 Improve fasta parser import prefix recovery 
Change-Id: Ib1265cee27ff4e7cfc20012d3e4281cd151accdc
Reviewed-on: https://dart-review.googlesource.com/53140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-05-01 11:26:11 +00:00
Kevin Millikin 9371ca061c Remove all the contravariance bits 
Change-Id: Ib43b32d12749ddac0a93795cb5e8543eb5131dd9
Reviewed-on: https://dart-review.googlesource.com/52867
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
 2018-05-01 10:56:11 +00:00
Dmitry Stefantsov 5af05d407d [fasta] Report type argument number mismatch during outline building 
Change-Id: I1c1f22f3117ccbfc8620b3b0459bc96ed1ad1bdf
Reviewed-on: https://dart-review.googlesource.com/51128
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-04-30 13:01:15 +00:00
Dan Rubel 79a15f52bf Fix isValidMethodTypeArguments 
Change-Id: I3c4bb8dc981c285b8ecfad7dcd7dc849ed1bda7b
Reviewed-on: https://dart-review.googlesource.com/52920
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-28 18:10:06 +00:00
danrubel 88a098c71c Improve fasta parser field name recovery 
Change-Id: I3a27b765df7543eda56c8ef691d6a3192a2769f1
Reviewed-on: https://dart-review.googlesource.com/52621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-27 11:58:30 +00:00
Kevin Millikin c1c90358a2 Record a missing file offset 
`this` in argument lists was missing a file offset.

Fixes https://github.com/dart-lang/sdk/issues/32871

Change-Id: Ic5f18f5de91e73f56371f384709f0b1af330a4e6
Reviewed-on: https://dart-review.googlesource.com/52641
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-04-26 14:47:15 +00:00
Kevin Millikin d47203a71b Fix a crash in type inference 
It's not generally safe to continue to use the Shadow nodes after they
have had their type inferred, because they give a false picture of the
tree.  In this case it led to an assertion failure.

Move the assert to a place in the code where it is true.  Use the
correct subexpression for subsequent check insertion.  Clear the
parent pointer when Kernel nodes are removed from the tree to try to
catch problems like this.

Fixes https://github.com/dart-lang/sdk/issues/32050

Change-Id: I775747d7a6a5240d63881c8563c83cc84628e3d7
Reviewed-on: https://dart-review.googlesource.com/52525
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-04-25 21:36:25 +00:00
Kevin Millikin d7ff30c3e1 Add a missing call to greatestClosure 
When we infer that a function's return type is the expected one, we
need to make sure to use the greatest closure of that expectation.
Otherwise, the type UnknownType will leak out of type inference if it
occurs in the expectation.

Fixes https://github.com/dart-lang/sdk/issues/32847

Change-Id: I2ce65c6b38d701073e3071f03b8c3d52442c2f86
Reviewed-on: https://dart-review.googlesource.com/52521
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Kevin Millikin <kmillikin@google.com>
 2018-04-25 17:34:09 +00:00
danrubel 8d4074175f Improve fasta parser method name recovery 
Change-Id: If0911c8ee8c8d403e711229e6f5f6bd4a8768c9c
Reviewed-on: https://dart-review.googlesource.com/52620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-04-25 15:09:59 +00:00
danrubel 52123b2dc0 Remove unused methods 
Change-Id: I19da00d0d2f55098aa6808cff0621125fb21d549
Reviewed-on: https://dart-review.googlesource.com/52460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-04-24 18:16:58 +00:00
Aske Simon Christensen 9c2fcedaf4 Error on missing method implementation in non-abstract class 
Bug: https://github.com/dart-lang/sdk/issues/32013

Change-Id: I163a84e70e94852a05ce99b07ec883c610ea788c
Reviewed-on: https://dart-review.googlesource.com/52320
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-04-24 13:07:54 +00:00