Commit Graph

4770 Commits

Author SHA1 Message Date
Johnni Winther 6eb9f54683 [cfe] Add ClassKind to Listener.begin/endClassOrMixinBody
This allows for special-casing extension declarations bodies. This
is needed because the on-clause hold the type of the parameter holding
the `this` value inside an instance method in an extension declaration.

Change-Id: I7af9bf0a9842f7e6f42dddb54fb487c69a8fa519
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111729
Reviewed-by: Dan Rubel <danrubel@google.com>
2019-08-05 17:15:37 +00:00
Johnni Winther bd8f7aeebb [cfe] Add DeclarationKind to DeclarationBuilder
The prepares for special-casing methods in extension declarations
during building of the outline. This is needed to add synthesized
type parameters and parameters to the method signature.

Change-Id: Id41d85d86a9ad4eedc4a4ce346ad14e18277dda9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111728
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2019-08-05 17:15:37 +00:00
Jens Johansen 6d1c9975d7 [CFE] Initial language versioning "support"
This CL sets up the bare minimum support for saving the language version
specified in a file on the kernel library, and adds simple support for
testing it.

The data is not serialized out, error checked or similar in this change.

Change-Id: I4b061ce617acae7964b85be105e0ad0e3e031aa4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111640
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-08-05 07:03:04 +00:00
Johnni Winther 972d4e9a75 [cfe] Move relativize code from dart2js to cfe
Change-Id: I2e07dcf91adf65965583189972b0c27cc0aee526
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111427
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-08-01 21:07:50 +00:00
Johnni Winther 7825801189 [cfe] Refactor [ValueKind] to support unions of types.
Change-Id: Ief59777ab304a166bb6b27e29ff126a5f55df5ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110910
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2019-08-01 13:07:19 +00:00
Johnni Winther 68e4eeee12 [cfe] Handle property access, update and method invocation on explicit/implicit this in extension methods
Handles property access, update and method invocation on explicit and
implicit this in extension methods. Also use ReadOnlyAccessGenerator
instead of ThisAccessGenerator to handle explicit this.

Change-Id: Ifd6861b1f931f854a39ddfb9ddae35ebf6094327
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110904
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-08-01 12:04:59 +00:00
Jens Johansen a69c81ac34 Id testing for directories with .packages etc
We should also be able to test for larger examples, so this CL adds
support for directories where all files are included. If the directory
contains a .packages file that is used so we can test packages too.

Change-Id: Iceda03505575bd9e5604a6e374b7f5fa7185a82e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111421
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-08-01 09:25:28 +00:00
Jens Johansen d49de8b68f succinct option for id testing
Add a "-s" (succinct) option to have a more dense output.
Meant for use together with "-a" so one can get a quick overview of how
many tests fail, e.g.
out/ReleaseX64/dart pkg/front_end/test/id_testing/id_testing_test.dart -a -s

Change-Id: I9e1d91694be76e6c66bf0f3c9168783f920a5bf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110914
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-08-01 09:25:28 +00:00
Aske Simon Christensen 60f646a51c [CFE] Do not accept null expressions in constant evaluator.
The constant evaluation method would produce a NullConstant whenever it
was given a null expresssion to evaluate. Since most expressions can't
be null, this could hide some internal inconsistencies and silently
emit incorrect output.

This change tightens the null checks to only check expressions which
can be null (default arguments and initializing expressions for
non-const variables).

Change-Id: Idcfc5df18ce2f8e0b2c51d64288b00fd3315d52b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111423
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
2019-08-01 08:39:48 +00:00
danrubel 86acffa440 fix prefixed type recovery crash
This fixes a crash when parsing an invalid prefixed type preceding a list literal.

Fix https://github.com/dart-lang/sdk/issues/37674

Change-Id: I43e84248c8addf6ed744fa0a836595a53a332d75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-08-01 02:52:11 +00:00
danrubel 3b1cb90146 allow void in extension declaration header
Fix https://github.com/dart-lang/co19/issues/449

Change-Id: I301c2472df3206c64462fc42936c736562c6d95a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-07-31 15:01:54 +00:00
Dmitry Stefantsov 58d3d71df4 [fasta] Don't report errors on NNBD features if experiment is enabled
Change-Id: Ic3247440413b6135d4f1090c5729854bb3c4fbbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111429
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
2019-07-31 13:56:34 +00:00
Johnni Winther 59aa4cd693 [cfe] Merge more Kernel*Builder classes into *Builder classes
* Remove EnumBuilder and rename KerneEnumBuilder to EnumBuilder
* Merge KernelInvalidTypeBuilder into InvalidTypeBuilder
* Merge KernelTypeAliasBuilder into TypeAliasBuilder
* Merge KernelTypeVariableBuilder into TypeVariableBuilder

Change-Id: Ie5554146fc0c073b48453bae446f36592e46ecab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110903
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-07-31 11:19:52 +00:00
Johnni Winther fe2f82650b [cfe] Remove generics from Loader and UnresolvedType
+ cleanup raw types to remove severity rewrite for codeMissingExplicitTypeArguments

Change-Id: I30af950db640cb15ddeeb86e17d9e9cb960a76d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110902
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2019-07-31 11:19:52 +00:00
Johnni Winther b9dbdffe6f [cfe] Remove generics from LibraryBuilder, FieldBuilder and ProcedureBuilder
Change-Id: I1c3f6089bd1ab7eb129d6adb8f018d128fe4d3ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110901
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2019-07-29 15:58:08 +00:00
Johnni Winther 1b06a1cd1b [cfe] Remove generics from TypeDeclarationBuilder hierarchy
Change-Id: Ied9be1426c7f77e1e209666dd243086acd00db56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110900
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2019-07-29 15:58:08 +00:00
Johnni Winther 3992be71c7 [cfe] Add this parameter to extension methods
Change-Id: I25326e755d63b5707f8f7ce52b3d80c3965372aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110725
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2019-07-29 15:58:08 +00:00
Johnni Winther 28a7369146 [cfe] Merge KernelClassBuilder into ClassBuilder
Change-Id: I0af957969863a69cd5c9b7a2da6ffc9550018e48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110723
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2019-07-29 15:58:08 +00:00
Johnni Winther 1e43d65d4a [cfe] Merge KernelFunctionBuilder into ProcedureBuilder
+ rename ProcedureBuilder to FunctionBuilder
+ rename KernelProcedureBuilder to ProcedureBuilder
+ rename KernelConstructorBuilder to ConstructorBuilder
+ rename KernelRedirectingFactoryBuilder to RedirectingFactoryBuilder
+ move all classes to procedure_builder.dart

Change-Id: Ia139b36730f8dafa151e19a08637d17363262c77
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109962
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-07-28 18:19:00 +00:00
Johnni Winther 8b6badda35 [cfe] Add static type test
Change-Id: Id7a0fba20fe03fce2809131ae81bde1f2b5c50fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110724
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-07-28 13:41:09 +00:00
Alexander Markov 16f7076547 [vm/bytecode] Generate bytecode for expression evaluation
Issue: https://github.com/dart-lang/sdk/issues/36427

Change-Id: I0a07bd8ff1be357d2962e6745c8ef1e500d45477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109984
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-07-26 18:22:51 +00:00
Johnni Winther 78224f9b0c [cfe+analyzer+dart2js] Support union markers in id-testing
Supports markers like `cfe|analyzer.` to annotated that the expected
result is for both `cfe` and `analyzer`.

Change-Id: Ie69809db5f63a9ee9b87ff1513b819fe85ce0bce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110500
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-07-26 17:18:01 +00:00
Johnni Winther bcfe26cba0 [cfe] Fail early on unsupported evaluated constants
The many different entrypoints to the CFE have repeatedly shown problems
with targets that do not support unevaluated constants being used
without providing an environment.

Making the targets opt-in to supporting unevaluated constants will
give the users of CFE early notice that CFE is used inconsistently
(as opposed to the backends failing when they happen to see an
UnevaluatedConstant node that they don't support).

Change-Id: I98c80df3a551823598e413e2895f5649f22f7c22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110561
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-07-26 16:57:51 +00:00
Johnni Winther 5357056a20 [cfe] Report errors when extension declarations are used as types
Change-Id: Iad0c7df54fac476c2f23af2fe4ba30ee5bf49167
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110222
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-07-25 17:20:54 +00:00
Siva Annamalai d9287f4fe6 Reland "[dart] Enable constant-update-2018"
This reverts commit 83d2aaa072.

Reason for revert: Want to reenable const-update-2018 by default.

Original change's description:
> Revert "[dart] Enable constant-update-2018"
> 
> This reverts commit 9bbd3192f4.
> 
> Reason for revert: Reverting enabling of constant-update-2018 by default as some blocking issues were found that are breaking Flutter and preventing rolls of Dart into Flutter. Once the blocking issues are addressed and fixed this CL will be relanded.
> 
> Original change's description:
> > [dart] Enable constant-update-2018
> > 
> > Change-Id: Ib3942b4f6e336a02826305d9f81839333a5464a0
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106943
> > Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> > Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
> 
> TBR=paulberry@google.com,vegorov@google.com,athom@google.com,vsm@google.com,aadilmaan@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: I5796881412cec464f450ff3894ca253c58edc4a2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109308
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>

TBR=paulberry@google.com,vegorov@google.com,athom@google.com,vsm@google.com,asiva@google.com,aadilmaan@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I06fbeef318706074c0efcfd42b459bf37c3c92e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109661
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2019-07-25 16:58:49 +00:00
Paul Berry b716a4e3cd Flow analysis: document how state methods are expected to be used.
I focused on the methods where the intended usage wasn't already
obvious from the method name or its documentation comment.

Change-Id: I8aeb01ccf8795e2f7a45b5cf1341d5ebbc77caaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110242
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-07-25 16:03:35 +00:00
Paul Berry 41907fd4a5 Flow analysis: clarify when variables are removed from the "promoted" map.
Change-Id: I72fe7d59ccce0dea507af63e1d7910ade8325544
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110241
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-07-25 15:55:54 +00:00
Paul Berry fdfad8d2f2 Flow analysis: fix a typo
Change-Id: I13d55745923c18fbdf959e440c26c143efe340fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110240
Auto-Submit: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-07-25 15:22:13 +00:00
danrubel 5713caaf09 prepend all remaining scanner error tokens
Change-Id: I325f0681a26e336a41ade9250a2ee0e90a658492
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-07-25 01:51:43 +00:00
Dan Rubel 3c05b8199b move identifier recovery into scanner
Change-Id: I1e4f4fa900b72e4fd405ae8dc86dfa9bc13f370f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110183
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-07-24 18:38:43 +00:00
Dan Rubel c62bd8f3f4 prepend unterminated comment error token and others
Change-Id: I18fd270e9b74e1fd94403ef90f275001983aa86d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-07-24 18:38:43 +00:00
Dan Rubel 34ed30f020 prepend unterminated string error code
Change-Id: I95884700f7a43abfb89753b7381167bac19e4c2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-07-24 18:38:43 +00:00
Dan Rubel 24d1e511df improve missing hex digit recovery
Change-Id: I12d9e3fe314e850a6ee9599187d67dfa5455b18a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110143
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-07-24 18:38:43 +00:00
Johnni Winther 82f657d7cb [cfe] Support error testing in annotated tests
Change-Id: I545ded4d82147f22efc80f4ed8ee833cd75a9be7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109963
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-07-24 07:10:23 +00:00
Johnni Winther b9828b5ac7 [cfe] Merge KernelFormalParameterBuilder into FormalParameterBuilder
Change-Id: I1904b14aa78f7cbadf61a3542e5146c4c7bf4a07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109961
Reviewed-by: Dan Rubel <danrubel@google.com>
2019-07-24 07:10:23 +00:00
Dan Rubel a082f8ce65 merge ArrayBasedScanner into AbstractScanner
There is no need for two separate abstract scanner classes,
so ArrayBasedScanner functionality has been moved into AbstractScanner.

Change-Id: I88765b0b1fa5bf5c73f457ceb5f85cae73b33a5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-07-23 20:19:52 +00:00
Dan Rubel 9c148623c5 prepend missing hex digits error token
This prepends (rather than append) another error token to the token stream
similar to https://dart-review.googlesource.com/c/sdk/+/110100

In addition, this addresses a comment in
https://dart-review.googlesource.com/c/sdk/+/110140

Change-Id: I27c739b0ee3213cdbce92c3ff18c31fde862251c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-07-23 18:08:37 +00:00
Dan Rubel b41b868797 prepend UnmatchedToken error tokens
This change ensures that instances of UnmatchedToken are always prepended
to the token stream. This should prevent the exception that occurs in
https://github.com/dart-lang/sdk/issues/37491.
This addresses only one type of error token and we may see a similar
exception with other types of error tokens.

Future CLs will prepend other and eventually all error tokens.

Change-Id: I99cdc331c03f47b21c5a67d436a0e62ebf416e94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-07-23 15:21:04 +00:00
Paul Berry baaeafa2bb Flow analysis: move into front_end.
This will allow it to be used by both the front end and the analyzer.

Change-Id: I3af67aaf3ad7ff2cca0cb245518570892ad473e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109986
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2019-07-23 12:55:11 +00:00
Johnni Winther ed38b6d664 Remove KernelMixinApplicationBuilder and KernelNamedTypeBuilder
NamedTypeBuilder and MixinApplicationBuilder are only subclassed by
KernelNamedTypeBuilder and KernelMixinApplicationBuilder, respectively,
so the distinction can be removed.

Change-Id: If0a6434d76c20c3c10a8e25b86d2a5542d5244b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109263
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
2019-07-23 09:20:28 +00:00
Johnni Winther 0177076f2f [cfe] Merge KernelBodyBuilder into BodyBuilder
Change-Id: Ica7d23a54659606ef8d01c647dc8d89f10796bb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109712
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-07-23 08:02:18 +00:00
Johnni Winther 05b5883813 [cfe] Add documentation to some Generator implementations
Change-Id: I0a57b08da639557376b1b6f666d2d8aa6344f59c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109711
Reviewed-by: Dan Rubel <danrubel@google.com>
2019-07-23 08:02:18 +00:00
Dan Rubel d7cb52b863 capture more info to debug 37528
This updates the exception message to capture more information
about where the exception is occurring. Hopefully that information
can be used to fix https://github.com/dart-lang/sdk/issues/37528

Change-Id: Iaf10395091f8bd8b540dddc59001f23b6dc6a073
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
2019-07-22 20:18:17 +00:00
Johnni Winther cddd21dde1 [cfe] Merge ExpressionGenerator into Generator
+ Make more internal properties private
+ Add documentation on more properties/methods

Change-Id: I40779c83fcb7f888e485ccbc7b1fad312199806c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109710
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2019-07-22 16:00:28 +00:00
Johnni Winther b52328e528 [cfe] Remove unneeded indirect generator construction through Forest
Change-Id: Ic535bfe84395608c9b0764edf8646fd2606429b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109708
Reviewed-by: Dan Rubel <danrubel@google.com>
2019-07-22 16:00:28 +00:00
Johnni Winther 2a199f3993 [cfe] Merge KernelExpressionGenerator with ExpressionGenerator
We no longer need the distinction between *Generator and Kernel*Generator
so the Kernel*Generator classes are now merge into the *Generator classes.

Change-Id: I9f9650fc4ab88a0952b8d2bd346e1d416d68eac6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109707
Reviewed-by: Dan Rubel <danrubel@google.com>
2019-07-22 16:00:28 +00:00
Johnni Winther 11755e537c [cfe] Add tests for extension members
+ Avoid creating default constructors.

Change-Id: Ie0ed967d9be4cf31a2eb6991767887de1f88149a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109702
Reviewed-by: Dan Rubel <danrubel@google.com>
2019-07-22 16:00:28 +00:00
Johnni Winther 610183d5f9 [cfe] Rename operator[] to getLocalMember on Library/ClassBuilder
Change-Id: I8d03cf939e15de53b3768ee946815cf31e3a1124
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109700
Reviewed-by: Dan Rubel <danrubel@google.com>
2019-07-22 16:00:28 +00:00
Johnni Winther b3b6533c3d [cfe] Create ClassBuilder for extension declarations
Change-Id: Ic372b89588ed9ec3afc43f7db7e3d38a81846ad5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109264
Reviewed-by: Dan Rubel <danrubel@google.com>
2019-07-22 16:00:28 +00:00
Johnni Winther 7075ae7026 [cfe+dart2js] Move features to CFE
To share support for annotated tests based on Features.

Change-Id: Ic319442e2e016bf4d1584825ea019d13a74acedb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109560
Reviewed-by: Stephen Adams <sra@google.com>
2019-07-22 16:00:28 +00:00