dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

1019 Commits

Author SHA1 Message Date
John Messerly 43fe94ae35 remove unused test expectation files 
R=vsm@google.com

Review URL: https://codereview.chromium.org/2246353002 .
 2016-08-16 08:19:18 -07:00
John Messerly 36273565e3 fixes #610, incorrect help output 
R=nweiz@google.com

Review URL: https://codereview.chromium.org/2244703003 .
 2016-08-12 15:06:41 -07:00
John Messerly 0aa5cbd128 fix #620, infer the input files from sources 
also simplifies build of packages used by our tests
this caused a bunch of tests that use parts to start passing

R=nweiz@google.com

Review URL: https://codereview.chromium.org/2234343003 .
 2016-08-11 13:19:36 -07:00
Vijay Menon 8fec051a8e Mark recursive_inheritance_test as passing 
This will get the dev and master bots green.

Will need to bump the pubspec on analyzer (once published) to make stable green after this.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2214263005 .
 2016-08-05 09:35:01 -07:00
Vijay Menon 3ddb76b95c Reify type params on map literals 
Fixes #621

R=jmesserly@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/2211293002 .
 2016-08-05 07:16:02 -07:00
Vijay Menon 0fd3e8821c Fix wrt analyzer tip 
This sidesteps #618 for now.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2209473002 .
 2016-08-02 14:42:06 -07:00
John Messerly e51f9de339 fixes #616, statics on callable functions 
also fixes `this` for them

R=vsm@google.com

Review URL: https://codereview.chromium.org/2200913002 .
 2016-08-01 17:12:37 -07:00
John Messerly 344124e4a1 fix optional params to mock methods, allow all signatures 
switches to use the same technique as `dsend`

R=vsm@google.com

Review URL: https://codereview.chromium.org/2201973002 .
 2016-08-01 16:21:59 -07:00
Vijay Menon b2353d7513 Fix analyzer error 
This is breaking travis.

TBR=jmesserly@google.com

Review URL: https://codereview.chromium.org/2199473002 .
 2016-07-29 14:31:46 -07:00
John Messerly 0f29ee9618 Remove DDC custom error list now that strong mode analyzer handles it 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2102053003 .
 2016-07-27 13:10:57 -07:00
John Messerly c3ee6dc5ee fix #606, allow specifying the summary file extension 
R=paulberry@google.com

Review URL: https://codereview.chromium.org/2176763002 .
 2016-07-22 11:39:35 -07:00
John Messerly c1e97b495f fix #603, support mock objects 
if noSuchMethod is used to implement an abstract member, this will be detected and appropriate code will be generated.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2158173003 .
 2016-07-19 13:24:02 -07:00
Leaf Petersen 0315595d60 Check in codegen test expectations. 
Codegen output is checked into repository to make codegen regressions
more visible (especially readability regressions).

BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/2128353002 .
 2016-07-07 15:57:22 -07:00
Leaf Petersen fceb82f49d Fix null aware generic invocation. 
Fixes #600

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2132763002 .
 2016-07-07 13:07:17 -07:00
Andrew Krieger 87bcbf9147 Move type tagging logic out of setSignature 
setSignature is only called for classes with constructors or static
members, so previously _runtimeType was only set explicitly on such
classes. Now _runtimeType is not set on any classes except for Object,
and all other types inherit _runtimeType from Object.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2076713002 .
 2016-06-27 15:29:15 -07:00
John Messerly d27eda4ffc implement user-defined nSM, Object members on functions 
fix #591 and fix #59

R=vsm@google.com

Review URL: https://codereview.chromium.org/2061373003 .
 2016-06-22 17:18:52 -07:00
Vijay Menon e8e19b4c5a Verify status of statically failing tests 
This should catch tests that suddenly start failing (or passing).

This is an admittedly contrived approach to track compilation failures in
the same runtime logic: the statically failing tests are now compiled
to a trivial output that throws a particular exception.  Ideally, we
wouldn't run these, but it's beneficial to keep status in the same
place.

On my laptop, this only adds ~8s to presubmit (which takes ~2:30 min).

Ideas on alternative approaches welcome.  :-)

R=jmesserly@google.com, leafp@google.com

Review URL: https://codereview.chromium.org/2079373002 .
 2016-06-22 06:25:48 -07:00
John Messerly 430e8f15af Partial fix for call methods #542 
This fixes the generated code to support these. Subtype checks are not fixed yet.

R=vsm@google.com

Review URL: https://codereview.chromium.org/2069903002 .
 2016-06-16 16:38:43 -07:00
Stan Manilov 715c845d85 Add a regression test for bug #587 
BUG= https://github.com/dart-lang/dev_compiler/issues/587
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2075493002 .
 2016-06-15 16:58:57 -07:00
John Messerly 477182e88d fix worker_test 2016-06-14 14:54:20 -07:00
Leaf Petersen 3e5d1d80e6 Fix function subtyping crash 
Fixes #588

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org/2069653003 .
 2016-06-14 09:55:04 -07:00
Leaf Petersen 59abfdb121 Fix bot, law of the excluded middle still holds 
TBR=jacobr@google.com

BUG=

Review URL: https://codereview.chromium.org/2037503002 .
 2016-06-01 20:58:44 -07:00
Leaf Petersen 40c7ac9038 Wire up class hierarchy for recursive inheritance 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/2033543002 .
 2016-06-01 19:21:45 -07:00
Stephen Adams 73479a600c Throw TypeError instead of CastError for type coercions. 
Added 'tag' type StrongModeError, implemented by all errors that are
specific to strong mode semantics.

Failed casts throw CastError(Implementation) or StrongModeCastError.
Failed type assertions and reified coercions throw TypeError or
StrongModeTypeError.

Triaged some tests. Some pass due to now throwing a TypeError, many
pass for unknown reasons.

R=leafp@google.com

Review URL: https://codereview.chromium.org/2026133002 .
 2016-06-01 10:18:17 -07:00
John Messerly f0517c4deb Enable strong mode in DDC, fix all warnings/errors 
R=leafp@google.com

Review URL: https://codereview.chromium.org/2016483002 .
 2016-05-26 11:13:32 -07:00
Leaf Petersen 3e9ed11db6 Name and hoist types 
Adds infrastructure for naming and hoisting types in various ways. Makes an initial cut at how to slice the naming, but we will want to adjust.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1988023008 .
 2016-05-25 11:07:38 -07:00
John Messerly f950e422b8 fix #577 - correctly toString ES Symbols 
R=sra@google.com

Review URL: https://codereview.chromium.org/1993293002 .
 2016-05-19 12:33:06 -07:00
Harry Terkelsen e105544411 implement top-level JS annotated getters 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1993813003 .
 2016-05-19 11:10:24 -07:00
Bob Nystrom f7ffb1a9c4 Check in a lockfile. 
This should ensure we all use the same versions of dev_compiler's deps
when we hack on it.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1988213003 .
 2016-05-18 16:51:16 -07:00
Bob Nystrom 1e5b3af2e0 Move generated files to gen/. 
- The generated SDK goes into gen/patched_sdk.
- Expanded multitests go into gen/codegen_tests.
- Compiled tests go into gen/codegen_output.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1988503002 .
 2016-05-18 13:48:10 -07:00
John Messerly d2b6f53630 fix #470, string interpolation now respects Dart toString 
R=sra@google.com

Review URL: https://codereview.chromium.org/1989663002 .
 2016-05-17 17:23:57 -07:00
Bob Nystrom d95a368e70 Update dart:collection. 
This doesn't include the copious changes in collection_patch.dart
because I believe (1) those are quite old and (2) are dart2js specific.

The changes here have basically no effect on DDC, but it at least gets
us a little better test coverage and reduces noise in the diffs.

R=sra@google.com

Review URL: https://codereview.chromium.org/1977003002 .
 2016-05-17 15:39:52 -07:00
John Messerly 0cedeb49af simplify constructors, fixes #564 
we still have an init method, for better or worse, to break out of ES6 restrictions

The idea here is default Dart constructor (really an initialization method) is always called `new` instead of the class name. We already do this for unnamed factory.

R=leafp@google.com

Review URL: https://codereview.chromium.org/1965213003 .
 2016-05-17 14:36:56 -07:00
Leaf Petersen 59012493cb Eliminate unnecessary covariance checks. 
This eliminates the erroneous checks inside of nested closures, and
eliminates checks where the type parameter is only used covariantly.

We still don't handle the cases where a generic is implemented by
a non-generic correctly.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1988613006 .
 2016-05-17 12:21:02 -07:00
John Messerly 1265dc470b fix #569, cache constants defined in methods 
R=leafp@google.com, sra@google.com

Review URL: https://codereview.chromium.org/1979013003 .
 2016-05-17 11:09:59 -07:00
Stephen Adams 3c44af0a51 Named constants are (usually) not null. 
R=vsm@google.com

BUG=

Review URL: https://codereview.chromium.org/1986683002 .
 2016-05-17 10:55:14 -07:00
Vijay Menon d15a603538 Allow the SDK to be set via a summary file 
The generated summary file matches the generated DDC sdk - i.e., it
does not include dart:io.  I modified the codegen_tests to the summary
and had to prune the parts of unittest that relied on dart:io.

Paul / Konstantin: can one of you please look at the summary part?

Bob: can you please look at the unittest changes?

R=rnystrom@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1982853002 .
 2016-05-16 17:10:08 -07:00
Harry Terkelsen 9458bdf428 enable top-level @JS() getters 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1976383002 .
 2016-05-16 09:22:32 -07:00
Vijay Menon 88870d0194 Migrate dart2js stubs for dart:io 
Modifies tests to use our SDK.  Didn't prune io dependences to make
sure the stubs above work.  :-)

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1976103003 .
 2016-05-16 08:23:41 -07:00
Bob Nystrom 851cbb0fb3 Delete stale .js or .err files when generating codegen output. 
This ensures that, for example, if you fix a test to no longer have
errors, then the old ".err" file is removed.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1978983002 .
 2016-05-13 16:34:13 -07:00
Bob Nystrom 4a51a187d3 Upgrade to the latest dart:convert. 
This fixes html_escape_test as well as codec1_test.

R=vsm@google.com

Review URL: https://codereview.chromium.org/1978963002 .
 2016-05-13 16:33:35 -07:00
Harry Terkelsen 2136fdc40e implement @JS classes 
BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org/1977893002 .
 2016-05-13 10:24:54 -07:00
Jacob Richman f59bf19564 html_escape_test does not fail with the dart sdk the build bot uses. 
BUG=

Review URL: https://codereview.chromium.org/1969293004 .
 2016-05-13 09:31:13 -07:00
Stephen Adams bfa432ef56 A few more tests pass 
TBR=vsm@google.com

Review URL: https://codereview.chromium.org/1978613003 .
 2016-05-12 13:51:37 -07:00
Bob Nystrom 2883b19b9c Upgrade StackTrace to the latest SDK version. 
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1967383002 .
 2016-05-12 10:31:04 -07:00
Jacob Richman 9b8f582b82 Double timeout for slow tests to reduce flakiness seen on travis. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1974873003 .
 2016-05-12 10:03:29 -07:00
Jacob Richman c325cecff8 Mark some tests that could be fail instead of skip_fail as fail. Mark timeout test as timeout instead of skip_fail 
BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1971923003 .
 2016-05-12 09:39:16 -07:00
Jacob Richman 548f1393a3 Work around is check issue causing zone error handlers to never fire. Update test expectations to reflect the correct expectations. 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org/1968323002 .
 2016-05-12 09:33:05 -07:00
Harry Terkelsen 382996f41c update dart:math 
BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1967773005 .
 2016-05-12 09:03:11 -07:00
John Messerly 825737dc13 fuse some null checks with type checks, introduce a special bool variant 
fixes #536

R=sra@google.com

Review URL: https://codereview.chromium.org/1964263002 .
 2016-05-11 11:16:00 -07:00