dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

12 Commits

Author SHA1 Message Date
Leaf Petersen e85bf740ef Opt pkg/dev_compiler out of null safety. 
Change-Id: I62207a436605480b6981b8b00bf7b88d8589db0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166980
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
 2020-10-12 23:25:42 +00:00
Nate Bosch 2d82fb42ce Enforce and fix lint prefer_single_quotes 
Change-Id: I7e7b18d90ae8518c700607ec383c73a0eda5a299
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130726
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
 2020-01-08 22:07:21 +00:00
Nate Bosch aa246f6588 Add return types on all main declarations 
Reduces the noise when disallowing implicit dynamic.

Change-Id: I98b03cb675ecd4b9e7f4135efa274fb57eb87832
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104164
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2019-06-11 00:19:00 +00:00
Jenny Messerly 1a122e3ac0 Deprecate module-root option in dartdevc, part of #32272 
Adds an option for specifying the output JS module name if that is
needed (only applies for some module formats).

Also removes repl-compile (it's set via API, not the command line).

Refactors dartdevk options to match dartdevc so we can migrate more
easily. Moves shared code into a shared location and removes copied
code.

Change-Id: I966343ecbbc962f5d0f14ea7e65d78660159f420
Reviewed-on: https://dart-review.googlesource.com/64823
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2018-07-26 02:43:48 +00:00
Jens Johansen 58ed2604af Fixup DDC test on Windows (attepmt #2) 
Directory.current.path on Windows uses "\" and not "/" and does not
start with a slash.

Bug:
Change-Id: Id1b75ee0e3962c3531ba964aee9300025cdbcdca
Reviewed-on: https://dart-review.googlesource.com/34101
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-11 08:06:21 +00:00
Jens Johansen a35a676f39 Revert "Fixup DDC test on Windows" 
This reverts commit 70020cd30d.

Reason for revert: Didn't quite work.

Original change's description:
> Fixup DDC test on Windows
> 
> Directory.current.path on Windows uses "\" and not "/".
> 
> Bug:
> Change-Id: I6ef789d586622f78d0401c1a892f6a475bf6d93a
> Reviewed-on: https://dart-review.googlesource.com/34100
> Reviewed-by: Jens Johansen <jensj@google.com>

TBR=dmitryas@google.com,jensj@google.com

Change-Id: Ied8897801005f1a1b83075c1fb2a0b905129bb18
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/34001
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-01-11 08:04:38 +00:00
Jens Johansen 70020cd30d Fixup DDC test on Windows 
Directory.current.path on Windows uses "\" and not "/".

Bug:
Change-Id: I6ef789d586622f78d0401c1a892f6a475bf6d93a
Reviewed-on: https://dart-review.googlesource.com/34100
Reviewed-by: Jens Johansen <jensj@google.com>
 2018-01-11 07:25:43 +00:00
Jens Johansen 83057c42b1 Run dartdevk tests on Windows too 
Attempt #4 at making Windows bot happy

Bug:
Change-Id: I6101851787ba956fc14f28130ac6b73bfa38b2a3
Reviewed-on: https://dart-review.googlesource.com/27723
Reviewed-by: Jens Johansen <jensj@google.com>
 2017-12-08 13:34:09 +00:00
Jens Johansen 6e3d94ab1a Revert "Run dartdevk tests on Windows too" 
This reverts commit 125d704a6e.

Reason for revert: Seemingly still looks for .packages in wrong place.

Original change's description:
> Run dartdevk tests on Windows too
> 
> Attempt #3 at making Windows bot happy
> 
> Bug:
> Change-Id: Iae01ddc20167eed00387bc7075fd3272665ed76a
> Reviewed-on: https://dart-review.googlesource.com/27680
> Reviewed-by: Jens Johansen <jensj@google.com>

TBR=jensj@google.com,kmillikin@google.com

Change-Id: If8f13daf50343f0347fd7b9c218227154a766306
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/27700
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2017-12-08 13:02:52 +00:00
Jens Johansen 125d704a6e Run dartdevk tests on Windows too 
Attempt #3 at making Windows bot happy

Bug:
Change-Id: Iae01ddc20167eed00387bc7075fd3272665ed76a
Reviewed-on: https://dart-review.googlesource.com/27680
Reviewed-by: Jens Johansen <jensj@google.com>
 2017-12-08 12:40:28 +00:00
Jens Johansen 511dfcf449 Revert "Run dartdevk tests on Windows too" 
This reverts commit 1a01e108c1.

Reason for revert: Getting error "out/ReleaseX64/dart-sdk/.packages: Error: Unable to read '.packages' file"

Original change's description:
> Run dartdevk tests on Windows too
> 
> Attempt #2 at making Windows bot happy
> 
> Bug:
> Change-Id: I0fb1147a67eb3ceda0e51f2f82348127a0c5ba66
> Reviewed-on: https://dart-review.googlesource.com/27640
> Reviewed-by: Kevin Millikin <kmillikin@google.com>

TBR=jensj@google.com,kmillikin@google.com

Change-Id: I5c00525a9325dd25d149f992ad4b6e33517b6327
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/27660
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2017-12-08 12:24:02 +00:00
Jens Johansen 1a01e108c1 Run dartdevk tests on Windows too 
Attempt #2 at making Windows bot happy

Bug:
Change-Id: I0fb1147a67eb3ceda0e51f2f82348127a0c5ba66
Reviewed-on: https://dart-review.googlesource.com/27640
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2017-12-08 12:03:11 +00:00