Commit Graph

2 Commits

Author SHA1 Message Date
Jaime Wren 70a3627d57 Update dartdev smoke tests for Dart version 2.12
I also took the time to
- add the smoke tests to the dartdev test_all.dart file
- change the order of the asserts to fail fast and with better messages if there are failures


Bug: https://github.com/dart-lang/sdk/issues/43842
Change-Id: Ic35e52145bf3f9d6871dcec07395966a02ca3d11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168761
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
2020-10-21 20:06:54 +00:00
Ben Konyi cb6ed67a73 [ VM ] Fix issue where dartdev's script_uri was being freed prematurely
This was causing flaky failures when initializing DDS as it was invoking
the getVM RPC which in turn sometimes accessed the script_uri after it
had been freed.

Change-Id: I4454b6fa2da3ad6767938ed12b1013223a667af7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155740
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2020-07-27 19:11:53 +00:00