dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4835 Commits

Author SHA1 Message Date
asgerf@google.com 73d063e5f4 Fix some bugs that blocked optimizations in the new IRs. 
- Bad reference counting in tree IR builder.
- Incorrect visit order in StatementRewriter.visitSetField.
- Bad hint assigned in IR builder for GetClosureVariable.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//807573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42913 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-15 15:50:36 +00:00
ahe@google.com dae8aed3d8 Register throwRuntimeError when creating an ErroneousConstructorElementX 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//848333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42912 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-15 15:02:37 +00:00
floitsch@google.com 884599197e dart2js: Remove unused function. 
R=zarah@google.com

Review URL: https://codereview.chromium.org//853923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42906 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-15 13:46:06 +00:00
ahe@google.com c179b70426 Don’t exit prematurely if compilation failed. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//828413004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42905 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-15 12:12:22 +00:00
ahe@google.com 8e39d5fed8 Recover from crash in language/async_test/constructor4. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//840723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42904 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-15 12:04:33 +00:00
ahe@google.com aa760547b4 Avoid duplicated messages. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//822423005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42903 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-15 11:59:35 +00:00
floitsch@google.com 12eaf70732 dart2js: start using the model in the old emitter. 
R=zarah@google.com

Review URL: https://codereview.chromium.org//849623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42902 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-15 11:55:30 +00:00
karlklose@google.com 7e80e7dfea Remove tracking of factories used with type arguments. 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//794933004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42899 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-15 08:39:45 +00:00
vegorov@google.com a45ed14472 Fix build broken by r42878. 
Remove parameter name left at internalError invocation.

TBR=johnniwinther@google.com
BUG=

Review URL: https://codereview.chromium.org//852833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42881 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 18:53:39 +00:00
vegorov@google.com a805ce5c5f Wrap standalone invariant() calls in assert(). 
To avoid unnecessary allocation: some of them have closure as an
argument.

R=floitsch@google.com, johnniwinther@google.com
BUG=

Review URL: https://codereview.chromium.org//819183005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42878 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 18:06:37 +00:00
ahe@google.com 3ca1728f97 Recover from read errors. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//841653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42872 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 14:16:10 +00:00
floitsch@google.com c67d68e399 dart2js: remove spurious semicolon. 
R=zarah@google.com

Review URL: https://codereview.chromium.org//854543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42869 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 13:39:20 +00:00
floitsch@google.com 240853c756 dart2js: Temporarily store output unit in Fragment. 
R=zarah@google.com

Review URL: https://codereview.chromium.org//835233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42867 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 13:03:29 +00:00
floitsch@google.com 6e769d9c7f dart2js: register output units explicitly in the program builder. 
R=zarah@google.com

Review URL: https://codereview.chromium.org//851683004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42866 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 13:02:37 +00:00
floitsch@google.com f072c6319b dart2js: register static non final fields in the model. 
R=zarah@google.com

Review URL: https://codereview.chromium.org//849933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42864 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 13:00:47 +00:00
floitsch@google.com 6eaf30d3d0 dart2js: Rename Fragment to LibrariesMap and Output to Fragment. 
Fragment is the better name and is now used more often.

R=zarah@google.com

Review URL: https://codereview.chromium.org//851793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42863 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 12:56:55 +00:00
ahe@google.com 5ec13e7ab7 Remove CompilerCancelledException. 
Review URL: https://codereview.chromium.org//848003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42862 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 12:51:41 +00:00
ahe@google.com 4c2121a9bd Recover from fatal parser errors. 
BUG=https://code.google.com/p/dart/issues/detail?id=22022
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//808953004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42861 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-14 12:48:28 +00:00
asgerf@google.com 9748ac4ac4 Avoid boxing loop variables that are only mutated in initializer or update 
For example:

for (int i=0; i<10; i++) {
  getFoo(i).then((x) {
    x.doBar(i);
  });
}

BUG=
R=floitsch@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//802813004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42809 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 14:11:13 +00:00
floitsch@google.com 22b3753ce2 dart2js: Use unique instance as exit signal. 
R=ahe@google.com

Review URL: https://codereview.chromium.org//840013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42806 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 13:51:30 +00:00
asgerf@google.com e50fd28ff7 Use closure conversion in new dart2js backend. 
New instructions: CreateBox, SetField, GetField, CreateClosureClass.

The "old" instructions based on ref-cells are still in use by dart2dart:
GetClosureVariable, SetClosureVariable, CreateFunction.

dart2dart still does not support captured for-loop variables, but this
is a separate issue.

BUG=
R=floitsch@google.com, kmillikin@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//831133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42802 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 11:57:15 +00:00
johnniwinther@google.com 0192ea71fc Emit to StreamCodeOutput instead of CodeBuffer. 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//830703004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42801 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 09:14:25 +00:00
zarah@google.com a664d5d416 dart2js OldEmitter: Remove processing of old metadata encoding. 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//849583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42800 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-13 08:46:50 +00:00
ahe@google.com 63d8097fad Use synthetic elements to recover from errors in signatures.dart. 
BUG=https://code.google.com/p/dart/issues/detail?id=22021
R=karlklose@google.com, zarah@google.com

Review URL: https://codereview.chromium.org//845183004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42772 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 13:57:30 +00:00
ahe@google.com f54164609b Update invariant in class_members.dart. 
Review URL: https://codereview.chromium.org//811933004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42770 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 12:45:21 +00:00
ahe@google.com e2cbbcaef1 Non-fatal errors in compile-time constants. 
BUG=https://code.google.com/p/dart/issues/detail?id=22018
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//829033004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42768 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 10:17:36 +00:00
ahe@google.com dc07285505 Non fatal errors on duplicated accessors. 
BUG=https://code.google.com/p/dart/issues/detail?id=22019
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//841303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42767 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 10:15:29 +00:00
ahe@google.com 60e17ef3cd Address comments from 820093006 
R=zarah@google.com

Review URL: https://codereview.chromium.org//837563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42766 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 10:14:02 +00:00
sigurdm@google.com 95582bb710 Add deferred map info to dump-info. 
I am not sure if we should bump the version property. That would require
an update of the viewer.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//831343003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42763 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-12 08:25:29 +00:00
floitsch@google.com ab9cc6e41e dart2js: collect static-non-final fields in the task. 
R=sigurdm@google.com, zarah@google.com

Review URL: https://codereview.chromium.org//830463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42744 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 17:23:53 +00:00
floitsch@google.com 57ae728cf5 dart2js: Register constants in the model builder. 
We need to make sure that constants are registered, as otherwise output units that only contain constants aren't generated.

R=zarah@google.com

Review URL: https://codereview.chromium.org//838643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42743 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 17:22:43 +00:00
floitsch@google.com 86d9c01cd5 dart2js: Support new const operations on strings. 
BUG= http://dartbug.com/21001
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//585173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42737 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 16:07:53 +00:00
ahe@google.com 1e3bca615b Less fatal errors 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//820093006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42731 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 11:28:04 +00:00
ahe@google.com 0803aae8df Create erroneous element when resolution of initializer fails. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//821593004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42729 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 10:50:15 +00:00
sigurdm@google.com e2b3d76994 Add option for outputting a deferred loading mapping. 
With the option --deferred-map=<file> dart2js will output a json-file
describing which files will get loaded for a given deferred import.

The output looks like:
{
  "_comment": "This mapping shows which compiled `.js` files are needed for a given deferred library import.",
  "main.dart": {
    "name": "mainLibrary",
    "imports": {
      "lib1": [
        "out.js_2.part.js",
        "out.js_1.part.js"
      ],
      "lib2": [
        "out.js_2.part.js",
        "out.js_3.part.js"
      ],
      "lib3": [
        "out.js_5.part.js"
      ],
      "lib4": [
        "out.js_6.part.js"
      ]
    }
  },
  "lib1.dart": {
    "name": "<unnamed>",
    "imports": {
      "convert": [
        "out.js_4.part.js"
      ]
    }
  }
}
BUG=dartbug.com/21869
R=floitsch@google.com

Review URL: https://codereview.chromium.org//785303003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42727 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 10:37:02 +00:00
johnniwinther@google.com 04e6184abe Handle platform access through prefix in dart2dart 
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//839063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42726 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-09 10:29:59 +00:00
floitsch@google.com dc1835da68 dart2js: Merge intercepted names map. 
R=ahe@google.com

Review URL: https://codereview.chromium.org//833623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42694 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-08 14:16:33 +00:00
ahe@google.com 195696cd9c More fatal errors to prevent crashes. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//839043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42693 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-08 14:05:35 +00:00
floitsch@google.com 11fa0a2a86 dart2js: Store mapTypeToInterceptor in embedded global. 
R=ahe@google.com, sra@google.com

Review URL: https://codereview.chromium.org//813873008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42692 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-08 13:31:00 +00:00
floitsch@google.com 764358ad0e dart2js: The main output unit always has a descriptor (at the very least main). 
R=ahe@google.com

Review URL: https://codereview.chromium.org//823633005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42691 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-08 13:22:41 +00:00
ahe@google.com 3e3fd384dc Quick work around dart2js crashes 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//841953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42687 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-08 11:33:53 +00:00
zarah@google.com 009cd7ff71 dart2js: Change name and comment of the flag needsArrayInitializerSupport. 
R=ahe@google.com

Review URL: https://codereview.chromium.org//843503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42685 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-08 10:28:32 +00:00
ahe@google.com a52a04a04a Remove Compiler.reportFatalError. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//791263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42678 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-08 08:37:24 +00:00
ahe@google.com cf8292288f Throw ArgumentError if packageRoot is null. 
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//838773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42677 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-08 08:36:27 +00:00
zarah@google.com 38d47fce2c dart2js: Change output so that in stack traces, dart method names get prefixed with 'dart.' instead of 'parseReflectionData'. 
BUG=dartbug.com/22000
R=ahe@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//798873004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42661 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-07 14:18:55 +00:00
sigurdm@google.com 0df0c89ae6 Fix deferred loading with multiple apps on same page. 
Even though two apps don't have to load a file twice, they still both have to initialize it.

Still missing this support for the new emitter.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//837903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42660 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-07 14:05:51 +00:00
floitsch@google.com 131370189e dart2js: First part of native support in the new emitter. 
R=sra@google.com

Review URL: https://codereview.chromium.org//836753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42657 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-07 13:11:54 +00:00
floitsch@google.com 270bbb32ab dart2js: Remove unused variable. 
R=ahe@google.com

Review URL: https://codereview.chromium.org//832043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42655 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-07 13:08:37 +00:00
zarah@google.com 292cd0cfbe Avoid emitting addStubs and tearOffCode when not needed. 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//810933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42654 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-07 13:07:38 +00:00
zarah@google.com cfef07acad dart2js OldEmitter: Small cleanups in output. 
R=floitsch@google.com

Review URL: https://codereview.chromium.org//834133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42651 260f80e4-7a28-3924-810f-c04153c831b5
 2015-01-07 08:05:08 +00:00