dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4835 Commits

Author SHA1 Message Date
Peter von der Ahé 06b8ce5d34 More dart2js strong mode cleanup. 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2934333002 .
 2017-06-15 09:42:22 +02:00
Peter von der Ahé fe2365584b More strong mode cleaning in dart2js. 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2941763002 .
 2017-06-15 09:34:47 +02:00
Emily Fortuna 1e599fd213 Edit docs as per Siggi's feedback. 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2937143002 .
 2017-06-14 17:13:54 -07:00
Emily Fortuna 7302ea43cf Make requiresContextBox a getter as per Siggi's suggestion. 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2936323003 .
 2017-06-14 17:12:33 -07:00
Emily Fortuna e6d7c0500c Rename ClosureClassMaps to CLosureDataLookup 
(doing small tasks while I wait to talk to Siggi).

BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2938853004 .
 2017-06-14 16:55:57 -07:00
Emily Fortuna a05f5000ad Modify types in dump_info to make kernel checked mode happy. 
This is a follow up CL from https://codereview.chromium.org/2933363003

BUG=

Review-Url: https://codereview.chromium.org/2940883006 .
 2017-06-14 13:39:46 -07:00
Peter von der Ahé 87700d381c Start making dart2js strong mode clean. 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2938823002 .
 2017-06-14 20:34:07 +02:00
Emily Fortuna a27ebd0c94 Add ClosureRepresentationInfo, the new public face of ClosureClassMap 
(removal of methods exposing ClosureClassMap coming in follow up CL).

BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2933363003 .
 2017-06-14 11:15:08 -07:00
Johnni Winther 195470419e Fix strong mode warning 
Review-Url: https://codereview.chromium.org/2942583002 .
 2017-06-14 13:45:05 +02:00
Johnni Winther 6a6a330623 Parameterize and move JumpTarget/LabelDefition to elements/jumps.dart 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2930293002 .
 2017-06-14 12:27:38 +02:00
Johnni Winther 52b1ea04e8 Refactor LoopHandler to avoid calling KernelAstAdapter.getNode 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2932023003 .
 2017-06-14 12:18:34 +02:00
Johnni Winther ea070c7264 Add ClosedWorld.elementEnvironment and remove Compiler.elementEnvironment 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2935063002 .
 2017-06-14 10:27:38 +02:00
Johnni Winther 5afe65e891 Remove Compiler.commonElements 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2935663002 .
 2017-06-14 10:18:42 +02:00
Emily Fortuna 0753ac689e Handle named mixin application in emitter 
Fixes regression in language/regress_18713_test with --csp

Closes #29844
Closes #29843

This reapplies Johnni's change from here: https://codereview.chromium.org/2934783002/

I am submitting it instead of Johnni because without this change we are blocking the new dart update internally in Google.
BUG=
TBR

Review-Url: https://codereview.chromium.org/2936063002 .
 2017-06-13 14:23:20 -07:00
Emily Fortuna 32e0be82ff Reapply "Separate out loop closure information." 
This reverts commit d85512e0ad.

BUG=

Review-Url: https://codereview.chromium.org/2936693002 .
 2017-06-12 14:55:17 -07:00
Emily Fortuna d85512e0ad Revert "Separate out loop closure information." 
This reverts commit 5636a225d7.

BUG=

Review-Url: https://codereview.chromium.org/2936683002 .
 2017-06-12 11:01:09 -07:00
Emily Fortuna 5636a225d7 Separate out loop closure information. 
BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2932103002 .
 2017-06-12 10:07:09 -07:00
Peter von der Ahé d8783acfb3 Revert "Handle named mixin application in emitter" 
This reverts commit d109fad7f3.

Also, update status and ignore strong mode warning.

R=erikcorry@google.com

Review-Url: https://codereview.chromium.org/2933093002 .
 2017-06-12 14:21:34 +02:00
Johnni Winther d109fad7f3 Handle named mixin application in emitter 
Fixes regression in language/regress_18713_test with --csp

Review-Url: https://codereview.chromium.org/2934783002 .
 2017-06-12 11:49:29 +02:00
Johnni Winther 44258bc8eb Support field initializers and static/top-level fields in compile_with_dill_test 
+ a String literal!

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2931153002 .
 2017-06-12 10:01:25 +02:00
Johnni Winther 7bd8cfe670 Handle instance fields in compile_from_dill_test 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2929143002 .
 2017-06-12 09:46:37 +02:00
Johnni Winther b1f129d258 Add MemberEntity.member and refactor Emitter.getReflectionName to avoid mixin Selector and Entity 
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2933553002 .
 2017-06-12 09:42:22 +02:00
Johnni Winther bed356cd46 Add FrontendStrategy.commonElements and remove Backend.commonElements 
This a step towards support different models between the frontend and the backend.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2932883002 .
 2017-06-12 09:35:22 +02:00
Johnni Winther 61c100da49 Rename FrontEndStrategy to FrontendStrategy 
It hurts my eyes to see

  FrontEndStrategy frontEndStrategy ...
  BackendStrategy backendStrategy ...

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2932793005 .
 2017-06-12 09:30:18 +02:00
Emily Fortuna d9015a73ea Separate out ClosureAnalysisInfo to separate interfaces between what 
the SSA builder needs to know and what the locals handler needs.

BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2928063002 .
 2017-06-09 13:29:17 -07:00
Johnni Winther 89e2719f2f Support user class in compile_from_dill_test 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2927093002 .
 2017-06-09 12:35:53 +02:00
Johnni Winther 29535a6ad9 Handle new Object() in compile_from_dill_test 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2927043002 .
 2017-06-09 12:03:55 +02:00
Johnni Winther 0f7ee4a6ed A step towards handling new Object() in compile_from_dill_test 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2925263002 .
 2017-06-09 11:58:30 +02:00
Peter von der Ahé 001ac97389 Implement initializer asserts. 
Closes https://github.com/dart-lang/sdk/issues/29762

R=kasperl@google.com

Review-Url: https://codereview.chromium.org/2930673002 .
 2017-06-08 13:46:26 +02:00
Johnni Winther 1b6d8cacce Introduce JsStrategy skeleton 
This is currently an identity conversion from the frontend model but
it serves as a basis to create actual J-elements corresponding to the
K-elements.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2929643002 .
 2017-06-08 09:36:05 +02:00
Johnni Winther 412f2cff8d Handle parameters in compile_from_dill_test 
R=efortuna@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2926863002 .
 2017-06-08 09:20:45 +02:00
Johnni Winther f538506e6d Avoid using FunctionSignature in builder_kernel 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2924803002 .
 2017-06-07 10:09:41 +02:00
Emily Fortuna c6195b03f6 Revert "Revert "Entity-ify some portions of LocalsHandler and Closure."" 
This reverts commit cdb41f9258.

Peter pointed out this caused a few analyzer errors. My "best tests" clearly fell short.

BUG=
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2926663002 .
 2017-06-06 13:34:24 -07:00
Emily Fortuna cdb41f9258 Revert "Entity-ify some portions of LocalsHandler and Closure." 
This reverts commit 03572798ff.

It was causing some type warnings.

BUG=

Review-Url: https://codereview.chromium.org/2931463002 .
 2017-06-06 12:10:12 -07:00
Emily Fortuna 03572798ff Entity-ify some portions of LocalsHandler and Closure. 
BUG=
R=johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2924693003 .
 2017-06-06 10:53:13 -07:00
Stephen Adams a146d932e5 invariant cleanup 
- remove inariant(), since all calls replaced wif failedAt()
- delete unused typedef

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2918253002 .
 2017-06-06 08:41:25 -07:00
Dmitry Stefantsov 09e755196a Pass a Target instance to DillTarget instead of its name 
R=ahe@google.com

Review-Url: https://codereview.chromium.org/2924833002 .
 2017-06-06 16:03:49 +02:00
Emily Fortuna faaba67a91 Revert "Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst."" 
This reverts commit 7bd51eb191.

BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2920253004 .
 2017-06-05 15:36:26 -07:00
Emily Fortuna 7bd51eb191 Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst." 
This reverts commit b7661431bf.

(I'm reverting just so I can get the tree green and then fix offline.)

TBR=jmesserly@google.com

BUG=

Review-Url: https://codereview.chromium.org/2924663002 .
 2017-06-05 13:06:55 -07:00
Emily Fortuna b7661431bf Make ClosureTask only accept Element-level APIs instead of resolvedAst. 
BAAAAABY STEPS here.
BUG=
R=johnniwinther@google.com, sigmund@google.com

Review-Url: https://codereview.chromium.org/2921673003 .
 2017-06-05 10:34:17 -07:00
Stephen Adams 7c4e5d53e7 Use failedAt in more places (ssa) 
TBR=johnniwinther@google.com

BUG=

Review-Url: https://codereview.chromium.org/2925443002 .
 2017-06-03 05:10:47 -07:00
Stephen Adams 49e2cfc295 Use failedAt in more places 
R=johnniwinther@google.com

BUG=

Review-Url: https://codereview.chromium.org/2917653002 .
 2017-06-03 02:48:16 -07:00
Johnni Winther 3e876bb010 Revert "Only call MirrorsData.retainMetadata* from codegen" 
This reverts commit 7b9875cd8c.

Review-Url: https://codereview.chromium.org/2915343002 .
 2017-06-02 22:07:08 +02:00
Johnni Winther 872a50cc2f Compute constants from IR nodes 
+ skip generateCodeWithCompileTimeErrors:
    KernelAstAdapter cannot handle all ConstantExpression for erroneous code
+ allow runtime-error in language/final_syntax_test/none:
    Constantifier currently don's support non-cyclic reference of final fields as constant expressions

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2916393002 .
 2017-06-02 22:03:46 +02:00
Johnni Winther ed01aef046 Support locals in compile_from_dill_test. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2916353002 .
 2017-06-02 21:14:52 +02:00
Johnni Winther 7b9875cd8c Only call MirrorsData.retainMetadata* from codegen 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2921933002 .
 2017-06-02 21:00:32 +02:00
Johnni Winther 8acac25e5e Handle list and map literals 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2918913003 .
 2017-06-02 20:53:15 +02:00
Dan Rubel 5b6d7653fe fix unterminated interpolation expression handling 
R=ahe@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2914213003 .
 2017-06-02 13:47:08 -04:00
Dmitry Stefantsov 1e2f06f8da Reapply "Use backend targets to run Kernel transformations in Fasta" 
This reverts commit 0b424ca5d2

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2919003003 .
 2017-06-02 16:10:28 +02:00
Johnni Winther 43dc39c585 Avoid adding constants for emission during resolution. 
Review-Url: https://codereview.chromium.org/2915173003 .
 2017-06-02 14:26:55 +02:00