dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4835 Commits

Author SHA1 Message Date
Emily Fortuna b7ef9072f1 Set "type" for FutureOr to dynamic (temporarily). 
Bug:
Change-Id: Ie4a376316c0fa444642c2535c0a97f3245c92fda
Reviewed-on: https://dart-review.googlesource.com/24621
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-11-30 18:18:04 +00:00
Johnni Winther 9ddb267c41 Use [StackFrame] class to hold data local to the current member in KernelSsaGraphBuilder 
Change-Id: I6f80ef33f7da3a3b332dea6a44bd435d16bbd06b
Reviewed-on: https://dart-review.googlesource.com/24461
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-30 09:32:11 +00:00
Johnni Winther c5034c6532 Remove enterInlinedMember and leaveInlinedMember from KernelToLocalsMap 
Change-Id: I9a33e7ba4b499785c50916c09496a35eaf99c301
Reviewed-on: https://dart-review.googlesource.com/24422
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-11-30 08:46:11 +00:00
Johnni Winther 5a238b215a More source information 
+ on super calls
+ null tests
+ logical and

Change-Id: I136500544d14afa5cbaf431ec12dfb1516c38d29
Reviewed-on: https://dart-review.googlesource.com/24480
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-30 08:45:39 +00:00
Stephen Adams e81ff9cb60 Avoid using Set as worklist 
It can be slow: https://github.com/dart-lang/sdk/issues/31470

Bug:
Change-Id: Id8dd5b0d158d04ad6387f868a774d047d2b99760
Reviewed-on: https://dart-review.googlesource.com/24504
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-29 23:58:10 +00:00
Johnni Winther 87b2e063cf Make source information a required argument on several H-nodes 
Change-Id: I35218dc46602c28a2d8c38b3bb36bddaa896475b
Reviewed-on: https://dart-review.googlesource.com/23780
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 11:43:49 +00:00
Johnni Winther 93d03da1db Add source information to yield* and async* 
Change-Id: I4e3f09f60527c0ea501b266abca6b70dc01d1a64
Reviewed-on: https://dart-review.googlesource.com/23668
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 10:16:54 +00:00
Johnni Winther 9bfef29e21 Add source information to throw/try/await in async and yield in sync* 
Change-Id: I8559aaf40c3cb12892113b7373608dc0eed3cb45
Reviewed-on: https://dart-review.googlesource.com/23680
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 09:56:09 +00:00
Johnni Winther 03aab05eea Add source information on try, is and as 
Change-Id: I83eaad5913eead816d28286d31e370cafeb7f52b
Reviewed-on: https://dart-review.googlesource.com/23520
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 09:43:20 +00:00
Johnni Winther bc32fb7e42 Add sourcemapping to (simple) async methods. 
Change-Id: Ia1dbf85d75b2dd2c3c0308aa8ff4c65605c62481
Reviewed-on: https://dart-review.googlesource.com/23380
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 09:22:10 +00:00
Johnni Winther 758306af54 Provide source info on switch, boxing and capture 
Change-Id: I6d8deaa5d523a1f9346c773295f3d1152636f01a
Reviewed-on: https://dart-review.googlesource.com/23665
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 09:06:41 +00:00
Emily Fortuna 6557792b5b Add information about what types are instantiated when dealing with 
factories and reified generics.

Bug:
Change-Id: Ia34b08859f1e54e7dc8fc3f8d51a1e78a1fa0e41
Reviewed-on: https://dart-review.googlesource.com/24022
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-11-28 01:00:53 +00:00
Stephen Adams 321dbe92b4 Make use of type parameter on JS pseudofunction 
Change-Id: I52d0190cd1aad42a3b35d7327a65fd680524c698
Reviewed-on: https://dart-review.googlesource.com/23724
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-28 00:57:33 +00:00
Johnni Winther 69106c6c8c Support simple static inlining from kernel. 
Change-Id: Ie9a062b2d825c9fb0ed7bd5933eb7cf841509409
Reviewed-on: https://dart-review.googlesource.com/23660
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-27 10:19:41 +00:00
Johnni Winther da9d21c49e Add inlining test 
Change-Id: I17663d41d0f4e2b6f3bb7f44bed694cfff7fac38
Reviewed-on: https://dart-review.googlesource.com/23481
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-27 09:22:57 +00:00
Johnni Winther d29cd4f183 Add toText to SideEffects and TypeMask for testing 
- and make toString more structured.

Change-Id: If62cfb8e7ee110db6dfb713236e119e7e2f0e244
Reviewed-on: https://dart-review.googlesource.com/22401
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-27 09:12:42 +00:00
Emily Fortuna d3eef66367 Add function parameter type checks in checked mode with constructors and loop variables. 
Bug:
Change-Id: Ib3245eb59c9f23b31e4a0b1c65a25f1c2ad3188f
Reviewed-on: https://dart-review.googlesource.com/23143
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-11-22 19:57:04 +00:00
Stephen Adams 3f9f7bb61d load elimination: do not create phis for for-in length check 
Refinement of previous CL avoids the handful of regressions generated
by the previous CL.

R=johnniwinther@google.com

Change-Id: Ifea90d48a339aa94dee0f73485f8ec24f10d9e53
Reviewed-on: https://dart-review.googlesource.com/22320
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-11-22 00:34:17 +00:00
Johnni Winther 3ee0a42842 Update source_mapping_test* to take arbitrary file input 
+ add the missing source information to HStringify found by through testing swarm with it.

Change-Id: Iaba9d8cc5c1ff2bee6a94988eb1916ac4abc66a2
Reviewed-on: https://dart-review.googlesource.com/22140
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 10:38:03 +00:00
Johnni Winther 9578eac4e2 Add source information to loops. 
Change-Id: I0d0ce8f39cba888741d8adffd7d07826dc82f93e
Reviewed-on: https://dart-review.googlesource.com/22120
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 10:23:17 +00:00
Peter von der Ahé a689397a36 Revert "Implement support for generic comment syntax in Fasta." 
This reverts commit f1959d6cd4.

Reason for revert: insufficient approval.

Original change's description:
> Implement support for generic comment syntax in Fasta.
> 
> Change-Id: I4c15a4adf2dbb50efd799b801dcb75a538bbe7d6
> Reviewed-on: https://dart-review.googlesource.com/21223
> Commit-Queue: Paul Berry <paulberry@google.com>
> Reviewed-by: Dan Rubel <danrubel@google.com>

TBR=paulberry@google.com,danrubel@google.com,sigmund@google.com

Change-Id: I047e4e87913002c6bd77e455599189349c123146
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/22460
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-11-21 10:08:39 +00:00
Johnni Winther 0a6782bab2 Reorganize source map tests, tools and helpers. 
Change-Id: Ie3e5ebb41377c709c6685046b46d6eeb711ddddf
Reviewed-on: https://dart-review.googlesource.com/22040
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 09:12:27 +00:00
Johnni Winther 5e6a6bd035 Test all files in sourcemaps/data 
Change-Id: I4cab4910818435c7d96bf494770e9b064b30cfc9
Reviewed-on: https://dart-review.googlesource.com/22000
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 08:49:28 +00:00
Johnni Winther a9fcb6b52d Make SideEffects.toString more readable. 
Change-Id: Ibf2b18ecba03ad33b3bb9b805f58a4fbc1a1838d
Reviewed-on: https://dart-review.googlesource.com/21960
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 08:46:47 +00:00
Stephen Adams 5aebf58b66 Add type parameter to JS pseudofunction. 
Bug: 31408
Change-Id: I90ce573c2022c2614269dcb73d2856fcc7573e24
Reviewed-on: https://dart-review.googlesource.com/21841
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-21 02:43:17 +00:00
Emily Fortuna 9e5ad7af1a Populate field setter method body for checked mode. 
Bug:
Change-Id: I802fc425b998ce1ff1110a7e48215b557035d442
Reviewed-on: https://dart-review.googlesource.com/22300
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-11-21 01:11:07 +00:00
Stephen Adams 5b13d23620 load elimination: do not create phis for length 
Do not create phis for length since it confuses bounds checker and
results in ugly code for for-in Array expansion.

Change-Id: I75160d38a8ad924b5a3f72fa4dd3d9f0d04e88b1
Reviewed-on: https://dart-review.googlesource.com/22303
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2017-11-21 01:07:57 +00:00
Paul Berry f1959d6cd4 Implement support for generic comment syntax in Fasta. 
Change-Id: I4c15a4adf2dbb50efd799b801dcb75a538bbe7d6
Reviewed-on: https://dart-review.googlesource.com/21223
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-11-20 22:01:27 +00:00
Johnni Winther f3c9d26cfb Compute side effects through SideEffectsBuilder 
Change-Id: Iec89f193a1bd4c897b94698457237e6b4fde9c1f
Reviewed-on: https://dart-review.googlesource.com/21721
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-20 09:28:08 +00:00
Johnni Winther d578cdb6a0 Test stacktrace sourcemaps for kernel. 
Change-Id: Ic2bf02ec8aaff9a1c2495768a9bf1b8362acccca
Reviewed-on: https://dart-review.googlesource.com/21802
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-20 09:17:20 +00:00
Sigmund Cherem 89aa45f7c7 Fixes in status-update script: 
* Off by one error
 * Re-sort records: this explains why sometimes we inserted records in the wrong
   place.

TBR

Change-Id: Ie6bb404cc120cc4caced973a1e2f34dc5f55b835
Reviewed-on: https://dart-review.googlesource.com/21788
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-18 01:43:46 +00:00
Emily Fortuna d74e73d320 Fix the CQ -- gardening. 
Bug:
Change-Id: If667c3f74e1314ec195a9a6edf64b6964fd334d2
Reviewed-on: https://dart-review.googlesource.com/21785
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-11-17 23:01:54 +00:00
Sigmund Cherem ba88fa0ad8 Add support to attach a message to the status file 
Change-Id: Ia8b31040696fa597ce607f620b9d7a62713a2cb4
Reviewed-on: https://dart-review.googlesource.com/21780
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-11-17 20:36:03 +00:00
Johnni Winther 5245aaa2e8 Register annotations on j: elements 
Change-Id: I8281491442c6b9dcba51d76a735d9aa2f8919273
Reviewed-on: https://dart-review.googlesource.com/21060
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-17 19:39:34 +00:00
Sigmund Cherem 5b957000a8 Add script to update status files for dartk/dartkp in strong mode automatically. 
This generalizes the dart2js script and adds a wrapper shell script to invoke
it.

Change-Id: I36e83f92204adc9f655619693b5841366edacaa7
Reviewed-on: https://dart-review.googlesource.com/21704
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-11-17 19:37:13 +00:00
Emily Fortuna c7dadec876 Capture this and type variables in closures in checked mode when needed. 
Bug:
Change-Id: I9e3bbc658590bcb6ec04cff4323cc2a97c20fc6b
Reviewed-on: https://dart-review.googlesource.com/21321
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Emily Fortuna <efortuna@google.com>
 2017-11-16 21:22:41 +00:00
Morten Krogh-Jespersen 4f98da3fca Remove sdk/ from paths to allow running outside repository. 
Bug:
Change-Id: Ie3abc56e9d3594528d4f7f4e52a3c78bea23f575
Reviewed-on: https://dart-review.googlesource.com/21422
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-16 19:22:28 +00:00
Johnni Winther 253eaef945 Add source information for invocations and operators in the kernel ssa builder. 
Change-Id: If9e77c773e5ca722f100e92f6ff4e417efda9d5e
Reviewed-on: https://dart-review.googlesource.com/20700
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-16 09:46:29 +00:00
Emily Fortuna bf94e73568 Fix up type inference to run in checked mode and enable checked mode tests running with kernel script. 
Bug:
Change-Id: If720b6868fbdf010f4aac614ceea1ddea533c277
Reviewed-on: https://dart-review.googlesource.com/21222
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-15 22:34:51 +00:00
Dan Rubel b5df8d7b0f Add fasta parser recovery for invalid operator name 
Change-Id: I10e7f2668f654f7be482b3ce1521d1872d6a6b34
Reviewed-on: https://dart-review.googlesource.com/20826
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2017-11-15 15:49:22 +00:00
Harry Terkelsen 0ccaef195e Do not add superclass members to deferred loading deps 
When we changed this from the element model we changed

cls.implementation.forEachMember

to

elementEnvironment.forEachClassMember

The difference is that forEachMember doesn't iterate over
superclass members by default, while forEachClassMember does.

Change-Id: I25dffa7744317af9928505df3140b66df221c17e
Reviewed-on: https://dart-review.googlesource.com/20902
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-11-14 22:06:44 +00:00
Emily Fortuna 4c8b26ab5f Fix infinite recursion runtime error in checked mode with Kernel. 
Bug:
Change-Id: I6612a97ec6d2b802aec024d905025aeb4ed2af97
Reviewed-on: https://dart-review.googlesource.com/20560
Commit-Queue: Emily Fortuna <efortuna@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-14 19:56:24 +00:00
Johnni Winther d3c000beaf Prepare source_mapping_*_tests for kernel. 
Change-Id: I89b3b2694adf91fb12cc8bbabd6f94528eb85bb9
Reviewed-on: https://dart-review.googlesource.com/20280
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-14 08:36:04 +00:00
Johnni Winther e8e3fb5224 Reenable source map tests 
- and fixes regressions + add more coverage for the regressed parts

Change-Id: Ied0aa54389164650b4fcd8f0363ddabb60c00a77
Reviewed-on: https://dart-review.googlesource.com/20204
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-14 08:18:44 +00:00
Harry Terkelsen 3e88496489 Don't process closures for extra loop information 
Change-Id: I9585786ba07767c618233226cc96a9b7bcd21f4b
Reviewed-on: https://dart-review.googlesource.com/20540
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-11-13 20:08:20 +00:00
Johnni Winther de6dab1a09 Handle loadLibrary in inferrer 
Change-Id: I4822a016fc5f74e37c1905de2d529b09dc44531c
Reviewed-on: https://dart-review.googlesource.com/20420
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-11-13 11:58:54 +00:00
Johnni Winther ff7cfea850 Turn on inference by default with --use-kernel 
Change-Id: I3f320cc5aa8f265b45c73c9d3023950d8ed4240b
Reviewed-on: https://dart-review.googlesource.com/20064
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-13 10:51:03 +00:00
Johnni Winther 9ce12fc134 Skip abstract methods in KernelToElementMap.getSuperMember 
Change-Id: Ic6d452cd3352fc557d59a54a37db4396c6a24d14
Reviewed-on: https://dart-review.googlesource.com/20100
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-13 09:33:34 +00:00
Johnni Winther 2ef55e96a5 Improve helpers for work on and test of inference. 
Change-Id: I111d3f286072605941d27d2b0922f9fa3347980c
Reviewed-on: https://dart-review.googlesource.com/20062
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-13 09:03:52 +00:00
Johnni Winther f3d7a95343 Correctly refine calls to locals in old inferrer. 
Closes #31333

Change-Id: I9336639a5d4774c9bbf444246d0458621b5f2a79
Reviewed-on: https://dart-review.googlesource.com/20000
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-13 08:52:54 +00:00