dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4835 Commits

Author SHA1 Message Date
William Hesse 3b2e368376 Revert 5 changes with failures 
TBR=askesc@google.com

Revert "[CFE] Move constant evaluator to Fasta."

This reverts commit 845b5b2df1.

Revert "[CFE] Always call the constant evaluator by the evaluate method."

This reverts commit 91bc4ec2b9.

Revert "[CFE] Use Fasta diagnostics in the constant evaluator."

This reverts commit c7b572aa29.

Revert "[CFE] Check for null in constant evaluation"

This reverts commit e6d2751e9c.

Revert "Rename import after moving file."

This reverts commit a6e2c5eb4c.

Change-Id: Iadfe087c0110f6f331b82d990213f95d3ef4541b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97223
Reviewed-by: William Hesse <whesse@google.com>
 2019-03-18 12:25:32 +00:00
William Hesse a6e2c5eb4c Rename import after moving file. 
Fixes error in commit of
https://dart-review.googlesource.com/c/sdk/+/96081

Change-Id: I628de76467ef8696f1c83d919c00821ccedfb852
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97222
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-03-18 12:11:42 +00:00
Aske Simon Christensen 845b5b2df1 [CFE] Move constant evaluator to Fasta. 
This is in preparation for recognizing Fasta-specific nodes in the
constant evaluator, and for using the Fasta diagnostics framework.

Change-Id: I8535fbb68e622f1814a1d577c348d87e573b6b34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96081
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-18 10:42:14 +00:00
Johnni Winther 0cd89e5bd1 Handle ir constants in field analysis and impact tests 
Include initial handling of unevaluated constants from environment.

Change-Id: Ibd330a14dfabad1dee95b64ce7015939412374d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97112
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-18 10:30:04 +00:00
Nate Bosch 8475338d58 Remove references to non-existent Resource type 
These getters are unused and the type does not exist in `dart:core`.

Change-Id: Ib22e47a07cde454dd60ea713a6813e908b7b65b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97123
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2019-03-15 22:41:55 +00:00
Johnni Winther 7a2949521d Handle ConstantExpression in ssa and kernel impact 
The ssa builder now also fails if we have any unhandled nodes.

Change-Id: Ieaaa6a86edcc3ead0a46c70c2e513c1fe581aee8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97102
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-15 21:52:25 +00:00
Johnni Winther eb6f1b6abd Handle effectively constant fields in class stub generator 
Closes #36222

Change-Id: Ic8b7a3963e1364903b4b2d7871ff0b12cb134572
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97082
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-15 20:15:25 +00:00
Johnni Winther d0c4d6b329 Take variance into account when computing rti checks 
Change-Id: Ie3f93a6ac1fbf796b1c66bf29d2e9de51f5dee13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96942
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-15 09:40:14 +00:00
Sigmund Cherem a8c94d0b52 Remove tools we no longer need to manage status files 
Change-Id: Ia106c48cdbecaa8eec722ee11cbc9b6813989477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96860
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-03-14 19:16:24 +00:00
Brian Wilkerson c5624274e1 Update the SDK constraints to match the fact that set literals are being used 
Change-Id: I0c1de0d972a38ebd5c4f0b2fc2cda4258b63339f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96981
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-14 19:12:44 +00:00
Nate Bosch 28d697a6c1 Enforce override annotations in dart2js 
Update the excludes in the test directory analysis options to match the
files that were not updated to add override annotations.
Update the excludes in `testing.json` to match the analysis options.

With a consistent analysis options test config the diagnostics in
editors will match what is enforced by the test.

Also clean up the no longer required `enableSuperMixins` config.

Change-Id: If0e23642c25e0b5c1aced6a5a8c8c05a6da538f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96836
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2019-03-14 18:47:05 +00:00
Johnni Winther 1ac41d26b4 Support @Creates and @Returns from ir constants 
Change-Id: I5afa43354f70e42dad93a568afabb14d2004cf52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96784
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-14 08:44:46 +00:00
Nate Bosch 69a4f20347 Add override annotations consistently 
This makes it easier to follow class hierarchies and understand where a
class is changing the interface. I hit this when I found a class that
had the annotation on some methods it was overriding, but not all, which
made it confusing.

Prepares for adding the lint rule and enforcing it.

40% of overridden methods were annotated - add annotations to the remaining 60%.

Change-Id: I02472f4b6c5026a820cf9ff1a7ada663a60f1868
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96666
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-13 22:36:11 +00:00
Mayank Patke bc5d613533 Fix typo in diagnostic when non-bool is passed to logical or. 
Change-Id: I406c062359a0dfbb89f22a6a6cb25017eed740e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96823
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-03-13 18:12:23 +00:00
Johnni Winther 3bc3205e39 Move ConstantValue handling outside BehaviorBuilder 
Change-Id: Ie397c7e1a927e694de2d5968c9c962c024713633
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96659
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-13 10:34:37 +00:00
Johnni Winther 63e22ea497 Remove unused parts of NativeDataBuilder 
Change-Id: I449e0906f098f5d72f82894c6c24f5975da49e6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96656
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-13 10:34:37 +00:00
Johnni Winther f307524421 Support native member annotations through ir constants 
Change-Id: I247385c951d3a794afe7e4066b3b1d1ea14a76b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96641
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-13 09:08:27 +00:00
Johnni Winther 6a2aa920cd Support pragma annotations through ir constants 
Change-Id: I40b2662a00596ca9ebbb5301f99b541806e71515
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96280
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-12 09:28:32 +00:00
Johnni Winther 440b4cd84e Insert implicit casts when setting interface targets 
This preserves the invariant that method invocations and property sets
with an interface target handle static types at the call site.

This is a prerequisite to improving dart2js with implicit checks.
With this we can mark dynamic invocations a statically safe and
discover when instance methods don't need to check parameter types.

Change-Id: Ife7a3f947952b3c1f73316b922b2aa107343068e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95400
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-11 13:08:34 +00:00
Johnni Winther 231c5c138e Create codegen work item for all members 
Ensures that constants of effectively constant instance fields are
registered also with --omit-implicit-checks.

Change-Id: Icc31799f1cc5f565321c832780f30c711e9c8c50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96160
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-03-08 23:46:55 +00:00
Johnni Winther 068aa0d2e7 Support eagerly initialized static fields. 
Change-Id: I4265fe9bcfccc6a99627e57705868a7ee1da828d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94749
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-08 20:48:35 +00:00
Johnni Winther b8069cbeca Refactor computation of modular data 
Add ModularStrategy as a step towards loading modular data from disk.

Change-Id: I9d0baebef8899794742164be4350bedbd3da5b68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95650
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-08 08:36:07 +00:00
Johnni Winther 889d5d9240 Fix type error in node_tracer 
From https://dart-review.googlesource.com/c/sdk/+/94749
This is triggered by set literal testing.

Change-Id: I151f9154410790820e1f4d6301b0ccde52a72767
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95441
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-08 08:21:47 +00:00
Aske Simon Christensen b5a1f6c36b Reland "[CFE] Move constant evaluation number semantics handling to front end." 
This is a reland of c2b466b09f

Original change's description:
> [CFE] Move constant evaluation number semantics handling to front end.
> 
> JavaScript number semantics is currently implemented as the simplistic
> version previously present in DDC. This is a starting point for fully
> detailed JS number semantics.
> 
> Change-Id: Id728b3dacec892a5cbf7ece0d9faea51427f5f9b
> Reviewed-on: https://dart-review.googlesource.com/c/94746
> Commit-Queue: Aske Simon Christensen <askesc@google.com>
> Reviewed-by: Sigmund Cherem <sigmund@google.com>

Change-Id: I1a488ef41bda819d34cb45cd481fd8fd88bfb01e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95460
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Aske Simon Christensen <askesc@google.com>
 2019-03-06 10:30:37 +00:00
Johnni Winther ea6e83004b Use @pragma instead of package:meta/dart2js in tests 
Change-Id: I16c0ed6f391a417d8faa55e68cde902d91e3db32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95220
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-06 08:32:05 +00:00
Mayank Patke dc02d859f4 Ensure all SetConstantValues are JavaScriptSetConstants. 
Change-Id: Ifa89be6cb2ce856bd10465f2502e28f0ceb72586
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95487
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-05 23:41:29 +00:00
Johnni Winther 6227ab0b97 Replace @ForceInline with @pragma in dart:html 
Change-Id: I73afc500438d3fba92f549c8c1955f5ccad47751
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95033
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 12:17:18 +00:00
Johnni Winther 204651f3ab Replace package:expect annotations with @pragma 
Change-Id: Ib43d0d71a3ee8b0f0e6d676e6a3e448a107b7ca5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95180
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 11:00:17 +00:00
Johnni Winther 013cf68624 Replace js_helper annotations with @pragma 
@ForceInline is still used by dart:html, will be removed in a later CL.

Change-Id: I480325fe91cc6baefb17ead49f839442e023d441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95160
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-03-05 08:56:18 +00:00
Aske Simon Christensen 2b2e71770c [kernel] Add SetConstant node to Kernel. 
Change-Id: I83da1afc9f15009c650a871a51ca8171b482d4df
Reviewed-on: https://dart-review.googlesource.com/c/94863
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2019-03-04 10:20:56 +00:00
Johnni Winther 95cfa6c583 Support native class and js-interop annotations through ir constants 
Change-Id: I8e9deb1392dc98d958f13611a984e422b028265c
Reviewed-on: https://dart-review.googlesource.com/c/95032
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-04 08:40:15 +00:00
Johnni Winther 62d22083ac Flatten native member resolver 
Change-Id: I1bd775d23fd184f00232693549943c4082926564
Reviewed-on: https://dart-review.googlesource.com/c/95031
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-03-04 08:40:15 +00:00
Johnni Winther 9201b906ee Convert ir.Constant to ConstantValue 
Needed for passing the --enable-experiments=constant-update-2018 option to start working on ir.Constant nodes.

Change-Id: I4f3d8fa6a59ddbda1635fe2da64591bcffcb0f12
Reviewed-on: https://dart-review.googlesource.com/c/95030
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-01 18:46:00 +00:00
Johnni Winther ba4cfb8613 Initial computation of initializer complexity through the scope visitor. 
Change-Id: I2951624a0ad901c7c518b6e5d2f147dceae870cc
Reviewed-on: https://dart-review.googlesource.com/c/94382
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-03-01 08:37:12 +00:00
Johnni Winther 9a4c49f301 Update field analysis tests to prepare for eager initializer improvements 
Change-Id: Ie9611ed269a42be4d7c406739cf935d569d8606a
Reviewed-on: https://dart-review.googlesource.com/c/94297
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-28 10:32:06 +00:00
Johnni Winther 1720704594 Recognize effectively constant static fields 
Change-Id: Ic8f7a014a6af2f9d8854e0731fe0d2df11b554da
Reviewed-on: https://dart-review.googlesource.com/c/94281
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-28 09:12:26 +00:00
Sigmund Cherem 50ab52d567 Use raw is-check when type arguments match the bounds 
Change-Id: Ifa7353cbfe9497bb9ed6bc19351451a4becd496b
Reviewed-on: https://dart-review.googlesource.com/c/94460
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-02-27 22:41:40 +00:00
Sigmund Cherem 36c14db2d3 Only refine non-null in SSA 
Code-size difference on a large app is very small (0.007% worse), but
this cuts the time spent in type-propagation by more than half
(23s -> 10s on my machine).

I saw a 0.4% code-size regression in pop-pop-win, but that is
recovered once we are smarter about generating simple is-checks
when the "raw" type can be used because the type arguments
match the bounds (see separate CL).

Change-Id: I45c0fb1afabdca3d045aec576c131ed764dc31ce
Reviewed-on: https://dart-review.googlesource.com/c/94120
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2019-02-27 21:48:00 +00:00
Sigmund Cherem a6b76df8d8 Add flag to re-run global inference when reading a data file. 
This private flag is useful when iterating on global inference on large apps to
avoid building the closed world

Change-Id: I418fc077adc182b91f03dadedb38b51c8bad35e0
Reviewed-on: https://dart-review.googlesource.com/c/94470
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-02-27 18:16:02 +00:00
Sigmund Cherem 82a15835f0 Short-circuit logical operators in constants 
Closes https://github.com/dart-lang/sdk/issues/35801

Change-Id: I32c8c5c57a0800d7668ad508d762ba797da39820
Reviewed-on: https://dart-review.googlesource.com/c/94469
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-02-27 18:07:57 +00:00
Johnni Winther edcaa05375 Support @pragma('dart2js:noElision') on non-internal methods 
Change-Id: Ifae3f76107086f6ad47de2f9eda7b7aec589fc89
Reviewed-on: https://dart-review.googlesource.com/c/94284
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-02-27 09:46:52 +00:00
Stephen Adams 05bba46133 Use DFS numbering for block dominates test 
Change-Id: Ieb4864e77ec3b92d9c91cca3507dad590b834ec4
Reviewed-on: https://dart-review.googlesource.com/c/94362
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
 2019-02-26 19:20:00 +00:00
Mayank Patke 3d3f6f9d4b Remove immediateUnderSetLiteral. 
Change-Id: I5abb8bb6dafa2a7ee88ce4bf559bae20ac0998fd
Reviewed-on: https://dart-review.googlesource.com/c/92401
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-26 18:38:00 +00:00
Mayank Patke 7b86d78f07 Enable set literal lowering in dart2js. 
Change-Id: I0d608713d7138f66ea46011abbb845d4a70c7521
Reviewed-on: https://dart-review.googlesource.com/c/92150
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-26 18:38:00 +00:00
Sigmund Cherem 5192cd1008 Narrowing improvements in dart2js global inference. 
* no longer narrow by selector use, only narrow by type and non-null
* check for narrow nesting
* add non-null in a couple known places

One large apps, I compared the type-masks in dump-info and all differences were improvements with non-null. We weren't doing any narrowing based on the possible targets of a selector.

Change-Id: I270f360f70fbe3171d09ccd71d10517be9140194
Reviewed-on: https://dart-review.googlesource.com/c/90340
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2019-02-23 00:10:11 +00:00
Mayank Patke ed796fcc3e Reland "Flatten constant operations to implement JS semantics by default." 
This is a reland of 8172270c95

Original change's description:
> Flatten constant operations to implement JS semantics by default.
>
> Change-Id: Id93e9a1ce77d8035928ba0b9c338a1030d0e13bd
> Reviewed-on: https://dart-review.googlesource.com/c/93960
> Commit-Queue: Mayank Patke <fishythefish@google.com>
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Change-Id: I33a167324bfb0825c23860b3f96fcb9d735395d1
Reviewed-on: https://dart-review.googlesource.com/c/94108
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-02-23 00:06:31 +00:00
Mayank Patke 8fface97f0 Reland "Eliminate singleton/static access to the constant system and expose its functionality at the top level." 
This is a reland of 027b76ecbf

Original change's description:
> Eliminate singleton/static access to the constant system and expose its
> functionality at the top level.
>
> Use sites have been updated to import the library with a prefix.
>
> Change-Id: I0f5e4e47bec089d2d0dc2fcd50caccfd98947cf5
> Reviewed-on: https://dart-review.googlesource.com/c/93842
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Change-Id: Ib04a9d48c8dca51020258313256e0fb0df330d9b
Reviewed-on: https://dart-review.googlesource.com/c/94107
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-23 00:06:31 +00:00
Mayank Patke e40b0e04c9 Reland "Merge the JavaScript constant system into the base constant system and flatten the inheritance hierarchy." 
This is a reland of cf51eb2fba

Original change's description:
> Merge the JavaScript constant system into the base constant system and
> flatten the inheritance hierarchy.
>
> dart2js only needs one constant system at most.
>
> Change-Id: I72e446652ea44298677e986b06e63152e381353b
> Reviewed-on: https://dart-review.googlesource.com/c/93880
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Change-Id: I83960035a7b0989397f9646f2f834ec468aa4908
Reviewed-on: https://dart-review.googlesource.com/c/94106
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-23 00:06:31 +00:00
Mayank Patke 6bdd38ae84 Reland "Move the JavaScript constant system into constants/constant_system.dart in preparation to merge it with the base constant system and flatten the constant system hierarchy." 
This is a reland of 1702b986c8

Original change's description:
> Move the JavaScript constant system into constants/constant_system.dart
> in preparation to merge it with the base constant system and flatten the
> constant system hierarchy.
>
> Change-Id: I6ef27b210515140d4516336fea015f74c8a0cd6a
> Reviewed-on: https://dart-review.googlesource.com/c/93840
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Change-Id: I20ef9755886a6b54135aa7169c9d7de08e8cbe93
Reviewed-on: https://dart-review.googlesource.com/c/94105
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-23 00:06:31 +00:00
Mayank Patke 960b08a969 Reland "Remove the Dart constant system and move all required classes into the JavaScript constant system." 
This is a reland of 5af8de8954

Original change's description:
> Remove the Dart constant system and move all required classes into the
> JavaScript constant system.
>
> Change-Id: I2a31ea743270459284c42b615b0dffd1c7aa2584
> Reviewed-on: https://dart-review.googlesource.com/c/93746
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>

Change-Id: I8c8399e94dd80c1f543a54454efc9cf59ef6ac7b
Reviewed-on: https://dart-review.googlesource.com/c/94104
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-02-23 00:06:31 +00:00