Brian Wilkerson
0bb8cbd9cb
Use void in place of Null in analyzer_plugin
...
Change-Id: I21a3d3646c5906256e21fb8d7d71f8433b1b39e9
Reviewed-on: https://dart-review.googlesource.com/69500
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-08-11 15:30:28 +00:00
Devon Carew
6fc1dd4480
analyzer_plugin no implicit-casts.
...
Change-Id: I12e5d4da5b61938b3eb7cc7c0e2ade6a64510b9e
Reviewed-on: https://dart-review.googlesource.com/69201
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-09 22:41:41 +00:00
Danny Tuppeny
b2d0f8ea63
Remove tests relating to selected parameter index + bump version number
...
Change-Id: I2417b202b6b11b4c714f4c1d92edb13fd8d0ccc3
Reviewed-on: https://dart-review.googlesource.com/66572
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-07-26 13:51:19 +00:00
Danny Tuppeny
d792809d6f
Add signature param defaultValue and remove (unused) selectedParameterIndex
...
Bug: https://github.com/dart-lang/sdk/issues/27034
Change-Id: I3409ab544b79a7f64d6d41e5d091ca20418f248a
Reviewed-on: https://dart-review.googlesource.com/66562
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-07-25 15:42:44 +00:00
Danny Tuppeny
ebb033cb72
Add signature information to spec and add basic implementation for functions
...
Bug: https://github.com/dart-lang/sdk/issues/27034
Change-Id: I8d3f1a9c9a824b4b80f9cfa0370a439fa897b226
Reviewed-on: https://dart-review.googlesource.com/64689
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-07-25 07:16:52 +00:00
Devon Carew
17b53a2835
Test out no_implicit_casts on the analyzer source base.
...
Change-Id: I4eb2414d7d9bbe21883c9e5e8eca10f2eaafb465
Reviewed-on: https://dart-review.googlesource.com/62725
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2018-06-28 02:20:43 +00:00
Devon Carew
b20dc7b98a
Update the script to re-gen the analysis server spec.
...
Change-Id: I9196cabf891d2260aeb7b89fce3aea91cdb0b726
Reviewed-on: https://dart-review.googlesource.com/62580
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-06-27 16:00:57 +00:00
Danny Tuppeny
3af09b5b26
Add support for invocation + list/map literal folding
...
Bug: https://github.com/Dart-Code/Dart-Code/issues/966
Change-Id: Id85471f095b26349e60e0b10f89b4465d4c9b138
Reviewed-on: https://dart-review.googlesource.com/58740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-06-07 09:05:33 +00:00
Danny Tuppeny
568e977a35
Update FoldingKinds enum, update specs and increase version number
...
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: Ieccfd90ead67a9803744c54db4eec8eea0b0403c
Reviewed-on: https://dart-review.googlesource.com/54920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2018-05-14 16:48:48 +00:00
Brian Wilkerson
d3295ded48
Remove the SORT_MEMBERS refactoring from the spec
...
Change-Id: Ic8b8135f22d8c3c07d4ded661ac43d2d5105dc3f
Reviewed-on: https://dart-review.googlesource.com/48464
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-03-27 16:37:44 +00:00
Konstantin Shcheglov
6bd38cc912
Analysis Server API for 'Extract Widget' refactoring.
...
R=brianwilkerson@google.com
Change-Id: Ie6b7c349d304785ab6829770ebd3504c0affe8df
Reviewed-on: https://dart-review.googlesource.com/47943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-03-22 20:25:29 +00:00
Konstantin Shcheglov
e1909cb52a
Update Outline protocol - change offset/length, add codeOffset/codeLength.
...
R=brianwilkerson@google.com
Change-Id: I4b5c03a21254f7c497adc4c043641b18599c5c39
Reviewed-on: https://dart-review.googlesource.com/45764
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-03-09 01:52:57 +00:00
Brian Wilkerson
602a8c2a7b
Clean up usage of deprecated constants
...
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-03-09 01:02:49 +00:00
pq
a4ecc44c30
Completion protocol API for overrides.
...
Proposed API to allow IDEs to ask a suggestion for a displayText which may differ from the value to insert (the completion).
Also, adds a new OVERRIDE suggestion kind.
See: https://youtrack.jetbrains.com/issue/WEB-31130
Change-Id: Ic0644308d746ac7771bc27bc2ff2789444733af3
Reviewed-on: https://dart-review.googlesource.com/40101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-02-09 17:57:17 +00:00
Konstantin Shcheglov
ffd67154f7
Add a new optional field - 'id' to SourceChange.
...
R=brianwilkerson@google.com
Change-Id: Ibe85415be35982327593ffd1187ec74b1d037463
Reviewed-on: https://dart-review.googlesource.com/40102
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-08 20:13:11 +00:00
Devon Carew
47a861ca85
Add two new element types to the protocol.
...
Bug:
Change-Id: I5a60081d7c8500590bbabb9ee6dce74fa611b0a3
Reviewed-on: https://dart-review.googlesource.com/14883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-18 19:02:47 +00:00
Devon Carew
a5c2256455
Send test element kinds for test outline items.
...
Bug:
Change-Id: Iebea8d4b9705c726e297722ef1678e1a2cd1ea96
Reviewed-on: https://dart-review.googlesource.com/12841
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 17:00:41 +00:00
Konstantin Shcheglov
455984bbf9
Fix fuzzy arrow warnings in analyzer and analysis_server.
...
There is one warning which I'd like to fix in a separate CL.
The rest is because of package:test predicate().
I think Leaf fixed it in https://github.com/dart-lang/matcher/commit/3625f13698346576da0f5baf44e95abc9c56fb49
R=brianwilkerson@google.com
Bug:
Change-Id: I060f7ced55dbcc460185916251c47ebbd5c838d3
Reviewed-on: https://dart-review.googlesource.com/3404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-06 00:26:18 +00:00
Brian Wilkerson
37042bb59b
Add an integration test for kythe support with bug fixes
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3006693002 .
2017-08-28 10:07:04 -07:00
Konstantin Shcheglov
f78d43c3d3
Convert GeneratedContent to async and use AnalysisDriver for tasks graph.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/3002293003 .
2017-08-26 07:51:34 -07:00
Brian Wilkerson
579a032564
Add kythe support to plugins and format the spec files
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/2994103002 .
2017-08-10 11:24:40 -07:00
Paul Berry
e2f77056a5
Eliminate dependencies on pkg/front_end.
...
The API for pkg/front_end is still in flux so we want to avoid having
any packages depend directly on it (other than analyzer and
back-ends).
This CL re-exports some of the critical pieces of front_end needed by
analyzer clients so that those clients can access them via analyzer,
without having to directly depend on front_end. It also updates
pkg/analyzer_plugin to make use of those re-exports.
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2993123002 .
2017-08-07 09:46:30 -07:00
Brian Wilkerson
cc7b83f4da
Mark refactoring support for plugins as experimental
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2990573003 .
2017-07-26 07:43:55 -07:00
Brian Wilkerson
8bbf373a5e
Remove the analysus.reanalyze request from the plugin API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2988743002 .
2017-07-25 12:10:52 -07:00
Brian Wilkerson
6248df44a6
Add the tests of the spec generator to the unit tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2966623003 .
2017-06-30 10:08:51 -07:00
Brian Wilkerson
4749014b06
Remove an unused request and the associated type
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2964113003 .
2017-06-30 09:44:59 -07:00
Brian Wilkerson
99cc563718
Update the spec to deprecate fileStamp
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2964653002 .
2017-06-30 08:21:47 -07:00
Brian Wilkerson
9ddb832e10
Generate constants in server as we do in plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2960073002 .
2017-06-28 08:21:33 -07:00
Brian Wilkerson
24996fbfe7
Add support to pass the location of the analysis options file to plugins
...
R=mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2947743002 .
2017-06-20 07:41:03 -07:00
Devon Carew
8df017b670
Re-gen analysis server specs.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2911783002 .
2017-05-27 12:42:17 -07:00
Brian Wilkerson
7f5e1f260f
Add a getNavigation request for plugins
...
R=mfairhurst@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2908523002 .
2017-05-25 10:51:24 -07:00
Brian Wilkerson
7e11a13cf5
Add requestTime to responses
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2890163004 .
2017-05-18 10:32:47 -07:00
Brian Wilkerson
daffcecc11
Pass the sdk path to plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2885993004 .
2017-05-17 08:19:49 -07:00
Brian Wilkerson
7d26ff6d4f
Remove some more library directives
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884233004 .
2017-05-17 08:02:08 -07:00
Brian Wilkerson
e2ebf96aea
Stop sharing two types between wire protocols
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2883793002 .
2017-05-15 07:57:27 -07:00
Brian Wilkerson
3085734ef6
Generate common types into a separate library
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2880443006 .
2017-05-13 08:12:14 -07:00
Brian Wilkerson
2cbcd96327
Allow the common spec types to be in a separate document
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2876023003 .
2017-05-12 12:24:05 -07:00
Brian Wilkerson
e55812a3f2
Unify the server and plugin versions of the generators
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2844273003 .
2017-04-28 07:46:29 -07:00
Devon Carew
eb1839b8fd
Minor changes to the generated spec, and display deprecated methods better.
...
BUG=
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2800283002 .
2017-04-15 13:43:36 -07:00
Brian Wilkerson
385cbc3839
Apply changes made to server spec generator
...
R=messick@google.com
Review-Url: https://codereview.chromium.org/2787703003 .
2017-03-30 10:04:40 -07:00
Devon Carew
a231501692
Format generated files.
...
BUG=
R=brianwilkerson@google.com , jacobr@google.com
Review-Url: https://codereview.chromium.org/2765953002 .
2017-03-21 15:54:16 -07:00
Paul Berry
c78b4d66bb
Move some of analyzer's code generation utilities into front_end.
...
These utilities are needed for generating the code that supports
summaries; in order to move summary logic into front_end, we will need
these code generation tools in front_end as well.
Also make a minor change to summary code generation logic so that it
talks to the file system directly rather than depending on analyzer's
file system abstraction.
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2742333005 .
2017-03-14 12:30:18 -07:00
Brian Wilkerson
67b7952cf0
Update plugin spec to match server spec changes
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2739473007 .
2017-03-08 13:41:20 -08:00
Devon Carew
0f7fc43df5
Remove the --no-error-notification flag.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2713053002 .
2017-02-23 16:55:46 -08:00
Brian Wilkerson
6ca3a29f2f
Rename generated file
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2686933002 .
2017-02-08 13:26:02 -08:00
Brian Wilkerson
f70f023261
Add an interface for request parameters
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2679093004 .
2017-02-08 07:44:09 -08:00
Brian Wilkerson
82d0383566
Revert "Add an interface for request parameters"
...
Review-Url: https://codereview.chromium.org/2683583004 .
2017-02-07 13:34:58 -08:00
Brian Wilkerson
41685ccf9a
Add an interface for request parameters
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2680053002 .
2017-02-07 12:54:02 -08:00
Brian Wilkerson
4a40efa4c7
Add a priority to source changes for assists and fixes
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2678263005 .
2017-02-07 09:11:55 -08:00
Brian Wilkerson
17a447c89e
Update plugin spec
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2677663003 .
2017-02-07 08:03:15 -08:00