25edeb7ae1
Support completing the extension name locally
...
Change-Id: I49174918ca84f2aaafe4b47200e9396f2191a727
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116802
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-09-11 21:42:26 +00:00
4f8f592b51
Remove adding prefixes for auto imports.
...
Adding import prefixes often has false positives.
At this point I think that this feature does more harm than benefit.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/38326
Change-Id: I99e3400aebc062d9de3c298d7ed58520534d061c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116746
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-11 19:04:47 +00:00
eb60f0531e
Support a fix to add a setter, both in extensions and elsewhere
...
Change-Id: I94d7ec13a2bcf73b120be18facf473a4710a6e28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116053
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-06 21:59:14 +00:00
8022f885af
Stop using TestTypeProvider in analyzer_plugin.
...
R=brianwilkerson@google.com
Change-Id: Idfc57043d72793858805aed745db02c1740df28a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116081
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-06 19:01:29 +00:00
9f57cf71d7
Add a blacklist to spelling tests; spell-check all packages and sdk with blacklist
...
Change-Id: I5bf3d5784d2ba48568a2699bb09ae39a85be17c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115214
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-09-03 12:39:24 +00:00
b6897ea094
Stop using resolutionMap in analyzer and analysis_server.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ie8f75e330e9efee67ded892929a3d78b7de1c586
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-26 23:18:54 +00:00
74e09abc6e
[CFE] Remove/move file that wasn't needed by frontend; cleanup pubspec.yaml a bit
...
Change-Id: I204b844e7f1cb892a529bca3a13017ed836275f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114074
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-08-23 07:42:03 +00:00
04bd34ed87
Issue 37916. The name of ConstructorName cannot be shadowed.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/37916
Change-Id: I905e0b9ebfa4514f9a7f28555f95a2154bcf2f04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-20 18:31:41 +00:00
6408a9cc4d
Tweaks for writeType() and summary2.
...
R=brianwilkerson@google.com
Change-Id: If3c682f3dfc12a9e13d805bc25476b16249c7754
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113273
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-17 07:28:52 +00:00
802937e5a6
Add support for completions inside extension (and mixin) bodies
...
Change-Id: I549e91ac7a8e293ea6592043988a67a2da680620
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113133
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-08-15 16:39:05 +00:00
1a0fe21fb2
Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
...
This reverts commit b8614ca613https://dart-review.googlesource.com/c/sdk/+/110941
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-07-29 19:02:24 +00:00
b8614ca613
Revert InheritanceManager3 changes.
...
These changes were inadvertenly rolled out in a way that breaks
clients, so we need to stage them out more gradually. See discussion
at
https://dart-review.googlesource.com/c/sdk/+/110552/2/pkg/analyzer/lib/src/generated/resolver.dart#3768
This reverts commit 5b5ddeda92e76879acc427bec56744https://dart-review.googlesource.com/c/sdk/+/110841
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-07-28 13:54:09 +00:00
27bec56744
Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
...
Initial: 5d6bab4ed239afa4e555https://dart-review.googlesource.com/c/sdk/+/110552
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-26 16:16:11 +00:00
17e15ee9a4
Add outline support for extensions
...
Change-Id: I1b7145e899614b3d73d3fc2bfbe3dd7f773d38d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109880
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-07-22 21:12:40 +00:00
b0463ea7e0
Add DartFileEditBuilder.format(SourceRange)
...
R=brianwilkerson@google.com
Change-Id: I65228f586119385e32d944d608cf21b6bd0dae87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109549
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-18 20:18:22 +00:00
11bdc5ceab
Send context messages from server and plugins
...
Change-Id: I76b5c5697ee660980f3be7d8b3d4b99c2ffa2422
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108967
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Danny Tuppeny <dantup@google.com >
2019-07-15 15:27:43 +00:00
8b012ac780
Replace package mock in strings with files in tests/mock_packages.
...
R=brianwilkerson@google.com
Change-Id: I5240fbd90c8220d14ff41d6a98069f943e56aa6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108920
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-12 17:17:33 +00:00
c1d3bf8506
Issue 36890. Ignore the name that contains the caret during completion.
...
The previous implementation worked fine in tests, when we asked for
completion where the user does, but that's not what happens during
actual completion. Actually the 'offset' is at the start of the
identifier.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/36890
Change-Id: I5ceaff055580a18fe34d2c17ccacef8f4c7663b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-08 17:03:32 +00:00
d63466041c
Issue 131596231. Suggest names for SimpleFormalParameter(s).
...
R=brianwilkerson@google.com , jwren@google.com
Change-Id: I9074ef1a5aaeee32303dcf247c2be86f9c173d14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
2019-06-03 17:34:18 +00:00
2e51423c3d
Convert the way function types are displayed to better match the syntax of Dart
...
Change-Id: Id5068bd52b3a35c70cb0d2ccc735469e2f8a0d3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103701
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-05-28 20:48:51 +00:00
58f3098650
Issue 36890. Improve importing elements when incomplete code.
...
There might be some false negatives, when there *is* another top-level
declaration with the same name as we are removing. But this is a
pre-existing conflict, so I think we should not be very concerned. At
some point we might collect initial potentially conflicting names using
the same SyntacticScopeNamesCollector instead of element model. With
element model we don't know about parser recovery.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/36890
Change-Id: Ia05db299990f41f16feb493c2812237be84f3d2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-08 23:31:49 +00:00
9670b2ccb9
Update the server API to support context messages
...
Change-Id: Ic07ef7d01125ca76f72e8c0e370181ea4f6f7cb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100825
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
2019-05-01 01:31:44 +00:00
e2d0f5a50b
Add featureSet parameter to Parser constructor.
...
And deprecate old parser configuration setters.
Change-Id: Ib1507b8d2b20be7c883061e2a92ec9205d6a378f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100664
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-29 16:42:19 +00:00
e70273c306
Issue 36733. Completion in spread, if, and for elements.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/36733
Change-Id: I019741086495eaaf1f2dc078d801f61a0919cc78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100523
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-25 17:18:50 +00:00
cee1e41fe8
Plumb new FeatureSet class into Scanner.
...
And change clients of the scanner (within the SDK) to use it.
Long term, it would be better to store the FeatureSet object directly
in the Scanner and remove the existing flags `enableGtGt` and
`enableNonNullable`. However there are analyzer clients that
currently use these flags. So for now, we simply plumb in the
FeatureSet as a new way of setting AstBuilder flags. Once we've
updated clients to use FeatureSet, we'll publish a breaking version of
the analyzer that removes the old flag API.
Change-Id: I9e662f4ed45668d9acd4f56e42d7d8dae6180d48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99975
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-23 16:13:43 +00:00
096b296390
Improve importing elements when incomplete code.
...
R=brianwilkerson@google.com
Change-Id: I49db7a5904ac18d38d2986a5d8ae6fb94108bbe8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98876
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-09 15:53:43 +00:00
11a148c85e
Add the ability to associate a URL with a diagnostic
...
Change-Id: I06f694311130a36b1db4b4baf2e7d46d999f07b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97554
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-03-22 13:32:05 +00:00
3019a8873a
Check for completeness of test_all in analysis server and analyzer plugin
...
Change-Id: Ia25b1f93d5f2f3942f0c76d74556228a41410182
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97352
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-03-21 13:24:03 +00:00
7d277c4a32
Introduce methods and classes to replace "2" variants left over from "UI as code" work.
...
The AST refactor for "UI as code" left behind a few things whose names
ended in "2". This CL deprecates those things and creates
replacements that don't end in "2", so that we keep the API clean. In
a future breaking change release of the analyzer we'll remove the
deprecated things.
The following methods and classes are added:
- ForStatement and ForStatementImpl
- ListLiteral.elements
- SetOrMapLiteral.elements
- AstVisitor.visitForStatement
- AstFactory.forStatement
- NodeLintRegistry.addForStatement
The following methods and classes are deprecated:
- ForStatement2 and ForStatement2Impl
- ListLiteral.elements2
- SetOrMapLiteral.elements2
- AstVisitor.visitForStatement2
- AstFactory.forStatement2
- NodeLintRegistry.addForStatement2
In a similar way to how we did the previous stage of AST migration,
the existing visitors have been modified so that the default
implementation of visitForStatement2 redirects to visitForStatement;
this allows clients to change their overrides of visitForStatement2 to
override visitForStatement instead. Once all clients have been
migrated we will be able to delete the visitForStatement2 method.
Change-Id: Ife5949071fe4cb50791cd4f2f4b99a1bfaad54c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97360
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-03-20 22:58:55 +00:00
632abb6a25
Improve 'Import Library' code generation when has 'part' directive.
...
R=brianwilkerson@google.com
Change-Id: Idb3370dcbb67a935939a8ee2c072b897b866f7b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96826
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-03-13 20:24:13 +00:00
382cd59388
Update completion target tests for new map syntax
...
Change-Id: Ibb059d802aac92af6331e19f0b14aca03859ac42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/96524
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
2019-03-12 21:04:35 +00:00
9a0a3fd8c1
Eliminate uses of old AST node types from analyzer_plugin
...
Change-Id: I1dc8e1d51d96c5fc4e6b8c77b143c8cc9564f63e
Reviewed-on: https://dart-review.googlesource.com/c/94761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-03-01 10:03:22 +00:00
266ce73e28
Remove CompletionSuggestion.elementUri, replaced with AvailableSuggestionSet.
...
R=brianwilkerson@google.com
Context: https://github.com/JetBrains/intellij-plugins/pull/633#issuecomment-465725310
Change-Id: I03a1b7e7ec7cc0a5b0797dc960b72ca314a32132
Reviewed-on: https://dart-review.googlesource.com/c/93745
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-20 21:34:18 +00:00
5e2529c82e
Remove 'importUri' from CompletionSuggestion.
...
R=brianwilkerson@google.com
Change-Id: I1c06f7e6d84d5c2dd0eee7fa80f2e4bca3959513
Reviewed-on: https://dart-review.googlesource.com/c/93379
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-20 18:14:45 +00:00
39afa4e555
Revert "Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it."
...
This reverts commit 5d6bab4ed2https://dart-review.googlesource.com/c/93141
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
Change-Id: I98d478f56e8aea037cbcc8b6cb940c36edb732fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/93440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-15 16:38:08 +00:00
078f8e67f8
Tests for invalid library id, and requested name.
...
R=brianwilkerson@google.com
Change-Id: I75c7445bd2e9e25805c8789af9e648a3000b0668
Reviewed-on: https://dart-review.googlesource.com/c/93381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-15 16:35:56 +00:00
d1b15cc92c
Support for FieldFormalParameter in SyntacticScopeNamesCollector.
...
R=brianwilkerson@google.com
Change-Id: I2d1311de5c373bf81034e7764086ad09ac22a041
Reviewed-on: https://dart-review.googlesource.com/c/93280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-14 19:26:29 +00:00
5d6bab4ed2
Add ExecutableElement(s) based InheritanceManager3, and switch analyzer to it.
...
Change-Id: I9d87619e05ae769f4df6a6ba26cd7901c7c98510
Reviewed-on: https://dart-review.googlesource.com/c/93141
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-14 18:11:18 +00:00
1e72e9c985
Fix tests now that set literal support is enabled by default.
...
Fixes #35870 .
Change-Id: Ie250961f12a720a4ffbfc114df55a18518bf0426
Reviewed-on: https://dart-review.googlesource.com/c/92864
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-12 22:23:51 +00:00
5f02f3cac2
Remove tests for removed ARGUMENT_LIST suggestions.
...
It was removed for https://github.com/dart-lang/sdk/issues/25197
This CL though does not remove it everywhere though.
There are 41 other references in tests, doing:
assertNoSuggestions(kind: CompletionSuggestionKind.ARGUMENT_LIST);
Maybe we should remove these as well?
R=brianwilkerson@google.com
Change-Id: I812a2d6900e8430e5808a5a5cd8285b32d1517d6
Reviewed-on: https://dart-review.googlesource.com/c/92620
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-11 17:55:00 +00:00
fdfe40ea95
Compute 'executableElement' and 'parameterElement' in CompletionTarget.
...
R=brianwilkerson@google.com
Change-Id: I58904548a034cf927d9205bdbba3be9014c49328
Reviewed-on: https://dart-review.googlesource.com/c/92539
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-11 06:08:00 +00:00
be79eb4517
Ship experiment 'set-literals'
...
Change-Id: Ief182017752b87ef099ac5140ff781cbb14d76a9
Reviewed-on: https://dart-review.googlesource.com/c/92125
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Commit-Queue: Kevin Millikin <kmillikin@google.com >
2019-02-08 16:17:55 +00:00
0a2de9238b
Extract importLibraryElement() implementation, make it less pessimistic.
...
R=brianwilkerson@google.com
Change-Id: I916d4b761c8a9886dc701206c03cfd88c9f047ef
Reviewed-on: https://dart-review.googlesource.com/c/92021
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-05 21:05:45 +00:00
849285276d
Extract and migrate ElementLocator tests.
...
R=brianwilkerson@google.com
Change-Id: I10914580c96daee9bae8794db477c6413a089c09
Reviewed-on: https://dart-review.googlesource.com/c/91850
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-03 17:26:46 +00:00
fe585471e3
Add DartFileEditBuilder.importLibraryElement().
...
R=brianwilkerson@google.com
Change-Id: I83e0f58bce36660d15c477f100fdb4052b3bb672
Reviewed-on: https://dart-review.googlesource.com/c/91687
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-01 22:59:05 +00:00
fbc267f18f
Support for override completions in mixins.
...
Also moves tests for override implementations into a separate class.
New tests:
test_mixin_method_of_interface
test_mixin_method_of_superclassConstraint
Changes for deciding whether to generate `super` invocation.
R=brianwilkerson@google.com
Change-Id: I7f875695ce81f0212863fbd2f9fe1f1b9d7aaa3f
Reviewed-on: https://dart-review.googlesource.com/c/90784
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-23 21:55:03 +00:00
3513f872ce
Extract DartFileEditBuilder.importLibrary() into separate file.
...
R=brianwilkerson@google.com
Change-Id: I2f4a4943ad4db573504a890e29424357e0775839
Reviewed-on: https://dart-review.googlesource.com/c/89722
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-17 19:22:05 +00:00
b767744cfc
Add optional elementUri field to CompletionSuggestion types in analysis server protocol
...
This will enable clients such as IntelliJ to display the package which code
completions are being offered from in addition to the keyword or identifier
that they're already getting from analysis server.
R=brianwilkerson@google.com
Change-Id: I30311451ad56b4eddbe73da20641ee0d14849293
Reviewed-on: https://dart-review.googlesource.com/c/88744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Ari Aye <ariaye@google.com >
2019-01-09 00:13:39 +00:00
c91a245e30
Use ChangeWorkspace to limit where DartChangeBuilder(s) can edit.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/35402
Change-Id: If5f78b44b69f01d9ddc235401f70cc4aefd3ca37
Reviewed-on: https://dart-review.googlesource.com/c/87382
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-12-14 22:32:35 +00:00
f96a7fbc7d
Create AnalysisDriver using AnalysisContextCollectionImpl in pkg/analyzer_plugin tests.
...
Mostly to ensure that AnalysisDriver/Session knows its AnalysisContext,
so we can check that a file path belongs to the context root.
R=brianwilkerson@google.com
Change-Id: I45798bcf2441716ade89e9f6ee40f2053ab18bad
Reviewed-on: https://dart-review.googlesource.com/c/87268
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-12-14 19:18:44 +00:00
Brian Wilkerson