114d7b980a
Migrate analyzer_plugin package to null safety
...
Bug: https://github.com/dart-lang/sdk/issues/45236
Change-Id: I01175a2b2b1eb3ce6cdf30ade794d8186c6e8ead
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191622
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-03-30 00:29:37 +00:00
089ca8c1eb
Make compute assists async and fix message
...
Fixes #44730 .
Fixes #44731 .
For "fixes" there were similar bugs that I've fixed as well.
Closes https://github.com/dart-lang/sdk/pull/44758
https://github.com/dart-lang/sdk/pull/44758
GitOrigin-RevId: e08b25ea2890fc6f796c9cc0411fe7a71eaf70b9
Change-Id: I026c325d9d362775e178a7621a17ce6ff919ed40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-23 17:58:57 +00:00
5c174c8d8c
Remove unused data from AssistKind
...
Change-Id: I71c21e4d8138fa7f92d1a3e5a919b9fff3b2098f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177980
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-01-07 23:16:48 +00:00
715361eef2
Change format of IDs for fixes and attach them to generated changes
...
Having IDs to the change allows them to be key-bound in VS Code (see https://github.com/Dart-Code/Dart-Code/issues/2169 ).
Changing for format is to make them better match the existing IDs for assists (these will need to be pre-loaded into VS Code to allow users to see them to aid keybinding).
Change-Id: Iedcfaaf9a29d5e8575f1b8394e3db0ff19360872
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143588
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-04-16 17:35:24 +00:00
6f15530536
Enable omit_local_variable_types in analyzer_plugin
...
Change-Id: I908e15b4820eab0e8375994ce3cebfac332306f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141581
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-03-30 04:06:49 +00:00
f34a25099b
Enable slash_for_doc_comments in analyzer_plugin
...
Change-Id: I9cafff7fcbf6c8930e3ac8ddba05061601aa8223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132452
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-18 18:17:31 +00:00
03c33360b7
Remove unnecessary uses of new in analyzer_plugin
...
Other than
- the change to enable the lint (in analysis_options.yaml) and
- updates to the generator (in tool) to stop generating 'new',
all of the changes were generated by dartfix.
Change-Id: I9d14b99ab748ef5b80f8800a802e20100eee04a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128577
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-17 20:12:05 +00:00
087c6e3eb7
Add associatedErrorCodes API to AssistKind
...
Background: https://github.com/dart-lang/linter/issues/1375 .
Provisional API. Open for discussion!
Change-Id: I2a1608d748dc0f807b953bd2bc94b24e276c8286
Reviewed-on: https://dart-review.googlesource.com/c/91857
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-02-04 13:54:50 +00:00
298d22f4ab
remove async parse method
...
Change-Id: I7a2e633b43283221790fb88a12065fed3dcdabb7
Reviewed-on: https://dart-review.googlesource.com/c/82120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-30 19:26:00 +00:00
180b3dd301
Remove extra spaces in copyright notices in analyzer_plugin
...
Change-Id: Icf01fbdd84747fc92908fe5ca818124c5df992af
Reviewed-on: https://dart-review.googlesource.com/c/79640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-13 18:05:23 +00:00
6fc1dd4480
analyzer_plugin no implicit-casts.
...
Change-Id: I12e5d4da5b61938b3eb7cc7c0e2ade6a64510b9e
Reviewed-on: https://dart-review.googlesource.com/69201
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2018-08-09 22:41:41 +00:00
c1d5d843af
Add identifiers for Quick Assists.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I07cd18ae38f98793f960a2c7bd971527eaa6d7d6
Reviewed-on: https://dart-review.googlesource.com/40140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2018-02-12 20:56:09 +00:00
84dd01904d
Missed change to conform to other APIs
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2965453002 .
2017-06-29 06:15:38 -07:00
7bd9e6c443
Add a mixin for assists similar to that for fixes
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2956353002 .
2017-06-28 11:44:22 -07:00
4a10003924
Update the plugin API
...
R=maxkim@google.com , mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2953093002 .
2017-06-23 12:31:00 -07:00
456f790aa7
Add support for implementing getAssists in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2924063002 .
2017-06-07 09:19:47 -07:00
Konstantin Shcheglov