c547f5d933
Enable prefer_generic_function_type_aliases in most of the packages
...
Change-Id: I1338e731aa3f42f67fec605b20455a83fd5fce43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-27 00:43:14 +00:00
21354dccc9
Remove SdkExtUriResolver.
...
Initial: https://dart-review.googlesource.com/c/sdk/+/128770
Reverted: https://dart-review.googlesource.com/c/sdk/+/128820
R=brianwilkerson@google.com
Change-Id: I446d0ddf130712e94aab756e04c91ab4b5e83aeb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-20 01:08:49 +00:00
a3d5ae4b30
Enable prefer_is_empty and prefer_is_not_empty in analyzer_plugin and analyzer_cli
...
Change-Id: I277b05dbeece24c227611fb0ebd62c806ec13b6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-19 01:51:53 +00:00
5470f10277
Remove unnecessary uses of const in analyzer_cli
...
Change-Id: I333cd62562370b02179277d4901141a0b7476496
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128847
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-18 18:53:54 +00:00
c1f0b359cd
Remove unnecessary uses of new in analyzer_cli
...
Change-Id: Ib6d0123ae7c49814275b5829a1fd2676122dc540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128842
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-18 14:29:21 +00:00
becb0c0b85
Revert "Remove SdkExtUriResolver."
...
This reverts commit 7ef8822c2abrianwilkerson@google.com
>
> Change-Id: If0d7bb91e9b1c42e15935b315288fa8e3a000c6d
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128770
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
Change-Id: I0c9a26662a6fe6abac558313c14949886364d28e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-18 01:07:34 +00:00
7ef8822c2a
Remove SdkExtUriResolver.
...
R=brianwilkerson@google.com
Change-Id: If0d7bb91e9b1c42e15935b315288fa8e3a000c6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128770
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-18 00:22:15 +00:00
2efeca700f
Rename the folder with sky_engine test package.
...
R=brianwilkerson@google.com
Change-Id: I38d71292096b53ef932b0c2d3b6dd7f61706e023
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128762
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-17 20:20:09 +00:00
6ea97cd853
AnalysisSession is required for LinkedElementFactory.
...
We now use sessions during linking, so during build mode, so we have
to provide it.
R=paulberry@google.com
Change-Id: Ia683a19e89d4fc0d74cdb802e8a81c7b934ca611
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-16 00:50:36 +00:00
2e1dd98e5e
Create burndown lists for enabling the pedantic lints
...
Change-Id: Ie57ea31912ba4d702b82ffd327889044988b1ab5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-15 21:58:36 +00:00
ae3973da40
Use FeatureSetProvider in AnalysisDriver.
...
So that package_config.json can be used to opt-out from context
specified features / experiments.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I5e62d733eda6939d66d942eb3d690583f6091a57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128369
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-14 21:06:04 +00:00
f14301b0df
Stop supporting _sdkext, look for _embedder.yaml only in sky_engine package.
...
Change-Id: I20d30ef0e07ec617d5d8b9fb2e5fb97a7fc9930f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128320
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-13 02:15:28 +00:00
3172748cb0
Remove ResolverProvider, and its using for fileResolverProvider / packageResolverProvider.
...
It does not look that these are used anymore.
Change-Id: Ieafecc306dbf2b53e3366b1ffadc34aa7ba416a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128081
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-12 19:54:51 +00:00
3389b3bd32
Remove Packages from SourceFactory.
...
We have PackageMapUriResolver, this should be the way to resolve
all `package:xyz` URIs. We should not repeat it in SourceFactory.
Change-Id: I52d33dbf7e2d44f2c53521f6a51b0aea70507d3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128106
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-12 17:10:00 +00:00
f979bd9899
Merge RestrictedAnalysisContext into AnalysisContextImpl.
...
We don't have any useful / old API(s) in AnalysisContextImpl,
so the distinction between these two does not exist.
Change-Id: I87ef84bc728cc1c2c0e269c695419c425afb6559
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125987
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 21:58:16 +00:00
dcaf959589
Fix several unused elements, and unnecessary casts.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I81559cb241c0ca6918f6730538f44a7411907867
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125986
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 21:37:52 +00:00
af37dcf540
[analyzer] remove older crash reporting from the dartanalyzer cli
...
Change-Id: I7c02195246994cd7f8d4e6fe8d5a69a2ad07a717
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124164
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-11-05 21:04:33 +00:00
7ba5584c2e
[analysis_server] Fix outdated desin Service->Server, use Service->Logger.
...
Also multiplex the service rather than the logger, so that we can
multiplex a crash reporting instrumentation service with a file logging
instrumentation service.
Change-Id: I7720c55e26225c27d2d9447a0156b2ca83da6598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122100
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-04 21:31:26 +00:00
924ec34e01
Remove analysis logger, replace with calls to InstrumentationService
...
Change-Id: Ifddd58b731aa0af8f76a91261757997dc52a9fc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123328
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-10-31 21:26:44 +00:00
5d4cd6d589
Breaking changes for analyzer version 0.39.
...
Change-Id: Ifa9ca24487f93f3eb0ec95eeb64f5bbb5aa32714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113216
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-10-21 18:23:10 +00:00
ad47b1ca64
Remove summary1, part 2.
...
Change-Id: I050b62bbbd77db6bd6a2d815e70cfe92cc9432a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119220
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-10-07 17:35:55 +00:00
595022bdea
Remove summary1, part 1.
...
Change-Id: I557785ac13fa411280ce032324b0305bf25a0a6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119170
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-28 14:30:05 +00:00
40cc975932
Increase the severity of the unused_import hint (to a warning).
...
Change-Id: Ie65eb7e9c0f48c54a1c537e821c88a5ea8451266
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-09-27 02:10:22 +00:00
59008b8692
Skip parts with invalid URIs.
...
R=brianwilkerson@google.com
Bug: https://buganizer.corp.google.com/issues/140849287
Change-Id: I97da019f5aa6ec4db3b796842aaaa91834fc00b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116894
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-12 15:51:20 +00:00
76e6325ae0
Remove unused methods of AnalysisContext.
...
Change-Id: Ie7f81ac09b51f7a4e70a32f962e6e15c81245820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-11 17:09:47 +00:00
6f38a73618
Remove most of the task model.
...
I run presubmit, and it does not look to me that any failin tests
are caused by this CL.
https://test.corp.google.com/ui#id=OCL:267824456:BASE:267824473:1567923135217:2380181a
R=brianwilkerson@google.com
Change-Id: I838f2174460e0d06c85bbb83de9037113c0b6393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116252
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-09 18:26:50 +00:00
19533094eb
Stop deleting the terminating period on diagnostic messages
...
We have messages that contain more than one sentence, and sometimes
include end-of-line markers. We really need to do more to improve the
output in these cases, but this is a start.
Change-Id: I4750feae0a8e6665a8243c6d15726350b26a558b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113940
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2019-08-21 15:21:49 +00:00
6ccfb4bab1
Update analyzer-cli test for summary2.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I671f22195ee7c6d0c1c5d43d33181ace6a581bfb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110133
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-24 01:00:13 +00:00
71cd8a6efa
Tests for analyzer_cli and --summary-deps-output results.
...
I was not able to find any existing tests, and it looks like an
important feature, which we don't want to break. I will need to verify
that it continues for work with summary2.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ied2985ebd7b71e85a4b49ec43bf22360fbdd01cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110126
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-23 21:28:52 +00:00
ccdddd2eee
Parallel build-mode and DDC changes for summary2.
...
It does not enable summary2 yet, but makes it possible to flip
one flag AnalysisDriver.useSummary2 to switch between summary1
and summary2.
I run presubmit scripts, and it seems that it works for both.
https://test.corp.google.com/ui#id=OCL:255717824:BASE:259228828:1563746330268:5481d33a
https://test.corp.google.com/ui#id=OCL:255717824:BASE:258892260:1563515248201:2d5ce329
One thing that is not implemented yet is tracking used dependencies
for summary2. So, //dart/bazel_codegen_tests:dependencies_test_run fails.
Change-Id: Iec9f3852e9b91236ce98e87041031daa0cc71a88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107689
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Vijay Menon <vsm@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-23 15:07:11 +00:00
0352fb2cb7
Fix package dependencies in analyzer_cli, dartfix, nnbd_migration
...
Change-Id: Ib7f3b3f12d95b59b81164321e7d2176179adc957
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109890
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-22 19:55:43 +00:00
79a5257155
Revert "Increase analyzer cache size to 512MB."
...
This reverts commit 0256155b7ahttps://dart-review.googlesource.com/c/sdk/+/107360
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: David Morgan <davidmorgan@google.com >
> Commit-Queue: Jake Macdonald <jakemac@google.com >
TBR=scheglov@google.com ,jakemac@google.com ,davidmorgan@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: If00c0f9b8ee3fc177433df7c8d92731c2e5f0f9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108140
Reviewed-by: David Morgan <davidmorgan@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: David Morgan <davidmorgan@google.com >
2019-07-08 08:39:50 +00:00
a2e1434603
Breaking changes for analyzer version 0.37
...
Change-Id: I65a16ab2d2ca05de701c27f08300de85a6316b41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99880
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-02 03:59:49 +00:00
0256155b7a
Increase analyzer cache size to 512MB.
...
I noticed earlier today that the cache looks to be to small for large internal apps, causing us to constantly reload summaries. This change fixes that, reducing build times significantly for large apps.
There is a larger issue here of the actual cache implementation though that should likely get resolved. We end up with several versions of each summary file in the cache until it fills up, so we will fill up the cache even on small apps today.
It is possible we should change how that works, instead of increasing this.
Fwiw, I see total ram consumption of almost exactly 1GB per worker after this change.
Change-Id: I0d8a06da72b86d44562819bc04f5ae5543610f0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107360
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: David Morgan <davidmorgan@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2019-06-27 15:44:03 +00:00
dd862e7933
Display context messages in command-line analyzer output
...
Change-Id: I2b2f668ef738cf7801dbfdc77d070a8d8a473fe5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107303
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-25 17:36:52 +00:00
a468780d96
Disable buildSummary2 in build_mode.
...
It is expensive internally.
R=paulberry@google.com
Change-Id: Ic39245af9b8adc26e8441a14900ba46b7b68ec12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-19 21:54:40 +00:00
97bf0a6834
Print the URLs associated with the diagnostics
...
Change-Id: I1078cbda2b11e5591c96864a57538d6c94004136
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106430
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2019-06-18 01:22:18 +00:00
149ebf683b
Support for 'uri' property of Import/Export/CompilationUnitElement.
...
_Builder in source_gen uses code like this to check that the generated
file is expected in the library. While it is a questionable approach,
I don't feel that I have time to fix it, and remove the `uri` property
completely. So, we fix in in Analyzer with summary2.
`if (!library.parts.map((c) => c.uri).contains(part)) { ...fail... }`
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I983f29589cbb2613d5f896b87f6218c31a47afa9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-11 16:53:03 +00:00
0629ce94cc
Change location where we set AnalysisDriver.useSummary2 in build mode.
...
We need to make sure that it is set when we create FileState(s).
Change-Id: I68103902d0f4df659291e02dd7809b2140b9af72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-10 14:47:03 +00:00
30390c6ba1
Prepare to compute the documentation URL for diagnostics
...
Change-Id: Ib1b7e4887e18b90c1552f3f8501948ee8d8d2c1f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105260
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-06 16:41:46 +00:00
ef62349c6d
Turn on useSummary2 in build mode only temporary when computing errors.
...
We don't want to keep it on while building summary1, because there
are changes in type manipulations that depend on it.
R=brianwilkerson@google.com
Change-Id: I4f84860ec197eb8f40dba80ecb51868f3d48e5e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-03 16:13:44 +00:00
7c956f4387
Make it possible to consume summary2 in build mode, but don't turn it on yet.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Iad4d625217e3eeb6d8e5142825224dc0b2dcf8bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-30 16:49:04 +00:00
b1d3a212a7
Fill references to dynamic/Naver in LinkedElementFactory.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I85f61c6322a6332ac6b095aaf8cf4203460babc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-29 01:20:42 +00:00
03781b9402
Build also summary2 in build mode.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I172612fd50c1cb50dfad8b5dc2807f744cf973b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-28 17:44:48 +00:00
959e7df20e
Remove 'await null' in build mode.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I903a389ab15d45cc18d3678bc44ff8d78ffba683
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103083
Reviewed-by: Paul Berry <paulberry@google.com >
2019-05-20 16:58:35 +00:00
65cea6b8bb
Add more information to manifest warning message
...
Change-Id: If937bc27bd1b392022a23f942c50a84ed12d2268
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100890
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-06 16:38:08 +00:00
5bac4d9b0c
Reland "Add support for recording context information with analysis errors, with one example"
...
This reverts commit b9bf239c656114435ea5https://dart-review.googlesource.com/c/sdk/+/100563
> > Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> > Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
>
> TBR=scheglov@google.com ,brianwilkerson@google.com
>
> Change-Id: I275c6e4473de73199ea9b5e490379ba58aec1d43
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100628
> Reviewed-by: Paul Berry <paulberry@google.com >
> Commit-Queue: Paul Berry <paulberry@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: Ib1b7e63a459e63bcbf02f26bcf167ddad45295b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101004
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-05-02 17:07:03 +00:00
e2d0f5a50b
Add featureSet parameter to Parser constructor.
...
And deprecate old parser configuration setters.
Change-Id: Ib1507b8d2b20be7c883061e2a92ec9205d6a378f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100664
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-29 16:42:19 +00:00
b9bf239c65
Revert "Add support for recording context information with analysis errors, with one example"
...
This reverts commit 6114435ea5https://dart-review.googlesource.com/c/sdk/+/100563
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
Change-Id: I275c6e4473de73199ea9b5e490379ba58aec1d43
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100628
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-26 18:03:57 +00:00
6114435ea5
Add support for recording context information with analysis errors, with one example
...
Change-Id: Iba1c48163ce264d85a68bcb9f70e5025a7cdbfbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100563
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-25 18:41:23 +00:00
Brian Wilkerson