Commit Graph

23 Commits

Author SHA1 Message Date
Brian Wilkerson e4bb500c7b Add a json format to dartanalyzer
Change-Id: I3a23607f29de6c6feeed468b2bcf065dbb9044d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193526
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2021-03-30 22:10:12 +00:00
Brian Wilkerson b25a68ecf5 Enable omit_local_variable_types in analyzer_cli
Change-Id: Icffcc6e64c538de45b055a691a06db5cb6ca3783
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140560
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-03-22 18:38:49 +00:00
Brian Wilkerson 36e3bae4fb Enable always_declare_return_types in analyzer_cli
Change-Id: I416b5839fc4833c2e20bd629f847fddd7dcba966
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133405
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-01-25 23:09:57 +00:00
Brian Wilkerson c1f0b359cd Remove unnecessary uses of new in analyzer_cli
Change-Id: Ib6d0123ae7c49814275b5829a1fd2676122dc540
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128842
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-12-18 14:29:21 +00:00
Brian Wilkerson 19533094eb Stop deleting the terminating period on diagnostic messages
We have messages that contain more than one sentence, and sometimes
include end-of-line markers. We really need to do more to improve the
output in these cases, but this is a start.

Change-Id: I4750feae0a8e6665a8243c6d15726350b26a558b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113940
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2019-08-21 15:21:49 +00:00
Brian Wilkerson dd862e7933 Display context messages in command-line analyzer output
Change-Id: I2b2f668ef738cf7801dbfdc77d070a8d8a473fe5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107303
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2019-06-25 17:36:52 +00:00
Brian Wilkerson dff53c12d0 Remove more uses of package:analyzer/analyzer.dart
Change-Id: I4b8abf72994d7a60b09529a740bd16b591813807
Reviewed-on: https://dart-review.googlesource.com/c/82800
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-11-04 19:36:36 +00:00
Brian Wilkerson c214c43758 Make LineInfo a public class
Change-Id: I1bc7f5302797374609752ea5293b96c30719b41f
Reviewed-on: https://dart-review.googlesource.com/51101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-04-13 16:23:47 +00:00
Brian Wilkerson bd6f28f4c7 Make analyzer_cli closer to Dart 2 clean
Change-Id: I2f9b9e5bf87b65e871699c16633b1bfcf7605de5
Reviewed-on: https://dart-review.googlesource.com/48061
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-23 13:14:07 +00:00
Konstantin Shcheglov 1db0b3a29c Replace typed_mock with mockito in analyzer_cli.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2989583003 .
2017-07-25 09:54:08 -07:00
Devon Carew f1a5503fcc Add --fatal-infos; hide --fatal-hints.
BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2874043002 .
2017-05-10 11:45:11 -07:00
Devon Carew eae2bf2747 Fix an issue with duplicate reported analysis errors.
BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2793813002 .
2017-04-23 21:05:10 -07:00
Devon Carew 0fcb91aa06 Fix analyzer tests when run in checked mode.
BUG=

Review-Url: https://codereview.chromium.org/2775073002 .
2017-03-25 15:34:40 -07:00
Devon Carew b51d1fd8e3 Use ansi color in the dartanalyzer cli output.
BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2775633002 .
2017-03-25 15:02:47 -07:00
Devon Carew 46cacfeae9 Some improvements to the command-line analyzer's output.
BUG=
R=brianwilkerson@google.com, danrubel@google.com

Review-Url: https://codereview.chromium.org/2704103002 .
2017-02-22 12:35:09 -08:00
Konstantin Shcheglov ec282eb726 Switch analyzer_cli to 'package:test'.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2395183002 .
2016-10-06 10:02:39 -07:00
pq b6a1d75444 Analyzer directory recursing (tk 2) (#25129).
Take 2 with a fix that addresses a regression in batch-mode.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1810103003 .
2016-03-18 09:19:35 -07:00
pq 3b520bc114 Revert "Directory support for the analyzer CLI (#25129)."
This reverts commit 0bd85a2435.

BUG=

Review URL: https://codereview.chromium.org/1811753002 .
2016-03-16 14:51:17 -07:00
pq 0bd85a2435 Directory support for the analyzer CLI (#25129).
Adds smarts to recurse through directories to assemble a list of dart files to analyze.

Addresses: https://github.com/dart-lang/sdk/issues/25129

Do note that all of these files are sharing the same analysis context (and options).  Once the the ContextManager re-work is complete this can get smarter (see: https://github.com/dart-lang/sdk/issues/24133).

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1805533005 .
2016-03-16 13:56:13 -07:00
pq 8d613feaf9 Migrate mockito mocks to typed_mock (#24994).
BUG=24994
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1462393002 .
2015-11-20 13:57:56 -08:00
pq 9ae1265ff5 analyzer_cli move to SDK.
Tracking bug: https://github.com/dart-lang/sdk/issues/24731

Note, dartium build changes are in a separate CL: https://codereview.chromium.org/1453413006/

Some tests had to be disabled for want of mockito in the SDK; tracking their reimplementation is here: https://github.com/dart-lang/sdk/issues/24994

BUG=24731
R=whesse@google.com

Review URL: https://codereview.chromium.org/1459683003 .
2015-11-19 14:52:54 -08:00
pq 5cc9a288bb Revert "Move analyzer_cli into the SDK."
This reverts commit a573ed31f1.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1462143002 .
2015-11-19 11:28:52 -08:00
pq a573ed31f1 Move analyzer_cli into the SDK.
Build changes to follow.

Tracking bug: https://github.com/dart-lang/sdk/issues/24731

BUG=24731
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1464553003 .
2015-11-19 11:11:17 -08:00