dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

127 Commits

Author SHA1 Message Date
Brian Wilkerson 0ea654a068 Remove the AnalysisOptionsProcessor 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2559523005 .
 2016-12-07 10:51:33 -08:00
Dan Rubel aff6b796f3 update analyzer cli to support include directive in analysis options file 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2541933002 .
 2016-11-30 15:16:55 -05:00
Brian Wilkerson e63105555b Remove uses of configuration data 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2522543007 .
 2016-11-22 11:26:08 -08:00
Brian Wilkerson 3121296942 (TBR) Fix failing tests 
Review URL: https://codereview.chromium.org/2426703002 .
 2016-10-17 11:55:31 -07:00
Konstantin Shcheglov ec282eb726 Switch analyzer_cli to 'package:test'. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2395183002 .
 2016-10-06 10:02:39 -07:00
Konstantin Shcheglov 5703f5adb1 Replace using reprecated 'package:analyzer/src/generated/error.dart'. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2364643002 .
 2016-09-22 10:10:53 -07:00
Brian Wilkerson f8d7925ff2 Mark analyzer_cli as strong-mode clean 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2196393003 .
 2016-08-01 12:44:59 -07:00
Brian Wilkerson 44836f8538 Support the name analysis_options.yaml for analysis options files 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1975963002 .
 2016-05-13 07:33:06 -07:00
pq 7913968725 Fix CLI SDK option config timing (#26129). 
Fixes: https://github.com/dart-lang/sdk/issues/26129

The issue was that we were creating the SDK and populating its options (notably `strong-mode`) *before* options processors were called.  The result was that client code analysis contexts and SDK contexts were getting configured differently causing confusion when client code was getting analyzed with a non-strong-mode SDK.

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1962403002 .
 2016-05-10 13:35:40 -07:00
pq 082edc9fa3 Suppress TODOs (#26215). 
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1870123002 .
 2016-04-08 08:54:59 -07:00
Paul Berry 014cfddea0 Clean up analyzer_cli build mode tests. 
- Properly convert relative to absolute paths when the command-line
  arguments are of the form "$uri|$path".

- Test the behavior of "--build-suppress-exit-code".

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1825283006 .
 2016-03-22 21:25:24 -07:00
Paul Berry c7e1de177a Change analyzer_cli's "package mode" into a "build mode". 
Build mode differs from package mode in the following ways:

- The analyzer no longer guesses the relationship between paths and
  URIs based on directory structure.  Instead, each input file is
  specified in the form "$uri|$path".

- The analyzer does not read any files from disk that are not
  specified on the command line.

- There are no restrictions on the relationship between summaries and
  packages.  In particular: (a) multiple input summaries may summarize
  parts of the same package, and (b) part of a package may be
  specified with an input summary while an output summary is being
  generated for other parts of the same package.

- Output may be redirected to a file.

- The analyzer may be told to exit with success even in the event that
  an error is found during analysis.

This should ease the integration with Bazel, and provide a starting
point for integrating with other build systems.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1830463002 .
 2016-03-22 20:38:30 -07:00
Paul Berry c39a890dd1 Respect machineFormat in package-mode. 
Ensures that stats printing in package-mode respects the `machineFormat`
flag.  (That is, only displays stats if not in machine mode.)

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1820233003 .
 2016-03-22 13:23:06 -07:00
pq 1dcec8c35f Bootloader cleanup. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1570603004 .
 2016-01-11 14:13:44 -08:00
pq 8887cd69f0 Fix analyzer_cli error overrides (#24452). 
Brings `analyzer_cli` inline with server wrt processing errors configured in `.analysis_options`.

Note some added complexity due to interactions with flags that globally escalate warnings/hints to errors.

https://github.com/dart-lang/sdk/issues/24452

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1529243002 .
 2015-12-16 12:44:38 -08:00
pq e4e61ee462 Disable temp-dir hosted tests pending fixes. 
Background here: https://github.com/dart-lang/sdk/issues/25258

BUG=

Review URL: https://codereview.chromium.org/1526533003 .
 2015-12-14 15:04:43 -08:00
pq fd0f649327 Driver failure mode fixes (and test cleanup). 
* `printAndFail(msg)` doesn't exit in testing (so we need to return null).

R=keertip@google.com

Review URL: https://codereview.chromium.org/1530453002 .
 2015-12-14 13:58:05 -08:00
pq 5a57d6e8dc CLI driver test re-enablement (#25001). 
Another stab.  The rub, I *think*, to our failures are unexpected calls to `exit()` on the bots (that are not reproducing locally).  These fixes should address that (and fix error stream handling along the way).

* fixes test setup and teardown to ensure exit handling is properly managed.
* fixes driver source to use the `exitHandler` and `errorSink` consistently

BUG=
R=keertip@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1525623003 .
 2015-12-14 13:08:47 -08:00
pq 1c3df7f4ec Revert "Make analyzer_cli tests bot-friendly (#25001)." 
This reverts commit e67affe6b6.

R=keertip@google.com

Review URL: https://codereview.chromium.org/1524493002 .
 2015-12-11 14:57:01 -08:00
pq e67affe6b6 Make analyzer_cli tests bot-friendly (#25001). 
* re-enables a host of tests that were breaking on the bots due to path issues

Bug: https://github.com/dart-lang/sdk/issues/25001

R=keertip@google.com

Review URL: https://codereview.chromium.org/1516353003 .
 2015-12-11 14:13:30 -08:00
pq ad7c566e04 Driver test fixes. 
* Updates to use new CONFIGURED_ERROR_PROCESSORS (rather than defunct CONFIGURED_ERROR_FILTERS).

BUG=
R=keertip@google.com

Review URL: https://codereview.chromium.org/1520663002 .
 2015-12-10 14:22:16 -08:00
Brian Wilkerson ea3ba0e31f Remove deprecated code 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1502213002 .
 2015-12-07 10:24:36 -08:00
pq 8d613feaf9 Migrate mockito mocks to typed_mock (#24994). 
BUG=24994
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1462393002 .
 2015-11-20 13:57:56 -08:00
pq 7c15fa857c More bot-unfriendly test fixing [TBR]. 
Remove tests pending update.

Background: https://github.com/dart-lang/sdk/issues/25001

BUG=25001

Review URL: https://codereview.chromium.org/1463133002 .
 2015-11-19 16:52:14 -08:00
pq 9ae1265ff5 analyzer_cli move to SDK. 
Tracking bug: https://github.com/dart-lang/sdk/issues/24731

Note, dartium build changes are in a separate CL: https://codereview.chromium.org/1453413006/

Some tests had to be disabled for want of mockito in the SDK; tracking their reimplementation is here: https://github.com/dart-lang/sdk/issues/24994

BUG=24731
R=whesse@google.com

Review URL: https://codereview.chromium.org/1459683003 .
 2015-11-19 14:52:54 -08:00
pq 5cc9a288bb Revert "Move analyzer_cli into the SDK." 
This reverts commit a573ed31f1.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1462143002 .
 2015-11-19 11:28:52 -08:00
pq a573ed31f1 Move analyzer_cli into the SDK. 
Build changes to follow.

Tracking bug: https://github.com/dart-lang/sdk/issues/24731

BUG=24731
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1464553003 .
 2015-11-19 11:11:17 -08:00