dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

10502 Commits

Author SHA1 Message Date
Konstantin Shcheglov f3455278ff Use 'isNonNullableByDefault' flag in TypeProviderImpl. 
Instead of giving it the NullabilitySuffix, for consistency with
TypeSystemImpl.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I16d1ca32071b8a28a31e207afed604f8d4b24a2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125982
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 21:43:56 +00:00
Konstantin Shcheglov dcaf959589 Fix several unused elements, and unnecessary casts. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I81559cb241c0ca6918f6730538f44a7411907867
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125986
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 21:37:52 +00:00
Konstantin Shcheglov 6646412705 Rewrite DEFERRED_IMPORT_OF_EXTENSION check to using ImportElement namespace. 
I think we thought about doing this, but probably forgot to do.
Also, we got NPE during google3 rool, 'importedLibrary' might be null.

R=brianwilkerson@google.com

Change-Id: Id321f18c97df06f543d619cf1913551535634d0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125985
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 21:32:37 +00:00
Konstantin Shcheglov 03676ad489 Remove AnalysisEngine.createAnalysisContext() 
In order to remove a way to create AnalysisContextImpl at all.

This method is not API, and is not used internally.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ie36c1cc9e414310a9e3ee08a9ac26da9191b1ef7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125983
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 21:13:50 +00:00
Konstantin Shcheglov 6444fba9c7 Implement upper bound computation with NNBD rules. 
https://github.com/dart-lang/language/blob/master/resources/type-system/upper-lower-bounds.md

Limitations:

1. Only UP is implemented, not DOWN.
   So, handling formal parameters in incomplete.

2. Handling required named parameters is not implemented yet.

Change-Id: I4ddebeeaad21d41e0cbecfbc08aee82ec9752bce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125761
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-21 17:24:46 +00:00
Brian Wilkerson 6dc3762b99 Stop producing a diagnostic for an error that was removed from the spec (issue 39476) 
Change-Id: I811356f737ea27bad804729c0ee518701a08dd8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125927
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 17:18:01 +00:00
Konstantin Shcheglov 821b3c44ff Add evaluateConstant() to LinterContext. 
R=brianwilkerson@google.com

Change-Id: I497f1eccf48d3bd9d425cc47fbca769b27cab119
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125922
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-21 16:29:36 +00:00
Konstantin Shcheglov b370346d60 Add 'isNonNullableByDefault' flag to TypeSystemImpl, make all parameters named required. 
R=brianwilkerson@google.com

Change-Id: I262f86ba964f4970ec570dc9fa4c1a802556fa63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 15:37:46 +00:00
Brian Wilkerson ad021d02d4 Integrate the latest batch of reviewed diagnostic docs 
This includes a small improvement to the validation tests, but there is
also one code whose docs can't be verified without additional work that
I will do in a follow-on CL.

It also includes splitting one code into two to improve the messages.

Change-Id: I52989ca336e42822327e3ac3805b1654d20a479c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125901
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 15:21:55 +00:00
Kallen Tu 54011e5622 [analyzer] Fix format.fbs after summary change for variance. 
Change-Id: I90379ad24f50e3d8a3d16879a4572529b3d83692
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-11-21 01:39:34 +00:00
Konstantin Shcheglov 615928c514 Stop referencing non-API TypeSystem in analyzer. 
Replace it with TypeSystem from lib/dart/element/type_system.dart,
or (internally) with TypeSystemImpl.

We keep the old TypeSystem where its is exposed from API:
- ResolveResult.typeSystem
- AnalysisSession.typeSystem
- AnalysisContext.typeSystem

  We will make changes to these as a breaking change later.

Change-Id: I40ca53ea77e440457c6d0f3832ec3b6286bacdf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125770
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-21 01:09:24 +00:00
Kallen Tu 8d328738b8 [analyzer] Add variance to analyzer summaries. 
Change-Id: Ia1a527eff5a784b2cb6d169c76108c16e6ccfe1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125554
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-20 23:01:02 +00:00
Konstantin Shcheglov be519e83b1 Remove XyzElementImpl.forNode() constructors. 
R=brianwilkerson@google.com

Change-Id: I39332a153b6d13be7b33d3980263eb3c3e952c65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125802
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-20 22:48:43 +00:00
Konstantin Shcheglov b55ae4e586 Remove TypeSystem.create() 
R=brianwilkerson@google.com

Change-Id: Ia916d90b0d33509538851024696665f296d966ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125764
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-20 21:13:32 +00:00
Paul Berry b14a4fbf49 Update the comment on parseString to clarify throwIfDiagnostics behavior. 
Change-Id: I67d5a37bd88f8dc355af6f3d2651a9aa0b037871
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125763
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-20 19:06:29 +00:00
Janice Collins 733db095ce Move nullabilitySuffix to the public interface for DartType. 
Change-Id: Idb53afaf30312b6423b84baa988ec2bb9ca29c24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125720
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
 2019-11-20 17:13:59 +00:00
Kevin Moore 8342ec2c71 Fix pub.dev URLs throughout SDK repo 
Change-Id: I5bcb7c40be12ee1dc887620281b4807469d67bbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125729
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
 2019-11-20 11:30:48 +00:00
mnordine f594720679 Fix typo 
Closes #39402
https://github.com/dart-lang/sdk/pull/39402

GitOrigin-RevId: 89a3ac03e3fc971e0fcfeb36ddcc1bc6b2ffcb34
Change-Id: Idee225262fbfa1c3dc7acbabd141eb7a275fee87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125442
Reviewed-by: Michael Thomsen <mit@google.com>
 2019-11-20 11:25:52 +00:00
Jaime Wren f414465c45 Analyzer refactoring Workspace.isBazelWorkspace() to a getter: get isBazel, this is follow up on https://dart-review.googlesource.com/c/sdk/+/125564 
Change-Id: I7e1dbc6b695b04a65bbb17761162daece797f238
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125470
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-19 19:05:59 +00:00
Brian Wilkerson 1f933abcee Convert a compile time error into a parse error (issue 39389) 
Change-Id: I115c7bb4ab05f8c6e9ddc566985126a1b9a09842
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125621
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-19 18:25:29 +00:00
Sam Rawlins db166e423e Fix unused elements when setter used 
Fixes #35677

Change-Id: I2daf8b4e2cc8e1a11ed0dde730d4126154b60910
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125620
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-19 17:44:19 +00:00
Sam Rawlins 6f5b3775ff Simplify IgnoreInfo. 
* Remove ignoreForFiles and ignores, unused public getters,
* Remove add(), unused public method,
* Make addAll() and addAllForFile() private.

Change-Id: I9d03b5bbae0b1db291c612f142725beb27281731
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125523
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-19 12:27:24 +00:00
Konstantin Shcheglov 0a98a7a153 Add helper predicates for upper/lower bounds. 
Change-Id: Icec2315e4a65539861d99c8e10e254d11454cba7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125361
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2019-11-19 02:48:23 +00:00
Konstantin Shcheglov 239e2eb4ed Issue 38813. If in a legacy library, use legacy interface types for CONFLICTING_GENERIC_INTERFACES. 
Bug: https://github.com/dart-lang/sdk/issues/38813
Change-Id: I950bf7bf492e80bc8f12c94252af360158dcb7b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125549
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-19 02:46:23 +00:00
Kallen Tu 2416116208 [analyzer] Support AST variance in visitors and cloning methods. 
Most of the visitor, clone and constructor methods support variance
in the AST. Some methods for summary work are missing from this CL,
but I have taken note and will change those in an analyzer summary CL
in the future.

Change-Id: I54a39b9ec44ced26d2bc55966d5938a91ab6a76c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125007
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 23:20:53 +00:00
Jaime Wren 89b4f55010 Fix an import at the top of the analysis server workspace.dart file 
Change-Id: I39cb68c9e9359df7d39ca23d996d4dc646f7001d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125546
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2019-11-18 23:12:15 +00:00
Kallen Tu 7c517ed007 [analyzer] Report invalid variance positions in fields. 
Change-Id: I51a0e64907569a722fd1df58e098bb92254d53c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125481
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 22:42:15 +00:00
Konstantin Shcheglov a8bf0dc2e5 Move type parameter variance tests for LUB to LeastUpperBoundTest. 
Change-Id: Ia1eda9f0be073043399488af43f9d0485656ceb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 22:25:00 +00:00
Konstantin Shcheglov 73d0ef6a30 Remove 'visitedTypes' from appendTo(). 
We don't have recursive types anymore.

Change-Id: I3bb67c91d1ba6f277c93495ae77ca5eee2356d5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 21:55:27 +00:00
Jaime Wren 8dd2e8e693 Modify DeclarationsContext.getLibraries to consider the entire context if it is a BazelWorkspace 
Change-Id: I3d06e46505741f9166acf66f68a9ee1654ac37d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125564
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2019-11-18 20:57:35 +00:00
Konstantin Shcheglov b716efbfc0 Attempt to work around repeating LinkedBundleContext exceptions. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I4dd52770d2cc128ebfb82f49fe52d7d83ed65a9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 19:10:13 +00:00
Konstantin Shcheglov 860132c9e0 Fix using interfaceType() without nullability, remove unused class. 
R=brianwilkerson@google.com

Change-Id: I8c8ab46dc629e9a6895fdd37abc98d86e01590cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 19:10:01 +00:00
Konstantin Shcheglov 7df44023f4 Issue 38878. Update SuperContext for annotations. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38878
Change-Id: Ib2944fd60062fca0ec2899d83656cdc02b0a4a87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125529
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 19:06:48 +00:00
Konstantin Shcheglov b5b45ffe4b Issue 38953. Exit the unit element walker on enter into a directive. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38953
Change-Id: I54e84e28f5d576bcd50c8bb10e99aefdae725c25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125528
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-18 18:11:53 +00:00
Konstantin Shcheglov 2a5d00bcd2 Issue 38992. Build annotation elements for type parameter elements on their creation. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38992
Change-Id: I98f7690914ce2acb7074a8333b9a482605bb9afb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125527
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:36:08 +00:00
Konstantin Shcheglov aa0cf44b05 Issue 38506. Don't attempt to use LibraryElement.metadata for not the first LibraryDirective. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38506
Change-Id: Ib76b1e81554f061622ec98fae21b4dd9a1280c24
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:28:45 +00:00
Konstantin Shcheglov 6df2491743 Issue 38551. Fix for reading references to PropertyAccessorElement(s) defined in extensions. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38551
Change-Id: Id93714a2db97ff1ab448fe408f4e86df9988a147
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-18 15:28:03 +00:00
Jens Johansen edbff4eae7 [CFE] Encapsulate 'Stack' and create DebugStack as an option 
Change-Id: Ib3dd188e3b2c65d6e6824487ae7794fe9214bfbb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125264
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2019-11-18 12:44:13 +00:00
Brian Wilkerson c96fe4e006 Add more explaination to existing examples 
Change-Id: I2f89ef54eb4467d23f7507c1217385a1df2d4a11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124594
Commit-Queue: Kathy Walrath <kathyw@google.com>
Reviewed-by: Kathy Walrath <kathyw@google.com>
 2019-11-16 02:52:18 +00:00
Kallen Tu a2fe9d450e [analyzer] Report invalid variance positions in methods of a class. 
Change-Id: I425f81e7e64a02b29e094dab53f37318a09a3c62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125228
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-15 23:55:19 +00:00
Kallen Tu 6ec813e07a [analyzer] Modified type inference constraints wrt variance. 
Change-Id: I0502bad1c57af358453c78d27fe738880beb7b4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125021
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-11-15 22:02:36 +00:00
Erik Ernst d290f1cec2 Add nonfunction-type-aliases experimental flag 
Change-Id: I203af5227ecfee8c9e6b0f4985f68e38a18553c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125203
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-15 17:04:15 +00:00
Sam Rawlins fea5e1b741 Fix UNUSED_MEMBER check for cross-class private class members 
Overhauled how UNUSED_MEMBER and UNUSED_FIELD work, by using
Elements instead of names. This requires careful extra logic for:

* implicit getters
* overridden members
* parameterized members
* unresolved members: when _x is called on a dynamic
  expression, we must declare that all members named _x on all
  classes are used.

Fixes https://github.com/dart-lang/sdk/issues/35677

Change-Id: Id097350499b34b33239e82e391af0b7ea9580cbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124521
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-15 03:42:55 +00:00
Konstantin Shcheglov c98a775436 Remove deprecated classes and fields from IDL. 
This patch should be landed atomically into both internal copies
of analyzer, and there should not be any pending roll into either copy.

Change-Id: Iae405b6c8292fb33ef5cf99332acec9d85257748
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125281
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-15 00:14:43 +00:00
Konstantin Shcheglov 385cfb61c6 Add nullability variants to create InterfaceType(s) to ElementsTypesMixin. 
R=brianwilkerson@google.com

Change-Id: I6ec6f6f1d533de4ec46e569c0b7becc9dd19b33b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125225
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-14 20:36:29 +00:00
Kallen Tu 85295c9298 [analyzer] Report incorrect type parameter superclass positions. 
Change-Id: I6c55c32db2c275a199b2878909576f445a87977c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125009
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
 2019-11-14 19:04:44 +00:00
Konstantin Shcheglov 81da345035 Use ElementsTypesMixin.mixin_ in analyzer tests. 
R=brianwilkerson@google.com

Change-Id: I2e7dfc608db1f8fe66c48b94b4faf73be5344cb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-14 18:23:31 +00:00
Konstantin Shcheglov fac27eae0a Use Member(s) as legacy views on elements. 
Change-Id: I3e8a603a50ecc04b217311bfc34f66e3dd924247
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124593
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-14 16:41:51 +00:00
Konstantin Shcheglov bd2163f122 Issue 39380. Fix for null loopVariable. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39380
Change-Id: I1d631d89f4c8cc72f8d76c3f62334d570c92aff2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125065
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-14 16:36:20 +00:00
Mike Fairhurst 8db87ad6e5 [analysis_server] Report lowest exception to API/crash reporting 
Change-Id: I6db4612e0342c0f5208e7bce420964c7f0de1966
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124912
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-14 16:33:46 +00:00