dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

10502 Commits

Author SHA1 Message Date
Konstantin Shcheglov e98085fdd8 Issue 40333. Verify types of static getters / setters. 
Bug: https://github.com/dart-lang/sdk/issues/40333
Change-Id: I10f366d4f451a94f8afa7b30cd6daa99073d7eda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133665
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-29 18:05:36 +00:00
Konstantin Shcheglov cb2d91c983 Convert to legacy members of Object and constructor elements. 
These two are not related, but I just drop them together.

Change-Id: I5ac83551d4438c53f8e0461e81a0acc5393bc902
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-29 06:00:22 +00:00
Konstantin Shcheglov 4b79594ab4 Update AnalysisDriverResolutionTest for compatibility with unforked SDK. 
Change-Id: I0aca71fae01594d3fba053bff9d53e739c2b65e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-29 02:37:22 +00:00
Konstantin Shcheglov b3a1f053a3 Issue 40333. Extract GetterSetterTypesVerifier, report GETTER_NOT_SUBTYPE_SETTER_TYPES for NNBD. 
Bug: https://github.com/dart-lang/sdk/issues/40333
Change-Id: I265d535956204644859b05d02dd39a0bfdc8c19a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-29 02:37:14 +00:00
Konstantin Shcheglov 2bde0e119e Support for searching references to imports when opt-in from opt-out. 
Change-Id: I4b558296cfd1ef17ca7fa03d1551658d2ae6d578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133546
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-28 21:08:20 +00:00
Konstantin Shcheglov 209e70b2a7 Convert loadLibrary() to legacy when opt-in from opt-out. 
Change-Id: I2834eac5522da3d5e20f54682fe1b7f0c78ea434
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133482
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-28 21:08:00 +00:00
Konstantin Shcheglov efdd38b0eb Move tests for MISMATCHED_GETTER_AND_SETTER_TYPES. 
Change-Id: I49f0ea4d30fb50be4ecb6b4226081470397d098d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-28 19:12:08 +00:00
Lasse R.H. Nielsen 36a6b1b5ce Analyzer: Don't do recursive flattening of FutureOr in await. 
The current behavior (removing all outer `FutureOr`s,
then calling *flatten* on the result) was never specified as correct behavior.

Since Dart 2.0, the await has not recursively flattened futures,
so the static analysis behavior did not match run-time behavior.


Change-Id: Ie1da323aedb4b0f51e2c1e3eebe84552576c5f37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121846
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2020-01-28 11:16:07 +00:00
Konstantin Shcheglov 44dff4e24b Issue 40221. NNBD_TOP_MERGE super-interfaces when checking for implementing the same generic class more than once. 
Bug: https://github.com/dart-lang/sdk/issues/40221
Change-Id: I776ee76ced12ec9ab0838f9bac76a3ec9fdb71b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133329
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-27 17:12:06 +00:00
Paul Berry 0399fcf6fa Flow analysis: fix shared tests to consider potential nullability instead of nullability. 
No change in functionality.  Just changing the analyzer's
nullability_test.dart so that it generates the `nonNullable`
annotation for a promotion from type parameter `E` to `E&Object`.
This makes it consistent with the front end test runner behavior.

Change-Id: I9b74222257b432e361fbe46aa7d4d7070225a5e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133322
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2020-01-27 12:43:06 +00:00
Konstantin Shcheglov b6fdba235e Update NORM and type parameters handling to new understanding. 
Change-Id: I5df83667b4016651a15182c22a621eb59c387feb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133410
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-27 00:32:54 +00:00
Brian Wilkerson 7d7643c2ad Add newly reviewed docs and change section header everywhere 
Change-Id: I337fe5764b9167240b42cf75f908a3d36ef08cc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133407
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-26 22:56:45 +00:00
Konstantin Shcheglov f5abdf27a7 Split NormalizeHelper. 
Change-Id: I93129d886d9cd6722147fda217d3d4d69a76841a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-25 21:45:45 +00:00
Konstantin Shcheglov 7ebfc3662f Extract NORM implementation into NormalizeHelper. 
R=brianwilkerson@google.com

Change-Id: I0f504d364887253c33f09cda3fb63377d1a0742e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-25 18:10:45 +00:00
Konstantin Shcheglov 21ab021637 Use test Matcher for checking Element(s). 
We have more elements that might be Member(s) because of isLegacy.
So, we need something more sophisticated for checking elements.

Change-Id: Ibbf661571bf56cd4e9bc067adf57e881619ff92a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133325
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 22:21:14 +00:00
Konstantin Shcheglov 318e8556e0 Issue 39917. Test that Never is resolved as Never* in legacy. 
Bug: https://github.com/dart-lang/sdk/issues/39917
Change-Id: Iaa236377b777f25b13fe3072a9b3f3dee4b8f436
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133284
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 21:33:34 +00:00
Konstantin Shcheglov 3f12134e60 Issue 40287. Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for external and native methods. 
Bug: https://github.com/dart-lang/sdk/issues/40287
Change-Id: I3ad4268321c2355573a058ad00c11276bff83796
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133283
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 21:00:44 +00:00
Konstantin Shcheglov ae372d68ee Move old AnalysisDriverResolutionTest to DriverResolutionTest. 
R=brianwilkerson@google.com

Change-Id: I6561c214850a8bdcad282dfec0676f61bea52c8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133321
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-01-24 20:57:43 +00:00
Konstantin Shcheglov 691df73a15 Issue 40287. Don't report MISSING_DEFAULT_VALUE_FOR_PARAMETER for abstract methods. 
Opens new issue: https://github.com/dart-lang/co19/issues/516

Bug: https://github.com/dart-lang/sdk/issues/40287
Change-Id: Ifd05e570b8411369cec296db52746ce4f144bbac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133201
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 20:19:28 +00:00
Paul Berry 8714a7fa1d Abstract resolution calls to .isNullAware. 
When migrating, we'll need to change some null-aware property accesses
and method calls to non-null-aware (due to the fact that the receiver
is non-nullable, or due to the new `?.` shortcut rules), so when
migration re-resolves, it will need to be able to override
resolution's determination of whether a given property access or
method call is null-aware.

Change-Id: I411f43fb937431e757d4dd9b968874db84158e47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 19:58:43 +00:00
pq 8ebe354ecc fix diagnostic messages for named constructors 
Fixes: https://github.com/dart-lang/linter/issues/1986

Change-Id: I67ba3393be48dc39d3bbaaa922542f11b138afae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133244
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-01-24 18:50:13 +00:00
Brian Wilkerson 9ac5aabe77 Fix an incorrect type annotation (issue 40299) 
Change-Id: Id461b5d798f58f182c2b84fa30b5f9a94e51b4fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133154
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-24 14:27:39 +00:00
Konstantin Shcheglov 3962edccf1 Convert opt-in elements to legacy when resolving annotations. 
Change-Id: Ifc32ec66e9e45dcaa206c662785bb7d4c054b701
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133166
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-24 01:34:11 +00:00
Konstantin Shcheglov c92b3e6f86 Fixes for NORM and FunctionType(s) - type parameters, and covariant formal parameters. 
I think this will fix the issue that required revert of:
https://dart-review.googlesource.com/c/sdk/+/133041

Change-Id: Ib25ea9c9ac9743dee560fb688cd026fa3b3fe6bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-23 22:44:43 +00:00
Konstantin Shcheglov fb667d2ae4 Revert "Use NNBD_TOP_MERGE to combine signatures of the inherited members." 
This reverts commit 0391d1fc7f.

Reason for revert: Breaks the build: https://ci.chromium.org/p/dart/builders/ci.sandbox/analyzer-nnbd-linux-release/1045

Original change's description:
> Use NNBD_TOP_MERGE to combine signatures of the inherited members.
> 
> Change-Id: I314eac1b9175409e6b2b05afd3b97d44c1156cf8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133041
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I15f73853b39a93fa2038aefea95aa1b364ca3d5c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133086
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-23 18:59:48 +00:00
Konstantin Shcheglov 0391d1fc7f Use NNBD_TOP_MERGE to combine signatures of the inherited members. 
Change-Id: I314eac1b9175409e6b2b05afd3b97d44c1156cf8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-23 17:25:07 +00:00
Konstantin Shcheglov eb271d997f Update NNBD_TOP_MERGE for pending updates to the spec. 
These changes are not yet in the spec, but it seems that we want
them before we can start using NNBD_TOP_MERGE for merging interfaces.

Change-Id: I4ba0f95b169febd05a2cbc1a50edf342227ee217
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132971
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-23 03:35:11 +00:00
Konstantin Shcheglov 582727a4ec Tests for TypeName resolution, fixes for NNBD opt-in/out mixes. 
Change-Id: Ifb119a266306dbdf8a712d3110038179ee3cd7f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132965
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-23 01:01:00 +00:00
Konstantin Shcheglov 7f2a5b54a4 Support for instantiating opt-in classes from legacy libraries. 
Change-Id: I3cafd51936a4af97d63424d6c8612570d27ac031
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-22 19:58:08 +00:00
Konstantin Shcheglov 02f1244921 Fix reporting of uninitialized field errors after a redirecting constructor. 
Change-Id: I868cec4a09ebdfce271d861b714c2100e812c5c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132808
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
 2020-01-22 19:53:48 +00:00
Konstantin Shcheglov 0b06a369de Replace ClassElement/FunctionTypeAliasElement.instantiateToBounds() with TypeSystem.instantiateToBounds2() 
Change-Id: I2b1aacc9d72ab444176a2a0e4d6a44d13780e357
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132804
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-22 18:38:48 +00:00
Konstantin Shcheglov b663ef5cc4 Build non-nullable or legacy SDK summary. 
Bug: https://github.com/dart-lang/sdk/issues/38666
Change-Id: I24f6f36b5ed1dbef64588dd787aaf2abbd62f53c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-22 18:02:08 +00:00
Sam Rawlins e685ff5131 Move UNDEFINED_{GETTER,METHOD,OPERATOR,SETTER} tests to their own files 
Change-Id: Iaf5049efdbf887f84d7db1444d5ea7d835a2c967
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132806
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-22 16:32:08 +00:00
Konstantin Shcheglov 52c535cd83 Issue 35908. Remove DartObjectImpl types comparison workaround. 
Bug: https://github.com/dart-lang/sdk/issues/35908
Change-Id: Icff1d3a19adddea0b15469cf93c2a90b8dd1b43e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-22 15:13:28 +00:00
Paul Berry 47950b5153 Migration: add logic to remove unnecessary "as" expressions. 
Only works when the FixBuilder is enabled.

Change-Id: I9f2ee95603f9b6b247eae1ba00e817a71fc299d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132681
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-22 00:05:34 +00:00
Konstantin Shcheglov 1c56176084 Parse --packages file as package_config.json or .packages, depending on the content. 
Bug: https://github.com/dart-lang/sdk/issues/38554
Bug: https://github.com/dart-lang/sdk/issues/39762
Change-Id: Ibce0cabd75ecbfd3aa4e573418c2127ff7f9687e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132744
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-21 23:07:59 +00:00
Konstantin Shcheglov 1478e48ea5 Issue 39833. Report an error when a function typed formal parameter has question and the experiment is not enabled. 
Bug: https://github.com/dart-lang/sdk/issues/39833
Change-Id: I742396890692cef6a5befa58f7717b3971c82257
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-21 21:30:19 +00:00
Paul Berry 16cb7cee1b Convert builder.dart to triple-slash comment style 
Change-Id: I73e371b073ef2f7448a175b5fdb85bd77d8529a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-21 15:58:02 +00:00
Konstantin Shcheglov 7e0726e077 Fix for asking constant value from a VariableMember. 
Change-Id: If67b0922010b730e887a764383889f0ee3e790c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132405
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-18 01:11:47 +00:00
Brian Wilkerson e2751d8d45 Clean up a couple of hints 
Change-Id: Ib925a603e3e751cc54c89f7a6fab759601dd8979
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132361
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-17 22:52:27 +00:00
Konstantin Shcheglov 72193714ed Fix await(ing) tests for List/MapLiteral inference. 
R=brianwilkerson@google.com

Change-Id: I13c69d9e3ea3309be9eb266bc6882f05cfa1e17d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 22:28:08 +00:00
Konstantin Shcheglov 58a65fe4ba Issue 40110. Update switchStatement_end() to 'isExhaustive', use for switch on enum in analyzer. 
Bug: https://github.com/dart-lang/sdk/issues/40110
Change-Id: Ic17ab4562f518b7e69b78c3285b577ea3b8d1223
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131712
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 22:07:16 +00:00
Mike Fairhurst d234c45f5b Remove unnecessary @override 
Change-Id: I48d2d1e3324838e2814f566de937db6cb061b12f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132308
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 21:17:56 +00:00
Paul Berry cacfb70f7b Migration: further support for adding ?s to types in FixBuilder. 
Previously, we tried to hook in to the resolver so that every time it
tried to check the type of a TypeAnnotation, the FixBuilder would see
if it needed to add a `?` to it before letting the resolver continue.
This was clumsy and didn't catch all the TypeAnnotations.  This CL
changes to a simpler technique where we simply visit all
TypeAnnotations, making note of where we need to add `?`s and updating
types, prior to re-running resolution.

Change-Id: Idf5ba286415fb2b90e2cd1d5ba3635b6b559aef6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132164
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
 2020-01-17 20:47:16 +00:00
Konstantin Shcheglov 03432747b9 Fix resolveNameInScope() for import scope. 
R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/dart-lang/linter/issues/1970
Change-Id: I6f3798950d6d20f444e731aea22b2e41516e1081
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 20:00:36 +00:00
Konstantin Shcheglov 2d33d4eec9 Re-read condition after resolution, it might be rewritten. 
Bug: https://buganizer.corp.google.com/issues/147866900
Change-Id: I1f18c52a569a813b454893ad02d3263897d4679b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132304
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 18:42:04 +00:00
Konstantin Shcheglov 2aee6026cb Use NullableDereferenceVerifier in BoolExpressionVerifier. 
So, we report UNCHECKED_USE_OF_NULLABLE_VALUE in one place, and only
during resolution.

Change-Id: I0c89f77afe1c311287906e27458a226965545369
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132171
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 17:20:34 +00:00
Johnni Winther 47743990a1 [cfe] Provide file offset on StringConcatenation 
Change-Id: I70d5f47fd118f9b40c01f0f71057bd8e244561d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132240
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2020-01-17 09:48:12 +00:00
Konstantin Shcheglov 746d3fb757 Use BoolExpressionVerifier in BinaryExpressionResolver. 
Change-Id: I249b475a3a5b35e1de6f59b7f9cd30102709bb29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132167
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-01-17 00:20:15 +00:00
Konstantin Shcheglov d19b2b0349 Use NullableDereferenceVerifier in resolver instead of ErrorVerifier. 
Change-Id: Ib360bd9091656e04820879052a04e6ee23c495d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132161
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-01-16 22:55:49 +00:00