Commit Graph

10502 Commits

Author SHA1 Message Date
Paul Berry 01bcfbdc88 External field support: also allow external static fields.
Change-Id: I32008de216d2840f7466176e45b96cab3da4edde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158140
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-08-11 19:40:19 +00:00
Paul Berry 490a4b65e2 External field support: suppress "uninitialized non-nullable field" errors.
External fields whose type is non-nullable don't need to be
initialized (in fact they can't be initialized), so we shouldn't
report "uninitialized field" errors for them.

This CL also adds some basic tests of the functionality of external
fields, making sure that the getters and setters they introduce are
properly resolved and that their types are properly respected by
inheritance checks.

Change-Id: I9b08727ab0d45d24801af3721e332c7ec21d08bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-08-11 19:32:12 +00:00
Konstantin Shcheglov fab57cfeb7 Switch ImportElementsComputer to the new scope.
R=brianwilkerson@google.com

Change-Id: Ieb07dd810274401dca1492619b83fcc9a2a8d9f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158107
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-11 19:30:12 +00:00
Konstantin Shcheglov 0412862a9f Prepare to publish analyzer 0.39.17 and _fe_analyzer_shared 7.0.0.
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Ie87fc587ac7f9b83f2853e9cd0b4704bafd9fa71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158146
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-11 19:00:02 +00:00
Konstantin Shcheglov ef8bca8f90 Fix AnalysisDriverCachingTest for windows.
R=brianwilkerson@google.com

Change-Id: Ifec1075ad9c891e0eb8332022be33273474235c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158105
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-11 18:19:19 +00:00
Konstantin Shcheglov 8bf2ae347d Use new Scope in AstRewriter.
R=brianwilkerson@google.com

Change-Id: I755d3815ba9b0c7e638bc2f87bf64593f89baf7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-11 17:38:39 +00:00
Konstantin Shcheglov d68227dfe0 Remove PackageMixin.
R=brianwilkerson@google.com

Change-Id: I801d64f919e8e8fded0e08ebc6e9ac2b8ece4b32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-11 17:20:39 +00:00
Konstantin Shcheglov aba88b6ed4 Migrate CheckerTest to PubPackageResolutionTest.
R=brianwilkerson@google.com

Change-Id: If63881900ed720caa3290a2a63f92b2a82e8f874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158084
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-11 15:34:44 +00:00
Konstantin Shcheglov 4cf5f3c600 Use new Scope in ElementResolver.
R=brianwilkerson@google.com

Change-Id: I44565fbdc71190226d958964e13cc22e5d4f8959
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158103
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-11 15:32:02 +00:00
Jens Johansen 4c0cab024e [parser] No longer support ?.[ syntax
Update CFE tests (and a few analyzer tests) to match the new world
of the syntax being unsupported.

Fixes https://github.com/dart-lang/sdk/issues/42681

Change-Id: I71bc973f36dfb978ddb825edb68530d8e260a58a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157980
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-11 08:09:59 +00:00
Brian Wilkerson e224540b1c Unify four diagnostic codes for the purpose of documentation
I would have prefered to have renamed them all to undefined_super_member,
but that would have broken existing links. Some day we should add the
support necessary to allow for forwarding so that we can rename codes.

Change-Id: I81e416407e3464b5b60a4dbbfe60a375eb47bb84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157921
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-08-11 01:07:44 +00:00
Paul Berry d4e4abdef6 External field support: add a notion of external fields to the AST and element model.
In follow-up CLs I will update error reporting logic.

Change-Id: Id07b861aa117b93e0c869ad0b52c048085706ee6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157801
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-08-10 21:54:54 +00:00
Konstantin Shcheglov 7e86900c65 Remove DriverResolutionTest.
R=brianwilkerson@google.com

Change-Id: I1ca6918da9a51d5650ba9b76a960d7a3348ba4b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158081
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-10 21:43:58 +00:00
Konstantin Shcheglov a8f1be78a5 Migrate SdkConstraintVerifierTest to PubPackageResolutionTest.
R=brianwilkerson@google.com

Change-Id: I0d6fa9ccdfbb4f9156226af2884a5f9b14dea495
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-10 21:24:25 +00:00
Konstantin Shcheglov e626e47ea9 Migrate SubtypeOfSealedClassTest and language version tests.
R=brianwilkerson@google.com

Change-Id: I573a6223fb58b2a412d0dcbf961739ecd9a7af82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-10 20:52:01 +00:00
Konstantin Shcheglov 287c796412 Migrate AnalysisDriverCachingTest to PubPackageResolutionTest.
R=brianwilkerson@google.com

Change-Id: Iafcc25686d1eb70f638347ed4af06e09eb965cc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158023
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-10 20:12:13 +00:00
Brian Wilkerson 276f10aaf6 Unify const_field_initializer_not_assignable with field_initializer_not_assignable for documentation purposes
Change-Id: I7b008febe4210d08768b81c59bf0ee6b2663fafd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-08-10 19:48:03 +00:00
Paul Berry 87f0d5d9dc Abstract field support: do not allow abstract fields to be late or static.
Although these error conditions are not reported by the parser, the
language grammar does not permit them, so from a customer perspective
they are parser errors.  Accordingly, they have been assigned
ParserErrorCodes and reported by the AstBuilder, as we do for other
similar errors.

Change-Id: I79d0ad1dcad518981b8b649c117df326279008f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157800
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-10 19:27:13 +00:00
Konstantin Shcheglov 8405d7c8e3 Remove dart2jsHint option, verifier, and tests.
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I95b88940c862d463af03e85fcdf0f4bf81c2fbd5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157641
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-10 19:19:43 +00:00
Konstantin Shcheglov 1af388c521 Move DEPRECATED_MEMBER_USE to AnalysisContextCollection.
Change-Id: I938891254b2bf3aae7d2c514a27a7ed49f95b775
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157883
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-10 17:46:33 +00:00
Paul Berry 92315c4b2d Abstract field support: do not allow initializing abstract fields.
There are three ways to initialize a field, so we have to check for
three error conditions:
- At the declaration site
- Via a field formal parameter
- Via a constructor initializer

Fixes #42981

Change-Id: Ifc32a28ffb62d60fd2171d4980e88da9eebcb481
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157664
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-08-08 13:36:52 +00:00
Konstantin Shcheglov 0aa5b0f019 Files generated for other packages in PackageBuildWorkspace do not belong to the package.
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I1608caf8fb54187f8154dd1510841f46a247383f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157841
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-08 01:26:57 +00:00
Konstantin Shcheglov a08a357bdb Remove unused code from PackageBuildWorkspacePackageTest.
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I3e6fc8c87671b60c5152f273b3ff6da96c71b103
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157782
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-07 18:57:51 +00:00
Konstantin Shcheglov 8ce4d6d6bf Replace 'non_nullable' with 'null_safety' in BUILD files.
The flag was renamed since the original issue was open.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/42594
Change-Id: Ie92d43d09d97386f3e61ad226c0a0c88287d2ea3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157725
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-07 18:51:14 +00:00
Konstantin Shcheglov 5bd3e5a63f Use PubPackageResolutionTest for diagnostics snippets.
Change-Id: I4fd0e38d0ab431f96056fba0819ddefefea72e8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157722
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-07 16:45:07 +00:00
Konstantin Shcheglov 8a0d5c25ee Use lookup() in VariableResolverVisitor.
Change-Id: I101ba07997cabcfa5fbccc59194acb79d7abf7e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157723
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-07 16:39:36 +00:00
Konstantin Shcheglov 6a5030981c Remove ResourceProviderMixin.newFileWithBytes().
R=brianwilkerson@google.com

Change-Id: I741d75149c1ff7108a458f661eb583b3fd711ef4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-07 16:14:41 +00:00
Konstantin Shcheglov fdef50f096 Support for declared variables.
Declared variables cannot be configured using analysis_options.yaml,
so I put them into AnalysisContextCollectionImpl for now.

R=brianwilkerson@google.com

Change-Id: I2aaa3cfa94ad4a386f0be7d47acc979a89b69b05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-07 03:33:39 +00:00
Paul Berry 8b2576fe66 Abstract field support: detect when a concrete implementation is missing.
This CL covers two cases: when an abstract field appears in a concrete
class (which we report as CONCRETE_CLASS_WITH_ABSTRACT_MEMBER, just as
we do for abstract methods), and when a concrete class implements a
class with an abstract field, but fails to supply the necessary
concrete implementation(s) (which we report as
NON_ABSTRACT_CLASS_INHERITS_ABSTRACT_MEMBER_*, just as we do for
abstract methods).

Change-Id: I94bdbafc4ed7b058d9b33b3774e79cb55393380b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157600
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-08-07 00:18:09 +00:00
Paul Berry fc7b79e5a9 Make NNBD and non-NNBD versions of non_abstract_class_inherits_abstract_member_test.dart
This is in preparation for working on external and abstract fields,
which will require introducing some NNBD-only tests to this file.

Change-Id: I2e1a77634aef0493d5e44edf88373deaa9acb6c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157580
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-08-06 23:33:59 +00:00
Konstantin Shcheglov c2379a800a Move more tests to PubPackageResolutionTest.
R=brianwilkerson@google.com

Change-Id: Ic6c37d069323cc06c6ab630757625a7e0b072200
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-06 22:30:39 +00:00
Paul Berry a7b11bd12a Make NNBD and non-NNBD versions of concrete_class_with_abstract_member_test.dart
This is in preparation for working on external and abstract fields,
which will require introducing some NNBD-only tests to this file.

Change-Id: Ida714ce7e3136acfaf05d12fe287ec9e1de1258c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157472
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-08-06 20:25:27 +00:00
Konstantin Shcheglov c59246d8ad Support for dart_package(non_nullable) in BazelWorkspace.
Bug: https://github.com/dart-lang/sdk/issues/42594
Change-Id: I927184d9065eb5c54790275a429927de8099a7e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157474
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-06 19:37:12 +00:00
Paul Berry d2c3758cc5 Abstract field support: suppress "final not initialized" errors.
Abstract final fields don't need to be initialized (in fact they can't
be initialized), so we shouldn't report "uninitialized field" errors
for them.

This CL also adds some basic tests of the functionality of abstract
final fields, making sure they don't introduce setters, and that the
getters they introduce are properly resolved and that their types are
properly respected by inheritance checks.

Change-Id: I885f23ce7ca554ba8f48e932ba9d76e128ac0bbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157520
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-08-06 18:59:52 +00:00
Paul Berry 90aedbac3b Don't forget to run tests in FinalNotInitializedWithNullSafetyTest.
These tests weren't being referenced in the test's main() function, so
they weren't being run.  Fortunately they pass :)

Change-Id: Ie04039e36bbcaea8d13973efb7fee19112407648
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157467
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-08-06 18:59:52 +00:00
Paul Berry 8076c9efd7 Abstract field support: suppress "uninitialized non-nullable field" errors.
Abstract fields whose type is non-nullable don't need to be
initialized (in fact they can't be initialized), so we shouldn't
report "uninitialized field" errors for them.

This CL also adds some basic tests of the functionality of abstract
fields, making sure that the getters and setters they introduce are
properly resolved and that their types are properly respected by
inheritance checks.

Change-Id: I1fe7b6f40456d03533b85403ec6f428656820706
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157466
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-08-06 18:59:52 +00:00
Devon Carew 31361ff444 [deps] bring cli_util 0.2.0 into the repo; update the analyzer dep
Change-Id: I705d500a745b5ca972bdc49314b39ee9357989f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157541
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-08-06 17:27:29 +00:00
Konstantin Shcheglov 5276973b22 Test and fix for completion in a part.
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I7653a24a3a315b2be51e50f223284537e5830b1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157469
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-06 16:08:59 +00:00
Brian Wilkerson 7997b49285 Clean up a hint in analyzer
Change-Id: Id65f28e22c297737e579f376dfe06d3156595fa1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157470
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2020-08-06 15:55:09 +00:00
Paul Berry 465246f4d3 Make NNBD and non-NNBD versions of undefined_setter_test.dart.
This is in preparation for working on external and abstract fields,
which will require introducing some NNBD-only tests to this file.

Change-Id: Idb389a079f7405fe4adc51bafd715a3f31a9cc7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157465
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-08-06 15:40:40 +00:00
Paul Berry af6e60927c Make NNBD and non-NNBD versions of undefined_getter_test.dart.
This is in preparation for working on external and abstract fields,
which will require introducing some NNBD-only tests to this file.

In the process, I discovered a flow analysis bug
(https://github.com/dart-lang/sdk/issues/42957), which I plan to fix
in a follow-up CL.  For now the test that provoked the bug is marked
as failing.

Change-Id: I0767d650cfaecb125b0cea27c0c7971d3112deff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-08-06 14:28:19 +00:00
Paul Berry 81b90be6be Add support for covariant fields to AstComparator
Change-Id: I82dc56840e2508f3dacd90db0bd41826d0e42e40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157463
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-08-06 02:46:25 +00:00
Paul Berry b5a3292260 Abstract field support: add a notion of abstract fields to the AST and element model.
In a follow-up CL I will update error reporting logic.

Change-Id: I6fd2916c24a531b1f41bd2872301ffec1fdb8722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157382
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-08-06 02:19:46 +00:00
Konstantin Shcheglov d15b04ad04 Switch resolution and many diagnostics tests to AnalysisContextCollection.
Change-Id: I869f61fc102717afb395bd07935ae5e82d46bc56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156983
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-05 21:28:09 +00:00
Brian Wilkerson 76f6423f9e Update the NodeLintRegistry and LinterVisitor to handle some missed classes of nodes
Change-Id: Ie2c6a612fdc1514f49235e28d28b799a78c732f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2020-08-05 18:38:19 +00:00
Konstantin Shcheglov 4ac540e21d Check the file digest when reading its content.
R=brianwilkerson@google.com, keertip@google.com

Change-Id: Id07652456bd659a37b66f21b052bcef12cbb1c57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-05 15:24:28 +00:00
Brian Wilkerson 363c72111d Update docs to use markdown styled links
Change-Id: Id5b966ee41c75ee02c7ce10609033b81d930697b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157120
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kathy Walrath <kathyw@google.com>
Reviewed-by: Kathy Walrath <kathyw@google.com>
2020-08-05 00:20:32 +00:00
Konstantin Shcheglov fd4edad020 Update id tests constants/ to use getDisplayString().
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: If7d737ca3a31954e4d3c061d316548e8f54b0d10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-04 23:38:32 +00:00
Konstantin Shcheglov ebd5b622ba Add DartSdk.languageVersion
Bug: https://github.com/dart-lang/build/issues/2763#issuecomment-666707445
Change-Id: I8232bd395abc9efea0e5c27716450d6a5442b3bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156489
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-08-04 21:01:09 +00:00
Konstantin Shcheglov 8c5af18cf0 Prepare to publish analyzer 0.39.16.
Change-Id: Ib20a70a7541cf037cce7b648f50a791ffacf08e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157006
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-08-04 19:29:08 +00:00