b8909a4878
Replace CiderMemoryByteStore with CiderCachedByteStore.
...
Change-Id: I6301cfbbaa4a65b5f1d326174879ebddff14cc98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164662
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2020-09-29 00:46:18 +00:00
499bae02e0
Issue 34699. Use type parameter variance when instantiate to bounds.
...
Bug: https://github.com/dart-lang/sdk/issues/34699
Bug: https://github.com/dart-lang/sdk/issues/43524
Change-Id: I8fe14c59fff17f3e4ebee62fbd7be2b45172a595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-28 23:25:58 +00:00
31e673d80c
Deprecate SimpleIdentifier.auxiliaryElements
...
Change-Id: Ie1e92cc61b7018d503cdf44c37611ea55b4b5391
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-28 16:00:44 +00:00
0176a3d4c5
Fix flow analysis handling of late variables with initializers.
...
A late variable with an initializer is very similar to a function
expression, in that it may be evaluated at any time in the future
(possibly more than once, if it throws an exception), so flow analysis
models it that way.
Fixes #42990 .
Change-Id: I90ed00c8fd7388145f89011628e31ff7e85a5c43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-09-28 14:40:02 +00:00
ffbe30f890
Deprecate IndexExpression.auxiliaryElements
...
Change-Id: I7359527db5bbf161a35296678ff2bd43052c1794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164740
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-27 18:28:46 +00:00
6fce77010a
Remove unnecessary getStaticType().
...
Change-Id: Ic727d2607999aa97a290345c22993cd2ba703d1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-26 20:32:21 +00:00
e3fcb1a646
Remove unnecessary convertPath() invocations.
...
Change-Id: I57d0d2204df02bd9a5fc97986347ac0218442d39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164722
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-26 18:25:00 +00:00
fe1ed1df59
Remove unnecessary _nonNullable() invocations.
...
We made TypeProvider legacy or null-safe long time ago, so we already
provide correct types.
R=brianwilkerson@google.com
Change-Id: I3bb7f9c6d8b2292fcb62df1820abbd84d142340d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-26 18:17:05 +00:00
90ec73cd28
Print default types of type parameters of type defining elements.
...
R=brianwilkerson@google.com
Change-Id: I62e2d7b050e0d81169b0d780ebce8858bee9dec0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-26 18:16:57 +00:00
fc151ec027
Compute variance for type parameters of typedefs.
...
Bug: https://github.com/dart-lang/sdk/issues/34699
Change-Id: I30f010f89da6abb1b3d27fe1eab11d5eb1c5e190
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164660
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-25 23:32:54 +00:00
b53d016f71
Prepare to publish analyzer 0.40.3 and _fe_analyzer_shared 10.0.0.
...
Bug: https://github.com/dart-lang/sdk/issues/43550
Change-Id: I555a958c14eb435ab6a8522e89cd90dd851da2c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-25 17:52:29 +00:00
f9e6e38b21
Straighten up invocation of an Object method on dynamic.
...
Fixes https://github.com/dart-lang/sdk/issues/39609
Change-Id: I9b98d9bff8d4e9b75ab7625323f62eb6b6701a94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164256
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-25 16:46:04 +00:00
e423e857f8
Make null check to participate in null shorting.
...
Bug: https://github.com/dart-lang/language/issues/1163
Change-Id: I6e648f76413c5036a867b2125359f28eb03027c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-25 16:02:34 +00:00
def50905c2
Make flow analysis handling of is/==/??=/?. consistent with mixed mode semantics
...
Bug: https://github.com/dart-lang/language/issues/1143
Change-Id: Id177f8b19c15ef246f21ddd840410cddfee2e5cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163600
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-09-25 08:35:03 +00:00
55496a1282
Deprecate getReadType() and remove getExpressionType().
...
Change-Id: Ibc32afd7867f5b0f940affdaea97904c1afb194c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-25 05:05:33 +00:00
7a06bcb96e
Pass TypeProvider to Member(s).
...
Bug: https://github.com/dart-lang/sdk/issues/43541
Bug: https://buganizer.corp.google.com/issues/169344717
Change-Id: I00b7c5308473de2bef949668c72aaad1967f199a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-25 05:03:03 +00:00
cd897bc86c
Remove the diagnostic default_value_in_function_typed_parameter
...
This diagnostic is obsolete because the parser also produces a
diagnostic for this situation.
Change-Id: I5c5f7fc734ddeb5cfaaba9cc9980efe174aeb4e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164461
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-09-25 04:35:53 +00:00
2c4bee37c0
Add documentation for some additional diagnostics
...
Change-Id: Ib6dc3740de759d820421fa3a899c72302de64c9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-09-25 04:35:33 +00:00
f04f00adac
Clean up INVALID_EXPORT_OF_INTERNAL_ELEMENT and INVALID_INTERNAL_ANNOTATION tests.
...
R=brianwilkerson@google.com
Change-Id: I38810fdf5fe05c5a18f003055b1bd5a8842ebb4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164255
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-25 02:17:43 +00:00
52b0285e41
Analyzer: Gather operator super calls for mustCallSuper
...
Fixes https://github.com/dart-lang/sdk/issues/27896
Change-Id: I7017026346a92ffc43a3cfa506f7a257af1a3471
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-09-24 21:15:38 +00:00
e21b596578
Analyzer: Add tests for @internal
...
Change-Id: I0974a25c7238a9e0831c035e47829c7039f0abf9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-09-24 19:53:27 +00:00
578d0c081f
Fix search for enums.
...
Bug: https://github.com/flutter/flutter-intellij/issues/4881
Change-Id: I7f474841c534891d6eb5de5e9fed07e7048e612e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-24 19:22:57 +00:00
7ec28c3f08
Enforce await_only_futures and fix violations.
...
R=brianwilkerson@google.com
Change-Id: Icfc093d46562ddc7084151e76f495cc1462bb900
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164257
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-24 14:28:00 +00:00
9b7c0ebd82
Extract SimpleIdentifierResolver.
...
The improvement is that we use PropertyElementResolver and stopped
using setReadElement() and setWriteElement().
The error reporting and type anlysis is moved as it were.
Change-Id: I808be8d0d52d4eece892be8234dd28c213dcb11c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164253
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-24 14:26:03 +00:00
e615c06c91
analyzer: Report illegal @internal usage of a library or unnamed super ctor call
...
Bug: https://github.com/dart-lang/sdk/issues/28066
Change-Id: Ifd7a54e590699de02d0db80d5aa38a3a0b2bce73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164248
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-09-24 01:53:59 +00:00
6cfef5017f
Remove special handling of Object in PrefixedIdentifierResolver.
...
It is already handled in TypePropertyResolver.
Change-Id: I83a14a459042d3c2a321913254d87c7c959d5270
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164247
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-24 01:17:59 +00:00
ac5c140f60
Extract PrefixedIdentifierResolver.
...
Element resolution is improved to use PropertyElementResolver.
And we don't call setReadElement() and setWriteElement() anymore.
Type analysis is kept as is for now.
Change-Id: If14a5b5690947f335e05a43f3f6166c0a228f9eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-23 21:47:59 +00:00
75ea66605a
Infer Object when subtype matching dynamic/void vs. Q?.
...
See https://github.com/dart-lang/language/pull/1200
TGP looks green.
https://test.corp.google.com/ui#id=OCL:333332281:BASE:333335686:1600887590104:a120780c
Bug: https://github.com/dart-lang/sdk/issues/43162
Change-Id: I1102fc5ee7c3210aa990c9f71f905190cd1665e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-23 21:24:09 +00:00
6cb9c66f28
Reland "Update SDK version to 2.11"
...
This reverts commit e834f9cf6e45ffef71e8TBR=athom@google.com ,johnniwinther@google.com ,jakemac@google.com
>
> Original change's description:
> > Update SDK version to 2.11
> >
> > Change-Id: I9ffec7e098fd77dcc0cd48b70613d919bda45672
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161342
> > Reviewed-by: Alexander Thomas <athom@google.com >
> > Reviewed-by: Jake Macdonald <jakemac@google.com >
> > Commit-Queue: Johnni Winther <johnniwinther@google.com >
>
> This breaks flutter hhh as packages that flutter depends on have upper bound of 2.10. This should be relanded after those packages have their upper bound raised.
>
> TBR=athom@google.com ,johnniwinther@google.com ,jakemac@google.com
>
> Change-Id: Ie00b8c77a16d863105517856118459e3e289d914
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163704
> Commit-Queue: Alexander Aprelev <aam@google.com >
> Reviewed-by: Alexander Aprelev <aam@google.com >
> Reviewed-by: William Hesse <whesse@google.com >
TBR=whesse@google.com ,aam@google.com ,athom@google.com ,johnniwinther@google.com ,jakemac@google.com
Change-Id: Iec81adfb047b3f5387cdc817af3b08e6c086430a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164241
Auto-Submit: Jake Macdonald <jakemac@google.com >
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
2020-09-23 19:54:49 +00:00
feb482abb5
[analyzer] remove unused command line options
...
Change-Id: I2bb415fefe7e1ebe95cea533f4979ca5f8cff4fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164180
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-23 19:21:59 +00:00
3b9e300b9c
Extract AnnotationResolver.
...
Just as is, without any attempt to clean it up for now.
Mostly to get it out of the way to clean up Prefixed/SimpleIdentifier
resolution.
Change-Id: I36c3338beb065bb834ed1b7ba8cc3ff7241d03f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-23 18:37:49 +00:00
863821476c
Analyzer: Report invalid use of internal members
...
Bug: https://github.com/dart-lang/sdk/issues/28066
Change-Id: Iee39fee48340fb9311a8f7a07d1ae7aa474a22f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163961
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-23 17:51:49 +00:00
f157b5ff80
Flow analysis: promote type X&T on initialization.
...
When flow analysis encounters a variable declaration of the form `var
x = expr;`, if the type of `expr` is `X&T`, then the variable is given
the inferred type `X`, but it is immediately promoted to `X&T`.
Change-Id: I2a5ffca3860ab009f0942e6efc641c1604ab6323
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163840
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-09-23 16:58:09 +00:00
f820c1fb8e
[Analyzer] Support using \r\n in correction tests when running on Windows
...
Change-Id: Id56e7c17974d5036706dbe451a2c307907bdcd3a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163208
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-23 07:53:16 +00:00
e89279c85f
Resolve IndexExpression and PropertyAcces as read only.
...
All writes are handled in corresponding assignment (-like) expressions.
Change-Id: Iab4220f7fce55daebd8aac1c90bf81efe3d7d8e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-22 21:59:31 +00:00
8e8836c768
Record log entries as FileResolver loads / removes libraries.
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I566ad9488351ef777a35d48979b32ce106c88597
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164021
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-22 19:31:31 +00:00
74d47c9891
Resolve PrefixExpression and PostfixExpression using shared write resolution.
...
Change-Id: Iebdcfe3e633836cdfc546d4bfa45a302a883985e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-22 18:49:00 +00:00
a7ae2dbce9
Move shared portions of AssignmentExpressionResolver._resolve_ back into resolve().
...
Change-Id: I2e7171c49aa8325a49afbe70c2cbfa9115b580b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-22 14:48:57 +00:00
a2cd89fb83
Include all library files with Cider exception.
...
R=brianwilkerson@google.com , keertip@google.com
Change-Id: I894a7504cb19249c812212f3ef65ce5f10737e7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163820
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-22 14:41:43 +00:00
a7364369a9
add missing @override
...
Change-Id: I2b4a87c66f09d3b54166f345417dbc71659aac86
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163761
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-09-22 14:26:23 +00:00
f860868740
Flow analysis: remove old "promotable via initialization" logic.
...
This logic was removed from the spec in
https://github.com/dart-lang/language/commit/b70bb3f90679eb1c67b7ee852e1322046b2e4777 .
Only a few places in the SDK itself were relying on this promotion
logic; I've fixed those places by adding explicit types.
Change-Id: Iaeaebe8dd5ab3e848699bc8ebc64a1ae80c1027a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163681
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-09-22 12:22:13 +00:00
e834f9cf6e
Revert "Update SDK version to 2.11"
...
This reverts commit 45ffef71e8TBR=athom@google.com ,johnniwinther@google.com ,jakemac@google.com
Original change's description:
> Update SDK version to 2.11
>
> Change-Id: I9ffec7e098fd77dcc0cd48b70613d919bda45672
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161342
> Reviewed-by: Alexander Thomas <athom@google.com >
> Reviewed-by: Jake Macdonald <jakemac@google.com >
> Commit-Queue: Johnni Winther <johnniwinther@google.com >
This breaks flutter hhh as packages that flutter depends on have upper bound of 2.10. This should be relanded after those packages have their upper bound raised.
TBR=athom@google.com ,johnniwinther@google.com ,jakemac@google.com
Change-Id: Ie00b8c77a16d863105517856118459e3e289d914
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163704
Commit-Queue: Alexander Aprelev <aam@google.com >
Reviewed-by: Alexander Aprelev <aam@google.com >
Reviewed-by: William Hesse <whesse@google.com >
2020-09-21 23:30:34 +00:00
5120a33aa6
Resolve IndexExpression in AssignmentExpressionResolver.
...
Change-Id: Ibaf1dad7d7dc271b73476ef61742d6d72aba0380
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163723
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-09-21 21:18:42 +00:00
8605286e11
Make constant-update-2018 available since 2.0.0
...
See https://github.com/dart-lang/language/issues/286#issuecomment-503614115
and https://github.com/dart-lang/sdk/issues/43462
Change-Id: Id844473e0cb371ffc4470a18993c66c8ad0427e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163503
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2020-09-21 20:39:32 +00:00
b4a09d8dec
Catch exceptions from File.resolveSymbolicLinksSync()
...
Bug: https://buganizer.corp.google.com/issues/169040783
Bug: https://github.com/dart-lang/sdk/issues/43497
Change-Id: I5f4c1ffaec4af2d4d3855b9a99c3a78c36401ce3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-21 18:36:32 +00:00
45ffef71e8
Update SDK version to 2.11
...
Change-Id: I9ffec7e098fd77dcc0cd48b70613d919bda45672
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161342
Reviewed-by: Alexander Thomas <athom@google.com >
Reviewed-by: Jake Macdonald <jakemac@google.com >
Commit-Queue: Johnni Winther <johnniwinther@google.com >
2020-09-21 11:22:26 +00:00
04591ddfbc
Move demoteType() into TypeSystemImpl.
...
R=brianwilkerson@google.com
Change-Id: I0c5ff9fcc3b3ec912e82fa91752e097f430b603c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-20 05:53:27 +00:00
cf5e8a7a2f
Use Object* or Object? when LUB with a type parameter.
...
Not the full fix yet.
Bug: https://github.com/dart-lang/sdk/issues/43478
Change-Id: Ic405ebdab4b5a1a6816328cfa66b55478dd60c71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-19 21:43:07 +00:00
089a3a0de0
Clean up resolving assigned/node types in AssignmentExpressionResolver.
...
Change-Id: Ia8e0a2d39492dc44cf36182fb125b0718ccff105
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163502
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-19 19:20:57 +00:00
0c8d9576eb
Remove unused hasPromotedTypeVariable().
...
Change-Id: Ia8c40e6675ad9fc6eaeb02772cbe8a9b470b89d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-09-19 17:51:17 +00:00
Keerti Parthasarathy