dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

10502 Commits

Author SHA1 Message Date
Konstantin Shcheglov 2cf24e3b57 Evaluate TypeAliasElement in ConstantVisitor. 
R=brianwilkerson@google.com

Change-Id: I53ce1ed1b838c0c2a3c977f9be930733b951547a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175383
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-08 21:13:35 +00:00
pq 60bec731a0 @doNoStore fixes for function expressions 
Fixes: https://github.com/dart-lang/sdk/issues/44425

Change-Id: I5bac77d9a2961750b0037cd1d464ae059bcbe886
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-12-08 21:01:55 +00:00
Danny Tuppeny 0fa6674ea9 [Analyzer] Include required-named params in defaultArgumentListString and LSP complete-function-calls 
Change-Id: I8b4c09305df6e868e7447c538be4a3b540aa7e57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174802
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-08 20:47:04 +00:00
Konstantin Shcheglov dbe003f6af Update AstRewriter to support non-function type aliases. 
R=brianwilkerson@google.com

Change-Id: Id2bca0b3c8603fceea18628286412fea5a4598de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-08 20:46:25 +00:00
Konstantin Shcheglov ef09410def Remove ElementImpl.getChild() 
It is not used internally or externally (and not API).

Change-Id: Ia35bfe2ea83e1da5ae4b7945220e2b1a31c88da8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175326
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-08 17:33:45 +00:00
Konstantin Shcheglov 1c864b1bc7 Fix for StackOverflow in FileState.library 
Change-Id: I6dd9ceefbfa8d5f457d69ae20838290b8a208c98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175329
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-08 17:26:54 +00:00
Konstantin Shcheglov f508063f9c When performing partial resolution for Cider, set the context. 
R=brianwilkerson@google.com, keertip@google.com

Bug: https://buganizer.corp.google.com/issues/175007667
Change-Id: Ia1f38a8016a5580cd26bf30716affce5bc386f43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175325
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-08 05:19:43 +00:00
Konstantin Shcheglov 8d01debeda For interactive use case in AnalysisDriver use separately stored ASTs for files. 
Change-Id: I92ee458a6c143a3164c0b5a10adf42c4dbe4878d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175282
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-08 00:58:18 +00:00
Konstantin Shcheglov 9b128c5173 Build only null safe SDK bundle for resynthesize tests. 
We don't have legacy SDK anymore.

R=brianwilkerson@google.com

Change-Id: Ib122afd953d7f1167c98125dce582713fd6f7a0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175284
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-07 21:35:48 +00:00
Konstantin Shcheglov ded707e265 Update latestSdkLanguageVersion to '2.12'. 
Change-Id: I4b06f02dfecf9e10bca7fb0b285527c80d76166e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-07 18:40:54 +00:00
Konstantin Shcheglov 1231658f99 Add 'redirectedConstructor' to unit API signature. 
ConstructorElement.redirectedConstructor exposes this data, so we
should include it into the signature.

Change-Id: I87d339589694b63709f722f6b5242fb95c1085d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175220
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-07 17:28:58 +00:00
Lasse R.H. Nielsen 6e29700e16 Update List constructor documentation, deprecate constructor. 
Emphasize that the operation is going away,
and mark constructor as deprecated.

TEST= Refactoring+deprecation only, covered by existing tests.

Change-Id: I82aa044cd2cf7bf347b624371399f44bda8f4a07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173261
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2020-12-07 16:20:28 +00:00
Brian Wilkerson 7316f346e3 Update the highlighting for private_optional_parameter to include only the parameter name 
Change-Id: Ie04c30d4d3db7aa9f6804097c8a5a0fd78854756
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175200
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-07 15:28:37 +00:00
Sam Rawlins 56cf16887c Analyzer: Don't report on prefixed import with illegal references 
Bug: TODO from https://github.com/dart-lang/sdk/issues/38784
Change-Id: I4ecdaf333c2613eb5fa0c57e4a8f8be56c35bb21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175184
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-07 01:27:25 +00:00
Sam Rawlins 3f8ce51efd Analyzer: Do not report unused prefixed import when extension is used 
Fixes https://github.com/dart-lang/sdk/issues/40298

Change-Id: I2fb70249749b3bb086470714e5d1e16e80c30811
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175185
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-12-06 19:36:44 +00:00
Konstantin Shcheglov c9854e3453 Flow analysis is not available outside of function bodies and initializers. 
This fixes a group of crashes during fuzz testing.

FAILURE: z({=?[
[NoSuchMethodError: The getter 'flow' was called on null.
Receiver: null
Tried calling: flow
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:54:5)
#1      ResolverVisitor.startNullAwareIndexExpression (package:analyzer/src/generated/resolver.dart:743:21)
#2      ResolverVisitor.visitIndexExpression (package:analyzer/src/generated/resolver.dart:1552:5)
#3      IndexExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:5993:49)
#4      AstResolver.resolve (package:analyzer/src/summary2/ast_resolver.dart:85:10)
#5      DefaultValueResolver._parameter (package:analyzer/src/summary2/default_value_resolver.dart:107:18)
#6      DefaultValueResolver._parameters (package:analyzer/src/summary2/default_value_resolver.dart:121:7)
#7      DefaultValueResolver._function (package:analyzer/src/summary2/default_value_resolver.dart:89:5)
#8      DefaultValueResolver.resolve (package:analyzer/src/summary2/default_value_resolver.dart:47:9)
#9      LibraryBuilder.resolveDefaultValues (package:analyzer/src/summary2/library_builder.dart:313:43)
#10     Linker._resolveDefaultValues (package:analyzer/src/summary2/link.dart:230:15)
#11     Linker._buildOutlines (package:analyzer/src/summary2/link.dart:89:5)
#12     Linker.link (package:analyzer/src/summary2/link.dart:69:5)
#13     link (package:analyzer/src/summary2/link.dart:33:10)


Change-Id: I6145a1f728d432be8d0fa55235858e091030461c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175187
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-06 05:39:04 +00:00
Konstantin Shcheglov d518832a7c Simplify type hierarchy for resynthesize tests. 
Change-Id: I82ba179c4f2756c63f3a30ea71f5f6332b902a6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-05 18:31:33 +00:00
Sam Rawlins f1916cf0bb Analyzer: do not report an undefined getter with an empty name 
Such code is already reported with parser errors, like missing_identifier.

Change-Id: I7f4cc049aa6129cea84d210ccb4e595e52d96fb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173740
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-05 14:39:03 +00:00
Konstantin Shcheglov dee85df64d Basic support for elements/types of non-function type aliases. 
Change-Id: Ide8f2fff98f7f03375efad23df3ed79795c33a23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174681
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-04 23:32:02 +00:00
Konstantin Shcheglov 2e67e92e0b Specialize writing InterfaceType with no arguments. 
This saves 124KB, or about 6% on SDK summary.

Change-Id: I7715136c069d71c6a4cafbd2d622c5d0aa2b81f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-04 23:15:52 +00:00
Konstantin Shcheglov a230d059e1 Add LinkedUnitContext.element, remove TODO for BooleanLiteral. 
I tried to do BooleanLiteral, it resulted in just 1500 bytes saving
for the SDK summary, so I think it is not worth it.

Change-Id: I01cccb67be67ccd33219400a7ecf414d310a201f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-04 22:30:33 +00:00
Konstantin Shcheglov 584a1aca16 Fix a couple of TODO in LinkedUnitContext. 
R=brianwilkerson@google.com

Change-Id: I8415e6f4e4d7cf68b7ea2484637cf6cc34129669
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175107
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-04 21:59:22 +00:00
Konstantin Shcheglov 4ddbbcbf99 Optimize serialization format for ExperimentStatus. 
This reduces SDK summary size by 23KB.

Change-Id: I4e59e0be55927198b566d74d6287bab97e1edfa1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175105
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-04 21:53:42 +00:00
Paul Berry 6a097edc48 Flow analysis: allow identical to promote values to non-nullable. 
This change causes `identical(x, y)` to be treated similarly to `x ==
y` for flow analysis.  For example:

    int? x = ...;
    if (!identical(x, null)) {
      print(x + 1); // Ok, x is known not to be null.
    }

Fixes https://github.com/dart-lang/language/issues/1226.

Bug: https://github.com/dart-lang/language/issues/1226
Change-Id: If2939d3d4dd0dc9d7aaf39984045e9ec3e10ce7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174760
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-12-04 14:40:15 +00:00
Konstantin Shcheglov 416329dafd Issue 44284. Fix LUB to consider also mixins. 
Bug: https://github.com/dart-lang/sdk/issues/44284
Change-Id: If1c67dbe4c5be38dd715ca4aa5a1fc82c0911e36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174820
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-03 17:32:43 +00:00
Sam Rawlins e0ebe30190 analyzer: Improve unused_import analysis for shared prefix names 
Fixes https://github.com/dart-lang/sdk/issues/38784

Change-Id: I42b32261e9ed71018967e228d2ec731a4613205d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147336
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-03 04:00:37 +00:00
Janice Collins 951046f94b Update lower SDK constraint of analyzer packages to 2.9. 
2.9 is two stable versions behind current, as discussed in
the analyzer standup.

Change-Id: I403460ff1621ccfa07192ae4dcf3fa89bf45b152
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174861
Auto-Submit: Janice Collins <jcollins@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2020-12-02 22:48:57 +00:00
Konstantin Shcheglov ca8c43e3ed Update FeatureSet(s) in ResynthesizeTestCases. 
Change-Id: I4966dc7420702a8d40ff4ec8d7e32969bc4db262
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174766
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-02 19:26:38 +00:00
pq 0d145f836b posix path validation 
Fixes: https://github.com/dart-lang/sdk/issues/44358

Change-Id: Iaa3e998148f0231dfce14e23cf91b9c721f439b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174600
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-02 02:36:57 +00:00
Konstantin Shcheglov 8a40e19824 Fix analyzer Windows bot. 
Change-Id: I6c59935930d1d9c78ff21ea37007e7b82c92d1a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174680
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-02 01:16:57 +00:00
Konstantin Shcheglov 2dd03f37c9 Issue 44334. Report DUPLICATE_FIELD_FORMAL_PARAMETER for not final FieldFormalParameter. 
Bug: https://github.com/dart-lang/sdk/issues/44334
Change-Id: I4f70daf9165e31d3948c210b84aee4c00561bd3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-01 22:05:27 +00:00
Konstantin Shcheglov f6362881d5 Make 'uniqueName' a field in ErrorCode. 
It started as a way to speed up IgnoreValidator, becaus computing
uniqueName as a concatenation of 'runtimeType' and 'name' was expensive.
We solved it in a better way, but I think this change is still useful.

Change-Id: I7d3cb8c91f4ca27a0aa3b93f8572cf12c6757bae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-01 21:41:08 +00:00
Konstantin Shcheglov 19652ae5ad Use binary format for summaries. 
Change-Id: Ibf0221a3c233c958e5065b64207faf9dfae33083
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168260
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-01 21:30:35 +00:00
Konstantin Shcheglov b4052982b5 Make documentaiton comments Null Safe by default, support %language directive instead. 
This is consistent with what we do for user project.
Null safety is not an experiment anymore.

OTOH, any future experiments should be applied on top of the latest
language version.

Change-Id: I6dcbc954aefefb1f7a03c9ceaf1d25be28e7adf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174488
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-01 06:51:44 +00:00
Konstantin Shcheglov 6c6dba54bd Replace some uses of StaticTypeAnalyzer2TestShared. 
R=brianwilkerson@google.com

Change-Id: Ic3ea45d3e894b3991593a2a349909bf289743e93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174489
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-01 06:50:14 +00:00
Konstantin Shcheglov 49ca82c4e8 Move literal inference tests from StaticTypeAnalyzer2Test. 
R=brianwilkerson@google.com

Change-Id: Ie08a60dcd1a0942e5e72ae3a1ed4bb76238786db
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-30 20:30:03 +00:00
Konstantin Shcheglov 295a9a856e Prepare to publish analyzer 0.41.1 and _fe_analyzer_shared 14.0.0. 
Change-Id: I3d103aa01f306b9f9ad1118fb56c392cf0cded7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174380
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-30 20:14:43 +00:00
Konstantin Shcheglov b1a6afba1c Remove specialized API for Angular analysis. 
We have removed the Angular plugin, so we don't need the API.

Change-Id: Ifba20fba248b690f429b6a532dc5333a25f5e610
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174400
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-30 19:37:24 +00:00
Konstantin Shcheglov b200c9d68d Remove functionTypeAlias tests from FunctionTypeImplTest. 
These tests were passing by a wrong reason.

It is not possible to express a recursive typedef anymore.
When we try to instantiate `G` in `typedef F = G Function()`, it
will instantiate `typdef G = F Function()` right now, directly into
the corresponding FunctionType, but because we are in the process
of setting the return type of `F` right now, `G` is not yet referenced
in `F`, so is not referened by `G` itself.

Such recursion is possible during linking, but then we break it.
We still report errors, and resolved AST still has necessary references.

Change-Id: I47b18f80b00edd01268c65c3e1786892ad0d5091
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174381
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-30 19:37:23 +00:00
Konstantin Shcheglov 7ee7f7ad17 Another tweak for FileContentCache. 
As I see on Golem, now there is a light degradation of performance
for files in the content overlay. This should fix it.

Change-Id: Ic762a646c7dab6cbbd4792cca2c5d3ce1c49edd0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174360
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-30 00:27:23 +00:00
Konstantin Shcheglov 94a7c94855 Use readAsBytesSync() in FileContentCache. 
This should be slightly more efficient because we read bytes from
the OS file. We need both bytes (to compute hash) and string (as code).
So, it seems silly to read bytes, decode into string, then again
encode into bytes.

Change-Id: I3ee7c7282cf4f72dc32bcf9b8ffe68899a2ca3c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174341
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-29 18:09:53 +00:00
Konstantin Shcheglov 6ca2c409dc Add one ErrorCode.temporary2() 
We need to add `uniqueName`, migrate a couple of existing subclasses,
and then do a bigger change
https://dart-review.googlesource.com/c/sdk/+/174322

R=brianwilkerson@google.com

Change-Id: If9ad2be70aae6fa7f53e57836438c4bfd8be92dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174325
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-29 07:20:13 +00:00
Brian Wilkerson 64105a6a15 Improve the highlight range for for_in_with_const_variable 
Change-Id: I3dfab4f6748e6e93cd416ee031206896274ff989
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174321
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-29 05:35:17 +00:00
Konstantin Shcheglov 52fa963f5b Cache unignorable names for IgnoreValidator. 
I saw from 4% to 6% analysis time used by IgnoreValidator constructor.
We did quite a few expensive operations each time, for each file.
Now we will do it once for each bucket.

Change-Id: Ia7c79b777269c9e4c10a9fb9f2864cc7249eacf9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174230
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-28 19:56:36 +00:00
Konstantin Shcheglov 24d7a6feba Remove unused computePlatformBinariesPath(). 
Change-Id: Ia757016e264f17edbae68abfc14ab5bb33e803cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174228
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-28 05:20:51 +00:00
Konstantin Shcheglov 47023e0cc4 Remove unused createDartSdkManager(). 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: If0e1b2753fe94d02fe353495cf5d5e7cc43d3617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174226
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-28 05:12:53 +00:00
Konstantin Shcheglov 6df4279ccb Remove unnecessary Platform.resolvedExecutable access. 
R=brianwilkerson@google.com

Change-Id: Ib037100e55bd9d038734d449998385db482de7b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174227
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-28 05:04:51 +00:00
Konstantin Shcheglov 6e311941bb Clean up WithNullSafetyMixin in analyzer/ and analyzer_plugin/. 
Bug: https://github.com/dart-lang/sdk/issues/43837
Change-Id: I2282d0230e5ea0abdd2a08de2a16cfaa602c3cc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174223
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-28 04:56:46 +00:00
Konstantin Shcheglov fe3dd43995 Fix for import directive in part while checking for IMPORT_OF_LEGACY_LIBRARY_INTO_NULL_SAFE. 
Bug: https://github.com/dart-lang/sdk/issues/44280
Change-Id: I6a8ef25deaedc55ef33e83ba7614f23fd56fe788
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-11-27 21:29:05 +00:00
Brian Wilkerson 6905e30446 Improve the message for missing_default_value_for_parameter 
Change-Id: I7bc453853716c24a4e1b6cacd44202656dabd743
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-27 21:21:45 +00:00