7d7643c2ad
Add newly reviewed docs and change section header everywhere
...
Change-Id: I337fe5764b9167240b42cf75f908a3d36ef08cc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133407
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-26 22:56:45 +00:00
7b7d8789ca
Use WRONG_NUMBER_OF_TYPE_ARGUMENTS instead of two other equivalent error codes.
...
R=brianwilkerson@google.com
Change-Id: Ibb5ea7d65df75655eaf2d43fba1110740be39912
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129833
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-31 20:27:03 +00:00
43066c9911
Add newly reviewed diagnostic docs
...
Change-Id: I1a090ebd0129040a5fcbf2fca3919c6e22cf1daa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128302
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-12-13 17:55:29 +00:00
54b7543c55
Fix unnecessary_const in analyzer.
...
The only non-mechanical change is update for tool/diagnostics/generate.dart
to handle MethodInvocation, because without resolution and without
explicit `new` and `const` we get MethodInvocation(s).
R=brianwilkerson@google.com
Change-Id: Ib89ce9c37066e9b27ad03aed96b349ef36f11d43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127453
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-06 15:03:00 +00:00
364dd8936b
Fix unnecessary_new in analyzer.
...
R=brianwilkerson@google.com
Change-Id: I70f80baa3da4b14c0a52c1f28da16a9ad26d7dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-06 01:11:30 +00:00
46c042a118
Improve a diagnostic message by unwrapping Future (issue 39561)
...
Change-Id: Ie74200e8f41aa70c33f5d7a62c8d0a0ae7a96146
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-11-29 16:08:46 +00:00
3663abd8db
Update the header in the generated diagnostic docs
...
Change-Id: I2dbf01bbde39029d06aa19fd5c6cd9d80cd3e06b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126241
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2019-11-26 00:37:53 +00:00
dcaf959589
Fix several unused elements, and unnecessary casts.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I81559cb241c0ca6918f6730538f44a7411907867
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125986
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 21:37:52 +00:00
ad021d02d4
Integrate the latest batch of reviewed diagnostic docs
...
This includes a small improvement to the validation tests, but there is
also one code whose docs can't be verified without additional work that
I will do in a follow-on CL.
It also includes splitting one code into two to improve the messages.
Change-Id: I52989ca336e42822327e3ac3805b1654d20a479c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125901
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 15:21:55 +00:00
c96fe4e006
Add more explaination to existing examples
...
Change-Id: I2f89ef54eb4467d23f7507c1217385a1df2d4a11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124594
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2019-11-16 02:52:18 +00:00
df8876582c
Include all variations of a message in diagnostic docs
...
We now have multiple messages for the same name (id) and all of the
messages should be included in the docs so that users aren't confused
when the message they see doesn't match what's documented.
Change-Id: I0f668ececae1e9852eff9db25f29a48b7414c4d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-10-28 15:55:31 +00:00
9cc57416be
Change error node for MISSING_RETURN to be the name
...
Fixes #35607
Change-Id: I66b9921b0ede5370364b89a89fb19bf0df96ac97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122726
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-10-24 19:42:07 +00:00
3778839976
Fix version number that first supports ui-as-code; fixes #37898
...
Change-Id: Iaaec4dedbe8f9b2b5331fa9c69c39d5032383d75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113743
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-10-15 19:35:49 +00:00
8f477fd84a
[parser] Disallow covariant on extension method parameters
...
Fixes #38560 .
Change-Id: I4c941fb6713983cc01efbe143c7924d0643efe73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119332
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2019-10-08 13:01:40 +00:00
04910d62f5
Include the deprecation message in diagnostics (issue 38667)
...
Change-Id: Ib1fa24fa4b112b9675d1f1900cbdda15319080a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119780
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-10-04 16:27:07 +00:00
3f65652ad0
Enable avoid_init_to_null.
...
R=brianwilkerson@google.com
Change-Id: I983fdff71c47dbf2b271508955095a73cfbeee59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-30 14:26:06 +00:00
a2803a1b2d
Add documentation for more diagnostics
...
Change-Id: I8270a74cc5a70dd16a46e3a7b2ff2bb822b69fb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-25 16:38:06 +00:00
139889e2b9
Fix a couple of diagnostic messages and re-order several constants to restore alphabetic ordering
...
Change-Id: Ifb853a1ae6b9b22e2f8e65c304b43ba2b8b895d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117161
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-13 15:58:42 +00:00
c74e68e501
Add documentation for more diagnostics
...
Change-Id: Id2aeb13db0ceb81fc18d67e6ef2778304b36d02b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-09-12 16:35:46 +00:00
e8836f5086
Fix sample for UNDEFINED_SETTER.
...
R=brianwilkerson@google.com
Change-Id: I9c897ee5890d4b951cf157a5da6c21a5505248d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116823
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-11 21:20:57 +00:00
d36f5ed181
Fix diagnostic documentation tests and add support for documenting parser codes
...
Change-Id: Ie2e360e6e4a344888bb409d20f21c969280bbdf9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116742
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-11 19:45:47 +00:00
a94a3c60d7
Format the code snippets in docs
...
Change-Id: Ieabed8b05df79b4872090e82cdc6ceb941979e71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115060
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2019-08-30 16:38:14 +00:00
7eecb77b0f
Minor updates to the diagnostic docs
...
Attempt to fix the link to the glossary and consistently place 'keyword'
after the name of the keyword in text.
Change-Id: Ib5f75568bdea0a875d1829ab52cbe93894e7f595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114742
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2019-08-28 17:29:01 +00:00
74e09abc6e
[CFE] Remove/move file that wasn't needed by frontend; cleanup pubspec.yaml a bit
...
Change-Id: I204b844e7f1cb892a529bca3a13017ed836275f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114074
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-08-23 07:42:03 +00:00
d2f1dde3c7
Merge two codes, improve some messages, and general code cleanup
...
In retrospect I probably should have made this three separate CLs, and
I'm happy to go back and do so if you'd prefer.
Change-Id: I816bbbc16794c86129c9b6501db4a5dce2a8e199
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110480
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-26 18:25:21 +00:00
fbcbb83cab
Add documentation for more diagnostics
...
Change-Id: I57b69e5e16c7b6effb369e49556fc744976b04e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110201
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-07-25 17:15:34 +00:00
4fc387f27e
Update doc the generator to convert code blocks
...
Change-Id: I7b5b6c42d700762bf82331113f90091754283534
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109620
Reviewed-by: Kathy Walrath <kathyw@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-19 17:51:10 +00:00
d32a4dbe57
Minor updates to existing docs
...
These are based on recent comments, and might not be appropriate.
Change-Id: I634dc30a29459f3ab41dae99233d27c9954b9347
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109542
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2019-07-18 15:43:55 +00:00
3a8d755989
Change the delimiters used to mark highlight ranges in diagnostic documentation
...
Change-Id: I4eb2c44ea4eb2a054eccbb4a6ab64a01d2866042
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108506
Reviewed-by: Kathy Walrath <kathyw@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-09 22:12:07 +00:00
d914839ce6
Add tests for diagnostic docs
...
This tests that the docs have been generated and that the code samples
in the docs generate the expected errors at the expected locations.
Change-Id: Iff254537c15c58d6c5dde2bb2bb739e52f156b50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-08 13:36:14 +00:00
f897a940c1
Fix minor nit in documentation
...
Change-Id: I0a75ecce970754b036f2af0a065aa392547dae7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-17 16:19:09 +00:00
c5cd37e727
Address more documentation feedback
...
Change-Id: I2e55e146495ab8bd59e87cff9915ee84c99da8b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-15 15:30:40 +00:00
a02d6de474
Update documentation based on addition feedback from the documentation team
...
Change-Id: If028f6f3a81a827537642da9f261001588f67bf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-14 17:09:37 +00:00
e6567601af
Add a notice that the markdown file is generated and remove documentation specific to nnbd
...
Change-Id: Iece4cd98399b243c9d7fb69af888460bb45421fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-11 19:57:19 +00:00
9559e4d444
Initial documentation for a small sample of diagnostics and a script to generate a markdown file containing that documentation
...
Change-Id: I06602a29c95829b42add1d655ad8d7190ae7100a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-07 22:31:16 +00:00
Brian Wilkerson