5dd02f0583
Add getParsedLibrary2(), deprecate getParsedLibrary() and other parse related
...
Change-Id: I585fa1f01b71522dc99ba86c2b9e20da256b2d27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-04-19 15:52:39 +00:00
7f54fc96e5
Add documentation for several more codes
...
Change-Id: I012db56773acee6a81fbb6a33958beb686793ec9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-03-28 21:16:11 +00:00
9f986d2501
Migrate package:analyzer to null safety.
...
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-02-01 18:56:04 +00:00
7d3bc4862d
Rename pkg/analysis_tool to pkg/analyzer_utilities.
...
It's no longer just for the tools in the `tool` directory; it also
contains test utilities for use by the analyzer and related packages.
Change-Id: I0f8cf57f24ea7aad8e2177e43ee2bcb2ab3030da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171704
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-11-13 17:46:30 +00:00
596198fb74
Share logic of package_root.dart
...
This CL unifies the implementations of `package_root.dart` found in
packages `analysis_server`, `analysis_server_client`, `analyzer`, and
`analyzer_plugin`.
This should make it easier to re-use this logic in other packages,
such as `nnbd_migration`.
Change-Id: I0da44edb379b8e929dd0b1c16a6989c1e9418acb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-11-11 18:09:18 +00:00
9e6486fe3f
Analyzer: Make test fields late, late final, or hinted for migration.
...
Many fields can be late or late final, so adding hints for the migration tool.
In SnippetTester, the fields are all set in the constructor. Added a factory
constructor so the fields can be final. Renamed them to be private.
Change-Id: I559e7ba92c7c6749038630b03f67f8a77bdc704a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170406
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-11-05 17:45:17 +00:00
9d1883c290
Remove duplicate messages from the generated documentation
...
Change-Id: I621f737faf08784faae5d7715ed4b5603a564985
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-10-12 17:54:02 +00:00
dfc3e2666e
Fix the formatting of a header
...
Change-Id: I9f0b7b564d71cf30fe3d5ac41e67c71ae3e3ee40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165146
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2020-09-29 23:42:08 +00:00
597588f698
Make additional requested changes to the diagnostic documentation
...
Change-Id: I30b1f44c957b0f7bc4d629e62e0d9aeca7560203
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-09-29 19:42:07 +00:00
2c4bee37c0
Add documentation for some additional diagnostics
...
Change-Id: Ib6dc3740de759d820421fa3a899c72302de64c9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-09-25 04:35:33 +00:00
e224540b1c
Unify four diagnostic codes for the purpose of documentation
...
I would have prefered to have renamed them all to undefined_super_member,
but that would have broken existing links. Some day we should add the
support necessary to allow for forwarding so that we can rename codes.
Change-Id: I81e416407e3464b5b60a4dbbfe60a375eb47bb84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157921
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-08-11 01:07:44 +00:00
363c72111d
Update docs to use markdown styled links
...
Change-Id: Id5b966ee41c75ee02c7ce10609033b81d930697b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157120
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2020-08-05 00:20:32 +00:00
8cc3d415e7
Integrate suggested changes from the PR to publish the docs
...
Please look this over carefully; all of your changes have been integrated,
but not all of the changes are yours. While itegrating your suggestions I
found a few more occurrances of 'is not' and 'are not' that I converted.
I also found a couple of other things that needed to be updated.
Change-Id: Iddaaa22d7e584506bc3c16606166771fd5a75caf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152942
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2020-07-01 15:58:11 +00:00
88876d5642
Add documentation for most of the Null Safety diagnostics
...
This also updates the testing framework to allow experiments to be
specified with code snippets so that the examples can be tested.
Change-Id: Ifd15c321fef60c736124d368f4d6bfa947460fe8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-04-19 15:24:59 +00:00
54b7543c55
Fix unnecessary_const in analyzer.
...
The only non-mechanical change is update for tool/diagnostics/generate.dart
to handle MethodInvocation, because without resolution and without
explicit `new` and `const` we get MethodInvocation(s).
R=brianwilkerson@google.com
Change-Id: Ib89ce9c37066e9b27ad03aed96b349ef36f11d43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127453
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-06 15:03:00 +00:00
364dd8936b
Fix unnecessary_new in analyzer.
...
R=brianwilkerson@google.com
Change-Id: I70f80baa3da4b14c0a52c1f28da16a9ad26d7dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-06 01:11:30 +00:00
3663abd8db
Update the header in the generated diagnostic docs
...
Change-Id: I2dbf01bbde39029d06aa19fd5c6cd9d80cd3e06b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126241
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2019-11-26 00:37:53 +00:00
dcaf959589
Fix several unused elements, and unnecessary casts.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I81559cb241c0ca6918f6730538f44a7411907867
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125986
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-11-21 21:37:52 +00:00
df8876582c
Include all variations of a message in diagnostic docs
...
We now have multiple messages for the same name (id) and all of the
messages should be included in the docs so that users aren't confused
when the message they see doesn't match what's documented.
Change-Id: I0f668ececae1e9852eff9db25f29a48b7414c4d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-10-28 15:55:31 +00:00
3f65652ad0
Enable avoid_init_to_null.
...
R=brianwilkerson@google.com
Change-Id: I983fdff71c47dbf2b271508955095a73cfbeee59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-30 14:26:06 +00:00
d36f5ed181
Fix diagnostic documentation tests and add support for documenting parser codes
...
Change-Id: Ie2e360e6e4a344888bb409d20f21c969280bbdf9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116742
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-11 19:45:47 +00:00
7eecb77b0f
Minor updates to the diagnostic docs
...
Attempt to fix the link to the glossary and consistently place 'keyword'
after the name of the keyword in text.
Change-Id: Ib5f75568bdea0a875d1829ab52cbe93894e7f595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114742
Commit-Queue: Kathy Walrath <kathyw@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
2019-08-28 17:29:01 +00:00
74e09abc6e
[CFE] Remove/move file that wasn't needed by frontend; cleanup pubspec.yaml a bit
...
Change-Id: I204b844e7f1cb892a529bca3a13017ed836275f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114074
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-08-23 07:42:03 +00:00
fbcbb83cab
Add documentation for more diagnostics
...
Change-Id: I57b69e5e16c7b6effb369e49556fc744976b04e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110201
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-07-25 17:15:34 +00:00
4fc387f27e
Update doc the generator to convert code blocks
...
Change-Id: I7b5b6c42d700762bf82331113f90091754283534
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109620
Reviewed-by: Kathy Walrath <kathyw@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-19 17:51:10 +00:00
d914839ce6
Add tests for diagnostic docs
...
This tests that the docs have been generated and that the code samples
in the docs generate the expected errors at the expected locations.
Change-Id: Iff254537c15c58d6c5dde2bb2bb739e52f156b50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-08 13:36:14 +00:00
c5cd37e727
Address more documentation feedback
...
Change-Id: I2e55e146495ab8bd59e87cff9915ee84c99da8b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-15 15:30:40 +00:00
e6567601af
Add a notice that the markdown file is generated and remove documentation specific to nnbd
...
Change-Id: Iece4cd98399b243c9d7fb69af888460bb45421fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Kathy Walrath <kathyw@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-06-11 19:57:19 +00:00
9559e4d444
Initial documentation for a small sample of diagnostics and a script to generate a markdown file containing that documentation
...
Change-Id: I06602a29c95829b42add1d655ad8d7190ae7100a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-07 22:31:16 +00:00
Konstantin Shcheglov