dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Konstantin Shcheglov 6cc220ec63 Add FileResolver.linkLibraries(), fix null typeProvider. 
Change-Id: I4222097336407736e4cf0c3e922e9fac8c762725
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-15 20:57:07 +00:00
Konstantin Shcheglov aad1a677c0 Deprecate GenericTypeAliasElement 
See also https://dart-review.googlesource.com/c/sdk/+/166680

Change-Id: I6018f3bf5796dcc8ab059aab5b29d01e7336581b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-15 16:03:26 +00:00
Konstantin Shcheglov 9ef964853c Use assertPropertyAccess2() in ExtensionOverrideTest for getters. 
We don't want to check if it is setter, because it never is now.

R=brianwilkerson@google.com

Change-Id: Iab52ff670f12ab56811b850b6518a3b7d4ae7730
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167724
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-14 19:46:30 +00:00
Brian Wilkerson 51b8dfb6fd Remove the unreported access_private_enum_field diagnistic 
If this diagnostic needs to be generated, then I can create an issue to
track that work, but I think we handle it by not defining the private
fields in our models, which means the issue is reported as an undefined
getter.

Change-Id: I8d220adf0d11b2c65f8953eec57a87f86f520d74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-14 19:36:43 +00:00
Konstantin Shcheglov 779a3219f3 Ignore names _$foo when there is a missing .g.dart part. 
Change-Id: I5a103cd362318b4db292b5f41da9e56a60f6431d
Bug: https://github.com/dart-lang/sdk/issues/42832
Bug: https://github.com/dart-lang/sdk/issues/42977
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166820
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-14 19:28:38 +00:00
Konstantin Shcheglov fbfc723de7 Use CompoundAssignmentExpression instead of LHS element/type. 
This adds some technical debt in form of using writeOrReadElement in
clients, which can be paid incrementally by migrating these places to
handling assignment like expressions one by one. Doing it all in one
CL was too much. But now the underlaying AST resolution will be
sound.

In the next breaking change we will remove
setAssignmentBackwardCompatibility(), so stop setting elements/types
for assignment targets.

Change-Id: I11626876cfed25653edb0cc18544aba51cef5965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165622
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-14 18:45:08 +00:00
Konstantin Shcheglov 5b52dfccf5 Fix --default-language-version support. 
Re: https://dart-review.googlesource.com/c/sdk/+/166790
Change-Id: Ic646f4cf8c59810e856722a9099cadd364bad96a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166923
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-10 23:55:20 +00:00
Konstantin Shcheglov 863e958cad Fix the issue with reusing LinkedElementFactory and supertype for Object. 
Bug: https://buganizer.corp.google.com/issues/170429675
Change-Id: Ieaec29e8b09ce5cc9c02e7dce5919e8b56278910
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166789
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-09 17:34:57 +00:00
Konstantin Shcheglov 694c8d0d6b Update UP for FutureOr. 
Bug: https://github.com/dart-lang/sdk/issues/43720
Change-Id: I9decd3a3b430f82e3e4bd0c4e6963cd3069f9adf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166786
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-09 00:00:55 +00:00
Konstantin Shcheglov 63e0cd6955 Issue 43717. Update UP(FunctionType, unrelated) to UP(Object, unrelated). 
Bug: https://github.com/dart-lang/sdk/issues/43717
Change-Id: Ib2fa861df24d010c768e4a06ba2bff175bbf88f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166783
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-08 23:42:45 +00:00
Konstantin Shcheglov 132e2307e7 Report MAIN_FIRST_POSITIONAL_PARAMETER_TYPE 
Bug: https://github.com/dart-lang/sdk/issues/43555
Change-Id: Ieacc710f1da1d92ab99337c6511a6b994e9bc0da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166780
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2020-10-08 19:59:19 +00:00
Konstantin Shcheglov 0c342ae491 Fix crash when invalid default field formal parameter has annotation. 
Change-Id: Iabb329f850195be981d80b0589d9f7851596c680
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166740
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-08 15:17:05 +00:00
Konstantin Shcheglov 103465c90c Report MAIN_HAS_MORE_THAN_TWO_REQUIRED_POSITIONAL_PARAMETERS and MAIN_HAS_REQUIRED_NAMED_PARAMETER. 
Bug: https://github.com/dart-lang/sdk/issues/43559
Change-Id: If74634187d411c0b008133b59c1c3e23e87319c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166309
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-08 00:05:16 +00:00
Sam Rawlins 19ada0706e Report indirectly exporting @internal typedef 
This type of exposure was brought up by Lasse at https://github.com/dart-lang/sdk/commit/afbb8f9063eaabf80fd3dfcd67ff2d3c07be2395#r42686423.

New "Indirect exposure" section in the doc: https://docs.google.com/document/d/130E4qfsjqRWtSNpIoNM628zVwGP-8W4J1P7W3wzJG8c/edit#

Change-Id: If38889b2134719804aa8cbaf613c8eb33cb6d949
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-10-06 21:58:23 +00:00
Sam Rawlins 1df5c58d29 Analyzer: Move MustCallSuperVerifier to its own library 
This will make it easier for upcoming bug fixes. Calling this verifier
in BestPracticesVerifier means it will only be run when hints are
enabled, perhaps boosting performance.

Also add a few more test cases.

Change-Id: If22ab02313d9f98f067ad4325b2f5ac473f4862c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164580
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-10-06 20:15:33 +00:00
Keerti Parthasarathy 168b7201d2 Fix finding third party analysis options. 
Change-Id: If6792018fa9a4a64316be034dfa4b6e14c2e03d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/166124
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-10-05 22:55:53 +00:00
Brian Wilkerson 8967e3b85b Fix the offsets for diagnostics produced while validating analysis options files 
Change-Id: I1417be1e77738b19728546c5caa449ae2e0e54c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165980
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-05 15:59:26 +00:00
Konstantin Shcheglov d03dd09e0f Report CompileTimeErrorCode.MAIN_IS_NOT_FUNCTION 
Bug: https://github.com/dart-lang/sdk/issues/43557
Change-Id: I773cd09a164c37444b9765ebc445477467bb7665
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-04 17:25:51 +00:00
pq 1ee70ab86c check sub-expressions for @doNotStore 
Change-Id: I3a54b3e84cb9f87ad7aefe5fc917bc0b6c890dc3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165921
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-04 14:58:21 +00:00
Konstantin Shcheglov 090166c79d Report CompileTimeErrorCode.UNDEFINED_IDENTIFIER read in compound assignment. 
Bug: https://github.com/dart-lang/sdk/issues/42704
Change-Id: Ibf9557c97a05229151254ad0d33ecf27764dce7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-03 16:32:01 +00:00
Konstantin Shcheglov ba9355624c Issue 1182. Use the initial type for extension instantiation. 
Bug: https://github.com/dart-lang/sdk/issues/43590
Bug: https://github.com/dart-lang/language/issues/1182
Change-Id: I80366ad4f777eec299143a002bbdc9d92ba61a5b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160883
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-10-02 23:44:41 +00:00
Konstantin Shcheglov f516210208 Replace assertTypeParameterType() with the display string check. 
Not that we include the promoted bound in the display string,
we can get back to checking these types just as strings.

R=brianwilkerson@google.com

Change-Id: Ie713e18082a3f5080ece039573098c998b8a2b98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-02 20:08:21 +00:00
Konstantin Shcheglov 3a59eafbe5 Include promotedBound into the TypeParameterType display string. 
Change-Id: I7d34a041559875d34a66de4504b8df1b57497e55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165684
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-02 18:42:21 +00:00
Konstantin Shcheglov 3698091858 Use demoteType() on inferred type arguments. 
Bug: https://github.com/dart-lang/language/issues/1182#issuecomment-702272641
Change-Id: I72d30f51aaf1d2651c1568cd68f37e5c7c03b582
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/165683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-01 22:22:47 +00:00
Konstantin Shcheglov 6a92616f52 Issue 43175. Report IMPLICIT_THIS_REFERENCE_IN_INITIALIZER in AssertInitializer. 
Bug: https://github.com/dart-lang/sdk/issues/43175
Change-Id: I23ae1c8d6177e99e634d3b05236c5787a3a95b5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-01 02:02:31 +00:00
Keerti Parthasarathy b8909a4878 Replace CiderMemoryByteStore with CiderCachedByteStore. 
Change-Id: I6301cfbbaa4a65b5f1d326174879ebddff14cc98
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164662
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-09-29 00:46:18 +00:00
Konstantin Shcheglov 499bae02e0 Issue 34699. Use type parameter variance when instantiate to bounds. 
Bug: https://github.com/dart-lang/sdk/issues/34699
Bug: https://github.com/dart-lang/sdk/issues/43524
Change-Id: I8fe14c59fff17f3e4ebee62fbd7be2b45172a595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-28 23:25:58 +00:00
Konstantin Shcheglov 31e673d80c Deprecate SimpleIdentifier.auxiliaryElements 
Change-Id: Ie1e92cc61b7018d503cdf44c37611ea55b4b5391
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-28 16:00:44 +00:00
Konstantin Shcheglov ffbe30f890 Deprecate IndexExpression.auxiliaryElements 
Change-Id: I7359527db5bbf161a35296678ff2bd43052c1794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164740
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-27 18:28:46 +00:00
Konstantin Shcheglov e3fcb1a646 Remove unnecessary convertPath() invocations. 
Change-Id: I57d0d2204df02bd9a5fc97986347ac0218442d39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164722
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-26 18:25:00 +00:00
Konstantin Shcheglov 90ec73cd28 Print default types of type parameters of type defining elements. 
R=brianwilkerson@google.com

Change-Id: I62e2d7b050e0d81169b0d780ebce8858bee9dec0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-26 18:16:57 +00:00
Konstantin Shcheglov fc151ec027 Compute variance for type parameters of typedefs. 
Bug: https://github.com/dart-lang/sdk/issues/34699
Change-Id: I30f010f89da6abb1b3d27fe1eab11d5eb1c5e190
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164660
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-25 23:32:54 +00:00
Konstantin Shcheglov f9e6e38b21 Straighten up invocation of an Object method on dynamic. 
Fixes https://github.com/dart-lang/sdk/issues/39609

Change-Id: I9b98d9bff8d4e9b75ab7625323f62eb6b6701a94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164256
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-25 16:46:04 +00:00
Konstantin Shcheglov e423e857f8 Make null check to participate in null shorting. 
Bug: https://github.com/dart-lang/language/issues/1163
Change-Id: I6e648f76413c5036a867b2125359f28eb03027c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-25 16:02:34 +00:00
Paul Berry def50905c2 Make flow analysis handling of is/==/??=/?. consistent with mixed mode semantics 
Bug: https://github.com/dart-lang/language/issues/1143
Change-Id: Id177f8b19c15ef246f21ddd840410cddfee2e5cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163600
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-09-25 08:35:03 +00:00
Konstantin Shcheglov 55496a1282 Deprecate getReadType() and remove getExpressionType(). 
Change-Id: Ibc32afd7867f5b0f940affdaea97904c1afb194c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-25 05:05:33 +00:00
Konstantin Shcheglov 7a06bcb96e Pass TypeProvider to Member(s). 
Bug: https://github.com/dart-lang/sdk/issues/43541
Bug: https://buganizer.corp.google.com/issues/169344717
Change-Id: I00b7c5308473de2bef949668c72aaad1967f199a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-25 05:03:03 +00:00
Brian Wilkerson cd897bc86c Remove the diagnostic default_value_in_function_typed_parameter 
This diagnostic is obsolete because the parser also produces a
diagnostic for this situation.

Change-Id: I5c5f7fc734ddeb5cfaaba9cc9980efe174aeb4e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164461
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-25 04:35:53 +00:00
Konstantin Shcheglov f04f00adac Clean up INVALID_EXPORT_OF_INTERNAL_ELEMENT and INVALID_INTERNAL_ANNOTATION tests. 
R=brianwilkerson@google.com

Change-Id: I38810fdf5fe05c5a18f003055b1bd5a8842ebb4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164255
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-25 02:17:43 +00:00
Sam Rawlins 52b0285e41 Analyzer: Gather operator super calls for mustCallSuper 
Fixes https://github.com/dart-lang/sdk/issues/27896

Change-Id: I7017026346a92ffc43a3cfa506f7a257af1a3471
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-09-24 21:15:38 +00:00
Sam Rawlins e21b596578 Analyzer: Add tests for @internal 
Change-Id: I0974a25c7238a9e0831c035e47829c7039f0abf9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-09-24 19:53:27 +00:00
Konstantin Shcheglov 578d0c081f Fix search for enums. 
Bug: https://github.com/flutter/flutter-intellij/issues/4881
Change-Id: I7f474841c534891d6eb5de5e9fed07e7048e612e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-24 19:22:57 +00:00
Konstantin Shcheglov 7ec28c3f08 Enforce await_only_futures and fix violations. 
R=brianwilkerson@google.com

Change-Id: Icfc093d46562ddc7084151e76f495cc1462bb900
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164257
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-24 14:28:00 +00:00
Konstantin Shcheglov 9b7c0ebd82 Extract SimpleIdentifierResolver. 
The improvement is that we use PropertyElementResolver and stopped
using setReadElement() and setWriteElement().

The error reporting and type anlysis is moved as it were.

Change-Id: I808be8d0d52d4eece892be8234dd28c213dcb11c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164253
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-24 14:26:03 +00:00
Sam Rawlins e615c06c91 analyzer: Report illegal @internal usage of a library or unnamed super ctor call 
Bug: https://github.com/dart-lang/sdk/issues/28066
Change-Id: Ifd7a54e590699de02d0db80d5aa38a3a0b2bce73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164248
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-09-24 01:53:59 +00:00
Konstantin Shcheglov ac5c140f60 Extract PrefixedIdentifierResolver. 
Element resolution is improved to use PropertyElementResolver.
And we don't call setReadElement() and setWriteElement() anymore.

Type analysis is kept as is for now.

Change-Id: If14a5b5690947f335e05a43f3f6166c0a228f9eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-23 21:47:59 +00:00
Konstantin Shcheglov 75ea66605a Infer Object when subtype matching dynamic/void vs. Q?. 
See https://github.com/dart-lang/language/pull/1200

TGP looks green.
https://test.corp.google.com/ui#id=OCL:333332281:BASE:333335686:1600887590104:a120780c

Bug: https://github.com/dart-lang/sdk/issues/43162
Change-Id: I1102fc5ee7c3210aa990c9f71f905190cd1665e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-23 21:24:09 +00:00
Konstantin Shcheglov 3b9e300b9c Extract AnnotationResolver. 
Just as is, without any attempt to clean it up for now.

Mostly to get it out of the way to clean up Prefixed/SimpleIdentifier
resolution.

Change-Id: I36c3338beb065bb834ed1b7ba8cc3ff7241d03f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-23 18:37:49 +00:00
Sam Rawlins 863821476c Analyzer: Report invalid use of internal members 
Bug: https://github.com/dart-lang/sdk/issues/28066
Change-Id: Iee39fee48340fb9311a8f7a07d1ae7aa474a22f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163961
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-23 17:51:49 +00:00
Konstantin Shcheglov e89279c85f Resolve IndexExpression and PropertyAcces as read only. 
All writes are handled in corresponding assignment (-like) expressions.

Change-Id: Iab4220f7fce55daebd8aac1c90bf81efe3d7d8e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-09-22 21:59:31 +00:00