dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Konstantin Shcheglov 90b694b93d Keep resynthesized annotations, even if partially unresolved. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ie56808e53d2acdf94153658197813150b138431f
Reviewed-on: https://dart-review.googlesource.com/c/84823
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-19 21:33:25 +00:00
Dan Rubel aa9d186fa5 More analyzer set literal tests 
Change-Id: I2d2dc2f8fb04f9baf135ac2504f0fa412c4ed262
Reviewed-on: https://dart-review.googlesource.com/c/84781
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-19 21:22:33 +00:00
Brian Wilkerson cb88347087 Port the SDK violation hint to the master branch 
Change-Id: Id795400473796f05e46c0ffdd0a8920f8ad5bcd3
Reviewed-on: https://dart-review.googlesource.com/c/84688
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-19 21:14:48 +00:00
Konstantin Shcheglov de2e6a5543 Return ResultState.NOT_A_FILE for external libraries from getParsed/ResolvedLibrary(). 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ia2604f7c5c675fe66dae430401d9fdc4b20a0860
Reviewed-on: https://dart-review.googlesource.com/c/84760
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-19 18:39:41 +00:00
Brian Wilkerson 032bfe0872 Use void rather than Object as a type argument when possible 
Change-Id: I275a20e6f58a01adda3be64cf83930cc238beed3
Reviewed-on: https://dart-review.googlesource.com/c/84700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-19 18:32:31 +00:00
Brian Wilkerson 47e11951a8 Add a missed test file 
Change-Id: Ica4bdb1120bebfd71bd893ecad330e00fddbf5ce
Reviewed-on: https://dart-review.googlesource.com/c/84689
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-19 17:35:13 +00:00
Konstantin Shcheglov 3f03b07d53 Keep actual resynthesized constant expressions even when they are partially unresolved. 
This is what Angular outliner (and another generator that I forgot)
expects. The alternative with resolving library seems less palatable.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I6e407c6034284043e169bc64076ec2c811b33bfe
Reviewed-on: https://dart-review.googlesource.com/c/84682
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-19 16:58:28 +00:00
Paul Berry 6d8e14c9db Merge commit 'f56fea3e6389727df2cae5c6feebcdd49437b12a' into analyzer 2018-11-19 08:24:02 -08:00
danrubel 7f63fcfe1f Add AstBuilder set literals support 
Change-Id: I8e126d31975bc3834b4091ba149c97b92dde9a10
Reviewed-on: https://dart-review.googlesource.com/c/84663
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-17 03:11:41 +00:00
Dan Rubel 9677ec9a14 Fix parsing complex function expressions 
Fix https://github.com/dart-lang/sdk/issues/35177

Change-Id: I378314741bbbe555f9cdc2b95dcfd5ce71a15efa
Reviewed-on: https://dart-review.googlesource.com/c/84660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2018-11-16 21:49:30 +00:00
Paul Berry 32a6032f03 Merge commit 'ddbe22190c41b1993a3c93b67f1bfa57287348f8' into analyzer 2018-11-16 12:01:38 -08:00
Paul Berry 920630acab Cherry-pick 19d9aa3337 to analyzer branch. 
Original commit message:
    Add isLibraryByUri() to AnalysisDriver.

    The package:build develpers told us that they need it.

Change-Id: Ieb276b175f244a122d2e5d2f31ac852252d2c595
Reviewed-on: https://dart-review.googlesource.com/c/84642
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-11-16 19:40:30 +00:00
Brian Wilkerson 716c9dcde2 Add a hint when Future is imported from core in code targeted to run with an SDK prior to 2.1 
Change-Id: I925412b9c7c3023836a0a2a7d3d00847adf0b0c7
Reviewed-on: https://dart-review.googlesource.com/c/84547
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-16 19:07:27 +00:00
Konstantin Shcheglov b27d6078c2 Update getLibraryByUri() to more directly use external summaries, and check for part instead of library. 
We need at least the external summaries portion, the checks for isPart
is to be a bit more clean, I think, hopefully does not break anything
internally.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ic2e47b45ffb057195d34e1c5c55bbb20541e423d
Reviewed-on: https://dart-review.googlesource.com/c/84551
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-16 18:11:59 +00:00
Brian Wilkerson 01e0df71a8 Stop unnecessarily extending Object 
Change-Id: Ib557755916b09be4e1ad1b1c2e4bed052a280513
Reviewed-on: https://dart-review.googlesource.com/c/84640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-16 16:43:24 +00:00
Konstantin Shcheglov 8414e2240c Don't report DEPRECATED_MEMBER_USE for deprecated mixins, top-level variables, and class fields. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ied5fbe5f7427d286a43902719eb153964c8800e0
Reviewed-on: https://dart-review.googlesource.com/c/84545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-15 20:35:57 +00:00
Konstantin Shcheglov a6665c1aa1 Fix for computing constant values of annotations with named constructors. 
We are given ConstructorElementHandle, not ConstructorElementImpl.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I41f8029dddc293e45628d7ecca131b337cc9e286
Reviewed-on: https://dart-review.googlesource.com/c/84543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-15 19:57:15 +00:00
Konstantin Shcheglov 19d9aa3337 Add isLibraryByUri() to AnalysisDriver. 
The package:build develpers told us that they need it.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ia48851faac353d5f83e7d6af7d579c2c1d8be1bd
Reviewed-on: https://dart-review.googlesource.com/c/84502
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-15 17:48:49 +00:00
Brian Wilkerson 7d84c2e4b0 Serialization of set literals 
Change-Id: I6e0e2dd3cda72d24d36e9b2c5d2c00d81f73379b
Reviewed-on: https://dart-review.googlesource.com/c/84364
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-14 20:01:57 +00:00
Brian Wilkerson 1d00a8a11f Add checking for errors related to set literals 
Change-Id: Iad1442da6be318a709f5782fbda4a9055f55dfac
Reviewed-on: https://dart-review.googlesource.com/c/84302
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-13 20:08:23 +00:00
Brian Wilkerson 3826a983b0 Add constant evaluation for lazy null-aware and lazy conditional expressions 
Change-Id: Iea892bee3ad5c0bdbc0803ce665acfe38ccbd9a1
Reviewed-on: https://dart-review.googlesource.com/c/84182
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-12 23:21:34 +00:00
Brian Wilkerson f6128b48b6 Add constant evaluation for operators that now apply to bool as well as int 
Change-Id: I080386cddfece2d789fcee7d13bdda01260cc724
Reviewed-on: https://dart-review.googlesource.com/c/84160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-12 21:26:08 +00:00
Konstantin Shcheglov 2079620a53 Issue 34733. Expand 'implicit-casts' controlled casts, and deprecate more of 'declaration-casts'. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/34733
Change-Id: Ifda5cbd8cc8d81a7e3ad8133d68c056b869bb588
Reviewed-on: https://dart-review.googlesource.com/c/84122
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-12 21:04:59 +00:00
Konstantin Shcheglov 6880bfca41 Cherry-pick 028ac52180 from analyzer to master. 
This fixes "Evaluation of this constant expression throws an exception"
during Flutter analysis.

Initial CL: https://dart-review.googlesource.com/c/sdk/+/81750

R=brianwilkerson@google.com, paulberry@google.com

Title: Enum values are always computed, compute even implicit null values of default parameters.
Change-Id: If38dde0490f04bf39119087b5f15a36272e58cab
Reviewed-on: https://dart-review.googlesource.com/c/84041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-12 19:54:18 +00:00
Konstantin Shcheglov c9ae39a9bf Issue 34741. Update error message to make it less unclear. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/34741
Change-Id: If766d0aad5d87578a578849f269746a64430a68b
Reviewed-on: https://dart-review.googlesource.com/c/84100
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-12 19:00:34 +00:00
Konstantin Shcheglov 9cf51348d4 Issue 33553. For get/set. Don't report ABSTRACT_SUPER_MEMBER_REFERENCE if the nominal superclass has noSuchMethod(). 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/33553
Change-Id: Ic0e142519a839607560ae0d0e551424a9b32c954
Reviewed-on: https://dart-review.googlesource.com/c/84045
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-12 17:31:25 +00:00
Brian Wilkerson 268993acb2 Provide support for is and as expressions 
Change-Id: I853fee6a868314392d37f51f8dd36e2dda319c38
Reviewed-on: https://dart-review.googlesource.com/c/84050
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-11-12 17:10:20 +00:00
Konstantin Shcheglov 799cad6dfd Fix tests failing on Windows bot. 
R=brianwilkerson@google.com

Change-Id: I711de50a5c7631ce55eacd333027446d8fba0480
Reviewed-on: https://dart-review.googlesource.com/c/84043
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-09 18:46:39 +00:00
Brian Wilkerson 3a427f3294 Add an object representation for literal constant sets 
Change-Id: If9ebebac0ba6891c7c5bd2398898f20a7ea82c6b
Reviewed-on: https://dart-review.googlesource.com/c/83940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-09 17:29:31 +00:00
Konstantin Shcheglov 9cbd76d2bd Issue 35090. Concrete nominal superclasses of mixin applications provide at least noSuchMethod forwarders for super-invoked members. 
Bug: https://github.com/dart-lang/sdk/issues/35090
Change-Id: Id54856cb44cfb30eccaac68a2ee21f4bc9439bd2
Reviewed-on: https://dart-review.googlesource.com/c/83881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-08 22:44:46 +00:00
Brian Wilkerson a50a6c14c0 Add support for experiments to the anaysis options file 
Change-Id: I79e1d50291d4cccc5e1115ae6435bae3808de059
Reviewed-on: https://dart-review.googlesource.com/c/83860
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-08 21:44:28 +00:00
Brian Wilkerson f0f3f445a7 Add a version of getAncestor that matches by type without a closure 
Change-Id: Ib10ab78284466b04b47b6480aded9d3535c79b12
Reviewed-on: https://dart-review.googlesource.com/c/83642
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-08 20:43:57 +00:00
Paul Berry d076571cd9 Merge commit '35c6c79ebc052ab28efcaf045b38ff71c6ed5f3e' into analyzer 2018-11-08 09:32:18 -08:00
Konstantin Shcheglov c450bd6375 Ignore part directives that don't resolve to a file. 
This fixes the issue in the internal repo, when switching resolvers
to AnalysisDriver, where missing parts are code generated, and not
available at the time when the parsed library is requested.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I77abb3b70a726a167d4ecc11849473ec037a281d
Reviewed-on: https://dart-review.googlesource.com/c/83600
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-11-08 17:16:16 +00:00
Dan Rubel 35c6c79ebc Fix parsing getter with prefixed name 
Fix https://github.com/dart-lang/sdk/issues/34610

Change-Id: I7004814af69b35d143779857a6bbd4bb639e257c
Reviewed-on: https://dart-review.googlesource.com/c/83240
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-08 14:31:43 +00:00
Konstantin Shcheglov cb28c1b7f4 Issue 32815. Fix _matchInterfaceSubtypeOf(). 
I applied the proposed fix, seems to work.
Not sure why it was not applied from the start.
Probably because it is our code base, so we have more time for it.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/32815
Change-Id: If046300d02cd520aba6fc054c2a6dbbfce8b62f6
Reviewed-on: https://dart-review.googlesource.com/c/83561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-07 23:19:29 +00:00
Konstantin Shcheglov 3cea05acde Don't report MIXIN_APPLICATION_NO_CONCRETE_SUPER_INVOKED_MEMBER when MIXIN_APPLICATION_NOT_IMPLEMENTED_INTERFACE. 
Not fully the fix for the bug.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35090
Change-Id: Ifdec0f3f839b459b613ed68486c827e7e7442372
Reviewed-on: https://dart-review.googlesource.com/c/83542
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-07 22:29:16 +00:00
Paul Berry b6833e9e6c Remove unused import 
Change-Id: I2589b6da4aaeef136a468ae331792e5f4be08d63
Reviewed-on: https://dart-review.googlesource.com/c/83462
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-07 17:32:33 +00:00
Brian Wilkerson 22408c6dee Remove references to previewDart2 
Change-Id: Id382dd95d3ae90d483467741b5b6d3dbc6c31ea1
Reviewed-on: https://dart-review.googlesource.com/c/83300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-07 14:52:37 +00:00
Konstantin Shcheglov 9af769539c Issue 34387. Don't report an error when a static member is referenced in a documentation comment. 
Also consolidate comment reference resolution tests.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/34387
Change-Id: I3c75c1679c7a880705e6aff9d2f5477eb81a7f11
Reviewed-on: https://dart-review.googlesource.com/c/83223
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-07 00:28:37 +00:00
Konstantin Shcheglov ed03883d76 Issue 35043. Fix type instantiation for implicit new. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/35043
Change-Id: Iaff74f25cb8bb3bfea5412892932dac46157c146
Reviewed-on: https://dart-review.googlesource.com/c/83061
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-06 22:38:28 +00:00
Konstantin Shcheglov d4ebc76d75 Fix AnalysisSessionHelper.getElementDeclaration() for elements in parts. 
Accidentally triggered it while working.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I89113e5b8dc2770acdaabe763c781d89a06b4084
Reviewed-on: https://dart-review.googlesource.com/c/83160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-06 21:28:50 +00:00
Brian Wilkerson e78ed8c3e2 Move canBeConst from InstanceCreationExpressionImpl to LinterContext 
Change-Id: I17a73c040ea15072c3e4f6cb1f2233dc003129ec
Reviewed-on: https://dart-review.googlesource.com/c/82944
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2018-11-06 19:35:11 +00:00
Konstantin Shcheglov 6906ce3964 Issue 33553. Don't report ABSTRACT_SUPER_MEMBER_REFERENCE if the nominal superclass has noSuchMethod(). 
Bug: https://github.com/dart-lang/sdk/issues/33553
Change-Id: I37ef61ed57d5a479771c7e76a78f7f6fcb99e28b
Reviewed-on: https://dart-review.googlesource.com/c/82947
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-06 16:41:37 +00:00
Konstantin Shcheglov 3166d6bf25 Replace ResolvedUnitCache with AnalysisSessionHelper. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ie19de8feaf82e97065d1068d0c1a06bdf3654e1d
Reviewed-on: https://dart-review.googlesource.com/c/82940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-05 20:49:44 +00:00
Paul Berry 97a51b2af2 Revert "Import path as p, in Workspace impl libraries" 
This reverts commit feba863557.

Reason for revert: for now, we want this change on the analyzer branch only.

Original change's description:
> Import path as p, in Workspace impl libraries
> 
> In package_build.dart, there are several spots (builtFile(),
> builtPackageSourcePath(), ...) where `context` is called, in cases
> where I imagine the author thought there was a class member at hand
> (as is the case with PackageBuildPackageUriResolver), but these
> locations are actually using the top-level const `context` from the
> path package.
> 
> I think it is super confusing to have class members, and local
> variables, that shadow an imported top-level const. Better to import
> with a prefix.
> 
> Additionally, I unified relative/absolute checking in these files as
> assert() calls, with helpful messages.
> 
> Change-Id: I6d409636dab41959cabf392c80f64c4ec5270f7b
> Reviewed-on: https://dart-review.googlesource.com/c/82560
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com,srawlins@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I03ee1a3d3f358f8a7ac6ddad5f1b3a2e5991468f
Reviewed-on: https://dart-review.googlesource.com/c/82900
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2018-11-05 17:59:20 +00:00
Paul Berry b1cbfab274 Merge commit '9a1a7763f150e92e39a05519be47e581584c5de9' into analyzer 2018-11-05 04:01:07 -08:00
Brian Wilkerson 30f1c7cbab Remove references to analyzer/analyzer.dart 
Change-Id: I3b3affa957ed8cc8c66f2b32c45b7dcd820f9b1e
Reviewed-on: https://dart-review.googlesource.com/c/82713
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-03 00:19:22 +00:00
Konstantin Shcheglov 3f431de188 Implement AnalysisSessionHelper.getElementDeclaration() using AnalysisSession. 
Also adds parsedUnit / resolvedUnit to ElementDeclarationResult, because
Analysis Server use case shows that we need them.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I845e85f658bec8fdaf3378f879e3d986a0bc01eb
Reviewed-on: https://dart-review.googlesource.com/c/82712
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-11-02 22:52:49 +00:00
Konstantin Shcheglov b71948faee Consolidate MockSdk(s) into one, living in analyzer/lib/src/test_utilities. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I70946b8e6f790608ad52c8f27cd6f506673f7b0d
Reviewed-on: https://dart-review.googlesource.com/c/82710
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-11-02 21:52:44 +00:00