fd2225ab6c
Adapt to the flow analysis spec v2.
...
R=paulberry@google.com
Change-Id: I42ad94079233516007bec6285088d3d8245a4edd
Reviewed-on: https://dart-review.googlesource.com/c/92160
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-02-06 20:11:12 +00:00
ae5bd68570
Lower relevance of deprecated suggestion sets.
...
R=brianwilkerson@google.com
Change-Id: I3b10c74d815c69f120238a6fd5028ae534fc7446
Reviewed-on: https://dart-review.googlesource.com/c/92142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-06 19:38:30 +00:00
adfa4791fc
Improve storage for available declarations.
...
1. Getters and setters.
2. Parameters.
3. Restore null where should when reading from flatbuffers.
R=brianwilkerson@google.com
Change-Id: I934e828ced6ae21c1c633c2a94e3336078eb2747
Reviewed-on: https://dart-review.googlesource.com/c/92084
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-06 17:35:45 +00:00
661e91e30e
Extract and migrate tests for ConstantEvaluator.
...
R=brianwilkerson@google.com
Change-Id: Ia637dbe78a710678153cfc74726bf4825e36f755
Reviewed-on: https://dart-review.googlesource.com/c/92080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-06 16:54:35 +00:00
cc74e20eee
Make some fields on Interface private, and change the way InheritanceManager2 is tested.
...
R=brianwilkerson@google.com
Change-Id: I960e512fa7d91fc64e66595419a1fbd358d68e2f
Reviewed-on: https://dart-review.googlesource.com/c/92065
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-06 16:52:50 +00:00
1c0422735e
Abstract type operations in flow analysis.
...
R=paulberry@google.com
Change-Id: I2dad238e7a49317951bd011095645341cf3b2bb4
Reviewed-on: https://dart-review.googlesource.com/c/92026
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-06 15:37:48 +00:00
efcf8b01b1
Move integration tests of migration API to analysis server.
...
Change-Id: I7109df482f17be884a31313e18e1b4cf57b1ad4c
Reviewed-on: https://dart-review.googlesource.com/c/92140
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-02-06 15:37:18 +00:00
631c550ff9
Extract and migrate ExitDetector and its tests.
...
R=brianwilkerson@google.com
Change-Id: I4d3699ffab56d85240809fe50b36c1593e4e19d2
Reviewed-on: https://dart-review.googlesource.com/c/92027
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-06 01:54:55 +00:00
c26bf54391
Add InheritanceManager2 APIs to access inherited interface/class maps.
...
I'm not particularly attached to the names of new methods.
So, if you have better ideas, please tell me.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/35833
Change-Id: Ibe906c7f779c7606ca3093fd27203fc7c77392b0
Reviewed-on: https://dart-review.googlesource.com/c/91847
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-05 22:15:05 +00:00
b5eb7d463e
Extract and migrate ErrorReporter tests.
...
R=brianwilkerson@google.com
Change-Id: I5fd12bdd3dc6bacbec61ad9b722a0016cbde2229
Reviewed-on: https://dart-review.googlesource.com/c/92024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-05 19:16:15 +00:00
3395550962
Provisional nullability migration API in analysis_server.
...
Limitations at this point:
- Only one file can be migrated at a time. If you try to migrate more
than one file, you will get an assertion failure.
- The ResolvedUnitResult passed to prepareInput must contain precisely
the same unit (in terms of `identical`) as the ResoledUnitResult
passed to processInput. Otherwise you will get an assertion
failure.
- There is not yet any way to query diagnostic information about the
migration (e.g. heuristic decisions that were made).
- Only a very small number of constructs can be successfully migrated
at this point.
- The implementation is not sensibly organized at this point. Most of
it is in the analyzer, and then wrapped in the analysis_server.
Really it all should go in the analysis_server.
I'll be working to rectify these limitations over the next few days,
which will probably involve a lot of rework under the hood. But
hopefully the API in provisional_api.dart should remain stable, so
that DartFix code can start being written against it.
Change-Id: Idc3ebab380448a812d5e83338789570e33c55af7
Reviewed-on: https://dart-review.googlesource.com/c/92020
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
2019-02-05 16:30:35 +00:00
3c1ffd23ba
remove unneeded override
...
Change-Id: Ic930f17a44471b724aaa0389278a899877f6ef69
Reviewed-on: https://dart-review.googlesource.com/c/91963
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-02-05 13:15:15 +00:00
1f638607c2
Rework the ConstraintVariable.or constructor.
...
The constructor now records constraints to make sure that the newly
created constraint variable is consistent with the variables that it
is formed from.
Change-Id: I928ff41aaab1b849905b7c8d622049fdd73cdd3e
Reviewed-on: https://dart-review.googlesource.com/c/91948
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-02-05 00:24:32 +00:00
35ab1755f4
Support more type propagation for code-as-ui features
...
Change-Id: I9f7d93387653cc279dc657e689764d19a6d31858
Reviewed-on: https://dart-review.googlesource.com/c/91766
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-02-04 21:55:21 +00:00
cda43dabda
Use findNode.simple in migration test
...
Change-Id: Ia61bb5a255f18086c3f42ed68c83910fb7ed4698
Reviewed-on: https://dart-review.googlesource.com/c/91946
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-02-04 19:57:19 +00:00
f89acfa374
Issue 35621. Part files should use their own transitive signatures.
...
Previously we had a bug, when a library linked summary was computed,
and then a part of this library is incorrectly imported as a library,
the implementation of `transitiveSignature` was returning the
signature of the containing library, so we would use the linked library
of the actual library, but the unlinked summary of the part file.
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/35621
Change-Id: If225136de4e6576f0499d2318a67c721d80d17ae
Reviewed-on: https://dart-review.googlesource.com/c/91855
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-03 19:05:26 +00:00
849285276d
Extract and migrate ElementLocator tests.
...
R=brianwilkerson@google.com
Change-Id: I10914580c96daee9bae8794db477c6413a089c09
Reviewed-on: https://dart-review.googlesource.com/c/91850
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-02-03 17:26:46 +00:00
d45a6ec893
Split Variables class into two interface classes and create DecoratedType.forElement constructor.
...
The two interface classes make it clearer which methods are intended
to be used by ConstraintGatherer vs. ConstraintVariableGatherer, and
refactoring DecoratedType.forElement paves the way for a future CL
that will handle constraints on inferred types.
Change-Id: Ibd2f22ea9d38df7be1c4da0e4eef2006556b7351
Reviewed-on: https://dart-review.googlesource.com/c/91851
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-02-03 02:35:16 +00:00
b9c89c9fb5
More test cases for the migration prototype.
...
Change-Id: If6cd64ae89ebb76a98160dc60d981c7db7ae82a6
Reviewed-on: https://dart-review.googlesource.com/c/91852
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-02-03 02:31:56 +00:00
a6e7361fa8
Add documentation comments to the migration prototype.
...
Change-Id: Ifad776cadfe9a2abc485c6ab251cdee08671d9ef
Reviewed-on: https://dart-review.googlesource.com/c/91848
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-02-02 23:21:16 +00:00
67ff7a6ef3
Remove unused import
...
Change-Id: Ib75766f76a6b6f57b9490d03fac0006da718f68f
Reviewed-on: https://dart-review.googlesource.com/c/91849
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-02-02 23:10:55 +00:00
a9c84ab887
Verify nullability of dynamic in DecoratedType constructor.
...
This required some clean-up of how the `always` constraint is handled.
Change-Id: I9c1124bf0d41b58b771eb46ee74a52659e0b5b52
Reviewed-on: https://dart-review.googlesource.com/c/91843
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
2019-02-02 21:54:56 +00:00
eaeffd2695
Rename ConstraintsTest to match the class it's testing
...
Change-Id: I5a9e3d4b098d53efd65201899d1bd6a07be05332
Reviewed-on: https://dart-review.googlesource.com/c/91845
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-02-02 20:36:06 +00:00
509ac0648c
Update non-nullability migration algorithm to handle missing types
...
Change-Id: Ia2bcf923be0cfd1c7e94112e6516a10d13d5a4ca
Reviewed-on: https://dart-review.googlesource.com/c/91861
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-02-01 20:59:41 +00:00
3802a6d7eb
Experimental prototype of a non-nullability migration algorithm.
...
Change-Id: Idda9b596d612953f4f370f220729f419b1f673e1
Reviewed-on: https://dart-review.googlesource.com/c/91380
Auto-Submit: Paul Berry <paulberry@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-02-01 17:55:37 +00:00
931051814c
Partial implementation of the 'available suggestion sets' protocol.
...
R=brianwilkerson@google.com
Change-Id: I856b6a39c2464caf6750e0b0abb0cfa29311e97c
Reviewed-on: https://dart-review.googlesource.com/c/91769
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-02-01 17:55:27 +00:00
e5164be27e
Issue 35127. Fixes for mixin implements / overrides.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/35127
Change-Id: I5869175cee13b6e22ce25c2d361b0b1aa52efe48
Reviewed-on: https://dart-review.googlesource.com/c/91690
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 16:01:55 +00:00
c31627b778
Remove the unused TypeOverrideManager
...
Change-Id: I031c2777e6b9d5cfd46bc0bc1978dfde95a316b7
Reviewed-on: https://dart-review.googlesource.com/c/91692
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 15:19:05 +00:00
8f12035f36
Clean up the diagnostic tests
...
Change-Id: I0c9e962246d4c83036f91ba49b0a28dd9d1c3c4b
Reviewed-on: https://dart-review.googlesource.com/c/91688
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-31 14:57:05 +00:00
b8fc017778
Replace convertAbsolutePathToUri() with toUriStr().
...
Change-Id: Ib34247ce7457ada7e4705714984034387f09a80c
Reviewed-on: https://dart-review.googlesource.com/c/91684
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-30 20:47:56 +00:00
f903ee6dc0
Don't crash on formal parameters without name, exclude private SDK lbiraries.
...
R=brianwilkerson@google.com
Change-Id: Ie5d72458c6d19fb250591550d47c4076082dff1e
Reviewed-on: https://dart-review.googlesource.com/c/91683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-30 19:48:28 +00:00
bc2a5a6789
Generate some of the code-as-ui diagnostics; implement more resolution
...
Change-Id: I6d5ac14d5b6cb601d6d968a8140bc63435519230
Reviewed-on: https://dart-review.googlesource.com/c/91586
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-30 16:40:46 +00:00
e8a0a209e3
Include into Declaration data that we will need for pre-cached suggestions.
...
R=brianwilkerson@google.com
Change-Id: Ie4419e785c06fa7b3913359e5831e97c611f46a7
Reviewed-on: https://dart-review.googlesource.com/c/91587
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-30 16:31:34 +00:00
b196cd2acb
Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
...
Downgrade INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED and INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL to warnings.
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I4399839e04135a5d9a557c0ab06f319d9759af23
Reviewed-on: https://dart-review.googlesource.com/c/91460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 22:35:15 +00:00
25d8456c48
Small improvements for DeclarationsTracker.
...
R=brianwilkerson@google.com
Change-Id: Ic35e7cead9a50b9eb8ae590f9fbf85df0a8f7fc1
Reviewed-on: https://dart-review.googlesource.com/c/91583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-29 22:33:34 +00:00
081160036a
Fix #35306 , improper recursion detection.
...
Bug: 35306
Change-Id: I28f7a298ebf701f9709cb3f49eff07da4cf01fd4
Reviewed-on: https://dart-review.googlesource.com/c/90880
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-01-29 21:28:49 +00:00
09e6a689c2
parse nested control flow collection entries
...
Change-Id: Id50c0a53a51f076dd75dd5bc13a694663449bc83
Reviewed-on: https://dart-review.googlesource.com/c/91400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 17:53:58 +00:00
213cfdc85e
Update AstBuilder to generate new for statement structure
...
... if control flow or spread collection entries are enabled.
Change-Id: I8718c1f7a649b7a2a7c9e376a6bf67c1df0542cf
Reviewed-on: https://dart-review.googlesource.com/c/91320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 17:53:58 +00:00
93a56336a3
Parse simple for control flow collection entires
...
... and address comments in:
https://dart-review.googlesource.com/c/sdk/+/91144
https://dart-review.googlesource.com/c/sdk/+/90901
Change-Id: I7a9288bf28e069832193bd8a196a11f9a407b20d
Reviewed-on: https://dart-review.googlesource.com/c/91300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-29 17:53:58 +00:00
c5a954794b
Fix PackageBuildWorkspacePackage's contains
...
This implementation did not check whether the path was actually contained
in the package:build workspace. It also made an assumption about how a
resource which is a directory would be treated, which was masked by an
unconditional-and-silenced catch.
The existing test which should have caught this had a hidden exception,
caught by the same unconditional-and-silenced catch. :(
Bug: https://github.com/dart-lang/linter/issues/1393
Change-Id: I0a6ecb584e06877463a47681830eed8f6f914030
Reviewed-on: https://dart-review.googlesource.com/c/91441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-01-29 02:01:51 +00:00
1ba59eb13d
Make ERROR the default severity for StaticWarningCode. Remove _StrongModeTypeErrorProcessor.
...
As a preparatory step for re-landing https://dart-review.googlesource.com/c/sdk/+/91170
and making these two restored problems to warnings.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I6266632ade84743b5725c54475fe402902576c00
Reviewed-on: https://dart-review.googlesource.com/c/91420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 22:08:17 +00:00
95b017a888
Implement changeFile() and recompute available libraries and declarations.
...
Some renames in tests.
R=brianwilkerson@google.com
Change-Id: Ia54752c816bbc62f99a200d62658b6f4dfb26480
Reviewed-on: https://dart-review.googlesource.com/c/91381
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-28 18:05:17 +00:00
ec5ba8a252
Revert "Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden."
...
This reverts commit 6699384dddhttps://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8923238548150736816/+/steps/analyze_flutter/0/stdout
Original change's description:
> Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
>
> R=brianwilkerson@google.com , paulberry@google.com
>
> Bug: https://github.com/dart-lang/sdk/issues/34437
> Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
> Reviewed-on: https://dart-review.googlesource.com/c/91170
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
TBR=paulberry@google.com ,scheglov@google.com ,brianwilkerson@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: I07c96c8131c16b2748a403f38d5f15b814131c63
Reviewed-on: https://dart-review.googlesource.com/c/91360
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 17:09:24 +00:00
7daa9f65fc
Start supporting resolution of the code-as-ui constructs
...
Change-Id: I8fba9bfcac2339b113de6bc2954821585e7b8ab4
Reviewed-on: https://dart-review.googlesource.com/c/91240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-28 15:12:47 +00:00
d927333c52
Add all SDK libraries, and context files belonging to the package / potions of it.
...
R=brianwilkerson@google.com
Change-Id: I7e5d6cc12657c92f16d65e89f4b60eacf16c51b6
Reviewed-on: https://dart-review.googlesource.com/c/91260
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-27 22:33:04 +00:00
6699384ddd
Issue 34437. Restore checking that optional parameters in derived classes should have the same default values as overridden.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/34437
Change-Id: Ic54d2e074bc764376f970c9c29ba260e7a373d93
Reviewed-on: https://dart-review.googlesource.com/c/91170
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-01-26 20:12:55 +00:00
2f3ebf70f6
Update definite assignment for the code-as-ui changes
...
Change-Id: Id425fd6eb76402118738da13275224ae2d1905aa
Reviewed-on: https://dart-review.googlesource.com/c/91168
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-25 22:28:05 +00:00
fe285e3e60
Update flow analysis for the code-as-ui changes
...
Change-Id: I2bf9ea0beda6bc95556d0e1e75183779433f990f
Reviewed-on: https://dart-review.googlesource.com/c/91169
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-01-25 22:27:54 +00:00
6fae43b8af
Check exact type for set literals (issue 35742)
...
Change-Id: Icce758b13536171dd20201e52ecae8ecda39a336
Reviewed-on: https://dart-review.googlesource.com/c/91166
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-01-25 21:09:42 +00:00
eadf9679f3
Fix #35750 by passing a real ContextBuilder to createWorkspace.
...
The PackageBuildWorkspace depends on its ContextBuilder to know if a
[findFile] should return null.
Bug: https://github.com/dart-lang/sdk/issues/35750
Change-Id: Ic562314fa87d1333e8f07efbb06a461be769ea32
Reviewed-on: https://dart-review.googlesource.com/c/91161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-01-25 21:07:03 +00:00
Konstantin Shcheglov