1682b4aac5
replace parser language version comment processing
...
This CL removes duplicate language version processing from parser
now that the scanner does this work.
In addition...
- update parser tests to listen for languageVersion scanner event
- remove languageVersion field from CompilationUnitImpl and AstBuilder
- add Scanner.buildConfig for translating a FeatureSet into a ScannerConfiguration
- remove old language version parser tests
- cleanup parser nnbd tests
Change-Id: I6ead6a3ab6d5d424e9a7dfbf69da110e43c63982
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100990
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-05-02 00:55:43 +00:00
143ebf1c1c
Compute default types for type parameters of GenericTypeAlias.
...
R=brianwilkerson@google.com
Change-Id: Ifbfa8e240b078285660b80fbb02914bc6666b753
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100985
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-01 20:06:39 +00:00
a7c0a75442
Disable DeclarationResolver tests with summary2.
...
R=brianwilkerson@google.com
Change-Id: I83ad273ba2a0862e659f407f5749e7ae11b507c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-01 20:06:05 +00:00
52608e3174
Convert more tests to DriverResolutionTest
...
Change-Id: Ib1c3018362f868626d788bc63ba33e5fe5900d8b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-05-01 17:02:19 +00:00
49dfd6f4df
Build elements for constructor initializers.
...
R=brianwilkerson@google.com
Change-Id: Ic41e6ec93571f0407184f8b8e8271517e1e1ec59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-05-01 16:22:39 +00:00
f66ef921ac
Write and read comment references.
...
R=brianwilkerson@google.com
Change-Id: If7d0e97ec98cc7ee2a5ac1c664cb296762911a69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100930
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-01 14:38:38 +00:00
b6997deb3e
Resolve typed constant initializers separately.
...
R=brianwilkerson@google.com
Change-Id: Id54b57a40004de0c9adc345e1f944fc89b568e68
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100929
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-05-01 14:19:20 +00:00
481d6b9f30
Fix the windows bots
...
Change-Id: Ia3f796a174c03912975b37fb9904eea0a05f04c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100926
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-30 22:53:22 +00:00
a30819a2f6
Add a diagnostic associated with the default List constructor
...
Change-Id: I41ba3e34c2f209c27bf83015feed0a2ce7918ea0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100789
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-30 22:24:02 +00:00
7cb1365f7f
replace individual scanner flags with scanner configuration
...
Change-Id: I3d4522a8bcabcbc139de09e08d44baf2eeae4a59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100882
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-30 21:29:02 +00:00
a20e7eee15
update scanner config based on language comment
...
... and add ScannerConfiguration.nonNullable const
Change-Id: I6917c535e40e94cb591f2c4f5582dc0127be17f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100884
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-30 21:28:02 +00:00
de1966db11
Separately handle InterfaceType and FunctionType while collecting free type parameters.
...
FuntionType(s) with summary2 are not Element + typeArguments,
they are just types.
R=brianwilkerson@google.com
Change-Id: I52887e6b31cd4e2f9749ff67943159f3c93722fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100888
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-30 20:59:52 +00:00
5152269d28
Convert another test class from ResolverTestCase to DriverResolutionTest
...
Change-Id: I621f55712f19be3b0d7ff4aadf1420f55d2ef53c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100824
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-30 17:21:01 +00:00
25daff618d
Support for 'late' keyword.
...
R=brianwilkerson@google.com
Change-Id: Ia731b56ab67d0d33af9a8ab4786d9204544a57ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-30 16:58:44 +00:00
ea708965ab
Find type alias self-references during linking.
...
Elements are not available for FunctionType(s), and during linking
we have the whole library cycle, so can compute self-references.
R=brianwilkerson@google.com
Change-Id: I2e145c4efae77ac5dbff2782f4b3590339187c0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100796
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-30 14:41:58 +00:00
156de21785
Adapt OptionalConstMixin to summary2.
...
R=brianwilkerson@google.com
Change-Id: I0648413fb4494e912c328c135677735b4faabbbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100821
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-30 14:20:03 +00:00
ca3d908719
With issue 36262 fixed, remove the workaround.
...
R=brianwilkerson@google.com
Change-Id: Id2f4c8f539290013aab2dc5afe7a8551eaa5a72e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100797
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-30 14:11:58 +00:00
532226f024
The library is synthetic when its defining unit is synthetic.
...
R=brianwilkerson@google.com
Change-Id: I9afbea2214e07f968deb74b490a27090766f8823
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100794
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-30 00:21:27 +00:00
c944328528
Refactor types resolution, compute default types for type parameters.
...
R=brianwilkerson@google.com
Change-Id: If8b89c611c10c0026ec40773aed2a38a5fb37b23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100787
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-29 21:44:05 +00:00
950e174799
It is not an error for a late final variable to not have an initializer in nnbd
...
Change-Id: I11a8367b6e5f3f57b2e78165d59f5114a2b89de3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100784
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-29 20:54:18 +00:00
9b3567a466
Rename poorly named error code and improve the message
...
Change-Id: I9b71b400cb597bc03abe837722dbff8be18465de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100783
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-29 19:07:59 +00:00
49573f59d3
cleanup analyzer warnings
...
Change-Id: Ieb2fd5e64efe7dbd7da70b4ee2f723d0fd5243ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-29 17:50:26 +00:00
e2d0f5a50b
Add featureSet parameter to Parser constructor.
...
And deprecate old parser configuration setters.
Change-Id: Ib1507b8d2b20be7c883061e2a92ec9205d6a378f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100664
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-29 16:42:19 +00:00
37f915543f
Introduce AstFactory.compilationUnit2 with a required featureSet argument.
...
Change-Id: I8d709fcb9be1b3a89e617a0c7b35f47813787f06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99966
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-29 15:44:39 +00:00
f598581e41
Support for type parameters in function typed formal parameters.
...
See also https://github.com/dart-lang/sdk/issues/28515
R=brianwilkerson@google.com
Change-Id: I4365a159a969b5cb77b755a9dad8602a9992ab7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-27 18:05:16 +00:00
d816a46806
Convert MixinDriverResolutionTest to subclass DriverResolutionTest
...
Change-Id: Ia538b7fe0df7aa0f0c26834dab60415ed07211d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100681
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-27 17:05:06 +00:00
c3669f787e
Add a diagnostic for missing arguments associated with required named parameters
...
Change-Id: I78a46a41ae1c361da0995bb851414e19ef375477
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100632
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-26 22:53:44 +00:00
986978ad8e
Additional FeatureSet plumbing for parser_fasta_test.dart
...
Change-Id: I6d0ff3f1b4a342717fd809f828db75401f9f0337
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100442
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-26 20:16:45 +00:00
0dc33da6e8
Add LinterContext.canBeConstConstructor().
...
So, the linter rule does not need to do its own hacks of AST.
R=brianwilkerson@google.com , pquitslund@google.com
Bug: https://github.com/dart-lang/linter/issues/1537
Change-Id: Id8d56c0abe077b439d4d67f7dc74b36c08acdf88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100277
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-26 19:27:15 +00:00
c6cc447e98
Convert StaticWarningCodeTest to use DriverResolutionTest
...
Change-Id: I2e5f282d79e7048984edbcd866ac4a8312e82b5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100626
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-26 18:18:35 +00:00
05d33b1240
Add WorkspacePackage support for InSummarySource sources
...
An alternative fix to https://dart-review.googlesource.com/c/sdk/+/94356
In this case, `library.source.fullName` results in a String representation
of a library's package: URI. :(
To accomplish this, each *Workspace's contains() method is refactored from
taking a `String path` to taking a `Source source`, so as to use package: URIs
as much as possible, avoiding looking at the filesystem and poking around for
Workspace markers (BUILD, BUILD.gn, WORKSPACE, .jiri-root, etc). This avoids
the issue with InSummarySource sources, which have a non-path `.fullName`, but
have a valid `.uri`.
These issues were found when trying to enforce @sealed internally.
Change-Id: Ia46f28aa7aad0fc4483a180fa47f1e509402da6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/94985
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-25 16:08:43 +00:00
4da31564cb
Fix the placement of late in two tests
...
Change-Id: I94e978a453441aeceac72e14873c9e7e895e5c32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100466
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-25 13:24:31 +00:00
f04cac8fbd
Implement inheritsCovariant.
...
R=brianwilkerson@google.com
Change-Id: Ieedcec9e51ad7c3e1087d114522b577998181c1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100407
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-24 20:29:05 +00:00
2cadc90ec5
Add summary support for isLate
...
Change-Id: I21fe14778e24477f234e2a1a1fe65a23ebd05e7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100274
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-24 20:23:45 +00:00
91e9962699
Don't report libraries that became parts as changed libraries.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/36725
Change-Id: Idea33b07e513147930d1a41a3b3c8718066ce817
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100461
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-04-24 19:24:15 +00:00
9a03c94d36
Clean up ParseBase's use of AnalysisOptions.experimentStatus
...
Change-Id: I83162b23f62f682ff1148ca62efb092bf7ae3dbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-24 18:07:05 +00:00
c5e57cc078
Plumb FeatureSet through resolver
...
Change-Id: I796b09469c2167122f535718e5ffacb1dc4dd012
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-24 17:21:37 +00:00
296505e2e3
Sort declarations in pkg/analyzer/test/generated/parser_test.dart
...
Change-Id: Iee4ae779ddc94c0022ff04273bb54b84d2ec0eb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100403
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-24 17:18:32 +00:00
ed984b6985
Sort declarations in pkg/analyzer/test/dart/ast/ast_test.dart
...
Change-Id: I6710fdfa4ae7a5ca9912d8d73b61a7951a371247
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100402
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-24 17:11:56 +00:00
e42c5d12fe
Cleanup tests by removing references to enabled experiments and by reducing duplication
...
Change-Id: Ic7eb96e1724d2a51469e41760856d4194e3379e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-04-24 13:20:36 +00:00
9af0574287
Remove unused import
...
Change-Id: I6fc0c75afc22b31e101631dac366b58a2f2ba8a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100285
Commit-Queue: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-24 01:17:15 +00:00
4624419736
Support UI-as-code in deprecated parse functions.
...
Fixes #36724 .
Change-Id: Iff8277c0e08b11ec815426b1940767076f4141ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100278
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-23 23:19:25 +00:00
594a0ef7a7
Perform instantiateToBounds() even for not simply bounded types.
...
Apparently my previous understanding was wrong.
R=brianwilkerson@google.com
Change-Id: I17ccce93d8e6b8744eaf05c80782ae4f1fe4a414
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100090
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-23 17:39:08 +00:00
b4d17f2eee
Add diagnostics related to default values
...
Change-Id: I4b30580e34fbf302a53778010fada54a2e100409
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99887
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-04-23 17:16:50 +00:00
cee1e41fe8
Plumb new FeatureSet class into Scanner.
...
And change clients of the scanner (within the SDK) to use it.
Long term, it would be better to store the FeatureSet object directly
in the Scanner and remove the existing flags `enableGtGt` and
`enableNonNullable`. However there are analyzer clients that
currently use these flags. So for now, we simply plumb in the
FeatureSet as a new way of setting AstBuilder flags. Once we've
updated clients to use FeatureSet, we'll publish a breaking version of
the analyzer that removes the old flag API.
Change-Id: I9e662f4ed45668d9acd4f56e42d7d8dae6180d48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99975
Reviewed-by: Dan Rubel <danrubel@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-04-23 16:13:43 +00:00
81b028de78
cleanup some error codes
...
* replace CovariantAfterFinal with ModifierOutOfOrder
* replace ConstAndCovariant with ConflictingModifiers
Change-Id: If09551a28d4bffecaf009b4e836a67dfc939c0bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-23 14:22:12 +00:00
1f1592edce
Add manifest checks for touchscreen feature
...
Change-Id: Ib849eccdbad6f41e22dbffeca755099cb3926f8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100160
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-23 00:32:54 +00:00
80bed430c8
Extract AnalysisDriver tests that work with summary1 into a separate test class.
...
R=brianwilkerson@google.com
Change-Id: I4c078d189b3c1bd7c0da3cfbe87490c2cedbc40f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99976
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-04-22 21:39:09 +00:00
8b6d04b2ee
sort tests
...
Change-Id: I598ea625cc7dce757906f2f7fbef0c5d186ee462
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99969
Commit-Queue: Paul Berry <paulberry@google.com >
Auto-Submit: Dan Rubel <danrubel@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-04-22 20:54:23 +00:00
ec79fc2ff4
update AstBuilder to process "late" modifier
...
Change-Id: I97530583b059a39d502469079940ffc5b8d4db71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-04-22 19:34:33 +00:00
danrubel