dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

7128 Commits

Author SHA1 Message Date
Konstantin Shcheglov 396fec7cfb Use DriverResolutionTest directly, without ResolutionTest mixins. 
Change-Id: I1c894e726a7645a94266ac9d62bc48c8fca7330b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118100
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-19 17:07:30 +00:00
danrubel 000de948fa add test for 38091 
Fixed by earlier parser recovery improvement.

Fix https://github.com/dart-lang/sdk/issues/38091

Change-Id: I9fa4c3870965c1f03bae9f11da6eaf1e65bfabf9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115904
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-09-19 16:56:50 +00:00
Konstantin Shcheglov f7472249a2 Remove EnumMemberBuilder. 
R=paulberry@google.com

Change-Id: If92fc95598cc2530b882d270efb97664fce4176a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117983
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-19 16:08:16 +00:00
Konstantin Shcheglov 4102e63f37 Deprecate TypeProvider.listType/mapType 
R=brianwilkerson@google.com

Change-Id: I7cef0b752be4ef6a7e4bc5394e14cd64ecb67ab5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117765
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-18 17:55:03 +00:00
Sam Rawlins f1afb34924 Move strict-raw-type tests; add tests for extensions 
Bug: https://github.com/dart-lang/sdk/issues/38105
Change-Id: I50794f6c4fdfe6852b06adacb24a0620bd44b2f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117642
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-18 17:54:43 +00:00
Konstantin Shcheglov 4fcef04d61 Deprecate TypeProvider.iterableType/streamType 
R=paulberry@google.com

Change-Id: Iab8038cf0ed413de7c05da4f69015c1d1309aa35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117684
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-18 17:29:58 +00:00
Konstantin Shcheglov d4f1b8f8db Deprecate TypeProvider.futureType/futureOrType 
R=paulberry@google.com

Change-Id: Idde7d82b217b5921c0770d9b69f6934a1e1fc493
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117682
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-18 15:37:21 +00:00
Brian Wilkerson 546440074a Stop reporting diagnostics on synthetic identifiers (issue 38448) 
Change-Id: Ief9b77a48526454db430bc131d3c1dbd04234dc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117761
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-18 15:36:41 +00:00
Konstantin Shcheglov 12c1b43365 Substitute bounds of fresh type parameters using all fresh type parameters. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/38365
Change-Id: I7603126bb7a5578b9ce2c74a7b130a591be0d4b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117640
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-18 00:21:16 +00:00
Konstantin Shcheglov 1a812bb6bb Deprecate TypeProvider.setType 
R=brianwilkerson@google.com

Change-Id: I522066c919b5eef9640243c8b08435756d9481f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117597
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-18 00:20:46 +00:00
Brian Wilkerson f342d07b0d Report an error if an extension override is used in a cascade (issue 38417) 
Change-Id: I578d0b9663f4bc85a9b3d9726457682953809a72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117461
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-17 19:13:31 +00:00
Konstantin Shcheglov 4adbc8f1e6 Use single TypeSystem.inferGenericFunctionOrType(), avoid using full generic DartType. 
Use instead separate components - return type, parameters.

R=brianwilkerson@google.com

Change-Id: Ie6728383683a507d5abcebe7766b7e3bf2216ed9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-17 15:56:52 +00:00
Brian Wilkerson 114fdbc50b Fix the messages associated with the invalid_override diagnostic 
Change-Id: I3d5fe5f3aee6eab6ab538fa795a6d511132a2454
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117284
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-16 22:25:41 +00:00
Sam Rawlins eb208b1074 Move inference-failure-on-collection-literal tests 
Change-Id: I10143d9deab89f5c3c5e8365ae5d99ca5b1c9094
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117293
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-16 22:25:02 +00:00
Konstantin Shcheglov 6a9d792454 Move NullabilitySuffix to API. 
R=brianwilkerson@google.com

Change-Id: I58547075d3472e6708e6b5ff1c6d89f768aba66a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-16 21:14:11 +00:00
Sam Rawlins 90b44e77d8 Report strict-inference issues with function return types 
Change-Id: I249a3a7b2b6698c784b1fea67679b0b810414161
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117201
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-16 20:43:41 +00:00
Konstantin Shcheglov 405ff47ebe Add ClassElement.isDartCoreObject, use instead of 'classElement.type.isObject'. 
R=brianwilkerson@google.com

Change-Id: I1354e111debca5145f6fc54959c391e65a21cf05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117298
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-16 19:57:42 +00:00
Konstantin Shcheglov f470695875 Stop using ClassElement/TypeParameterElement.type in tests. 
There are 4 references to `type` left in tests, because it looks
that these tests validate peculiarities of the `type` getter itself.
I will remove them later, when the production code is off `type`.

R=brianwilkerson@google.com

Change-Id: I4b8a590e561fe3d3103500b097c13d989514976e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-16 15:53:29 +00:00
Mike Fairhurst 330fccbc0d Implement extension override in summary2 
Change-Id: I0c7028eaa53ae070d521cda86a885435e4345089
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117124
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-09-13 21:23:03 +00:00
Konstantin Shcheglov 08518a6d5e Stop using ClassElement.type and InterfacecType.instantiate in TypeSystem tests. 
R=brianwilkerson@google.com

Change-Id: If455bac28edae6d37b418f956ec862211b763495
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117167
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-13 21:09:53 +00:00
Sam Rawlins d53086e005 Fix strict-inference failure on ctor call to allow upwards dynamic 
The tests highlight the change:

    class C<T> {
      C([T t]);
    }

    // This used to be a strict-inference failure, but is no longer.
    var upwardsInfersDynamic = C(42 as dynamic);

Additionally, strict-inference no longer takes @optionalTypeArgs into account.

strict-inference spec: https://github.com/dart-lang/language/blob/master/resources/type-system/strict-inference.md

Bug: https://github.com/dart-lang/sdk/issues/33749
Change-Id: Iac07d9d15ce2146108753cae25890a559288a318
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111740
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-13 20:34:19 +00:00
Konstantin Shcheglov daa22105fd More clean up for TypeSystem tests. 
R=brianwilkerson@google.com

Change-Id: I269af4969d855610c6b94c3752278d968118748d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117123
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-13 15:56:22 +00:00
Sam Rawlins 3129ad9585 Only report a non-const initializer for const variables; fixes #35985 
Bug: https://github.com/dart-lang/sdk/issues/35985
Change-Id: Iec21a08db57580af910be5a655bd439ecab15123
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-13 15:39:52 +00:00
Konstantin Shcheglov c138b505be Update TypeSystem tests to reuse AbstractTypeSystemTest. 
R=brianwilkerson@google.com

Change-Id: Ic6e446cf124a52c8663140a995d4a58c3e4c92a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117015
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-12 23:18:07 +00:00
Mike Fairhurst 5beca80bc7 [analyzer] add isNullAware to IndexExpression 
Change-Id: I3c3b1b0a38ea81fd573ec005e810eb2b000b3430
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-09-12 21:31:57 +00:00
Mike Fairhurst 2bc48ad1b6 [analyzer] add isNullAware to propertyAccess 
Change-Id: Ia785a308e7281d6d17d05b38d52337f611708206
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116685
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-12 21:29:27 +00:00
Mike Fairhurst 68bcc00d10 [analyzer] implement isNullAware for method invocations 
Change-Id: I630f94311a55b7a7fce5e47143e333abffe19c9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116681
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-12 21:21:22 +00:00
Konstantin Shcheglov fc2f744d9e Deprecate 'Source.encoding'. 
R=brianwilkerson@google.com

Change-Id: I1a97c9b5a1401a16044df4e37117b2ec7e4e5db2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-12 16:48:16 +00:00
Brian Wilkerson c74e68e501 Add documentation for more diagnostics 
Change-Id: Id2aeb13db0ceb81fc18d67e6ef2778304b36d02b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-09-12 16:35:46 +00:00
danrubel 3b1d3de988 update parser to report out of order "?.." operator 
Change-Id: I2d90e458d5721d16142752e8ac6a522cc41c2051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-09-12 14:38:31 +00:00
David Morgan 60ca2b840d Revert "Enable visibleForTesting on unnamed constructors" 
This reverts commit de7ad46797.

Reason for revert: breaking for google3; need to discuss how to land this kind of change.

Original change's description:
> Enable visibleForTesting on unnamed constructors
> 
> Fixes #37936
> 
> Change-Id: I99023b66d7d53922edecfbab7be41d4c4145ec15
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114591
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=brianwilkerson@google.com,srawlins@google.com

Change-Id: I9d3688b4dcdff92f94b83e1e557a488abfd963cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116782
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
 2019-09-12 07:34:49 +00:00
Konstantin Shcheglov c6b0ae1fda Fix for indexing FieldFormalParameterMember with unresolved field. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38071
Change-Id: Ifa2f9218357f0f7bb3236f66aee34c8940c8b206
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116865
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 22:45:59 +00:00
Konstantin Shcheglov 3e63f06afd Remove CancelableFuture. 
We don't use it anymore, and none of our clients does.

R=brianwilkerson@google.com

Change-Id: Iac840c182b47d85595ca80762fa8a207d8545585
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116752
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 22:03:19 +00:00
Konstantin Shcheglov d39b67dbfe Remove more unused classes from engine.dart 
R=brianwilkerson@google.com

Change-Id: I8d660025e201ef8a79d377c1923fe9a87bbc80ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116750
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 20:12:49 +00:00
Brian Wilkerson d36f5ed181 Fix diagnostic documentation tests and add support for documenting parser codes 
Change-Id: Ie2e360e6e4a344888bb409d20f21c969280bbdf9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116742
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 19:45:47 +00:00
Brian Wilkerson be93b04a7c Introduce a better diagnostic message for unqualified references to static members within extensions 
Change-Id: Ie505bf86e510161bf5dece489292388039902f83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116748
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 19:02:56 +00:00
Sam Rawlins de7ad46797 Enable visibleForTesting on unnamed constructors 
Fixes #37936

Change-Id: I99023b66d7d53922edecfbab7be41d4c4145ec15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114591
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 18:20:46 +00:00
Sam Rawlins 80040e5cfe Remove errors for raw types in is or as expressions. 
This brings the errors in line with the exceptions described in the spec:

https://github.com/dart-lang/language/blob/master/resources/type-system/strict-raw-types.md#conditions-for-a-raw-type-hint

Change-Id: I045237d937579d4390d3e676dc5e12346b90b480
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-11 18:13:46 +00:00
Konstantin Shcheglov dd3d6547de Rewrite property resolution, fix reporting errors when compound assignment without a getter. 
Change-Id: Id737ea776866c3d9a52033181759f27e26dc34b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116559
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 17:28:53 +00:00
Konstantin Shcheglov 76e6325ae0 Remove unused methods of AnalysisContext. 
Change-Id: Ie7f81ac09b51f7a4e70a32f962e6e15c81245820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-11 17:09:47 +00:00
Brian Wilkerson 9113fb3ce0 Move the remaining StaticWarningCode tests to their own files 
Change-Id: I764c9cbd961bc377d1b158aa0e16b2fb0e77b8cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116722
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-11 13:34:57 +00:00
Konstantin Shcheglov 6e01ad4d22 Fix for codeOffset/codeLength for enum constants. 
R=brianwilkerson@google.com

Change-Id: I5694f96fc0e7863f18c208005ec9984eaf58bacb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116682
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-10 22:52:29 +00:00
danrubel 30ea777c65 fix parsing of "?.." cascade operator 
Fix https://github.com/dart-lang/sdk/issues/37859

Change-Id: Ie29f4fd000199f0099137308603335e36af6ae26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116089
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 20:36:04 +00:00
Brian Wilkerson 7ffb9de00f Update the version in the extension methods version hint 
Change-Id: I465413e0d1252573112bff2e518fc933308e093b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116640
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 19:48:17 +00:00
Konstantin Shcheglov c11ca7d439 Check for CompileTimeErrorCode.CONST_WITH_TYPE_PARAMETERS in LinterContext.canBeConst(). 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/linter/issues/1712
Change-Id: I8e6ec22999baf2af95f05af13fdaf596cba7676a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-10 17:57:11 +00:00
Konstantin Shcheglov fa099eb717 Look for both getter and setter in the hierarchy before looking for extension. 
Change-Id: I7080f5ffb307b9deb9bba453e1d1c1aa253b7cc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116489
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 16:39:09 +00:00
Konstantin Shcheglov 331271d405 Set id(s) for GenericFunctionType(s) in constructor initializers and default values. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38282
Change-Id: I05d5b5c003fa51cc5061ed2dd6883809b6f82cae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116490
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-10 16:26:39 +00:00
Mike Fairhurst 7413879026 [analyzer] Add getter isNullAware to SpreadElement 
Change-Id: I89d644da2277b4527f32e176f9355cf16734dc64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116380
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 03:20:19 +00:00
Konstantin Shcheglov 0851b9ae4c Consider both getter and setter when deciding whether an extension reference is ambiguous. 
Change-Id: I8acbabda7f748e7415bd38a957e96f906afd7f6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116250
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-09 19:13:06 +00:00
Konstantin Shcheglov 6f38a73618 Remove most of the task model. 
I run presubmit, and it does not look to me that any failin tests
are caused by this CL.
https://test.corp.google.com/ui#id=OCL:267824456:BASE:267824473:1567923135217:2380181a

R=brianwilkerson@google.com

Change-Id: I838f2174460e0d06c85bbb83de9037113c0b6393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116252
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-09 18:26:50 +00:00