88380d5708
Revert "Fix value computation for multi-line strings (issue 22993)"
...
This reverts revision 44722
This is causing test failures:
http://build.chromium.org/p/client.dart/builders/pub-linux-be/builds/11761/steps/pub%20and%20pkg%20%20tests%20failures/logs/stdio
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1038353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44734 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-27 13:59:13 +00:00
ada62d06d1
Rewrite constants evaluation and checks to avoid using 'is double'.
...
We have 33 hints because of it.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1017573004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44724 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 22:45:18 +00:00
b073936fd0
Allow "dynamic" as a constant value in analyzer.
...
BUG=dartbug.com/22989
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1004353006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44723 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 21:50:44 +00:00
117ed251cc
Fix value computation for multi-line strings (issue 22993)
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//1034953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44722 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 21:45:31 +00:00
695b438019
Task: Resolve References.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1038963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44720 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 19:28:28 +00:00
dc0499d075
Task: Resolve Variables.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1031303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44710 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-26 14:01:31 +00:00
4b418376fe
BuildLibraryConstructorsTask to build all constructors of all library classes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1031283002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44701 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 21:59:58 +00:00
d0a5715e61
Tests for ListTaskInputImpl.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1034783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44694 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 20:14:09 +00:00
247b3edb06
Add toMap / toMapOf / toList
...
Rename 'inputOf' to 'of'.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1005693007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44690 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 17:54:17 +00:00
3e62e9ff67
Task: BuildClassConstructorsTask.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1029953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44675 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-24 21:20:15 +00:00
3d8bd5fcb6
Add UNITS and CLASS_ELEMENTS results.
...
R=paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//1034493004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44673 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-24 18:47:22 +00:00
cc1eaee4e2
Issue 22962. Adding/removing method/accessor body is a declartion mismatch.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22962
Review URL: https://codereview.chromium.org//1024553006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44667 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-24 14:52:35 +00:00
79af2ba662
Fix constant evaluation of division.
...
To be consistent with the VM and dart2js implementations, the
analyzer's constant evaluation of a / b should always yield a double,
even if the arguments are ints. For example, 300 / 2 = 150.0 and 301
/ 2 = 150.5.
BUG=dartbug.com/22937
R=danrubel@google.com
Review URL: https://codereview.chromium.org//1027453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44645 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 19:36:37 +00:00
5c9110841e
Fix hints in the analyzer package.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1026093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44639 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 17:34:00 +00:00
85db3fbe62
Report separate UNUSED_CATCH_CLAUSE and UNUSED_CATCH_STACK hints.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//1020243004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44635 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 16:41:20 +00:00
d74e115bfc
(TBR) fix the build
...
BUG=
Review URL: https://codereview.chromium.org//1025233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44627 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-23 04:25:44 +00:00
03cac10578
improve parser recovery of type argument list
...
BUG=
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//1025903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44626 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-22 18:33:23 +00:00
54e1ea2333
Make helper methods in ParserTestCase non-static.
...
This will help prepare for work on DEP 9 (null-aware operators) by
allowing parser tests that require null-aware operators to enable them
using an instance variable in ParserTestCase.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1024313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44624 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-21 20:55:53 +00:00
f2df67f2fe
ResolveLibraryTypeNamesTask to force type name resolution in parts.
...
Also clean ups in other tasks inputs.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1024973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44623 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-21 01:08:20 +00:00
c16fc96d58
Implement the new definition of flatten() from r44569 in analyzer.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1023903002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44603 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-20 13:29:05 +00:00
3b8c23ce58
Fix static type analysis of function invocation expressions.
...
BUG=dartbug.com/22916
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1021773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44588 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 19:39:20 +00:00
b36c00f15f
Temporarily move plugin support
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1027433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44586 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 19:06:22 +00:00
505b83a377
Rewrite ImplicitConstructorBuilder to use only element model.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1022843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44583 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 18:11:33 +00:00
abaf8171cc
Task: Resolve Type Names.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1023503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44566 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 21:50:43 +00:00
10a83e55c4
Task: Build Type Aliases.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1012403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44565 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 20:49:26 +00:00
47d33ecd72
Add public and export namespaces to LibraryElement.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1023443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44563 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 19:25:51 +00:00
8fba9fa5a4
Task: Create Export Namespace.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1017743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44545 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 22:22:27 +00:00
fe5c9fdfd5
fix for getting node for class element
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1007563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44539 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 17:00:05 +00:00
c6a760de66
Task: Build Export Source Closure.
...
It's result will be used later to compute EXPORT_NAMESPACE for each library.
One of the inputs of the task computing EXPORT_NAMESPACE is a map of each source from EXPORT_SOURCE_CLOSURE to its PUBLIC_NAMESPACE.
It will require also changes to NamespaceBuilder to replace direct
AnalysisContext.getPublicNamespace(LibraryElement) with an externally provided function.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1012993004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44535 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 14:54:01 +00:00
1ff4ead0f6
Rename ContributionPoint
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1012993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44534 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 14:52:45 +00:00
8910e64632
Start analyzing LibraryUnitTarget(s) from BuildLibraryElementTask.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1018443003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44529 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 23:39:48 +00:00
aea99bdfa1
Remove the old formatter from analyzer.
...
BUG=https://code.google.com/p/dart/issues/detail?id=22401
R=brianwilkerson@google.com , pquitslund@google.com
Review URL: https://codereview.chromium.org//1001403002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44522 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 20:03:33 +00:00
ef2a41217d
Add NOT_INITIALIZED_FIELDS property for FINAL_NOT_INITIALIZED_CONSTRUCTOR_X.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1004793003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44511 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 17:49:19 +00:00
5432c74cd6
Add readAsStringSync() to File.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1007233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44506 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 15:01:52 +00:00
dfb5713b95
Include the common library name used in 'part of' directives.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1012543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44496 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-15 23:38:31 +00:00
3c49c97afc
Task: Build Enum Member Elements.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1009693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44494 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-15 19:19:50 +00:00
384b8ce7f1
Compute TYPE_PROVIDER using BuildTypeProviderTask.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1009033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44492 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-14 03:10:48 +00:00
9d05d623ec
Use AnalysisDriver to run task tests.
...
It's much more concise now.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1007993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44482 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 21:58:14 +00:00
2fe598c6ea
Fix line info for multi-line strings (issue 22794)
...
R=pquitslund@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//1000913004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44481 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 21:54:16 +00:00
01dadf8285
Provide value for values field in enums (issue 22722)
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1007013003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44479 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 21:47:37 +00:00
adc6b6c4fa
Rename ListToX inputs.
...
Also harder the GenerateTaskInputs interface.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1000203004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44446 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 21:57:30 +00:00
3b922a53ac
Correctly compute whether a class subclasses Function (issue 22805)
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1001063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44439 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 19:01:16 +00:00
11f6cd218c
Task: Build Directive Elements.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1008433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44436 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 18:27:46 +00:00
2679bf65d5
Add MapBasedTaskInput.
...
I found out that I'm blocked by its absence.
To resolve directives (actually to report errors) I need to know source kinds.
And the only way to get the SourceKind of a Source is to request a Map-based input.
If you have already implemented it yourself, feel free to upload your CL instead.
I'm not too much attached to this implementation :-)
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//997383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44429 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 15:11:42 +00:00
40dea00f27
Task: Build Public Namespace.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//998053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44413 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 21:02:55 +00:00
0a35aec78f
Fix type promotion (issue 22732)
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//991033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44410 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 18:01:25 +00:00
e834e4194f
Task: Build Library Element Model
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//994293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44406 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 16:57:13 +00:00
29c0fb7cd6
Add an analyzer option to properly check ".call" methods.
...
Enabling this option fixes issue 21938. For now the option is
disabled by default, since there is a lot of code in the dart SDK (and
in third_party) that isn't warning clean with this option enabled.
Once the SDK and third_party code have been cleaned up, we should be
able to turn this option on permanently.
BUG=dartbug.com/21938
R=scheglov@google.com
Review URL: https://codereview.chromium.org//994253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44390 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 00:35:31 +00:00
f0c4735db7
Convert file system tests into reflective.
...
I need to add new tests... to add new methods... to fix issue 22757.
It's too hard to do now.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//1000473002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44389 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 00:03:01 +00:00
9f3ff6a1a7
Fix for matching field formal parameters.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//995853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44381 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 17:36:56 +00:00
ricow@google.com