Commit Graph

7128 Commits

Author SHA1 Message Date
Brian Wilkerson 1463fb3ff2 Task to infer static variables
R=leafp@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1323653002 .
2015-08-31 11:36:43 -07:00
Konstantin Shcheglov 3e9645af53 Resolve enum documentation comments.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1325513004 .
2015-08-28 14:07:13 -07:00
Konstantin Shcheglov 3d1da0f320 Add AnalysisContext.getResult()/computeResult()
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1308033008 .
2015-08-28 13:57:25 -07:00
Brian Wilkerson 7ce07af57e Implement a task to compute the dependencies between static variables
R=leafp@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1320923003 .
2015-08-28 11:42:15 -07:00
Leaf Petersen bff9b65509 Strong mode local variable inference
BUG=
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1314793005 .
2015-08-27 13:27:10 -07:00
Brian Wilkerson c3b12a65ba Add a task to partially resolve a compilation unit
R=leafp@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1321523002 .
2015-08-26 11:22:03 -07:00
Brian Wilkerson 335b87c701 Integrate recent parameter override logic
R=leafp@google.com, paulberry@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//1311433005 .
2015-08-26 10:35:34 -07:00
Konstantin Shcheglov 597f189eb4 Extension point for WorkManagerFactory(s).
I'm not quite happy that internal classes get into the extension point declaration.
But I guess that because of the nature of the work WorkManager(s) are doing, we have to have significant exposure to internals.

Also, onAnalysisOptionsChanged() and onSourceFactoryChanged()... these probably are better to implement as streams in InternalAnalysisContext.
Thoughts?

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1311773005 .
2015-08-26 09:45:19 -07:00
Brian Wilkerson 0061447293 Implements instance member inference. Records the correct return type for synthetic function elements representing initializers.
R=leafp@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1306313002 .
2015-08-25 07:48:49 -07:00
Paul Berry b547acc883 Band-aid fix for issue #24191.
This is sufficient to avoid throwing an exception in the resolver,
which in turn will prevent the analysis server from going into an
infinite analysis loop.

I'll work on a more complete fix (which infers the proper type in all
cases) for the next release.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1307353002 .
2015-08-24 16:05:05 -07:00
Konstantin Shcheglov 581e20d2f6 Disable incremental resolution for not BlockFunctionBody(s).
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1310073002 .
2015-08-22 10:04:53 -07:00
pq 67e988bb9f No more warnings for duplicate unnamed lib imports
Fixes #24156.

R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1305433005 .
2015-08-20 14:30:37 -07:00
pq e11ce8ba87 Handle comparison of empty URIs (sdk/24126).
Fixes issue where `.packages` provides a key mapped to an empty value (https://github.com/dart-lang/sdk/issues/24126).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1298393004 .
2015-08-19 12:53:55 -07:00
pq de245cf5a7 Test fix for new dart2js hints default.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1300933002 .
2015-08-18 13:34:40 -07:00
pq a428c4607a Disable dart2js hints by default.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1289273005 .
2015-08-18 13:04:13 -07:00
Paul Berry 8f2ed2c68d Fix most implementations of UriResolver.restoreAbsolute.
Although it wasn't previously clear in the documentation,
implementations of UriResolver.restoreAbsolute() should only depend on
Source.fullName.  To do otherwise breaks some assumptions made by
analysis server.  This CL fixes all implementations except
SdkExtUriResolver (which has been deferred to issue #24090).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1296653003 .
2015-08-18 11:32:15 -07:00
Brian Wilkerson 7e32b22461 Add missed test file
Review URL: https://codereview.chromium.org//1294023006 .
2015-08-18 07:48:25 -07:00
Brian Wilkerson 81fbf6af7c Initial steps toward adding strong mode to the new task model
R=leafp@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1289283004 .
2015-08-17 17:07:50 -07:00
John McCutchan aa430494f4 Fix script entry case of SdkExtUriResolver.restoreAbsolute
- Fix entry case of restoreAbsolute.
- Add TODO to fix part case

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1294473009 .
2015-08-17 10:01:01 -07:00
John Messerly 6417c36b0a [analyzer] remove "auto-generated do not edit" comments
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1291143002 .
2015-08-13 13:36:02 -07:00
danrubel da92573117 fix sorting of compilation unit members - related to #23947
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1281793004 .
2015-08-11 14:24:37 -04:00
Brian Wilkerson 913524d12d Possible fix for tests failing on the Windows bots
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1282823004 .
2015-08-10 13:59:38 -07:00
Brian Wilkerson 6359735d93 Disable flaky test under Windows (and fix formatting from an earlier CL)
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1287513002 .
2015-08-10 13:32:07 -07:00
Brian Wilkerson 67f82df1b6 Provide more data on failure
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1283783004 .
2015-08-10 12:40:44 -07:00
Brian Wilkerson fa80ca52e9 Revert a work-around that is now causing bot failures
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1282873002 .
2015-08-10 12:06:27 -07:00
Brian Wilkerson e4052e936f More fixes for the Windows bot
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1276973002 .
2015-08-06 11:39:43 -07:00
Paul Berry d977370e3f Fix PathFilter constructor to be backward compatible with analyzer 0.26.0.
Commit 24189ea4f9 modified the
PathFilter constructor signature in a backwards-incompatible way, and
made corresponding changes to analysis_server, causing warnings to
show up in analysis_server when analyzed using the version of analyzer
in its pubspec.

This CL switches to a backwards-compatible signature and updates the
analyzer pubspec in preparation for publishing.  Once the new version
of analyzer is published I will update analysis_server's pubspec to
point to it, which should fix the warnings.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1278823002 .
2015-08-06 11:03:55 -07:00
Brian Wilkerson 9aa45d4cf0 Capture more data when instrumenting exceptions
R=lukechurch@google.com

Review URL: https://codereview.chromium.org//1257023003 .
2015-08-06 08:50:39 -07:00
Brian Wilkerson f05106f7d1 Fix ToStringVisitor to handle external functions (issue 23968)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1269393002 .
2015-08-05 08:27:52 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
2015-08-05 08:13:28 -07:00
Brian Wilkerson 58199fbad9 Propagate a type in asynchonous for-in statements (issue 23945)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1268733004 .
2015-08-03 17:23:35 -07:00
Konstantin Shcheglov b125399a95 Update LineInfo during incremental resolution.
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/116

Review URL: https://codereview.chromium.org//1262453007 .
2015-07-31 10:37:33 -07:00
Brian Wilkerson 24189ea4f9 Make PathFilter use the resource providers path context
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1260443006 .
2015-07-31 10:06:38 -07:00
Konstantin Shcheglov 8eb0de07f3 Issue 23919. Fix for line starts in multiline comments.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23919

Review URL: https://codereview.chromium.org//1271553002 .
2015-07-31 08:33:38 -07:00
Paul Berry fcfea00af8 Implement DEP 34 (less restricted mixins) in analysis engine.
The feature is disabled by default; enable it by setting the option
"enableSuperMixins".  (This name was chosen to match the
"--supermixin" flag accepted by the VM).

The feature is not yet exposed through analysis server or the
analyzer_cli.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1262163002 .
2015-07-29 08:50:49 -07:00
Brian Wilkerson 2ec502a583 Code clean-up, mostly constructors
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1265453005 .
2015-07-28 11:12:51 -07:00
Paul Berry 0e98c58190 Fix analyzer interpretation of 'ClassName?.staticMember'.
Previously, trying to access a static member of a class using '?.' was
not allowed.  But the spec was changed in
b11670f899 so that
'ClassName?.staticMember' is now equivalent to
'ClassName.staticMember'.

This CL updates analyzer to follow the spec, and updates the tests in
"tests/language" accordingly.  VM and dart2js still need fixing
(see #23794 and #23795).

Fixes #23464.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1255293005 .
2015-07-28 09:49:35 -07:00
pq f013d3868c Actual URI support for package URI resolution.
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1245263002 .
2015-07-21 15:53:56 -07:00
Brian Wilkerson f241b383a9 Implement a strong-mode option in analyzer
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//1241243003 .
2015-07-20 12:30:05 -07:00
John McCutchan 4bf66ce912 Add an AnalysisOptionsProvider to analyzer
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1231633011 .
2015-07-17 13:34:03 -07:00
Brian Wilkerson d37ac8d4d0 Fixed bug in implicit analysis notification and renamed tests
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1236013003 .
2015-07-17 12:43:59 -07:00
John McCutchan c9dd867c1f Add path filter
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1232763004 .
2015-07-17 10:06:29 -07:00
Brian Wilkerson 503e2b68f1 Add hook for listening to implicitly analyzed files
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1239863002 .
2015-07-16 08:10:38 -07:00
Paul Berry 4b83219847 Switch on null-aware operators by default in analyzer.
Patches to update analyzer_cli and analysis_server will follow once a
new version of analyzer has been published.

BUG=dartbug.com/23793
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1239513005 .
2015-07-13 15:56:21 -07:00
Brian Wilkerson 4d2bb64183 Generic method support in element model
R=leafp@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1217373005 .
2015-07-10 13:53:35 -07:00
pq a81c308283 Analyzer code cleanup.
Removed some unused imports and fixed member sorting.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1230273002 .
2015-07-10 13:42:27 -07:00
John McCutchan 7abe54a857 Move from .sdkext to _sdkext
Reason: Pub does not publish dot files.

Review URL: https://codereview.chromium.org//1224103003 .
2015-07-08 16:33:09 -07:00
John McCutchan 6ecf960c5e Move SdkExtUriResolver from analysis_server to analyzer so it can be used in analyzer_cli
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1214823003 .
2015-07-08 10:28:19 -07:00
pq 81f8d4fa54 Fix for URI resolution w/ file scheme set in package map.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1224693014 .
2015-07-08 09:18:04 -07:00
Brian Wilkerson 27f600058e Improve propagation in binary expressions
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1226823003 .
2015-07-08 08:02:05 -07:00