dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

40 Commits

Author SHA1 Message Date
Sam Rawlins 5d1faf6cc6 Refactor yaml utilities in analyzer and analysis_server 
* Two extension methods were moved from analysis_server to analyzer, to replace
  identical top-level helper functions in analyzer.
* Add nodes2 which returns a YamlMap with YamlNode keys.
* Privatize two static functions in Merger.

Change-Id: If54e73d6e8133bf1b2a3af809d6bb732c77ab9be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191381
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-03-17 16:57:05 +00:00
Konstantin Shcheglov a629b48fdc Remove file name constants from AnalysisEngine. 
Change-Id: I3457973212e704a0fedee20db17956c017ec91ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 05:52:56 +00:00
Konstantin Shcheglov 27e707268f Always crawl up in getOptionsFile() 
Change-Id: I424cd625f05d9bc10ae0366e0332e96496633062
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-11 23:24:11 +00:00
Sam Rawlins 237c84249b Remove unnecessary imports in analyzer 
Change-Id: Ifb9a5c0a31cf3669febf2981b1d26b84f5b9d237
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180781
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-02-02 14:40:24 +00:00
Konstantin Shcheglov 9f986d2501 Migrate package:analyzer to null safety. 
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-02-01 18:56:04 +00:00
Sam Rawlins 17b7d05e72 Analyzer: prepare for null safety in tests: casts and late variables 
Change-Id: I37f3663b340952b79cef0e423caf81e5950b700b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/175841
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-11 19:50:39 +00:00
Keerti Parthasarathy 8329bd7ca8 Do not check for '.analysis_options' for default options file in builder. 
Change-Id: I9decba4d0db318caedcfd3695f41c127b66f416f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138660
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2020-03-09 19:31:24 +00:00
Konstantin Shcheglov 8a0d30d4e2 Fix annotate-overrides in analyzer. 
R=brianwilkerson@google.com

Change-Id: I7a587daf9715ded6450b28ecf3892ce4181aeb37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-23 00:02:37 +00:00
Konstantin Shcheglov 364dd8936b Fix unnecessary_new in analyzer. 
R=brianwilkerson@google.com

Change-Id: I70f80baa3da4b14c0a52c1f28da16a9ad26d7dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 01:11:30 +00:00
Konstantin Shcheglov eee20b4e60 Fix prefer_equal_for_default_values in analyzer. 
Change-Id: Ia72a2ac31d6cf6329c78baad6954ac9595a6c45a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127448
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 00:00:30 +00:00
Brian Wilkerson 5f0de26d48 Clean up the remaining copyright notices 
Change-Id: If099be4f71ba551df0dc3d69815ae6a9f55d1eba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97781
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-24 20:11:28 +00:00
Kevin Moore cb4a19b5fc misc(pkg/analyzer): update to latest pkg:matcher API 
Change-Id: I42a5c41394226f6ddc9c0608c6d688ae683ffdea
Reviewed-on: https://dart-review.googlesource.com/62680
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-06-27 19:29:20 +00:00
Brian Wilkerson 7054d92a02 Remove some classes from the analyzer public API 
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-24 15:28:15 +00:00
Brian Wilkerson b936ffb329 Move several libraries out of the public API 
Change-Id: I8259de00134310f25b1c6168940aea5190488999
Reviewed-on: https://dart-review.googlesource.com/51443
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-04-17 17:35:27 +00:00
Brian Wilkerson 26c06cdd82 Clean up Dart 2 type issues related to YAML support 
Change-Id: Ic29054afca9773286aa899eecede287f7ecbca9a
Reviewed-on: https://dart-review.googlesource.com/47680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-03-22 17:06:40 +00:00
Devon Carew 2b3b0272c4 Switch to using specific throws calls instead of general throwsA() calls. 
Bug:
Change-Id: Id604dca1b8c3060c1d12c9ed0b1493771d2eb0d6
Reviewed-on: https://dart-review.googlesource.com/5883
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2017-09-14 18:04:44 +00:00
Devon Carew b12d010064 Remove the use of deprecated package:test API. 
Bug:
Change-Id: I671678117f72efac5efd60d7b4e459dffcce47c6
Reviewed-on: https://dart-review.googlesource.com/5542
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-13 21:55:00 +00:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt. 
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
 2017-07-13 16:28:18 -07:00
Dan Rubel c1451ac218 fix include options test on windows 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2505633002 .
 2016-11-15 15:13:25 -05:00
danrubel 18ab91f70b skip new test on windows 
Review URL: https://codereview.chromium.org/2496403002 .
 2016-11-14 16:35:45 -05:00
danrubel 68ba3cfe51 work in progress - support analysis options include declaration 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2489973002 .
 2016-11-14 15:12:03 -05:00
Konstantin Shcheglov 5455fd0118 Remove 'initializeTestEnvironment' from 'analyzer'. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2399913002 .
 2016-10-06 10:18:54 -07:00
Konstantin Shcheglov 175dad4f15 Switch 'analyzer' to 'package:test' and test_reflective_loader ^0.1.0. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2391423003 .
 2016-10-06 08:46:35 -07:00
Brian Wilkerson ef2a3b982c MemoryResourceProvider always uses the current platform 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2391883002 .
 2016-10-03 19:24:21 -07:00
Brian Wilkerson 5bd4de469e Clean up warnings and hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2324463006 .
 2016-09-09 09:09:59 -07:00
Paul Berry 94309733cd Revert "Remove unnecessary hide clauses" 
The `Resource` class wasn't removed from the SDK until version
1.20.0-dev.0.0, which was only recently published.  Reverting this
change to allow people using older SDK releases a little more time to
upgrade.

This reverts commit 2cdafd82c2.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2299243002 .
 2016-09-01 16:08:43 -07:00
Brian Wilkerson 2cdafd82c2 Remove unnecessary hide clauses 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2305453002 .
 2016-08-31 16:44:52 -07:00
Konstantin Shcheglov cc6beaf56d Pull in test_reflective_loader 0.0.4 and switch analyzer to it. 
There are following changes:

1. DEPS to pull in test_reflective_loader 0.0.4
2. Rename runReflectiveTests() to defineReflectiveTests().
3. Remove analyzer's pkg/analyzer/test/reflective_tests.dart
4. Replace reflective_tests.dart imports with package:test_reflective_loader/test_reflective_loader.dart imports.
5. Sort/format and organize imports in the files with imports changes.
6. Fix for a couple of bugs in analysis_server exposed by the new loader.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2298913003 .
 2016-08-31 13:46:39 -07:00
Brian Wilkerson 44836f8538 Support the name analysis_options.yaml for analysis options files 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1975963002 .
 2016-05-13 07:33:06 -07:00
Konstantin Shcheglov d097a6e1cd Allow Analysis Server crawl up the folders to search .analysis_options file. 
R=brianwilkerson@google.com, jwren@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org/1832643002 .
 2016-03-23 17:09:48 -07:00
danrubel d26d023ce7 update tests for execution on windows 
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1774623006 .
 2016-03-09 22:33:35 -05:00
Brian Wilkerson f0d249e269 Clean up package imports and library names 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1513643009 .
 2015-12-10 08:11:56 -08:00
pq b0a08827aa Improves options validation type safety (#24885). 
Fixes #24885.

https://github.com/dart-lang/sdk/issues/24885

BUG=24885
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1437703003 .
 2015-11-12 09:44:25 -08:00
pq 67dc108f39 Map merging. 
Basic YAML map merging suitable for merging a default map with an overriding one.

The semantics favor the overrider with a twist to support a short-hand for lists that stand-in for maps of scalars to booleans.  Specifically, lint rules can be enumerated as a list or as a map.  To make this work, lists can be "promoted" to maps.  In particular, if

linter:
  rules:
    - camel_case_types
    - one_member_abstracts

is merged with

linter:
  rules:
    one_member_abstracts: false
    always_specify_return_types: true

the right thing is done to get us to:

linter:
  rules:
    camel_case_types: true
    one_member_abstracts: false
    always_specify_return_types: true

R=brianwilkerson@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1425393002 .
 2015-11-03 10:42:18 -08:00
pq ffeacec73d Improved YAML doc exception handling. 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1415153004 .
 2015-10-28 11:24:42 -07:00
pq 6c85fe785a Analysis Options error notifications. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1411013003 .
 2015-10-21 09:59:19 -07:00
Brian Wilkerson 04c5a5f199 Clean up hints 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1382403002 .
 2015-10-05 09:20:44 -07:00
John McCutchan 9535715f92 Fix handling of empty .analysis_options files and test this case 
Fixes #24431

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1369573003 .
 2015-09-24 12:38:53 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
John McCutchan 4bf66ce912 Add an AnalysisOptionsProvider to analyzer 
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1231633011 .
 2015-07-17 13:34:03 -07:00