abecefd1ac
Forward compatible portion of CL that does not set types for identifiers that are not expressions.
...
The full CL:
https://dart-review.googlesource.com/c/sdk/+/119761
Change-Id: I9c909a4e1eec5d05f5718849ea45da79f01c5291
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121643
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-15 17:29:07 +00:00
c9c8e4d84f
Resolver fix: set auxiliaryElements properly for property accesses.
...
Previously we only set it for index expressions, prefixed identifiers,
and simple identifiers.
Change-Id: Ib666aa936f0e7bf7421cb74e491d35ab5507d412
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-10-14 19:44:10 +00:00
dc0db066e6
Remove ChangeSet from engine.dart
...
Change-Id: I289c5edd0c3e52a873013f8c52d8202bf29cf3be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-14 17:45:56 +00:00
5c2b86897c
[parser] late is a built-in identifier
...
Fixes #38803
Change-Id: I2fe7817aa0311c2370222a3205f1a1e02dc9aba4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-10-11 06:19:13 +00:00
f9e7761895
Stop using lazy FunctionType where possible.
...
We have to keep it for now for GenericFunctionType nodes, because
of the way we build types - we first build elements, for example
GenericFunctionTypeElement, and set the type of the GenericFunctionType
nodes to a lazy FunctionType on top of not-yet-resolved element.
Then on the next step TypeResolverVisitor goes over the AST second
time and updates elements with actual types for TypeName(s).
There is no need for doing this now when we are using summary2, it
has its own way to solve forward references with creating elements for
unresolved AST nodes, and breaking cycles with TypeBuilder(s). But the
current implementation is quite big, and it will take some time for me
to try one or another approach to restructure it.
Change-Id: Ic0b8594a6723f715bc5484f9946324c46e30ffb2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120620
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-10-08 15:25:51 +00:00
a389015083
Rewrite MethodInvocation to FunctionExpressionInvocation when the target is not a method.
...
Failing tests for DDC are tracked in the following issue:
https://github.com/dart-lang/sdk/issues/38749
Change-Id: I96e0fe9bc87509b99ba982be4572d4ad4f133cca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120342
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-10-08 00:22:39 +00:00
f918214f36
Add a unit test reproducing issue #38352 .
...
Change-Id: I0a7046ebc7d4e21458707af5aafd0382899a83d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119530
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-10-07 17:54:06 +00:00
33cd343374
Clean up the stack when a constructor initializer is found (issue 38674)
...
Change-Id: I219586288a8588298cef94f80be8030581907556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-10-02 17:11:40 +00:00
8c3065e947
Add fuzz tests for annotation resolution crashes.
...
Change-Id: I2748ae2bee93b621f864c11dc4d58ec9b1e4b9fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119581
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-01 21:50:20 +00:00
cb9a35ca53
Issue 38565. Revert incomplete annotation constructor invocation inference implementation.
...
This partially reverts https://dart-review.googlesource.com/c/sdk/+/118901
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/38565
Change-Id: I4d259a380985ce6e0670fc644594054b820b9bf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119534
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-01 20:44:26 +00:00
929716a446
Stop using DartType.isSubtypeOf() in runtimeTypeMatch().
...
Change-Id: If073faa8659494a04861df653189648b0d54bc1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-30 19:54:43 +00:00
963c338104
Don't use ResolverTestCase for two tests.
...
R=brianwilkerson@google.com
Change-Id: I375dfe9d9227d9a0cca50ed9ed5938620f9cfc50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-30 14:35:37 +00:00
3f65652ad0
Enable avoid_init_to_null.
...
R=brianwilkerson@google.com
Change-Id: I983fdff71c47dbf2b271508955095a73cfbeee59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-30 14:26:06 +00:00
595022bdea
Remove summary1, part 1.
...
Change-Id: I557785ac13fa411280ce032324b0305bf25a0a6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119170
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-28 14:30:05 +00:00
9bf38afe9c
Check that ClassElement is Object using the corresponding getter.
...
Bug: https://github.com/dart-lang/sdk/issues/38589
Change-Id: I76c510bd212c48dbb3efc6b2ca2156d187937fa1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-27 18:31:25 +00:00
61b4c0f770
Cleanup hints and lints in analyzer packages
...
Change-Id: I7f1a6ad1ed3610da9616683576ebfb5efd543fd9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119164
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-27 16:12:44 +00:00
c3c31b74fd
[parser] Fix bug wrt when the handleNonNullAssertExpression is added
...
This fix is basically a revert of the first fix for for the same issue,
https://github.com/dart-lang/sdk/commit/627e4c8cad17f069a9dc281e6726cc2080f1af45
Fix #37708
Bug: 37708
Change-Id: Ic470b2663e7171fcac6a8de3d9e1276b7815a64b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118574
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Commit-Queue: Jens Johansen <jensj@google.com >
2019-09-27 11:53:15 +00:00
eac2eadff7
Stop using 'Element.type' in resolver.
...
Change-Id: I90ed74e2c673544f3eae903859fb3b9e4c284240
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119082
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-26 23:55:02 +00:00
402951b399
Stop using 'Element.type' in ErrorVerifier.
...
Change-Id: I8313bccb7bf302fd80fa2da1e5256e1e40998fa8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-26 20:17:28 +00:00
327bc451f8
Added variance support in listeners to ast.
...
Pass variance data to field in TypeParameter through the listeners.
ast_to_text will print variances for classes and mixins if specified.
Avoids serialization/deserialization (impl in future CL).
Change-Id: I298537604823710f0d30001f4cb5f1e81530959f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118464
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
2019-09-26 18:11:10 +00:00
8dcf5cb413
Remove IncrementalAstCloner and TokenMap.
...
R=brianwilkerson@google.com
Change-Id: I0ccc3bcd3134a65821e6464cd1e60ac12d90e295
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118885
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-26 00:59:42 +00:00
bd3792e714
Remove unused MapIterator and implementations.
...
R=brianwilkerson@google.com
Change-Id: If433e5d7065b6635f8b9bfca1c495f16455dc68c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-25 22:13:07 +00:00
2bd2392e2a
Remove EngineTestCase.
...
R=brianwilkerson@google.com
Change-Id: Ica78c0dfef239e15b3f7d8d624422017d5b8375e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118600
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-25 17:53:16 +00:00
c3bbd6a247
Added parser recovery for multiple variance modifiers.
...
New error message for multiple variances and will handle recovery from
more than one variance modifier before a parameter.
Change-Id: I63ed8a7f04dd664e20d72b632b40f723aa43020f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118621
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-25 17:12:06 +00:00
bf361ebe19
Replace addTestFile()/resolveTestFile() pair with resolveTestCode().
...
R=brianwilkerson@google.com
Change-Id: Ie3289e355421b0339b012319ce39d2b8eb9569d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-25 16:03:16 +00:00
89220fd812
Variance Parsing and Syntax Support
...
With the experiment flag on, will properly parse the `in`/`out`/`inout`
keywords. Without it, will issue an error regarding the flag. First CL
for parsing, syntax support, no AST work yet.
Keywords only parse correctly for classes and mixins.
See test `variance_disabled_syntax_test.dart`.
Change-Id: I37d765804fa0752512abf52fa44456a173087ef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117929
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-09-24 17:21:39 +00:00
fc56445218
Remove EngineTestCase.getGetter()/getMethod().
...
R=brianwilkerson@google.com
Change-Id: I89cde7189f33b6a4e0cd7c3a9542232dc8f2d134
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118506
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-24 15:45:07 +00:00
c195896c84
Remove many uses of EngineTestCase.findNode()
...
R=brianwilkerson@google.com
Change-Id: I60c71f55f1d5e01a645b41fd0bd82282ca2eae20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-24 14:21:19 +00:00
5a84f09a26
Remove EngineTestCase.findSimpleIdentifier()
...
R=brianwilkerson@google.com
Change-Id: I96dd3d62f2df4e433c79afdc41156e522a779d8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-24 14:12:59 +00:00
11fa3e0e2b
Don't extent EngineTestCase where possible.
...
R=brianwilkerson@google.com
Change-Id: I6489a9bbe0bd442d1356c34fcedfde811e6f9778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118505
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-24 14:05:19 +00:00
000de948fa
add test for 38091
...
Fixed by earlier parser recovery improvement.
Fix https://github.com/dart-lang/sdk/issues/38091
Change-Id: I9fa4c3870965c1f03bae9f11da6eaf1e65bfabf9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115904
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-09-19 16:56:50 +00:00
f7472249a2
Remove EnumMemberBuilder.
...
R=paulberry@google.com
Change-Id: If92fc95598cc2530b882d270efb97664fce4176a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117983
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-19 16:08:16 +00:00
4102e63f37
Deprecate TypeProvider.listType/mapType
...
R=brianwilkerson@google.com
Change-Id: I7cef0b752be4ef6a7e4bc5394e14cd64ecb67ab5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117765
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-18 17:55:03 +00:00
4fcef04d61
Deprecate TypeProvider.iterableType/streamType
...
R=paulberry@google.com
Change-Id: Iab8038cf0ed413de7c05da4f69015c1d1309aa35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117684
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-18 17:29:58 +00:00
d4f1b8f8db
Deprecate TypeProvider.futureType/futureOrType
...
R=paulberry@google.com
Change-Id: Idde7d82b217b5921c0770d9b69f6934a1e1fc493
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117682
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-18 15:37:21 +00:00
4adbc8f1e6
Use single TypeSystem.inferGenericFunctionOrType(), avoid using full generic DartType.
...
Use instead separate components - return type, parameters.
R=brianwilkerson@google.com
Change-Id: Ie6728383683a507d5abcebe7766b7e3bf2216ed9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-17 15:56:52 +00:00
6a9d792454
Move NullabilitySuffix to API.
...
R=brianwilkerson@google.com
Change-Id: I58547075d3472e6708e6b5ff1c6d89f768aba66a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-16 21:14:11 +00:00
f470695875
Stop using ClassElement/TypeParameterElement.type in tests.
...
There are 4 references to `type` left in tests, because it looks
that these tests validate peculiarities of the `type` getter itself.
I will remove them later, when the production code is off `type`.
R=brianwilkerson@google.com
Change-Id: I4b8a590e561fe3d3103500b097c13d989514976e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-16 15:53:29 +00:00
330fccbc0d
Implement extension override in summary2
...
Change-Id: I0c7028eaa53ae070d521cda86a885435e4345089
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117124
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-09-13 21:23:03 +00:00
08518a6d5e
Stop using ClassElement.type and InterfacecType.instantiate in TypeSystem tests.
...
R=brianwilkerson@google.com
Change-Id: If455bac28edae6d37b418f956ec862211b763495
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117167
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-13 21:09:53 +00:00
daa22105fd
More clean up for TypeSystem tests.
...
R=brianwilkerson@google.com
Change-Id: I269af4969d855610c6b94c3752278d968118748d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117123
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-13 15:56:22 +00:00
3129ad9585
Only report a non-const initializer for const variables; fixes #35985
...
Bug: https://github.com/dart-lang/sdk/issues/35985
Change-Id: Iec21a08db57580af910be5a655bd439ecab15123
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-09-13 15:39:52 +00:00
c138b505be
Update TypeSystem tests to reuse AbstractTypeSystemTest.
...
R=brianwilkerson@google.com
Change-Id: Ic6e446cf124a52c8663140a995d4a58c3e4c92a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117015
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-12 23:18:07 +00:00
fc2f744d9e
Deprecate 'Source.encoding'.
...
R=brianwilkerson@google.com
Change-Id: I1a97c9b5a1401a16044df4e37117b2ec7e4e5db2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-12 16:48:16 +00:00
3b1d3de988
update parser to report out of order "?.." operator
...
Change-Id: I2d90e458d5721d16142752e8ac6a522cc41c2051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-09-12 14:38:31 +00:00
d39b67dbfe
Remove more unused classes from engine.dart
...
R=brianwilkerson@google.com
Change-Id: I8d660025e201ef8a79d377c1923fe9a87bbc80ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116750
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-11 20:12:49 +00:00
dd3d6547de
Rewrite property resolution, fix reporting errors when compound assignment without a getter.
...
Change-Id: Id737ea776866c3d9a52033181759f27e26dc34b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116559
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-11 17:28:53 +00:00
76e6325ae0
Remove unused methods of AnalysisContext.
...
Change-Id: Ie7f81ac09b51f7a4e70a32f962e6e15c81245820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-11 17:09:47 +00:00
9113fb3ce0
Move the remaining StaticWarningCode tests to their own files
...
Change-Id: I764c9cbd961bc377d1b158aa0e16b2fb0e77b8cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116722
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-09-11 13:34:57 +00:00
30ea777c65
fix parsing of "?.." cascade operator
...
Fix https://github.com/dart-lang/sdk/issues/37859
Change-Id: Ie29f4fd000199f0099137308603335e36af6ae26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116089
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-10 20:36:04 +00:00
Konstantin Shcheglov