Commit Graph

3034 Commits

Author SHA1 Message Date
scheglov@google.com ebf761a5af Convert all the generated tests to reflective.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//637003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40974 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 19:48:40 +00:00
scheglov@google.com e2a3d42150 A tentative step into converting analyzer tests into reflective.
We don't generate / translate tests anymore, so managing dartSuite()
manually is quite labor-consuming.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//636903003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40964 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 17:27:41 +00:00
scheglov@google.com 9b0697baac More string literals getters.
To use in the inline local refactoring.

1. We can unwrap a literal only if its `isSingleQuoted` is the same as of the target literal.

2. We can unwrap a single-line literal into a multi-line one, but not vice versa.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//632203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40957 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 15:51:02 +00:00
scheglov@google.com 6d0260be31 Add SingleStringLiteral with accessors.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//630163004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40949 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-07 00:51:12 +00:00
brianwilkerson@google.com 9f194c3548 Unify Entry and EntryImpl classes
R=scheglov@google.com

Review URL: https://codereview.chromium.org//630763004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40944 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 19:43:38 +00:00
brianwilkerson@google.com d23930956a Remove cache entry copying. This also removes the extractContext/mergeContext methods, but I don't believe that anyone is depending on them.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//630743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40936 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-06 16:06:03 +00:00
brianwilkerson@google.com 9c1093ffb0 Make it easier to run engine tests
R=scheglov@google.com

Review URL: https://codereview.chromium.org//632553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40915 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-05 22:22:41 +00:00
scheglov@google.com 3fab2628f4 Uncomment and clean up engine_test.dart
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//627133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40913 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-05 19:55:07 +00:00
scheglov@google.com d682c178b4 Write end-of-block comments.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//624403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40912 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-05 17:53:52 +00:00
scheglov@google.com 8debcea519 Uncomment and clean up all_the_rest.dart tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//630513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40906 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-03 22:09:29 +00:00
scheglov@google.com bc287b5a3e New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//622743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40867 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-02 04:13:16 +00:00
scheglov@google.com bbbcddfac6 New analyzer snaphot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//581733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40394 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:07:57 +00:00
scheglov@google.com 8ed8098a48 Issue 17389. Analyzer snapshot and server tweaks to use new ParameterElement.defaultValueCode.
This also makes Analysis Server to return hovers with parameter default values.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=17389

Review URL: https://codereview.chromium.org//564413005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40298 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 01:46:27 +00:00
scheglov@google.com d2d8fb708e Issue 20894. Rename 'Class' when rename refactoring is activated on 'Class' in 'new Class.name()'.
To do this we need to tweak the Java version of ElementLocator and regenarate the Dart version.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20894

Review URL: https://codereview.chromium.org//571523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40208 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 17:16:15 +00:00
scheglov@google.com 778536d97c Issue 19682. New analyzer snapshot that fixes an inline refactoring problem.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19682

Review URL: https://codereview.chromium.org//561373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40193 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 22:47:29 +00:00
scheglov@google.com b7189ea678 New analyzer snapshot.
We compute the parameter element for 'object.field = 42' now, so:
1. We can stop doing it in InlineMethodRefactoring.
2. We need to update the corresponding hover integration test.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//535543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39772 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-02 20:10:47 +00:00
scheglov@google.com a2cc52070c New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//509073008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39654 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-28 14:54:20 +00:00
scheglov@google.com 8647752153 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//515543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39599 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-27 15:51:56 +00:00
scheglov@google.com 711827d462 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//492463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39500 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-22 17:28:29 +00:00
scheglov@google.com c74b350b50 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//489173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39416 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-20 18:18:43 +00:00
scheglov@google.com decee0f35a Remove check for relative pathin java_io_test.
Hopefully this will fix one of the pub bot failures.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//485773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39341 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-18 18:10:06 +00:00
scheglov@google.com f127b725e9 Test for JavaFile.toURI().
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//479593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39300 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-15 16:28:03 +00:00
scheglov@google.com de7d21f38c New analyzer snapshot, add format/formatList.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//475543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39222 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-13 21:51:47 +00:00
scheglov@google.com 9e3aa826dc New analyzer snapshot.
Basically it includes all the code that was not translated before.

Includes new library: element_handle, but it should not be used because of WeakReference absence in Dart.
Includes new test: engine_test, but it has too much code requirering manual tweaks, after we will stop translating.
All other tests are in all_the_rest.dart, again to be moved into corresponding libraries and cleaned up later.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//459703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39091 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-11 15:41:37 +00:00
scheglov@google.com c5263aae9f Breaking changes in 'analyzer' package.
1. Source.uri added.

2. DartSdk.fromEncoding() replaced with fromFileUri().

  This CL cannot be committed as is until pkg/code_transformers is fixed.

R=brianwilkerson@google.com, sigmund@google.com
BUG=

Review URL: https://codereview.chromium.org//428303004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38949 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 20:41:42 +00:00
scheglov@google.com 57f076f17f New analyzer snapshot.
Not to be published.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//435483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38764 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-31 00:40:17 +00:00
scheglov@google.com a4dee8bf4c Resolve names in combinators for PropertyInducingElements instead of PropertyAccessorElements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//384093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38199 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-14 17:11:34 +00:00
scheglov@google.com 7a27ca20dd New analyzer snapshot.
Also includes the tweak for property accessor identifiers.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//382953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38129 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-10 20:33:33 +00:00
scheglov@google.com b405df0d27 New analyzer snapshot.
Mostly to get GetContentTask.internalPerform() to catch all exceptions.
We throw non-Java exception from memory resource, so we cannot test not existing parts/libraries cases in server.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//360393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37907 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-01 21:01:50 +00:00
paulberry@google.com 35461efcb8 Analyzer snapshot based on r37767.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//353083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37788 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-27 15:31:20 +00:00
scheglov@google.com 46b9b138d6 Move Tokenfactory, AstFactory and ElementFactory from tests to the testing/ Folder.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//351283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37748 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 17:30:25 +00:00
scheglov@google.com 6b6467a9ca New analyzer snapshot.
R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//348673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37516 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 20:58:28 +00:00
scheglov@google.com d06a1cff08 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//322603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37096 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 19:48:47 +00:00
scheglov@google.com 555bc4ef2d New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//294903015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36511 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-22 16:58:29 +00:00
scheglov@google.com af851cdcdc New analyzer snapshot (with CaughtException).
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//285423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36256 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-16 01:43:54 +00:00
scheglov@google.com 862a54b592 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//267293006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35872 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-07 22:06:01 +00:00
scheglov@google.com 593096bef2 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//263913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35704 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-02 20:06:26 +00:00
scheglov@google.com 496aa45ed1 New analyzer snapshot. Sorted unit members.
New Character utilities.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//259773005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35468 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-26 22:37:24 +00:00
paulberry@google.com 0af02e38a1 Comment out generated resolver tests (TBR).
Review URL: https://codereview.chromium.org//252723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35427 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 15:38:43 +00:00
paulberry@google.com 6c000ea2cb New analyzer snapshot, based on r35422.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//257773008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35426 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-25 15:18:19 +00:00
scheglov@google.com d1cc18b5e1 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//247053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35270 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-22 17:10:47 +00:00
scheglov@google.com 314fd76902 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//243263004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35179 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-18 19:55:14 +00:00
scheglov@google.com f8e1c92a55 Comment out resolver tests to fix VM bot.
TBR

R=jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//228323003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34895 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 20:46:57 +00:00
scheglov@google.com e5652e0e90 New analyzer snapshot with MapIterator.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//229653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34891 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 20:18:01 +00:00
scheglov@google.com 6da7a82a20 Fix for translation of \!= to \!identical(), but use == and \!= for Enum.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//221483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34636 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 03:09:22 +00:00
scheglov@google.com 1145c19860 Rollback pkg/analyzer that breaks code_transformers
R=blois@google.com, brianwilkerson@google.com, sigmund@google.com
BUG=

Review URL: https://codereview.chromium.org//214593008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34479 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 20:29:08 +00:00
scheglov@google.com 240b4138ce Translate Java enums to Dart constants.
1. Restore "this.field" field formal initializers.

2. Tweaks for several Java places - mostly to the constructors; but also duplicate HintCode messages (in Dart we cannot get values of constant values final fields).

3. Translate field that are not written to Dart final fields and also to field initializers, even if there are no property for them.

4. And constant enums.

5. pkg/code_transformers/test/resolver_test has to be skipped, I cannot fix it myself.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//214253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34474 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 15:37:37 +00:00
scheglov@google.com eedaae10e6 Optimizations for hashCode.
This improves Dart-based analyzer performance.

dart2js:   12500 -> 11600 ms, about 900 ms or 7%.
blueshift: 23500 -> 21500 ms, about 2000 ms or 8%.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//207853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34318 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 18:18:14 +00:00
scheglov@google.com d12545d5fa New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//207023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34227 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 05:09:57 +00:00
scheglov@google.com 5edf555a9a New analyzer snapshot.
R=blois@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//197213036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34188 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 17:38:28 +00:00