ee07335392
Improve message around re-assigning a local final.
...
Add a new ASSIGNMENT_TO_LOCAL_FINAL code for the new text.
Fixes https://github.com/dart-lang/sdk/issues/28721
Bug: https://github.com/dart-lang/sdk/issues/28721
Change-Id: I5492dd0d9ee09d5b73296b46fe10271661c3c64f
Reviewed-on: https://dart-review.googlesource.com/29621
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-12-15 01:09:55 +00:00
b709bc4bbe
Fix AstBuilder interpolation expression construction
...
Add a new handleInterpolationExpression fasta parser event
so that AstBuilder can correctly construct interpolation expressions
with left and right brackets.
Change-Id: Icca977067fe3a28dbab83488108c7286ec135dca
Reviewed-on: https://dart-review.googlesource.com/29541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2017-12-14 19:18:16 +00:00
eb834e1886
Analyzer: allow identifier references in comments
...
When referencing an identifier in a documentation comment that precedes the
identifier, but exists in the same scope, do not raise an error.
Bug: https://github.com/dart-lang/sdk/issues/24880
Change-Id: I1cf9b54e0af280ea9f9a64f5e2a751e9573a1e5b
Reviewed-on: https://dart-review.googlesource.com/29561
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2017-12-14 15:05:55 +00:00
3f273903bb
Add fasta parser incomplete field recovery
...
Change-Id: Ifb948c752d8cda3afcd39f80d4681a25fac9e3a8
Reviewed-on: https://dart-review.googlesource.com/29445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2017-12-14 01:25:45 +00:00
14629098dd
Enforce @visibleForTesting annotations.
...
In particular, enforce that a method annotated with @visibleForTesting can only
be referenced from within the declaring library, or within a file that has
"/test" in its path. This allows @visibleForTesting methods to be accessed from
test files, or files in "/testing" folders, etc.
Bug: https://github.com/dart-lang/sdk/issues/28273
Change-Id: I3c19f73be330c49face7e3203879742d514bca74
Reviewed-on: https://dart-review.googlesource.com/27201
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-14 00:17:24 +00:00
77d3b70220
Add previewDart2 to remaining kernel tests
...
Change-Id: I097df911af5d90f38eb177a6744c798a29a5804e
Reviewed-on: https://dart-review.googlesource.com/29460
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-12-13 22:46:14 +00:00
4804108735
Support for more than one variable defined in a statement.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I9c5163099e46639a58487d217c1895b21bbc754d
Reviewed-on: https://dart-review.googlesource.com/29440
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-13 22:14:24 +00:00
3f90f36380
Apply resolution to not procedures/methods invocations.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I419245d819c68a28ecb328e78073cbe5373f7455
Reviewed-on: https://dart-review.googlesource.com/29360
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-13 21:13:14 +00:00
9267fe0dbb
Add flag to CompileTimeErrorCodeTest_Kernel
...
Change-Id: I926d4072d93c1c32107d7bcf8fba5add906c7fd0
Reviewed-on: https://dart-review.googlesource.com/29380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-13 20:44:24 +00:00
1b7ae4e98b
Fix for the test that does not fail anymore.
...
TBR
R=brianwilkerson@google.com , pquitslund@google.com
Bug:
Change-Id: I0a17afcd8379fcebf0547735bd4b5f7bfcc05bf1
Reviewed-on: https://dart-review.googlesource.com/29341
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-12-13 19:17:36 +00:00
88575a3f4c
Fix resynthesis for 'dynamic op value' constant expressions.
...
1. Move error checking before.
2. Remove check for operator using resolution, because there is no
resolution for dynamic target. _toBinaryOperatorTokenType() will
throw if the operatorName is not actually the name of an operator.
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Iaa7d909ec8a6c13f306fd73122a10a0de170e7e1
Reviewed-on: https://dart-review.googlesource.com/29181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-13 18:18:35 +00:00
24a510a91e
Enable previewDart2 for more tests
...
Change-Id: I1f2003040246b5b12f2866d513ff3502246ac39f
Reviewed-on: https://dart-review.googlesource.com/29220
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-13 18:15:45 +00:00
74dcc87393
Triage several tests in NonErrorResolverTest_Kernel.
...
I opened several issues for missing errors and providing actual source
span, not just single offset. We need them anyway, and it is better to
let the FrontEnd know about them sooner, so that they have time to
plan implementing them.
https://github.com/dart-lang/sdk/issues/31626
R=brianwilkerson@google.com
Bug:
Change-Id: I9238a06c8489679fa2a19f853ead2a2b93c39e39
Reviewed-on: https://dart-review.googlesource.com/29042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-13 15:38:48 +00:00
fe7e7df11c
Give function expression elements unique names to ensure unique identity.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I1bf76b14a63e35403629bb5864f7f1122cf28d5e
Reviewed-on: https://dart-review.googlesource.com/29002
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-13 15:37:47 +00:00
ebddad2329
Fix fasta parser recovery of redirection in non factory
...
Change-Id: Ia9943fb3c600a042b71bd2901cf962c06f61b523
Reviewed-on: https://dart-review.googlesource.com/28940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2017-12-13 15:24:55 +00:00
ccc20bedf5
Apply resolution to function typed formal parameters.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I512bd3aca390d7b8b25dec595d0d7b580ea31fde
Reviewed-on: https://dart-review.googlesource.com/28960
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-13 02:36:29 +00:00
fa265c892e
Triage some failing tests
...
Change-Id: Ia6ef2b687b4eb5abc5d88a58b8416a6b4c9e2bb8
Reviewed-on: https://dart-review.googlesource.com/28860
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-12-12 23:17:01 +00:00
f6338287ab
Apply resolution to constructor redirection.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Idb9c6c7f43bda03864b9a2ba291b5dba6e45f637
Reviewed-on: https://dart-review.googlesource.com/28841
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-12 20:28:49 +00:00
b1fce8078e
Enable strong mode when previewDart2 is enabled
...
Change-Id: I2d26dec1e3e4dc7a32ef51ff740211032919adb1
Reviewed-on: https://dart-review.googlesource.com/28524
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-12 14:08:40 +00:00
c284c428bb
Add fasta parser type parameter recovery
...
Change-Id: I6363aa558b2ac6dec3fb3c7ba1abd82dd8e98874
Reviewed-on: https://dart-review.googlesource.com/28060
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-12 14:06:40 +00:00
b427e02609
Apply resolution to (real) redirecting constructors.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I6993d549b9b8a459923fa3d72eace63e93cff1cd
Reviewed-on: https://dart-review.googlesource.com/28460
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-12 05:46:06 +00:00
3be5621449
Handle method invocations that cannot be resolved because of missing type information
...
Change-Id: I07f22964b07f38fee37ab28ff205f227f50b3024
Reviewed-on: https://dart-review.googlesource.com/28500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-12 01:23:33 +00:00
b8b9073e24
Fix for named arguments for InstanceCreationExpression.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ie9433fdd0f1ea2dfd65fa6bd1f44b9356d0a402e
Reviewed-on: https://dart-review.googlesource.com/28364
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2017-12-11 22:50:33 +00:00
fbe4151da4
Handle member references that cannot be resolved because of missing type information
...
Change-Id: I3599846476c082a533882f6d8d18e1adeb70fa3c
Reviewed-on: https://dart-review.googlesource.com/28383
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-12-11 22:21:53 +00:00
d58e9735bc
Apply resolution to 'dynamic' type literal.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I5ca078942c4841f7df8c66261acab3d103cefece
Reviewed-on: https://dart-review.googlesource.com/28365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-11 21:52:53 +00:00
5c580dbe21
Remember explicit static get/assign Class and offset.
...
Revert merging ResolutionApplier with ValidatingResolutionApplier.
Bug:
Change-Id: Ie55ebdcb5d63be26720156a28a68f2727ebc96d3
Reviewed-on: https://dart-review.googlesource.com/28380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-11 21:46:13 +00:00
bc836ba30e
Triage comment failing comment references tests as a FastaProblem.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/31604
Change-Id: I9750673cae3287e3d13534d549c8fec01263b6a7
Reviewed-on: https://dart-review.googlesource.com/28363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-11 19:11:09 +00:00
b0d520314e
Run tests with previewDart2 enabled and update failure list
...
Change-Id: I580545037a820e37fe22288177b289371c6ce645
Reviewed-on: https://dart-review.googlesource.com/28320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-12-11 17:57:23 +00:00
fd5a780898
Parse documentation comment references
...
Change-Id: I35912533db63c3bd681099715e60c94e7af5939a
Reviewed-on: https://dart-review.googlesource.com/28040
Reviewed-by: Dan Rubel <danrubel@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-10 23:08:56 +00:00
94fdf7dfe3
Apply types to top-level variables.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I93577570ae2b1cf1c2a5a837128378f1e2ce785f
Reviewed-on: https://dart-review.googlesource.com/27961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-09 23:49:35 +00:00
7e22dbf1f9
Apply KernelType(s) based on function type alias.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I8cb26120cfc7d58f1d59e0034fbe0d94c7422478
Reviewed-on: https://dart-review.googlesource.com/27927
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-08 23:28:20 +00:00
6c23d21a4c
Upgrade test_reflective_loader to 0.1.3
...
Update test expectations for tests that pass.
R=brianwilkerson@google.com , devoncarew@google.com
Bug:
Change-Id: If822e47146c438c57eb8dd45554a019f01fdca89
Reviewed-on: https://dart-review.googlesource.com/27921
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Devon Carew <devoncarew@google.com >
2017-12-08 21:28:10 +00:00
d1a265ba93
Partially fix the copying of constructor-based annotations
...
Change-Id: I31a6077b7d046fb36dafbff173e3c6861efa5b67
Reviewed-on: https://dart-review.googlesource.com/27900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-08 20:06:10 +00:00
62e5c677a8
Enable previewDart2 in static warning code kernel tests. Others passing.
...
Enable previewDart2 and annotate all @potentialAnalyzerProblems.
Also fix two of the @failingTests related to
https://github.com/dart-lang/sdk/issues/31073 which appear to be
passing now.
Bug:
Change-Id: Ic2fd534c8a9cf45eccf0f5d09dc47cd4e78aaf42
Reviewed-on: https://dart-review.googlesource.com/27468
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2017-12-08 18:31:58 +00:00
39b3e79dfe
Apply resolution to CatchClause.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I0203f510802b9b258da608231957c9383f677360
Reviewed-on: https://dart-review.googlesource.com/27503
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2017-12-08 16:56:18 +00:00
31dfab26e2
Fix for applying resolution to MapLiteral.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Icc213c310ae49ac315ed6772f88a16337d441475
Reviewed-on: https://dart-review.googlesource.com/27410
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-08 05:53:49 +00:00
af4b9b8436
Translate FunctionType and InterfaceType references.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ib0814e8c25234fea4d8a3685c96b481f27d3af03
Reviewed-on: https://dart-review.googlesource.com/27413
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-08 00:09:49 +00:00
14c730d9de
Apply resolution to constructor parameter default values.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I9241e86963e9821fa914f4daef8717a67328cadb
Reviewed-on: https://dart-review.googlesource.com/27409
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-07 23:19:39 +00:00
8b37075fd4
Gracefully handle some cases of missing data
...
Change-Id: I56d8d2395b416663d1580239e4d35683b5dfd583
Reviewed-on: https://dart-review.googlesource.com/27440
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-12-07 23:09:49 +00:00
2f39ad2f74
Apply types to FunctionTypeAlias.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Id7be33790dcb07952738c83ac6ebdeaa8659e1fd
Reviewed-on: https://dart-review.googlesource.com/27405
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-12-07 21:56:40 +00:00
76e3d55b10
Apply type to TypeParameter bounds.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ica3501ae8a38d7956948d4c7aa7afaaa7421f9af
Reviewed-on: https://dart-review.googlesource.com/27403
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-07 21:04:34 +00:00
be50952130
Apply types to FieldDeclaration type annotation.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Iec0dd5dc72bd221a27fae9f8083c32f1798843f6
Reviewed-on: https://dart-review.googlesource.com/27401
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-07 20:33:23 +00:00
950891fd2f
Apply resolution to enums.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I1cf5aed4fdecae1d660ec2717b6c98ca69603959
Reviewed-on: https://dart-review.googlesource.com/27380
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-07 20:04:49 +00:00
87f4f462bf
Apply types to ClassTypeAlias.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: If6d0b4d9886b9e217e57cd6076ddadbfc39ad8cf
Reviewed-on: https://dart-review.googlesource.com/27320
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-07 19:33:11 +00:00
0a6253312f
Check for @alwaysThrows when evaluating for dead code.
...
The meta package version 1.1.0 includes a new `alwaysThrows`, which developers
can use to annotate methods that always throw. This helps to avoid erroneous
DEAD_CODE warnings from analyzer.
Bug: https://github.com/dart-lang/sdk/issues/31384
Change-Id: I70e2469b4f3a0d2c87064851160b268ea2259807
Reviewed-on: https://dart-review.googlesource.com/26563
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-07 19:29:18 +00:00
031ef9821c
Apply types to ClassDeclaration in DeclarationResolver..
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I27dc21e877aee21c3012db58b02c52feeecb40fe
Reviewed-on: https://dart-review.googlesource.com/27300
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-07 18:57:50 +00:00
129710e565
Run NonErrorResolverTest_Kernel with FrontEnd resolution.
...
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I07473ddea5f2b56291fb7f735994397afccab1a8
Reviewed-on: https://dart-review.googlesource.com/27280
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2017-12-07 18:09:27 +00:00
1ba0dbdb8a
Improve local variable recovery some more
...
Change-Id: I0b1bb3e956e501416cbc786ccfc0ab98ead27946
Reviewed-on: https://dart-review.googlesource.com/27200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2017-12-07 16:07:46 +00:00
87a3998f71
Improve local variable recovery
...
Change-Id: Ib3d84d2e40bbadee6bf1ccf81c6afb9669765e84
Reviewed-on: https://dart-review.googlesource.com/26901
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-12-07 15:28:15 +00:00
1cd64fd472
Implement fasta parser parseDirectives
...
Change-Id: Ic8d9ba44184f66c90086b0b46df0ce9f43bd9282
Reviewed-on: https://dart-review.googlesource.com/26660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2017-12-06 18:21:40 +00:00
Sam Rawlins