dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

3034 Commits

Author SHA1 Message Date
Paul Berry e2d0f5a50b Add featureSet parameter to Parser constructor. 
And deprecate old parser configuration setters.

Change-Id: Ib1507b8d2b20be7c883061e2a92ec9205d6a378f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100664
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-29 16:42:19 +00:00
Konstantin Shcheglov f598581e41 Support for type parameters in function typed formal parameters. 
See also https://github.com/dart-lang/sdk/issues/28515

R=brianwilkerson@google.com

Change-Id: I4365a159a969b5cb77b755a9dad8602a9992ab7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-27 18:05:16 +00:00
Paul Berry 986978ad8e Additional FeatureSet plumbing for parser_fasta_test.dart 
Change-Id: I6d0ff3f1b4a342717fd809f828db75401f9f0337
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100442
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-26 20:16:45 +00:00
Brian Wilkerson c6cc447e98 Convert StaticWarningCodeTest to use DriverResolutionTest 
Change-Id: I2e5f282d79e7048984edbcd866ac4a8312e82b5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100626
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-26 18:18:35 +00:00
Paul Berry c5e57cc078 Plumb FeatureSet through resolver 
Change-Id: I796b09469c2167122f535718e5ffacb1dc4dd012
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-24 17:21:37 +00:00
Paul Berry 296505e2e3 Sort declarations in pkg/analyzer/test/generated/parser_test.dart 
Change-Id: Iee4ae779ddc94c0022ff04273bb54b84d2ec0eb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100403
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-24 17:18:32 +00:00
Brian Wilkerson e42c5d12fe Cleanup tests by removing references to enabled experiments and by reducing duplication 
Change-Id: Ic7eb96e1724d2a51469e41760856d4194e3379e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-24 13:20:36 +00:00
Paul Berry cee1e41fe8 Plumb new FeatureSet class into Scanner. 
And change clients of the scanner (within the SDK) to use it.

Long term, it would be better to store the FeatureSet object directly
in the Scanner and remove the existing flags `enableGtGt` and
`enableNonNullable`.  However there are analyzer clients that
currently use these flags.  So for now, we simply plumb in the
FeatureSet as a new way of setting AstBuilder flags.  Once we've
updated clients to use FeatureSet, we'll publish a breaking version of
the analyzer that removes the old flag API.

Change-Id: I9e662f4ed45668d9acd4f56e42d7d8dae6180d48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99975
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-23 16:13:43 +00:00
danrubel 8b6d04b2ee sort tests 
Change-Id: I598ea625cc7dce757906f2f7fbef0c5d186ee462
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99969
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Dan Rubel <danrubel@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-04-22 20:54:23 +00:00
Dan Rubel ec79fc2ff4 update AstBuilder to process "late" modifier 
Change-Id: I97530583b059a39d502469079940ffc5b8d4db71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-22 19:34:33 +00:00
Dan Rubel 08832508ec Forward "late" modifier to parser listeners 
... and update parser tests to use preNonNullable feature set
to address comments in https://dart-review.googlesource.com/c/sdk/+/99963

Change-Id: I3a3293d65805807b7b95e887f829f3f0080ae3b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99964
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-22 17:20:10 +00:00
Dan Rubel fd48001ace Put NNBD modifiers behind a flag 
Fix https://github.com/dart-lang/sdk/issues/36691

Change-Id: I48aa72eb6a4aa63d072089baaf99d249763095fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99963
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-22 15:31:09 +00:00
Paul Berry d50232a3f5 Plumb new FeatureSet class into AstBuilder. 
And change clients of parser and AstBuilder (within the SDK) to use
it.

Long term, it would be better to store the FeatureSet object directly
in the AstBuilder and remove the existing flags `enableNonNullable`,
`enableSpreadCollections`, `enableControlFlowCollections`, and
`enableControlFlowCollections`.  However there are analyzer clients
that currently use these flags.  So for now, we simply plumb in the
FeatureSet as a new way of setting AstBuilder flags.  Once we've
updated clients to use FeatureSet, we'll publish a breaking version of
the analyzer that removes the old flag API.

Change-Id: I6d37177c40b1a1216956e95f473252aa218d10b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100000
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-22 13:38:59 +00:00
Paul Berry 780f1b6c3e Remove unused imports 
Change-Id: Ia34e9d49e1baffe96a7da72a663f6751de31fc36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100041
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-22 13:29:19 +00:00
Brian Wilkerson c3f822eae6 Attempt to fix failures on the windows bot 
Change-Id: I668e62e5b866b83bba24a8406ffcaca4450eeb46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-21 19:42:17 +00:00
Brian Wilkerson 47a8ff60e1 Convert more analyzer unit tests 
Change-Id: Ie457491e24bc8820d24c533342b0d74edb922370
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/100001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-21 15:29:17 +00:00
danrubel a2e06eafff allow built-in keywords as identifier in for-in loop 
Fix https://github.com/dart-lang/sdk/issues/36678

Change-Id: I2af3a21e96c5654b12c199fc71d87f088e9d739d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99904
Auto-Submit: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-19 19:07:11 +00:00
Konstantin Shcheglov 92729e0cd3 Remove UndefinedTypeImpl. 
And corresponding DartType.isUndefined as well.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I85debe627e989b5a5671becf5d9dd16413562236
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99729
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-18 17:42:28 +00:00
Konstantin Shcheglov 7b6b8f8c43 Restore 'parameters' and 'typeParameters' for ParameterElementImpl. 
This partially reverts https://dart-review.googlesource.com/c/sdk/+/5000
which was done during moving toward integration with Kernel, which
we don't do anymore.

With summary2 the FunctionType of a function type parameter is purely
synthetic, without its original element. However parameters in
function typed parameters still exist as nodes, so they must have
elements.

R=brianwilkerson@google.com

Change-Id: I6689b05459f3989a20839346013c80a86ac8dc7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99709
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-04-18 14:10:18 +00:00
Dan Rubel b8a9711489 Update AstBuilder to handle "required" modifier 
Change-Id: I68a3f0abd405119ccc52dc9263860129fff7453a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-17 21:19:51 +00:00
Dan Rubel ca28e2c8ce forward "required" modifier to parser listeners 
... and have each report an error by default

Change-Id: If818a7bb207becbed95a97890632a1803917d285
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-17 21:19:51 +00:00
Dan Rubel 81e554ea43 parse "required" modifier for NNBD 
This updates the parser to recognize the "required" modifier
but always reports an error when it is detected.
A subsequent CL will update the listeners to handle the new modifier.

This also cleans up ModifierContext initialization
and adds a new pseudo-keyword-used-as-type test

Change-Id: I83f9a6b410c2bfb3476e691d3e8482bf7c97b0dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99643
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-17 17:54:00 +00:00
Brian Wilkerson b9eb7c312c Add nullability testing methods to TypeSystem 
Change-Id: I6451468eafedddb75a7012f328d730836694bdd4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99380
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 20:32:05 +00:00
danrubel 0b6c61dbd3 tests for issue 36055 
Change-Id: I1ccd5deb6cff6e046895220ffdd03842ec5c20d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-15 19:28:45 +00:00
Brian Wilkerson ec0447db5d Add support for using ExpectedError and convert a couple of tests over to use it 
Change-Id: I04a89cc922e0046dee4d7e9f964f272cfc60a055
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-15 02:17:44 +00:00
Brian Wilkerson ea8d6e6fa9 Rename some error checking methods 
Change-Id: I5a750c16a8c49d724f964efa5184a3d82abce8ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-04-14 15:10:33 +00:00
Paul Berry 22a843a23d Fix precedence of postfix "!" operator 
Change-Id: I00446e15cd7e19285b35742a1936c36b1faf4774
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99282
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-13 16:20:22 +00:00
danrubel 2e7bd1359d parse dart language version comment 
This updates the parser to recognize a language version comment
of the form

// @dart = <major>.<minor>

as specified in
https://github.com/dart-lang/language/blob/master/accepted/future-releases/language-versioning/language-versioning.md#individual-library-language-version-override

Change-Id: I884620ac7da86025f5b408bcba8dd1f77e4c523c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99261
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-13 13:09:22 +00:00
danrubel 5dd89ef9a0 fix invalid var init parser recovery 
Fix https://github.com/Dart-Code/Dart-Code/issues/1548

Change-Id: Ib593c17fa8dfcee3c8ad139b72ceff56497d43a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99093
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-11 18:42:02 +00:00
Paul Berry b6dbdfa62d Fix test in preparation for constant-update-2018. 
This will prevent a spurious error when the flag is enabled.

Change-Id: I2f432844b5d41d7a13aff04644193341a5be69c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98942
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-04-09 15:03:33 +00:00
Brian Wilkerson 830ec419b6 Cleanup warnings and sort a few files 
Change-Id: Ie781e1dff7eb079311b833d4a13f7a1d38ef0515
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98603
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 17:51:36 +00:00
danrubel fe2d66006d improve type-before-factory error message 
Address comment in https://dart-review.googlesource.com/c/sdk/+/98449

Change-Id: I38e7cf04e2061dbd6c9b37cca713e8420a1e021d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98520
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-03 16:30:18 +00:00
Sam Rawlins 8aabbf39e5 Move last meta-based hint code tests to diagnostics: 
* INVALID_FACTORY_ANNOTATION
* INVALID_FACTORY_METHOD_IMPL
* INVALID_USE_OF_PROTECTED_MEMBER
* INVALID_USE_OF_VISIBLE_FOR_TEMPLATE
* INVALID_USE_OF_VISIBLE_FOR_TESTING
* MISSING_REQUIRED_PARAM

Change-Id: I3bb556f140dd61d8c707ae8db7ec2ce36d01ed97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98451
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-04-02 18:18:49 +00:00
danrubel 725c070632 report error on type reference before factory keyword 
This updates the parser to report an error if there is a type reference
preceding the factory keyword.

Fix https://github.com/dart-lang/sdk/issues/36400

Change-Id: Iba04f68bba8d260444d55168322d67a600feba53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98449
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-04-02 15:39:29 +00:00
Sam Rawlins 75b2f9f919 Move more HintCode tests to individual files: 
* DUPLICATE_IMPORT
* IMPORT_DEFERRED_LIBRARY_WITH_LOAD_FUNCTION
* NULL_AWARE_*
* OVERRIDE_*

This puts non_hint_code_test alllllmost at empty.

Change-Id: Iade3a2fd29b484d711556ff688a6386789a50d0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98289
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-04-01 16:54:55 +00:00
Brian Wilkerson 3642eddca1 Create an experiment flag for triple-shift and move existing support for the operator behind the new flag 
Change-Id: Ibff112644921618f8d21b0b1b8eb6332a590bfab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98305
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-29 21:51:40 +00:00
Brian Wilkerson 1b2a4b8eb1 Convert some tests to DriverResolutionTest 
Change-Id: I0fdccb13b95b6e5047030ba084d4358c65a8e72f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98303
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-29 17:11:38 +00:00
Brian Wilkerson 0560014c79 Remove unused error codes 
Change-Id: I47daa6dab610af657ca781db5ca88438988c3c87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98162
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-29 15:37:26 +00:00
Brian Wilkerson d0fda82493 Clean up some of the unused task model support in test code 
Change-Id: I2a70070866e38377a4dd149b6407942e3f81c92d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98049
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-28 17:13:45 +00:00
Brian Wilkerson 4555cf788d Convert one more set of tests 
Change-Id: I4854985bd475d95c17be83e648bf5716d6156fbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98020
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-27 17:37:41 +00:00
Brian Wilkerson 5f0de26d48 Clean up the remaining copyright notices 
Change-Id: If099be4f71ba551df0dc3d69815ae6a9f55d1eba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97781
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-24 20:11:28 +00:00
danrubel 36e6eb36c5 rename and reword invalid initializer error messages 
Change-Id: Ieae7b11f6aee46567247dbc9532098e7541774b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97720
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-23 15:59:43 +00:00
danrubel 466b6884dc add scanner/parser support for >>>= 
Change-Id: I8bbf19e70f35aba600cb768fc3c7537f2aa604e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97602
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-22 23:38:51 +00:00
Mike Fairhurst c22c2b7645 Test that set/list if elements/else elements get implicit casts 
Change-Id: Ia8b7b02645a9288d09573b19b89787d5e61fc143
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97546
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2019-03-22 17:21:36 +00:00
danrubel f3ac707aea report error for invalid super/this initializer 
This reports an error for two more invalid initializer situations
to address comment in https://dart-review.googlesource.com/c/sdk/+/97404

The comments about error message text will be addressed in a subsequent CL.

Change-Id: I45785ae7de4adfdb63a238383e6accf465bd8a74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-22 13:40:10 +00:00
danrubel 4cd410d6ac add parser listener handleErrorToken event 
Change-Id: I11ae5f8d25248b9cc3586edbc6e49037d99bb5a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97555
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-22 13:36:35 +00:00
Mike Fairhurst 3678efae60 Test that map if elements/else elements keys/values get implicit casts 
Change-Id: I920400f6924a48364d09cfc9f27dfff57bbe9044
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97523
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-03-22 07:17:13 +00:00
Konstantin Shcheglov fa74184b7a Verify that constructor initializers use only potentially constant expressions. 
...but don't evaluate them, because they don't have to be constants.

R=brianwilkerson@google.com

Change-Id: I5bc44a02947c1682da85c1f22b3fc28b52b13370
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97549
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-22 02:50:43 +00:00
danrubel 8b8a8f7b4e Report error for invalid this/super in initializer 
Fix https://github.com/dart-lang/sdk/issues/36262

Change-Id: I20b0997f58a2835b87869952f186fbe83bfe5e3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97404
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-03-22 01:43:13 +00:00
Mike Fairhurst 602ac1226d Check if element conditions for downcasts 
Change-Id: Ie1277f0efd5b327d1d068c0f8ce21f377313ee82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97543
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-03-21 20:49:12 +00:00