Commit Graph

14 Commits

Author SHA1 Message Date
Konstantin Shcheglov 9f986d2501 Migrate package:analyzer to null safety.
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2021-02-01 18:56:04 +00:00
Sam Rawlins 1b130f47c1 Analyzer: Prepare some manually lazily initialized fields etc for null safety
* Add `/*late final*/ hints for fields which are manually lazily
  initialized in a public getter.
* Switch List(size) constructor with [] list literal.
* Force a few non-nullable types.
* Remove `null` assignments in embedder_tests.dart which change type of
  fields.
* Remove `null` Tokens in tests where null should not be.

Change-Id: I260657d222f6b8ca10e31d06991dc9e2cb575e5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/171140
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-12-10 01:14:48 +00:00
Konstantin Shcheglov a12fd560b7 Implement allowedExperimentsJson for EmbedderSdk.
https://github.com/flutter/engine/pull/18830

Change-Id: Iab1a3dd319da12d192a042b75a8ff6affc4d11cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150169
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-06-04 23:29:12 +00:00
Konstantin Shcheglov 364dd8936b Fix unnecessary_new in analyzer.
R=brianwilkerson@google.com

Change-Id: I70f80baa3da4b14c0a52c1f28da16a9ad26d7dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-12-06 01:11:30 +00:00
Nate Bosch 6c36630958 Update to latest package:yaml
Closes #38958

Tweak an analyzer test that fails after the update. There is a change in
package:yaml where map keys are now iterated in the order they are
defined in the file rather than an arbitrary order based on hash codes.

It is not clear to me whether this is safe or if it indicates a deeper
bug in the analyzer.

Change-Id: Ie02f1bc4277999f991583f9019e67ef70c33a895
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122029
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2019-10-18 20:40:48 +00:00
Brian Wilkerson 469e1e2e64 Remove unnecessary library directives
Change-Id: I7a157080e4d7fd80d64489a13de4e996b5870930
Reviewed-on: https://dart-review.googlesource.com/c/79474
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-10-13 00:44:04 +00:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt.
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
2017-07-13 16:28:18 -07:00
Konstantin Shcheglov 5455fd0118 Remove 'initializeTestEnvironment' from 'analyzer'.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2399913002 .
2016-10-06 10:18:54 -07:00
Brian Wilkerson ef2a3b982c MemoryResourceProvider always uses the current platform
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2391883002 .
2016-10-03 19:24:21 -07:00
Brian Wilkerson 5bd4de469e Clean up warnings and hints
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2324463006 .
2016-09-09 09:09:59 -07:00
Paul Berry 94309733cd Revert "Remove unnecessary hide clauses"
The `Resource` class wasn't removed from the SDK until version
1.20.0-dev.0.0, which was only recently published.  Reverting this
change to allow people using older SDK releases a little more time to
upgrade.

This reverts commit 2cdafd82c2.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2299243002 .
2016-09-01 16:08:43 -07:00
Brian Wilkerson 2cdafd82c2 Remove unnecessary hide clauses
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2305453002 .
2016-08-31 16:44:52 -07:00
Konstantin Shcheglov ce5a17ab63 Attempt to load sdk.ds from the only embedder.
And return it only in strong mode.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2277003003 .
2016-08-25 09:08:00 -07:00
Chris Bracken 5a936f26ea Extract EmbedderRelatedTest to a utility file
This avoids importing all the embedder_test tests for tests where only
EmbedderRelatedTest is required. It also simplifies automatically globbing
utility code vs tests.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2254313002 .

Committed: https://github.com/dart-lang/sdk/commit/8e35cbf413a25814bf3ebb4aea945a66156139a5
2016-08-18 13:38:34 -07:00