dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

8489 Commits

Author SHA1 Message Date
Konstantin Shcheglov 3dacbae99e Use 'isRequiredNamed' for FunctionType subtyping. 
Change-Id: I3d8ca70be7f782e1574535e463f9049ddd0e28a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124285
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-07 00:17:53 +00:00
pq e93bf30171 fix deprecated messages for implicit getters/setters 
Fixes: https://github.com/dart-lang/sdk/issues/39267

Change-Id: Iad0f22f4da8239a0d802d7b3d951afb42a5c8965
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-11-06 21:43:51 +00:00
Konstantin Shcheglov 3e3a926690 Fix spread and Set/Map literal disambiguation when NNBD. 
Fixes https://github.com/dart-lang/sdk/issues/39120
Fixes https://github.com/dart-lang/sdk/issues/39117
Fixes https://github.com/dart-lang/sdk/issues/39115

Change-Id: Ice9c525b2584940b66e9afe2c593bd41852026c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124207
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-06 19:20:44 +00:00
Konstantin Shcheglov 89dd099cad Update TypeParameterElement.== as discussed, add tests. 
Change-Id: I53e0f36bb3f11875a220f457f4c2205eae8ef2ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-06 18:32:13 +00:00
Mike Fairhurst 5134490b78 [analysis_server] add crash reporting 
Change-Id: I8005e87f75eecb0e8320d6db124256c8c7c509d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123549
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-05 21:07:33 +00:00
Sam Rawlins d3f19cf7ae Reland "Enable visibleForTesting on unnamed constructors" 
This is a reland of de7ad46797

Original change's description:
> Enable visibleForTesting on unnamed constructors
> 
> Fixes #37936
> 
> Change-Id: I99023b66d7d53922edecfbab7be41d4c4145ec15
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114591
> Commit-Queue: Samuel Rawlins <srawlins@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Change-Id: I1ac1dad28dab1b35dcc0a1cd69e64076b758c6a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122591
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-11-05 19:20:43 +00:00
Mike Fairhurst 7ba5584c2e [analysis_server] Fix outdated desin Service->Server, use Service->Logger. 
Also multiplex the service rather than the logger, so that we can
multiplex a crash reporting instrumentation service with a file logging
instrumentation service.

Change-Id: I7720c55e26225c27d2d9447a0156b2ca83da6598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122100
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-04 21:31:26 +00:00
Konstantin Shcheglov 8119253f64 Include space after comma in FunctionType.toString(). 
R=brianwilkerson@google.com

Change-Id: I6a30f98c11bc85d2c1afb0d86ba40160e11e85e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-04 19:00:26 +00:00
Konstantin Shcheglov c38dafec6b Issue 39051. Implement isAbstract for ConstructorElement. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39051
Change-Id: I1ed42bd7c95fc3b7a359d9125c4c1eb3ce9f594c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124084
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-04 18:18:56 +00:00
Konstantin Shcheglov abb1a17c89 Include FeatureSet into unlinked API signature. 
R=brianwilkerson@google.com

Change-Id: I3c5898e1500b6a70689ef7068de2b88bae69b90c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124080
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-04 18:06:16 +00:00
Sam Rawlins 48d44af154 Report error if inheriting from FutureOr. Fixes #33745 
Change-Id: Ia78892e48c6268d944cfb8f5b4afd25f37c95b7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123883
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-04 16:32:26 +00:00
Konstantin Shcheglov 5a3c4002b8 Replace 'bottom' with 'Never' in subtyping tests. 
Change-Id: I592b2c9ca50d4c320adcc337b667aef4d1ccf644
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-04 15:08:18 +00:00
Konstantin Shcheglov 2438fe10cb Rename BottomTypeImpl to NeverTypeImpl. 
The corresponding element is Never, and the spec says "the type Never".

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Icb6427ef13fa6ee74bd07d5345e68402a1b90b6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-03 19:03:02 +00:00
Johnni Winther a996783de5 [cfe+analyzer] Move StackListener to _fe_analyzer_shared 
Change-Id: I7e0ebef15b904afc14ed3b1c0f72cde5389d9c59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123730
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-11-02 11:21:49 +00:00
Paul Berry b3ed442f70 Fix some unnecessary imports of front_end in analyzer 
Change-Id: I9d45dffffafca7799055b3db165200c2a8454537
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123841
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-01 13:54:22 +00:00
Paul Berry 2ad5af1e13 Move resolve_relative_uri.dart into _fe_analyzer_shared 
Change-Id: I2d9cc3988fd16ce1aabd6881c825d1917bb16848
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123861
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-11-01 13:54:22 +00:00
Paul Berry c4b6df5009 Move ID testing infrastructure into _fe_analyzer_shared. 
Change-Id: I9f2692dbe750f3c31f8c86e86fe732f34e166517
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123860
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-01 12:39:00 +00:00
Johnni Winther 00c2962db8 [cfe+analyzer] Move messages, scanner and parser to package:_fe_analyzer_shared 
Change-Id: I4fa87aee65f30a9868a6cf8f0342591869ece7ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123663
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-11-01 09:37:57 +00:00
Mike Fairhurst 924ec34e01 Remove analysis logger, replace with calls to InstrumentationService 
Change-Id: Ifddd58b731aa0af8f76a91261757997dc52a9fc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123328
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-31 21:26:44 +00:00
Konstantin Shcheglov 09bc0cc5ab Issue 38734. Don't report IMPLICIT_THIS_REFERENCE_IN_INITIALIZER for late fields. 
Bug: https://github.com/dart-lang/sdk/issues/38734
Change-Id: If942d831cf4c64c873026cb2010406656d20565b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123688
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-31 21:20:11 +00:00
Konstantin Shcheglov 84a8a2db33 Issue 39192. Fix codeLength / codeOffset, store it into the cached data. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/39192
Change-Id: I17fe30839dd8a51c047103e028eea145ced1ec87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123689
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-31 20:03:58 +00:00
pq d7def97773 typo 
Change-Id: I9ecb419895e8e722afc47df4090b7fa0dec1524b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-31 17:55:23 +00:00
Konstantin Shcheglov 9b15195448 Inline CompialtionUnitElementImpl.getTypeFromTypes 
R=brianwilkerson@google.com

Change-Id: Ifa3386f19e69fd424f73a4f092438353709ae7e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-31 17:14:33 +00:00
Konstantin Shcheglov f8ab10b322 Remove CompilationUnitElementImpl.replaceTopLevelVariable 
Change-Id: I598fff647524fb8c6737d4eeed9ca9d0fc863913
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123623
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-31 14:31:43 +00:00
Paul Berry 5b4612bc68 Move front_end/lib/src/base/errors.dart into _fe_analyzer_shared package. 
Change-Id: I9369e8dbf7b5d6fff9ad2a74346871b3e274e8ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123640
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-31 13:05:53 +00:00
Paul Berry 499815842c Create a package to hold code shared between front_end and analyzer. 
Previously such shared code was in the front_end package, but that
created problems because there is a lot of code in front_end that
isn't intended to be shared with the analyzer (including, notably, the
dependency on kernel).

This CL just moves over the flow_analysis logic to the new shared
package.  Follow-up CLs will move over other shared logic and tests.
The end goal is that the analyzer package will no longer have a
dependency on front_end.

Change-Id: I5642d6565204422d79808ca47648462db85e442a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123624
Reviewed-by: Jens Johansen <jensj@google.com>
 2019-10-31 13:05:53 +00:00
Johnni Winther d76ffbc149 [cfe] Handle assigned variables in for and for-in 
Change-Id: I06deda7f017dcd40e5c6987c61261cf3be2be0ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123410
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-31 11:36:43 +00:00
Konstantin Shcheglov decca61f8c Deprecate TypeDefiningElement.type except ExecutableElement. 
Change-Id: I7888f7ff796f1c4523cdc7030451dfc3ab622970
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122729
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-31 05:09:13 +00:00
Konstantin Shcheglov 2f6de17113 Add extensions to LibraryElement.topLevelElements 
R=brianwilkerson@google.com

Change-Id: I543a2e8d49cf083a5222b3664f81d31197c4077f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123551
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-30 22:12:45 +00:00
Konstantin Shcheglov fb362b54a7 Stop using FunctionTypeAliasElement.parameters/returnType in analyzer. 
The goal is to stop implementing FunctionTypedElement in
FunctionTypeAliasElement, and keep only TypeParameterizedElement.

For some time we will have to keep implementing TypeDefiningElement, it
is used currently as a marker for top-level declarations.

Change-Id: I0062aaa66861a4d7dd5337eb9a44338ad49f5901
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-30 21:36:33 +00:00
Brian Wilkerson bbe273081c Report a diagnostic when the length getter in a constant expression is defined in an extension (issue 39170) 
Change-Id: Ice1f0620abda8bcbb2b04c3e8912e4c8e36acdca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123542
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-30 21:09:23 +00:00
Konstantin Shcheglov 2b903a6bfd Add more subtype tests. 
Change-Id: I4908e161255afd9f5e9fc161d2c73dc88f0f15ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123561
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-30 21:03:23 +00:00
Konstantin Shcheglov 79900aea3a Remove AstBuilder.localDeclarations 
R=brianwilkerson@google.com

Change-Id: Ic814dac169f2f1ee97e0561c085e92a5984332d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123543
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-30 19:49:13 +00:00
Konstantin Shcheglov e01ba33faf Remove CompilationUnitElementImpl.localDeclarations 
Change-Id: I8c283d7997a26093dff6909a396ec0dee6d13c41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123469
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-30 18:54:08 +00:00
Konstantin Shcheglov 948e1da54c Remove _HasTypedefSelfReferenceVisitor, already computed during linking. 
Change-Id: Iecf75e52e1c41fc88df84aaa09951cceb9d4b114
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123468
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-30 18:46:13 +00:00
Konstantin Shcheglov 4495165191 Always return some GenericFunctionTypeElement from GenericTypeAliasElementImpl.function 
This will help with invalid cases like `typedef F = int;`.

I plan for FunctionTypeAliasElement to stop implementing FunctionTypedElement,
so stop implementing `parameters` and `returnType`, which currently
do the correspoding workaround. Instead clients will ask
`function.returnType`, and I'd not like to make null-aware in many places.

Change-Id: I3ae9abe4778e530fb02e66f32e4d52f7b57ffeb4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123484
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-30 18:46:04 +00:00
Paul Berry d50c158d42 Flow analysis: fix analyzer "desugaring" of try/catch/finally statements. 
Flow analysis requies the client to desugar a try/catch/finally
statement into a try/catch statement nested inside a try/finally
statement (or, in the analyzer's case, to make calls to flow analysis
as though such a desugaring has been done).  The analyzer was doing
this incorrectly:

- It was always calling the flow analysis methods for try/catch, even
  if there were no catch clauses present.

- When calling tryFinallyStatement_finallyBegin for a
  try/catch/finally statement, it was passing in the node associated
  with the original try block (prior to "desugaring").  It needs to
  pass in the node associated with the desugared try block (which
  includes the catches).

Includes a similar fix in the migration engine.

Fixes #39178.

Change-Id: I16440e71d4964b9905fc2316380c8c98f14b13f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123506
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-10-30 16:30:04 +00:00
Paul Berry 9be1920abf Flow analysis: Fix AssignedVariables handling of try/catch/finally in analyzer. 
A corresponding fix needs to be made to the front end as well.  For
now I've used the "analyzer." and "cfe." prefixes in the test case to
note the differences.

Change-Id: I00d42b224577dea67ee198a3c68c775b631e2b29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123504
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-10-30 11:46:14 +00:00
Paul Berry 0d6a59950d Account for possible AST rewrites during type resolution of forEach loops 
Fixes #39171

Change-Id: Id7ab65e22747926ead38c778275d7456c54b0f5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123483
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-29 21:45:36 +00:00
Brian Wilkerson 12f424f194 Apply updates to previous CL 
Change-Id: I69f2fd5f26c42d166b1b2f2dfb0bc576305eb3f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-29 19:39:36 +00:00
Brian Wilkerson 19cab51a4b Check for undefined unary operators in extension overrides (issue 39158) 
Change-Id: I3808cdaeb523902bd3f23112ca91b3fe3efa7dcb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123462
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-29 18:52:26 +00:00
Brian Wilkerson d639388366 Arguments to extension overrides cannot have type void (issue 39156) 
Change-Id: I907c706bf994cac5a60ec74bc1c22939ffa868e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123461
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-29 18:49:46 +00:00
Konstantin Shcheglov 4a07d80178 Deprecate ParameterizedType.typeParameters, update typeArguments doc. 
Change-Id: I76c02e026c6c566def4f33478ef18f7df9d1d96e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123323
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-29 17:39:59 +00:00
Konstantin Shcheglov 7e53b2703a Replace TypeParameterMember.from() method. 
Change-Id: Iea0a71badab18178807dd1adc43866f0d9f41a95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123332
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-29 16:15:36 +00:00
Konstantin Shcheglov 60b7102d31 Simplify evaluating TypeName in ConstantVisitor. 
Change-Id: Id71404512671f6efdd48ced377137f5bea9d6390
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123331
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-29 16:15:26 +00:00
Paul Berry 12532e327f Analyzer ID test fix: annotate methods properly. 
This avoids the need to special case test expectations for CFE in
pkg/front_end/test/flow_analysis/reachability/data/never_return_type.dart.

Change-Id: Ib754a76c96e73c8183b5ff10a2e7d2908e653a31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-10-29 14:58:14 +00:00
pq 0a828c7497 context workspace caching 
Change-Id: Ia0c5a4446e79f48b2cbd76d84e503b03751d5b76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123326
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-29 13:50:27 +00:00
Paul Berry 780af0fcfc Flow analysis: promote to "types of interest" on assignment. 
This allows so-called "ensure guarded" promotions, e.g.
- `if (x is! int) x = 0;`
- `if (x == null) x = 0;`
- `x ??= 0;`

The latter two are particularly important to prepare for NNBD.

Change-Id: Ib53ca916e6d485945326b19e86f8cfb5b3ee2160
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123280
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-10-29 13:23:59 +00:00
Johnni Winther c8ff1b0c21 [cfe] Add BlockKind to parse/begin/endBlock 
... and use this to computed AssignedVariables data for try statements

Change-Id: I235575b055cb89b553baf0ac728d9954d8d0aaa6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123251
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-10-29 09:17:06 +00:00
pq 669375b269 linter context package api 
Change-Id: I77b4a0f5df461d1fee7e2ebdab6df005f27e0e16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-10-28 22:17:39 +00:00