Commit Graph

8489 Commits

Author SHA1 Message Date
jwren@google.com ed38678776 Collect analysis errors from change notifications.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//202633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33780 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 22:14:25 +00:00
jwren@google.com c3cb70a124 Fix batch mode to now print out errors, this gets us closer to the FYI bot passing
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//200423006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33725 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 22:20:44 +00:00
scheglov@google.com d160c5b259 Forgotten change in analyzer.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//200613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33711 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 19:44:39 +00:00
jwren@google.com b3be009788 Restore batch mode in the Dart-based Dart analyzer
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//200523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33709 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 19:09:22 +00:00
scheglov@google.com 206c643c4e Analyzer snapshot with disabled 'this.field' generation.
This should help to workaround https://code.google.com/p/dart/issues/detail?id=17483 is Spark.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//200583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33708 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 18:22:14 +00:00
jwren@google.com b39018a1ba New verbose flag for the dart command line analyzer
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//196223004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33656 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 17:13:09 +00:00
scheglov@google.com b058e9b442 New analyzer snapshot.
It includes optimization that Jaime made today.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//198453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33636 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 06:34:29 +00:00
pquitslund@google.com 8a54c6f9d2 Fix handling of 'else if' statement blocks (dartbug.com/17363).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//196983003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33613 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 21:11:30 +00:00
jwren@google.com 84de116968 Nit change in the Dart command line analyzer and analysis server.
Logger.logError takes a String, not Error types.  This will enable the exception to be printed, instead of the message '<SomeError> is not a String'.

Also, in the command line version of the dart analyzer, I put in a commented out stdout/stderr logger for developers.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//196373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33587 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:30:23 +00:00
pquitslund@google.com 979ef447b0 Formatter space/tab width configuration fixes (dartbug.com/16969).
R=brianwilkerson@google.com, danrubel@google.com

Review URL: https://codereview.chromium.org//196243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33586 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:25:45 +00:00
jwren@google.com 978872b5ad Convert the command line dart analyzer to be async.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//195483004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33558 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 22:05:37 +00:00
scheglov@google.com f68715dd64 Increase Dart based command line analyzer cache size to 512.
R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//195563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33554 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 21:07:57 +00:00
scheglov@google.com 0d6637eb53 Translate Java's @Override into Dart's @override.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//192363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33474 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-10 02:20:23 +00:00
scheglov@google.com 34255da9a2 Support for @DartName and @DartOptional annotations.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//192303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33472 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-10 01:12:42 +00:00
scheglov@google.com 844751f9ed Support for DartBlockBody, DartExpressionBody, DartOmit in java2dart.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189433006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33468 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 23:53:28 +00:00
jwren@google.com dbed544450 Analzyzer test fixes
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//189443009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33464 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 23:18:17 +00:00
scheglov@google.com a674327095 Translate private Java members to private Dart members.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189803004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33453 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 20:59:57 +00:00
jwren@google.com f4a2d2ae9b Change to dart command line analyzer- Remove the rich toString in AnalyzerError to prevent .contents from being called on a source.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//189913004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33452 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 20:55:25 +00:00
scheglov@google.com 151c4c3a7d Improved 'has' properties translation.
New analyzer snapshot.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33399 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:18:26 +00:00
scheglov@google.com 9d622fc1d9 Unroll 'synchronized {}' in java2dart.
...and corresponding 'analyzer' snapshot.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//185403018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33318 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 02:30:21 +00:00
scheglov@google.com 12558a8511 New analzyer snapshot.
Replace isInstanceOf() with a predicate.

Tweaks for other packages.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//186153005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33304 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 21:50:40 +00:00
scheglov@google.com 1f8c20a04d Update and analyzer snapshot with AST -> Ast rename.
R=brianwilkerson@google.com, rnystrom@google.com, blois@google.com, karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//185603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33296 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 20:02:28 +00:00
scheglov@google.com 79e687be71 Add timing info for file IO into Dart based analyzer.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//179123010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33191 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-01 19:47:36 +00:00
scheglov@google.com 7f73657ad6 New analyzer snapshot.
No 'isInstanceOf' changes yet.
Just current state with changes required to adopt to the API changes in Java.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//184893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33176 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 22:52:15 +00:00
scheglov@google.com a2ff040825 Option to disable Angular in Dart-based Analyzer.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//175793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32936 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 22:32:28 +00:00
pquitslund@google.com ca7f5ebf71 Support for removing empty statements (dartbug.com/16810).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//169283013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32918 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 19:20:32 +00:00
pquitslund@google.com 7b7b87ed97 Fix to ensure decls with initializers get their own lines (dartbug.com/16849).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//170403004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32873 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 22:46:24 +00:00
scheglov@google.com 27fcf8df64 Issue 16827. Add 'set length' to NodeList.
https://code.google.com/p/dart/issues/detail?id=16827

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//170723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32746 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 17:06:50 +00:00
scheglov@google.com 1c5bdef314 Fixes for exit problems.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//135593009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32446 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 19:32:51 +00:00
pquitslund@google.com 79f352e4c2 Constructor initializer indent fixes.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//141443011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32396 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 00:15:24 +00:00
pquitslund@google.com 18c4e5c74e Fixes for empty class and method bodies.
See Kevin's nits CL for more context: https://codereview.chromium.org/153623006/

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//151243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32378 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 19:28:18 +00:00
scheglov@google.com bd4d6033ba New analyzer snapshot.
1. Rename WorkManagerPriority -> SourcePriority.

2. Replace CharSequence with String.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//156763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32373 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 18:09:20 +00:00
scheglov@google.com a85da5e2d8 New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//131233009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32362 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 15:31:22 +00:00
scheglov@google.com 5f9e9b47e5 Fix for JavaFile path in DDA.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//156503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32361 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 15:08:29 +00:00
pquitslund@google.com eaae0b64dc Fix to ensure no breaks after new and general zero-length space support (dartbug.com/16379).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//156033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32332 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 18:41:14 +00:00
pquitslund@google.com 5c26be4b49 Indent fix for trailing comments (dartbug.com/16383).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//153203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32287 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 20:50:12 +00:00
pquitslund@google.com 07888b2f25 Indent fix for switch statement defaults (dartbug.com/16406).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//150533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32174 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 21:39:28 +00:00
pquitslund@google.com 18ad816d5f Max line length test fix (dartbug.com/16405).
The rub: two off by ones! --- Proof that two wrongs don't make a right! :)

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32166 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 18:35:17 +00:00
pquitslund@google.com 9d5f39180c Empty map formatting fix (dartbug.com/16382).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32143 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 22:02:26 +00:00
pquitslund@google.com 4260d5a585 Fix to allow single method cascades to fit on one line (dartbug.com/16384).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32138 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 20:57:44 +00:00
scheglov@google.com becf22691a New analyzer snapshot.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//147903005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32135 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 20:03:33 +00:00
pquitslund@google.com d6d365cdcc Format fix for assert statements.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//149363007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32133 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-29 19:46:52 +00:00
pquitslund@google.com b66342b854 Remove workaround for missing setter function returns (dartbug.com/15914).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//145953006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32091 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 22:51:27 +00:00
pquitslund@google.com 99595ef86b Remove workaround for missing abstract keyword for ClassTypeAliases (dartbug.com/15912).
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//144743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32086 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 22:25:38 +00:00
pquitslund@google.com 13961dc1f6 Improved linebreaking for imports (darbug.com/16366) and non-breaking line support.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//147983005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32084 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 21:37:05 +00:00
scheglov@google.com 37b6debef7 New analyzer snapshot.
There are some problems with JDT and line comments.
Interesting, that it works almost everywhere, and also worked coupld weeks ago.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//137143010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32052 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-28 04:24:41 +00:00
pquitslund@google.com aac07d9e6b dartfmt line wrapping bypass option support.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//139263011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32034 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-27 22:23:52 +00:00
pquitslund@google.com f04199eda4 Line pre-chunking.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//132983008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31941 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-18 00:17:12 +00:00
scheglov@google.com 3ad3ff9a2e New analyzer snapshot.
Extracts SdkLibrariesReader_LibraryBuilder into sdk.dart library.
https://code.google.com/p/dart/issues/detail?id=14791

R=brianwilkerson@google.com, devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//135653008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31939 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-18 00:05:43 +00:00
pquitslund@google.com 7605b96c4b Interpolated String hack-around.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//136453008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31846 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 19:18:25 +00:00