Commit Graph

8489 Commits

Author SHA1 Message Date
scheglov@google.com 39c3a6c255 Issue 22886. Quick fixes create getter' and 'create field' for hints.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22886

Review URL: https://codereview.chromium.org//1024573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44585 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 18:16:04 +00:00
scheglov@google.com 505b83a377 Rewrite ImplicitConstructorBuilder to use only element model.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1022843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44583 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 18:11:33 +00:00
brianwilkerson@google.com e9dfd7e3b1 Clean up comments in element_resolver
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1019643004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44574 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-19 14:41:57 +00:00
scheglov@google.com abaf8171cc Task: Resolve Type Names.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1023503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44566 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 21:50:43 +00:00
scheglov@google.com 10a83e55c4 Task: Build Type Aliases.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1012403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44565 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 20:49:26 +00:00
scheglov@google.com 47d33ecd72 Add public and export namespaces to LibraryElement.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1023443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44563 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-18 19:25:51 +00:00
scheglov@google.com 8fba9fa5a4 Task: Create Export Namespace.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1017743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44545 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 22:22:27 +00:00
scheglov@google.com a151c5d495 Move PublicNamespaceBuilder into tasks.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1002393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44543 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 20:47:09 +00:00
keertip@google.com fe5c9fdfd5 fix for getting node for class element
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1007563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44539 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 17:00:05 +00:00
brianwilkerson@google.com 80913d8fa0 Clean up comments in constants.dart
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1017633003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44536 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 15:30:15 +00:00
scheglov@google.com c6a760de66 Task: Build Export Source Closure.
It's result will be used later to compute EXPORT_NAMESPACE for each library.
One of the inputs of the task computing EXPORT_NAMESPACE is a map of each source from EXPORT_SOURCE_CLOSURE to its PUBLIC_NAMESPACE.

It will require also changes to NamespaceBuilder to replace direct
AnalysisContext.getPublicNamespace(LibraryElement) with an externally provided function.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1012993004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44535 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 14:54:01 +00:00
brianwilkerson@google.com 1ff4ead0f6 Rename ContributionPoint
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1012993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44534 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 14:52:45 +00:00
scheglov@google.com 2c7348f585 Use PUBLIC_NAMESPACE for computing TypeProvider.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1013973003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44533 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-17 13:56:33 +00:00
scheglov@google.com 8910e64632 Start analyzing LibraryUnitTarget(s) from BuildLibraryElementTask.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1018443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44529 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 23:39:48 +00:00
rnystrom@google.com aea99bdfa1 Remove the old formatter from analyzer.
BUG=https://code.google.com/p/dart/issues/detail?id=22401
R=brianwilkerson@google.com, pquitslund@google.com

Review URL: https://codereview.chromium.org//1001403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44522 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 20:03:33 +00:00
scheglov@google.com 970cff5002 Fix ErrorProperty enum.
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1010873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44512 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 18:14:39 +00:00
scheglov@google.com ef2a41217d Add NOT_INITIALIZED_FIELDS property for FINAL_NOT_INITIALIZED_CONSTRUCTOR_X.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1004793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44511 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 17:49:19 +00:00
scheglov@google.com 5432c74cd6 Add readAsStringSync() to File.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1007233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44506 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-16 15:01:52 +00:00
scheglov@google.com dfb5713b95 Include the common library name used in 'part of' directives.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1012543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44496 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-15 23:38:31 +00:00
scheglov@google.com 3c49c97afc Task: Build Enum Member Elements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1009693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44494 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-15 19:19:50 +00:00
scheglov@google.com 384b8ce7f1 Compute TYPE_PROVIDER using BuildTypeProviderTask.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1009033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44492 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-14 03:10:48 +00:00
scheglov@google.com 9d05d623ec Use AnalysisDriver to run task tests.
It's much more concise now.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1007993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44482 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 21:58:14 +00:00
brianwilkerson@google.com 2fe598c6ea Fix line info for multi-line strings (issue 22794)
R=pquitslund@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1000913004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44481 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 21:54:16 +00:00
brianwilkerson@google.com 01dadf8285 Provide value for values field in enums (issue 22722)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1007013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44479 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 21:47:37 +00:00
brianwilkerson@google.com 4dac0013c0 Fix hints
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1008583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44447 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 21:58:22 +00:00
scheglov@google.com adc6b6c4fa Rename ListToX inputs.
Also harder the GenerateTaskInputs interface.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1000203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44446 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 21:57:30 +00:00
scheglov@google.com 9e69ee59f5 Use Map.addAll() where possible in the resolver.
I accidentally bumped into it and found out that Map.addAll() was added since the (first?) translation.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//996053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44442 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 21:38:21 +00:00
brianwilkerson@google.com 3b922a53ac Correctly compute whether a class subclasses Function (issue 22805)
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1001063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44439 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 19:01:16 +00:00
scheglov@google.com 11f6cd218c Task: Build Directive Elements.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1008433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44436 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 18:27:46 +00:00
scheglov@google.com 2679bf65d5 Add MapBasedTaskInput.
I found out that I'm blocked by its absence.
To resolve directives (actually to report errors) I need to know source kinds.
And the only way to get the SourceKind of a Source is to request a Map-based input.

If you have already implemented it yourself, feel free to upload your CL instead.
I'm not too much attached to this implementation :-)

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//997383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44429 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 15:11:42 +00:00
brianwilkerson@google.com a839a34199 Deprecate utility method
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1000873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44428 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 14:39:54 +00:00
brianwilkerson@google.com b75e60037c Comment clean-up in sdk model
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1004543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44420 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-12 03:44:02 +00:00
brianwilkerson@google.com 9ee8b81bf1 Another pass over scanner comments
R=scheglov@google.com

Review URL: https://codereview.chromium.org//999913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44414 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 21:18:42 +00:00
scheglov@google.com 40dea00f27 Task: Build Public Namespace.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//998053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44413 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 21:02:55 +00:00
brianwilkerson@google.com 0a35aec78f Fix type promotion (issue 22732)
R=paulberry@google.com

Review URL: https://codereview.chromium.org//991033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44410 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 18:01:25 +00:00
scheglov@google.com fb848271cd Add FunctionElement.isEntryPoint getter.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//997203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44407 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 17:21:12 +00:00
scheglov@google.com e834e4194f Task: Build Library Element Model
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//994293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44406 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 16:57:13 +00:00
paulberry@google.com 29c0fb7cd6 Add an analyzer option to properly check ".call" methods.
Enabling this option fixes issue 21938.  For now the option is
disabled by default, since there is a lot of code in the dart SDK (and
in third_party) that isn't warning clean with this option enabled.
Once the SDK and third_party code have been cleaned up, we should be
able to turn this option on permanently.

BUG=dartbug.com/21938
R=scheglov@google.com

Review URL: https://codereview.chromium.org//994253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44390 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-11 00:35:31 +00:00
paulberry@google.com f8a99cde53 Don't suppress error/warning output for package being analyzed.
BUG=dartbug.com/22761
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//987413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44385 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 21:48:49 +00:00
scheglov@google.com 9f3ff6a1a7 Fix for matching field formal parameters.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//995853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44381 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 17:36:56 +00:00
brianwilkerson@google.com c729e56d66 Clean up parser comments
R=scheglov@google.com

Review URL: https://codereview.chromium.org//995003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44374 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 15:33:45 +00:00
jwren@google.com dbcce3568e Fix for dartbug.com/22656- analysis.flushedResults implementation.
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//987143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44373 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 14:54:00 +00:00
scheglov@google.com 339476c61f Wrap dart:io exception in getChildren(), implement for the memory FS.
...for consistency.

Plus tests.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//989393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44358 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 04:30:56 +00:00
scheglov@google.com d81d792c14 Implement 'node' for ClassElement and FieldElement for enums.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//987263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44356 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-10 03:07:05 +00:00
brianwilkerson@google.com a75e87a430 Fix introduced bug
R=scheglov@google.com

Review URL: https://codereview.chromium.org//979193004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44341 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 20:22:10 +00:00
brianwilkerson@google.com 3d9ce7e534 Fix for issue 22709
R=scheglov@google.com

Review URL: https://codereview.chromium.org//993633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44338 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 19:18:00 +00:00
brianwilkerson@google.com d954183441 Change all sources associated with changed files (issue 22680)
R=paulberry@google.com

Review URL: https://codereview.chromium.org//981283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44335 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 18:28:21 +00:00
brianwilkerson@google.com 2bff66aa0f Clean up comments in error support
R=scheglov@google.com

Review URL: https://codereview.chromium.org//990793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44321 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-09 14:48:29 +00:00
brianwilkerson@google.com e2cc65949f Clean up doc comments
R=scheglov@google.com

Review URL: https://codereview.chromium.org//989883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44312 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-08 15:25:20 +00:00
scheglov@google.com 24c14e7f2e Test for GetContentTask.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//988993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44310 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-07 17:25:18 +00:00