beea8076cd
Migrate more of server
...
Change-Id: I6342016847257ae95314e97b2f31186c43f10e6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-04-08 19:05:30 +00:00
90e54dee18
InstrumentationLogger in InstrumentationLogAdapter is not null.
...
Change-Id: Ie4ab159002c74796429e5176cd09abdcd1a90ad7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184382
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-02-11 17:44:05 +00:00
9f986d2501
Migrate package:analyzer to null safety.
...
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-02-01 18:56:04 +00:00
000f3135a5
[analyzer] Remove unused dart:async imports
...
Change-Id: If21c3a30f3bc521586ad01f8f9e241038e7aa7eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/161448
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-09-02 17:14:22 +00:00
041e0dd618
Analyzer: Enforce strict-inference
...
Change-Id: Iba49bfa7cf10f8a3b1d3be03e73fdca280f0940a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155062
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-07-22 00:44:55 +00:00
83378633e1
Add the attachment with the content of the file being analyzed.
...
Change-Id: I75b1c61e2d04cd5e03ef4375e97ef3c9f4add874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138384
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-03-10 04:57:20 +00:00
2d332ee1d3
Make private fields final where possible
...
Change-Id: I16ee52f1b23e8d708e40cb482c5150f1e04d2417
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128524
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-12-17 06:12:39 +00:00
364dd8936b
Fix unnecessary_new in analyzer.
...
R=brianwilkerson@google.com
Change-Id: I70f80baa3da4b14c0a52c1f28da16a9ad26d7dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-12-06 01:11:30 +00:00
e68ca9b652
[analyzer] move crash reporting to server because telemetry isn't pulished
...
Change-Id: I8fb293632267e7991c578076a43bfbd277fc1ee1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124461
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-11-07 22:19:07 +00:00
5134490b78
[analysis_server] add crash reporting
...
Change-Id: I8005e87f75eecb0e8320d6db124256c8c7c509d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123549
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-05 21:07:33 +00:00
7ba5584c2e
[analysis_server] Fix outdated desin Service->Server, use Service->Logger.
...
Also multiplex the service rather than the logger, so that we can
multiplex a crash reporting instrumentation service with a file logging
instrumentation service.
Change-Id: I7720c55e26225c27d2d9447a0156b2ca83da6598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122100
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-11-04 21:31:26 +00:00
924ec34e01
Remove analysis logger, replace with calls to InstrumentationService
...
Change-Id: Ifddd58b731aa0af8f76a91261757997dc52a9fc7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123328
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-10-31 21:26:44 +00:00
6f38a73618
Remove most of the task model.
...
I run presubmit, and it does not look to me that any failin tests
are caused by this CL.
https://test.corp.google.com/ui#id=OCL:267824456:BASE:267824473:1567923135217:2380181a
R=brianwilkerson@google.com
Change-Id: I838f2174460e0d06c85bbb83de9037113c0b6393
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116252
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-09 18:26:50 +00:00
8f90265176
de-lint collection size checks
...
Change-Id: Id8e7ce2ec59ad7cd2b0b9c961594a37d4fef621a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108522
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-07-10 13:46:43 +00:00
632a94967a
Log when LSP drops invalid notifications to the instrumentation log
...
Change-Id: I8388bf7fe42134fd20d9c7b9727a1f47e4d5a277
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107285
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-06-28 12:42:05 +00:00
5f0de26d48
Clean up the remaining copyright notices
...
Change-Id: If099be4f71ba551df0dc3d69815ae6a9f55d1eba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97781
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-03-24 20:11:28 +00:00
469e1e2e64
Remove unnecessary library directives
...
Change-Id: I7a157080e4d7fd80d64489a13de4e996b5870930
Reviewed-on: https://dart-review.googlesource.com/c/79474
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2018-10-13 00:44:04 +00:00
f6d2c2378a
Add awaits in async methods to restore previous semantics
...
Change-Id: I7711cd878a31df0fb0c92572e2256c0a26923640
Reviewed-on: https://dart-review.googlesource.com/59480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2018-06-08 19:58:07 +00:00
dd897d35a2
Move the task API out of the public API
...
Change-Id: I0fbafb4965ced89fb9a063edb773c3f1cb3a39fa
Reviewed-on: https://dart-review.googlesource.com/51242
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-04-16 18:18:08 +00:00
602a8c2a7b
Clean up usage of deprecated constants
...
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2018-03-09 01:02:49 +00:00
62d0376231
Run the sorter to reduce code churn
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2933753002 .
2017-06-12 07:37:14 -07:00
d7d3ee40dd
Report plugin errors to the instrumentation service
...
R=mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2913913002 .
2017-05-31 08:01:07 -07:00
5659afc812
Make instrumentation data structure more regular
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2890193002 .
2017-05-18 09:09:17 -07:00
3b2c3ae5b2
Add support for built-in plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2874803003 .
2017-05-10 13:31:20 -07:00
a3102bf441
Add support for reporting plugin data to instrumentation
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2834453002 .
2017-04-19 11:01:24 -07:00
c91736b8e5
Fix bugs and add instrumentation
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2748683003 .
2017-03-13 10:12:25 -07:00
8f36669937
Add instrumentation data to the analysis server diagnostics page.
...
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2717253002 .
2017-03-10 14:08:14 -08:00
74686371b3
Add support for getting the sessionId from instrumentation and sending it to the client
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2359233002 .
2016-09-22 10:26:13 -07:00
a3ed9fe569
Optimize more megamorphic dispatch sites
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/2015513003 .
2016-05-25 10:49:11 -07:00
c07b21d03b
Dangling comment reference cleanup in analyzer.
...
First pass with the new `comment_reference` lint.
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1994243002 .
2016-05-19 10:24:53 -07:00
675c221140
Remove a couple of unnecessary is checks
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1906543002 .
2016-04-20 08:38:50 -07:00
f0d249e269
Clean up package imports and library names
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1513643009 .
2015-12-10 08:11:56 -08:00
c5f82b8376
Additional clean-up after moving to the new task model; a breaking change needed to allow a bug to be fixed
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org/1503203002 .
2015-12-07 12:02:42 -08:00
d49d0f7e06
Wait for InstrumentationService.shutdown() before exit(0).
...
Otherwise we don't get the last portion of instrumentation data in the
file at all.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org/1413403007 .
2015-11-04 10:08:20 -08:00
24b24a3569
Reformat code to reduce churn
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1322513004 .
2015-09-09 08:19:41 -07:00
9aa45d4cf0
Capture more data when instrumenting exceptions
...
R=lukechurch@google.com
Review URL: https://codereview.chromium.org//1257023003 .
2015-08-06 08:50:39 -07:00
2980c8839d
Improve logging performance
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//1152923002
2015-05-23 09:14:31 -07:00
279c20a625
Log details of calls to "pub list" to instrumentation.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//1079673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45080 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-10 21:50:45 +00:00
730390fb82
Overwrite local instrumentation file.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//977953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44243 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-04 18:19:23 +00:00
98b7382071
Reformat
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//975453004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44149 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-02 21:34:46 +00:00
5a4919c270
Add instrumentation (issue 22572)
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//956103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44071 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-26 19:54:36 +00:00
f5f408e412
send priority instrumentation message on startup with version info
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//859513002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43017 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-20 17:30:47 +00:00
81b8596681
Add indication of instrumentation active/inactive to analysis server status.
...
The instrumentation status shows up when querying the "/status" page, when analysis server is started with the "--port" option.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//847963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42879 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 18:23:22 +00:00
e07125e634
Report incremental/full analysis performance via instrumentation.
...
R=brianwilkerson@google.com , lukechurch@google.com
BUG=
Review URL: https://codereview.chromium.org//844683003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42784 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-12 18:28:11 +00:00
c63e50307a
Instrument file reads
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//825683005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42748 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 18:26:52 +00:00
9fb54ea3db
Capture log messages via instrumentation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//840553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42741 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-09 17:06:44 +00:00
501d449ecc
File-based and multicast InstrumentationServer implementations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//833633004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42718 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-08 21:58:41 +00:00
b2835b572b
Tweak for escaping in instrumentation.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//837753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42637 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 17:16:07 +00:00
fa896352ca
Escape field separator
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//835213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42634 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 15:37:20 +00:00
248d764ba5
Fix for issue 21982. Note the new instrumentation data tag.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//818733006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42608 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 19:56:45 +00:00
Brian Wilkerson