Konstantin Shcheglov
9bf55768f3
Deprecate ParameterizedType.instantiate()
...
We keep instantiate() for FunctionType(s), because they, and only they,
have type parameters.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ibc67ed63542a92f49e4cbc7c89d4b6489be4e249
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122727
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-10-24 20:42:07 +00:00
Konstantin Shcheglov
83b6026f9f
Deprecate DartType.substitute2()
...
Change-Id: I326f236391ab46539066eb58962efc501f4b53cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122724
Reviewed-by: Paul Berry <paulberry@google.com >
2019-10-24 19:40:49 +00:00
pq
0f2787c9f3
validation of @nonVirtual use
...
see: https://github.com/dart-lang/sdk/issues/34378
Change-Id: I0fe67c56bf7c08f211b6bf89d84c5495e32601a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122742
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-10-24 13:16:44 +00:00
Paul Berry
5d4cd6d589
Breaking changes for analyzer version 0.39.
...
Change-Id: Ifa9ca24487f93f3eb0ec95eeb64f5bbb5aa32714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113216
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-10-21 18:23:10 +00:00
Sam Rawlins
d9fa27a9ed
Update ~48 doc comments to have one-sentence summaries
...
From Effective Dart: Documentation:
* https://www.dartlang.org/guides/language/effective-dart/documentation#do-start-doc-comments-with-a-single-sentence-summary
* https://www.dartlang.org/guides/language/effective-dart/documentation#do-separate-the-first-sentence-of-a-doc-comment-into-its-own-paragraph
Change-Id: Ie49b2e6a2cad5c1d01a6cd625f91f89e4fcc39ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/69260
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-10-17 21:48:46 +00:00
Konstantin Shcheglov
9fe78bc9a8
Support for 'question' in FieldFormalParameter.
...
So, with 'question' token in AST, we can finish fixing the issue.
Bug: https://github.com/dart-lang/sdk/issues/38811
Change-Id: I9997be57c891c99c85dbfe3ef85871043fd3bffe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121884
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-10-16 23:04:56 +00:00
Konstantin Shcheglov
0881a4a691
Reland "Deprecate TypeParameterTypeImpl.getTypes()"
...
This is a reland of aa0bd58926
Original change's description:
> Deprecate TypeParameterTypeImpl.getTypes()
>
> Presubmit in google3 looks green.
> https://test.corp.google.com/ui#id=OCL:272795904:BASE:272795986:1570167013170:de765f48
>
> Change-Id: I9ef25658a8a8e806b7fcc23b8d9d4e1d297ebff8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120003
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Change-Id: Idbe4fb391711f2f3a03fe9fb32c136af71a7ef04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-07 17:28:45 +00:00
Devon Carew
73d880b949
[analyzer] add a quick fix for the prefer_relative_imports lint
...
Change-Id: Ic69ebe799f425fd09e002b65d66a4382f5f96ead
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120160
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2019-10-04 20:13:07 +00:00
Konstantin Shcheglov
3cdfd90481
Revert "Deprecate TypeParameterTypeImpl.getTypes()"
...
This reverts commit aa0bd58926 .
Reason for revert: https://dart-review.googlesource.com/c/sdk/+/119587 was reverted. So, this change now breaks bots because of deprecated
getTypes() usage in DDC.
Original change's description:
> Deprecate TypeParameterTypeImpl.getTypes()
>
> Presubmit in google3 looks green.
> https://test.corp.google.com/ui#id=OCL:272795904:BASE:272795986:1570167013170:de765f48
>
> Change-Id: I9ef25658a8a8e806b7fcc23b8d9d4e1d297ebff8
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120003
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=scheglov@google.com ,brianwilkerson@google.com
Change-Id: I3dc1a700f496c25eea9898de658a31138bbedcce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120141
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-04 16:04:07 +00:00
Konstantin Shcheglov
aa0bd58926
Deprecate TypeParameterTypeImpl.getTypes()
...
Presubmit in google3 looks green.
https://test.corp.google.com/ui#id=OCL:272795904:BASE:272795986:1570167013170:de765f48
Change-Id: I9ef25658a8a8e806b7fcc23b8d9d4e1d297ebff8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-10-04 14:32:25 +00:00
Konstantin Shcheglov
3f65652ad0
Enable avoid_init_to_null.
...
R=brianwilkerson@google.com
Change-Id: I983fdff71c47dbf2b271508955095a73cfbeee59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-30 14:26:06 +00:00
Paul Berry
ec2823d052
Make an interface type to represent promotable variables.
...
And updade flow analysis clients to use this interface, so that we
have no risk of accidentally trying to promote things that shouldn't
be promotable. (Previously we used VariableElement, which would have
allowed fields).
Fixes https://github.com/dart-lang/sdk/issues/38572 .
Change-Id: I225d3adabea503ca7eb9042516cf95d5a257fec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-09-27 20:54:00 +00:00
Kallen Tu
89220fd812
Variance Parsing and Syntax Support
...
With the experiment flag on, will properly parse the `in`/`out`/`inout`
keywords. Without it, will issue an error regarding the flag. First CL
for parsing, syntax support, no AST work yet.
Keywords only parse correctly for classes and mixins.
See test `variance_disabled_syntax_test.dart`.
Change-Id: I37d765804fa0752512abf52fa44456a173087ef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117929
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
Reviewed-by: Dan Rubel <danrubel@google.com >
2019-09-24 17:21:39 +00:00
Konstantin Shcheglov
a1fdfb8fc8
Move ClassElement.thisType to API.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Ib1b85e01159e93adbab8b3e186f30e939d462739
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117766
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-18 18:02:48 +00:00
Konstantin Shcheglov
6a9d792454
Move NullabilitySuffix to API.
...
R=brianwilkerson@google.com
Change-Id: I58547075d3472e6708e6b5ff1c6d89f768aba66a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-16 21:14:11 +00:00
Konstantin Shcheglov
405ff47ebe
Add ClassElement.isDartCoreObject, use instead of 'classElement.type.isObject'.
...
R=brianwilkerson@google.com
Change-Id: I1354e111debca5145f6fc54959c391e65a21cf05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117298
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-16 19:57:42 +00:00
Konstantin Shcheglov
aa318ee261
Add Class/TypeParameter/FunctionTypeAliasElement.instantiate() methods.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I4d8d065683d65e83484543798963c1bc3935422d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117209
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-14 19:06:25 +00:00
Mike Fairhurst
5beca80bc7
[analyzer] add isNullAware to IndexExpression
...
Change-Id: I3c3b1b0a38ea81fd573ec005e810eb2b000b3430
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2019-09-12 21:31:57 +00:00
Mike Fairhurst
2bc48ad1b6
[analyzer] add isNullAware to propertyAccess
...
Change-Id: Ia785a308e7281d6d17d05b38d52337f611708206
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116685
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-12 21:29:27 +00:00
Mike Fairhurst
68bcc00d10
[analyzer] implement isNullAware for method invocations
...
Change-Id: I630f94311a55b7a7fce5e47143e333abffe19c9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116681
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-12 21:21:22 +00:00
Konstantin Shcheglov
76e6325ae0
Remove unused methods of AnalysisContext.
...
Change-Id: Ie7f81ac09b51f7a4e70a32f962e6e15c81245820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-09-11 17:09:47 +00:00
danrubel
30ea777c65
fix parsing of "?.." cascade operator
...
Fix https://github.com/dart-lang/sdk/issues/37859
Change-Id: Ie29f4fd000199f0099137308603335e36af6ae26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116089
Commit-Queue: Dan Rubel <danrubel@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-10 20:36:04 +00:00
Mike Fairhurst
7413879026
[analyzer] Add getter isNullAware to SpreadElement
...
Change-Id: I89d644da2277b4527f32e176f9355cf16734dc64
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116380
Auto-Submit: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-10 03:20:19 +00:00
Konstantin Shcheglov
6bcf67a6a2
Move isLate to VariableElement.
...
R=brianwilkerson@google.com
Change-Id: I9228dc48a42d7daa08d96b8cd52949a817bcbeff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115272
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-09-03 21:31:54 +00:00
Sam Rawlins
7bc9515ac2
Fix CompilationUnitMember doc comment. Fixes #27170
...
Change-Id: I2aee1bb92e05fb780910ee319ff4e29b5a16de35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113946
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2019-08-21 16:44:11 +00:00
Paul Berry
468800f9d7
Refine the type of FunctionTypeAlias.declaredElement.
...
A FunctionTypeAlias is known to declare a FunctionTypeAliasElement.
This was already reflected in the type of
FunctionTypeAliasImpl.declaredElement, it just wasn't reflected in the
public API.
Change-Id: Ia1a01f91e8fccee261fceddfc8797c3be36f7ea1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113942
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-08-21 15:01:59 +00:00
Paul Berry
fecc4c8f2d
Breaking changes for analyzer version 0.38.
...
Change-Id: I93fbcb9e86c6c809c4610d2d90dc8bc8b69c45c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108162
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-15 19:42:31 +00:00
Paul Berry
edb7d0e1d4
Fix the documentation of TypeSystem.isAssignableTo
...
Change-Id: Ic3e7aae0a5ee9cfbd803366caf25fef48bcfea71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113045
Auto-Submit: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2019-08-14 18:44:52 +00:00
Brian Wilkerson
3e6e0bb368
Enhance the documentation to call out that some members of a class can now be members of an extension
...
Change-Id: Ie98e8331b265f4e3ce7af376bd21b11d842ad5b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113043
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-08-14 18:33:01 +00:00
Paul Berry
a5772382dc
Migration: refactor infrastructure for testing decorated types.
...
I have a lot more testing of decorated types to land in follow-up CLs;
this CL introduces a mixin containing helper methods that should make
that testing a lot easier.
Change-Id: I29c17ffb4af65498fcd85704dc404343429e09ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112847
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-13 16:49:14 +00:00
Konstantin Shcheglov
4bebfebdbc
Initial support for extension methods inference.
...
Only the case with ExtensionOverride is supported for now.
Still fixes some co19 tests.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I6c7c98f4839a1fc40504d93107648d952a4176d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111866
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-08-02 23:24:41 +00:00
Konstantin Shcheglov
a05ef7c0cc
Store inferred type arguments for tear-off(s).
...
This change passes pre-submit run over google3.
https://test.corp.google.com/ui#id=OCL:260993915:BASE:261043007:1564632838252:e80ace42
Change-Id: Ibef739f241fdb60a574da971961b1abe6abde9c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111402
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Nicholas Shahan <nshahan@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-08-01 18:25:39 +00:00
Konstantin Shcheglov
c4e423db48
Deprecate isSupertypeOf, flattenFutures, isAssignableTo of DartType.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I3028d79580602d5e4d64ca9f013b28173ad63787
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110756
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-07-31 22:47:41 +00:00
Konstantin Shcheglov
6a4d805df4
Implement 'Import Library' quick fix using DeclarationsTracker.
...
This reverts commit 143e5ef556 .
Change-Id: I3c575ff690fd8c8d93a90e50a451a6ec993c4164
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111305
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-31 22:14:21 +00:00
Brian Wilkerson
3fa3f0e62d
Enhance the comment for TypeParameterElement.bounds to capture information from a previous CL
...
Change-Id: I5d736f8078f3bfadb75d8b358952e0ea29d6e696
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111381
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-31 12:40:04 +00:00
Paul Berry
de013a4b51
Add an optional path parameter to parseString.
...
This is needed because some clients rely on the path showing up in
error messages.
Change-Id: I3746db3fc9eecef048b4e50c37b6a0b60a13dc7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110340
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-30 21:34:56 +00:00
Konstantin Shcheglov
48ce5c2f16
Deprecate isMoreSpecificThan() and isDirectSupertypeOf().
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I57a884f411d006ed720b372826288cf39c91901e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110752
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2019-07-26 23:52:27 +00:00
Konstantin Shcheglov
e1cb626127
Deprecate DartType.isEquivalentTo and replace with '=='.
...
There is just one use of it internally, in Angular, trivially fixable.
R=brianwilkerson@google.com , paulberry@google.com
Bug: https://github.com/dart-lang/sdk/issues/35331
Change-Id: If46ca0e3a9faaeca4c4721de908ae675c651e4b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-26 16:40:06 +00:00
Konstantin Shcheglov
800b734ee5
Add DartType.isDartCoreNum getter.
...
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: Iac0cfb3e3d97a0402fc52b041bac137adcc6b505
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110548
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-25 23:09:28 +00:00
Brian Wilkerson
8fb6f68f43
Support resolution of this
...
Change-Id: I491703d7dd7c6eed6eebf3597ba33d10cfdb2958
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110402
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-07-25 17:23:38 +00:00
Paul Berry
4c08c5026d
Expose DartObjectImpl.toFunctionValue() through the public API
...
Change-Id: Ib75a95b20e0abe2a13caa0867ecc60c192ebbbd9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110122
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-23 20:56:34 +00:00
Paul Berry
c37eebd011
Add a more "isDartCore..." getters to DartType.
...
Change-Id: I5c192b812e44f9b9f278bc3eaefddd8bc326cf6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-23 20:56:34 +00:00
Paul Berry
7b6c667863
Flow analysis: rework tracking of nullability.
...
We now track nullability via type promotion, e.g. by promoting from
`int?` to `int` to represent a non-nullable value.
I've added a few more unit tests of flow analysis that were helpful
while preparing this CL. I plan to add more tests in follow-up CLs.
A few behaviors are lost by this change:
- We no longer track whether a variable's value is exactly null
(previously the tests annotated such variables as "nullable", which
was a bit misleading). I'm not sure whether we really want this
feature or not; I've filed
https://github.com/dart-lang/language/issues/461 for discussion.
- Assignment of a non-null value to a nullable-typed variable no
longer promotes it to non-nullable. I think we want to get this
behavior back, but we'll need to add a little bit more machinery to
get it back (we need to allow assignments in general to promote.
I'll address in follow-up CLs. See
https://github.com/dart-lang/language/issues/440 for discussion.
- A promotion to non-nullable that happens during a "try" block is
lost if there is a "finally" block. I think we want to get this
behavior back, but we'll need to add a little bit more machinery to
do so, to allow promotions in general to be preserved by
try/finally. I'll address in follow-up CLs.
Change-Id: Ibc45d70043725697fbee063a8dcefb1179506e9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109780
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-07-21 04:09:14 +00:00
Brian Wilkerson
11bdc5ceab
Send context messages from server and plugins
...
Change-Id: I76b5c5697ee660980f3be7d8b3d4b99c2ffa2422
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108967
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Danny Tuppeny <dantup@google.com >
2019-07-15 15:27:43 +00:00
Konstantin Shcheglov
8b012ac780
Replace package mock in strings with files in tests/mock_packages.
...
R=brianwilkerson@google.com
Change-Id: I5240fbd90c8220d14ff41d6a98069f943e56aa6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108920
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-12 17:17:33 +00:00
Brian Wilkerson
28962e1e80
Support static fields in extensions
...
Change-Id: Id7897485e23f39e45918f6029b43a75e5327e0a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108764
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-11 21:47:25 +00:00
Brian Wilkerson
97587b554f
Update the element model to support extension methods
...
Change-Id: Ia3bd6a19514368b3e046fead2eed0a4d0bfb133d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108504
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-11 13:28:37 +00:00
pq
8f90265176
de-lint collection size checks
...
Change-Id: Id8e7ce2ec59ad7cd2b0b9c961594a37d4fef621a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108522
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-07-10 13:46:43 +00:00
Brian Wilkerson
480337106e
Implementation of extension override AST node
...
Change-Id: Ia4249512c3bc14a995179328603fb847c2fe768e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107925
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-03 14:01:07 +00:00
Brian Wilkerson
4f78ad90df
An initial and partial implementation of an element model for extensions
...
Change-Id: Id780bc64104690389a5af18f8acac8fc44536201
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-03 13:49:17 +00:00