dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

237 Commits

Author SHA1 Message Date
Konstantin Shcheglov 7374f441f3 Add TypeProvider.isNonSubtypableClass, deprecate TypeProvider.nonSubtypableClasses. 
Change-Id: I78beaaeb763c33420d84c33b0e87cd5310f99fea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193094
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-29 02:33:52 +00:00
Konstantin Shcheglov 11e922f761 Update a few documentation comments for elements to remove null. 
https://github.com/dart-lang/sdk/issues/45236#issuecomment-800564647

Change-Id: Ic9aa0b120cb0796ad1796c6f34aef8fc5360700a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-16 21:39:41 +00:00
Konstantin Shcheglov 3f5694c827 Issue 45141. Check for loadLibrary() using namespace. 
Bug: https://github.com/dart-lang/sdk/issues/45141
Change-Id: Ifb0825d66a560d0136873942f9666d3dc630b6c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189320
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-05 22:21:54 +00:00
Konstantin Shcheglov 959adec89d Deprecate FunctionTypeAliasElement. 
Change-Id: I52b49ecadc7217416341b7d7474ded5b36a8ca73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 19:08:36 +00:00
Konstantin Shcheglov e4643d5809 Deprecate ElementVisitor.visitFunctionTypeAliasElement() 
Change-Id: Ib5d364b77af7974d757626a0719604fa7ec1fec7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185902
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-19 22:21:15 +00:00
Konstantin Shcheglov 5ba061c4e1 Un-experiment null safety APIs. 
Change-Id: Ib1d0502458625e5569b057140b9a066cc9c0f0b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184642
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-12 18:23:12 +00:00
Konstantin Shcheglov 875af7c991 Deprecated TypeProvider.futureType2/listType2/etc 
Change-Id: Ia994be1e29b4d96b89d714beafcb9256a0cb4de6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-12 17:26:07 +00:00
Konstantin Shcheglov b4409ea3b4 Deprecate FunctionType.element/typeArguments 
Bug: https://github.com/dart-lang/sdk/issues/44629
Change-Id: I5009a1abd456f33738d3b5e2ecae24b269b20000
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182700
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-10 17:17:58 +00:00
Konstantin Shcheglov 9cbe1cafe0 Element.session can be nullable 
This is not convenient, and not nice, but it can be.
We have to accept that it can for now, and plan to make it better.

Bug: https://github.com/dart-lang/sdk/issues/44837
Change-Id: Icbd2d55b6690ed817b38a7768198c41ce36cf002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182960
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-04 22:02:29 +00:00
Sam Rawlins 43e4536ebb analyzer: Fix documentation for TypeProvider 
Text like "Future<Null>" turns into an HTML tag. Referencing the elements with
[] escapes the HTML and creates links for the user.

Change-Id: Ib20020f879ec1eef4a5d98e896f72b00242deac7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2021-02-03 21:53:59 +00:00
Konstantin Shcheglov 7313f905e3 Remove 'functionTypeAliasElement' from 'TypeSystem.instantiateToBounds2'. 
Change-Id: I402d55b1ccdc0178680406c5f6135b497115a1c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182603
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-03 19:54:29 +00:00
Konstantin Shcheglov 4c6f5f7658 Remove NullSafetyUnderstandingFlag. 
Bug: https://github.com/dart-lang/sdk/issues/40531

Change-Id: I197cfdf64c697a09bb9e0e3896f3ee5ac1967757
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168160
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-02 18:03:24 +00:00
Konstantin Shcheglov 9f986d2501 Migrate package:analyzer to null safety. 
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-02-01 18:56:04 +00:00
Konstantin Shcheglov 7f95c18812 Deprecate CompilationUnitElement.functionTypeAliases 
Change-Id: I0f13761adf3d1dfd18798d5b7549e64462be0b65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179360
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-14 22:38:23 +00:00
Konstantin Shcheglov 9717c775e4 Deprecate FunctionTypeAliasElement.function 
Change-Id: Id629afa92c6681ba796aed75b24c4251fd86810f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176140
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-14 22:26:29 +00:00
Konstantin Shcheglov 6606edee3c Add ElementVisitor.visitTypeAliasElement 
R=brianwilkerson@google.com

Change-Id: Id2e2fa118d5d9f363201aeb5384806bc6536c973
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176063
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-12-14 21:20:29 +00:00
Konstantin Shcheglov dee85df64d Basic support for elements/types of non-function type aliases. 
Change-Id: Ide8f2fff98f7f03375efad23df3ed79795c33a23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174681
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-04 23:32:02 +00:00
Konstantin Shcheglov 619e388a1d Breaking changes for analyzer version 0.41. 
Change-Id: Ib16351e05b498fa9879e6bb4c117638cde276bfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-29 17:08:16 +00:00
Erik Ernst f506071e34 Add DartType.alias{Element,Arguments} and class TypeAliasElement 
First step in implementing non-function type aliases in the analyzer:
Just add the new back-references in types, such that they can refer to
a type alias which was used to obtain the type, if any.

Next step: Preserve the aliasElement and aliasArguments in summaries,
next again: Create `TypeAliasElementImpl` and ensure that the parser
can create them.

Change-Id: I1bfbc2c3893e32c5b1826552361a0238aa2b4058
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/169380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2020-10-29 14:39:33 +00:00
Konstantin Shcheglov b155af2442 Update documentation for ElementAnnotation.element 
R=brianwilkerson@google.com

Change-Id: I166545cd2359370d2bfff5fdfaa36c5ce6950f52
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168129
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-17 17:37:15 +00:00
Konstantin Shcheglov aad1a677c0 Deprecate GenericTypeAliasElement 
See also https://dart-review.googlesource.com/c/sdk/+/166680

Change-Id: I6018f3bf5796dcc8ab059aab5b29d01e7336581b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-15 16:03:26 +00:00
Sam Rawlins 51840c501a Analyzer: add two checks for the @internal annotation. 
The meta package does not yet have an `internal` constant;
this CL just adds one to the mock packages for testing.

Two checks are implemented:

* Hint if an @internal annotation is found on an element which is
  already part of a package's public API (based on file path).
* Hint if an element annotated with @internal is exported from a
  package's public API.

The notion of "public API" is also implemented for each type of Package:
BasicPackage, BazelPackage, GnPackage, PackageBuildPackage,
and PubPackage.

Bug: https://github.com/dart-lang/sdk/issues/28066
Change-Id: Ifc2709028afcd241f59e802f5952539f717704c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/163126
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-18 23:04:06 +00:00
Konstantin Shcheglov 8ae9842e12 Deprecate ElementAnnotation.constantValue 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: Ifae6a614c20b703d9614d7ccc2f8b254bafcb070
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-28 21:52:19 +00:00
Brian Wilkerson d5088c0a8f Reland the CL to "Add a hint for the new Target annotation". 
This reverts commit 50946855dc.

The bug that caused dartdoc to fail has been fixed by restoring the
creation of the invalid field. An issue has been created to update the
dartdoc package to stop using the invalid field, and the field will
need to be removed after dartdoc has been updated and pulled into the
SDK.

Change-Id: Ia7e282972e541a33b379872fbcd57a137a9c8a25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160120
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-25 16:53:10 +00:00
David Morgan 50946855dc Revert "Add a hint for the new Target annotation" 
This reverts commit 351a1cc489.

Reason for revert: caused a generator to fail, b/166257389

Original change's description:
> Add a hint for the new Target annotation
> 
> Change-Id: I5d8723eead20bb68407ce2a23e8de6cb9ae8a4de
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159921
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>

TBR=scheglov@google.com,brianwilkerson@google.com

Change-Id: I16af4403867d31f731d1efafce2c0c2be405df9c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160102
Reviewed-by: David Morgan <davidmorgan@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
 2020-08-25 14:20:52 +00:00
Brian Wilkerson 351a1cc489 Add a hint for the new Target annotation 
Change-Id: I5d8723eead20bb68407ce2a23e8de6cb9ae8a4de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159921
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-24 18:04:47 +00:00
Konstantin Shcheglov 085076337b Add LocalVariableElement/PropertyInducingElement.hasInitializer, ParameterElement.hasDefaultValue, deprecate VariableElement.initializer 
Change-Id: I02ba37b4f6f1ce79ffddf40613646b99ecbedc9d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159582
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-21 18:20:30 +00:00
pq 37c1da672c element model support for @doNotStore 
Change-Id: Ic69dcee22de76540d7034a0a9265cb22ea325b4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159184
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-19 04:50:14 +00:00
Konstantin Shcheglov a51f1747e0 Prepare to publish analyzer 0.40.0 and _fe_analyzer_shared 8.0.0. 
Change-Id: I126207dcc47885565a3a6d7002ff15ad3cc493c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-18 15:12:10 +00:00
Konstantin Shcheglov 95d47368ec Add LibraryElement.featureSet 
This generalizes `LibraryElement.isNonNullableByDefault`.
I don't have yet plans to remove it though.

R=brianwilkerson@google.com

Change-Id: I6385a568f87e449c9c18e7d93802463567322bfe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158369
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-13 01:06:48 +00:00
Paul Berry b7d139a626 External variable support: add a notion of external top level variables to the AST and element model. 
In follow-up CLs I will update error reporting logic.

Change-Id: Iee42088beffee3915a2ef6a4c8cb5c1031535d4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158149
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-08-12 15:59:24 +00:00
Paul Berry d4e4abdef6 External field support: add a notion of external fields to the AST and element model. 
In follow-up CLs I will update error reporting logic.

Change-Id: Id07b861aa117b93e0c869ad0b52c048085706ee6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157801
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-08-10 21:54:54 +00:00
Paul Berry b5a3292260 Abstract field support: add a notion of abstract fields to the AST and element model. 
In a follow-up CL I will update error reporting logic.

Change-Id: I6fd2916c24a531b1f41bd2872301ffec1fdb8722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157382
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-08-06 02:19:46 +00:00
Konstantin Shcheglov caaa2a752b Add TypeVisitorWithArgument and DartType.acceptWithArgument(). 
Bug: https://github.com/dart-lang/sdk/issues/40478
Change-Id: I2a8d196bf3ba41f771e390acb7eade5cdd5f1e6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156563
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-30 21:33:04 +00:00
Brian Wilkerson 4a268b764c Support const subclasses of visitor classes (issue 42853) 
Change-Id: Idee546d25a4cb96d790d966695c852c22f4c3392
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156064
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-28 13:54:18 +00:00
Konstantin Shcheglov 6f8ce20c99 Move asInstanceOf(ClassElement) to DartType. 
This follows to the change to the specification.
https://github.com/dart-lang/language/pull/1106

R=brianwilkerson@google.com

Change-Id: I6575f201161c454de98e9bcbec74b9974d91d062
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155242
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-22 01:22:05 +00:00
Konstantin Shcheglov f0e54a6657 Deprecate Scope.lookup(), replace it with lookup2(). 
R=brianwilkerson@google.com

Change-Id: I14074500a4df6803ef362ac1d183bd595e85769f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-16 16:53:53 +00:00
Konstantin Shcheglov eb38d2a03b Add PrefixElement.scope to API. 
Change-Id: Ie673f521301d6ddc1b40d86ef7c02544f07e53fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154160
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-12 17:11:14 +00:00
Konstantin Shcheglov 93fa1cf17d Add Scope and LibraryElement.scope to API. 
Change-Id: I5cfda9ed6c52fde38252d82ee1bc9c9152b906f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154141
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-11 06:20:42 +00:00
Konstantin Shcheglov c367b488ee Add InterfaceType.allSupertypes. 
R=brianwilkerson@google.com

Change-Id: I9c5058091b1a4473a2535ba792aa6bbfac35793c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153945
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-10 16:23:07 +00:00
Konstantin Shcheglov 9dea0a8d97 Add InterfaceType.asInstanceOf(ClassElement) to API. 
R=brianwilkerson@google.com

Change-Id: I91c61aea37bb4ccfb300083e1b017b8e71ef6d6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153703
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-09 00:34:38 +00:00
Konstantin Shcheglov 9280712d29 Change ConstructorElement.returnType to InterfaceType. 
R=brianwilkerson@google.com

Change-Id: I3f2605b26cc953d707dc5c37b690ec0438a99b3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-08 20:01:07 +00:00
Konstantin Shcheglov fea5f5866e Add DartTypeVisitor and DartType.accept(DartTypeVisitor) to API. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/40478
Change-Id: I8453011f4a39323bda86244a749509b4b347b4b6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-07 20:13:10 +00:00
Konstantin Shcheglov 3b25d6ff69 Add DynamicType, NeverType, and VoidType to API. 
R=brianwilkerson@google.com

Change-Id: Icf917d999878b3c4d7b1d9425eb8a3c79921ba6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-07 00:22:40 +00:00
Konstantin Shcheglov 9cfdc02e58 Stop depending on exports from generated/resolver.dart 
We cannot remove them completely just yet, there are users in google3.
But this CL will allow experimenting internally to track these users
and update them similarly.

R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Ic588b2873f9d5202783c8991f58e86bab28bd47e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-03 15:55:41 +00:00
Konstantin Shcheglov 13a24f4de1 Issue 42474. Add LibraryElement.languageVersion 
Bug: https://github.com/dart-lang/sdk/issues/42474
Change-Id: I316f34b14f01daa517182c1cb7b7c3fb038f0be2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152601
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-25 23:54:03 +00:00
Konstantin Shcheglov 2ec47ad273 Use ElementKind.ENUM for enums. 
There was a crash internally, caused by the fact that when we have
duplicate name for class and enum, during linking we put them into
different Reference bucket - @class and @enum, and also inside
the class, the reference to its name is the class.

But when we resolve, we check equality of elements using not
references, but locations. So, we need to make sure that their
kinds are also different, so go into different bucket, and so
not equal.

When they are InterfaceType and equal, we would try to match
type arguments against the wrong number of type parameters and crash.

Change-Id: Iee3f8691adac65d4b0395ceec7fc7250f96afa88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152404
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-25 00:20:31 +00:00
Konstantin Shcheglov 48f2d10d3e Deprecate ClassElement.hasReferenceToSuper 
Change-Id: Ie94d8e2b0be6ccb30c7ca59c80da2832cfed3689
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151168
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-15 17:45:06 +00:00
Parker Lougheed cad7b26b47 [pkg/analyzer] Update pedantic to 1.9.0 
Change-Id: I1161ed0c4681ddc8d2bd494586a9442a2ce1c4e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-06-02 21:41:03 +00:00
Konstantin Shcheglov 2ebd8e22a0 Add DartType.isDartCoreIterable 
R=brianwilkerson@google.com

Change-Id: Ia21b8f66bc19467b1b4e84c0cd9d59d6553a58a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147600
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-11 22:06:20 +00:00