dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

158 Commits

Author SHA1 Message Date
Konstantin Shcheglov af4b4d9575 Update NamespaceDirective.uriElement to return LibraryElement? 
Change-Id: Ief36ea6d6dc0fab4a1f6976e034418695bd2e128
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196043
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-04-20 16:27:49 +00:00
Konstantin Shcheglov fd92cd4ce1 Add Expression.inConstantContext to API. 
Change-Id: I13f96d2123e96eea11ccdcef2bb9a301a8afd26a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-03-16 19:28:30 +00:00
Konstantin Shcheglov 0506b1b2d3 Deprecate setters in API of AST. 
Change-Id: Ib2ec164ef87b3a5a4bf028d592552e37451abd35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/189520
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-03-07 21:48:50 +00:00
Konstantin Shcheglov 959adec89d Deprecate FunctionTypeAliasElement. 
Change-Id: I52b49ecadc7217416341b7d7474ded5b36a8ca73
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/185980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-25 19:08:36 +00:00
Konstantin Shcheglov c749c0e3a9 ConstructorDeclaration always has a body, at least EmptyFunctionBody. 
Change-Id: I5cbc5317256d02cd1422233107ce469e8d8935f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184341
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-11 18:08:15 +00:00
Konstantin Shcheglov 3d8d4b4c2b FunctionExpression always has a body, at least EmptyFunctionBody. 
Change-Id: I0d09df2571436f30a7706e657a98056a021e25e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/184342
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-11 18:00:11 +00:00
Loren Van Spronsen c426bc5eff Correct the inline grammar in the SimpleStringLiteral dartdoc. 
Change-Id: I03956ea2e7f2dfba45bab265b0ab7a7b86559224
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183080
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-02-06 01:46:48 +00:00
Paul Berry ba5064fa31 Analyzer AST changes for generic metadata 
Bug: https://github.com/dart-lang/sdk/issues/44838
Change-Id: I55b8dacc571570568c1b3f101a1a4e1f517f7f6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182581
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-02-04 09:45:47 +00:00
Konstantin Shcheglov 9f986d2501 Migrate package:analyzer to null safety. 
Change-Id: Iffe4370431587e46a141ddc72a86ceec29c163b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176486
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2021-02-01 18:56:04 +00:00
Konstantin Shcheglov dee85df64d Basic support for elements/types of non-function type aliases. 
Change-Id: Ide8f2fff98f7f03375efad23df3ed79795c33a23
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174681
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-12-04 23:32:02 +00:00
Sam Rawlins 19a96e4d5e Analyzer: override element type in ExportDirective and ImportDirective 
This reduces the number of explicit casts needed for null safety.

Change-Id: I8ad0ab9cddbbe81e5fbf66b95ae4ae1cb57efebc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172743
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-11-20 15:22:46 +00:00
Erik Ernst 9045077b35 Add ast support for non-function type aliases 
Change-Id: I5883ce6e80d451b52073f3770fbdf971e7dcf18c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170692
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-11-11 07:59:18 +00:00
Konstantin Shcheglov 619e388a1d Breaking changes for analyzer version 0.41. 
Change-Id: Ib16351e05b498fa9879e6bb4c117638cde276bfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-10-29 17:08:16 +00:00
Konstantin Shcheglov 31e673d80c Deprecate SimpleIdentifier.auxiliaryElements 
Change-Id: Ie1e92cc61b7018d503cdf44c37611ea55b4b5391
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164760
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-28 16:00:44 +00:00
Konstantin Shcheglov ffbe30f890 Deprecate IndexExpression.auxiliaryElements 
Change-Id: I7359527db5bbf161a35296678ff2bd43052c1794
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/164740
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-09-27 18:28:46 +00:00
Konstantin Shcheglov 893481591a Store readElement/Type and writeElement/Type in AssignmentExpression. 
Change-Id: Ibe0eea6126c7e85cdfefa09652228b5a89b522cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/160444
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-27 20:22:14 +00:00
Konstantin Shcheglov a51f1747e0 Prepare to publish analyzer 0.40.0 and _fe_analyzer_shared 8.0.0. 
Change-Id: I126207dcc47885565a3a6d7002ff15ad3cc493c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-18 15:12:10 +00:00
Paul Berry b7d139a626 External variable support: add a notion of external top level variables to the AST and element model. 
In follow-up CLs I will update error reporting logic.

Change-Id: Iee42088beffee3915a2ef6a4c8cb5c1031535d4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158149
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-08-12 15:59:24 +00:00
Paul Berry d4e4abdef6 External field support: add a notion of external fields to the AST and element model. 
In follow-up CLs I will update error reporting logic.

Change-Id: Id07b861aa117b93e0c869ad0b52c048085706ee6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157801
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-08-10 21:54:54 +00:00
Paul Berry b5a3292260 Abstract field support: add a notion of abstract fields to the AST and element model. 
In a follow-up CL I will update error reporting logic.

Change-Id: I6fd2916c24a531b1f41bd2872301ffec1fdb8722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157382
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-08-06 02:19:46 +00:00
Sam Rawlins 6bf946bbfc analyzer: Always declare return types. 
Change-Id: I23d89bb572310a1a8deef8e173630d9bb59c9a50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152708
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-06-26 23:54:28 +00:00
Konstantin Shcheglov 18b753cbcd Support for null-aware ExtensionOverride. 
Bug: https://github.com/dart-lang/sdk/issues/41780
Change-Id: Ib5d11000847434c679df1ec882ee6d9777670fe0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151097
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-15 23:45:08 +00:00
Konstantin Shcheglov c6ca3180df Support null shorting for FunctionExpressionInvocation. 
Change-Id: I470c85574662d70517aa880e5c094d54226efa11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150668
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-06-10 16:25:57 +00:00
Konstantin Shcheglov 279024d823 Deprecate InstanceCreationExpression.staticElement 
Change-Id: I3c2de8ce22944963418d543b887720db15badd0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148981
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-05-26 22:56:42 +00:00
Mike Fairhurst 5999b6bad5 Reland "[analyzer] Remove deprecated language version API" 
This is a reland of 65a377b967

Original change's description:
> [analyzer] Remove deprecated language version API
> 
> Change-Id: I10122c8860b7b4c7dfcea1d6f8829ad6be439e7e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141300
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

Change-Id: I1c5180fcc40b14b4bcc209e0b6b9bc053814047d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141720
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2020-03-31 18:41:50 +00:00
Alexander Markov a32dc76b86 Revert "[analyzer] Remove deprecated language version API" 
This reverts commit 65a377b967.

Reason for revert: this change broke Flutter HHH and Flutter Golem build:

third_party/dart/third_party/pkg/pub/lib/src/validator/language_version.dart:57:40: Error: The getter 'languageVersion' isn't defined for the class 'CompilationUnit'.
 - 'CompilationUnit' is from 'package:analyzer/dart/ast/ast.dart'

Original change's description:
> [analyzer] Remove deprecated language version API
> 
> Change-Id: I10122c8860b7b4c7dfcea1d6f8829ad6be439e7e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141300
> Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

TBR=scheglov@google.com,mfairhurst@google.com

Change-Id: I979fa6201f03e1957bb2557d507b5090c303c82c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141521
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2020-03-28 00:35:21 +00:00
Mike Fairhurst 65a377b967 [analyzer] Remove deprecated language version API 
Change-Id: I10122c8860b7b4c7dfcea1d6f8829ad6be439e7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141300
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-27 18:54:47 +00:00
Mike Fairhurst 3095a082cd [analyzer] Add an API to get a language comment token off a unit. 
Change-Id: I377fdc44d5e514d6d9a601b3947c3908e5a4497a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140768
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-03-26 03:47:57 +00:00
Konstantin Shcheglov 4844fa9622 Issue 40959. Support null-shorting for cascades. 
Bug: https://github.com/dart-lang/sdk/issues/40959
Change-Id: Ia7fd153debafd13ab469bbfcc3a2d1ef3feaa5f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139865
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-18 07:36:36 +00:00
Konstantin Shcheglov fbd232dbe6 Issue 40958. Fix null shorting for MethodInvocation. 
Bug: https://github.com/dart-lang/sdk/issues/40958
Change-Id: Ic96b54feeeced5adb3b4271180636b493f951976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139749
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-17 00:29:51 +00:00
Konstantin Shcheglov 0f8238efe9 Issue 41036. Add null-shorting for prefix/postfix expressions. 
Bug: https://github.com/dart-lang/sdk/issues/41036
Change-Id: Iccff235bc81b6e65a3b40f972aaa75707ac2232c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139462
Reviewed-by: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-03-16 20:23:16 +00:00
Brian Wilkerson 6ed6a11f9b AST support for the null aware index operator 
I think this also includes the necessary changes to the summary format.

Change-Id: I12bb28d5579f05d7026d0778e847380425e90b3d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137252
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 19:30:11 +00:00
Konstantin Shcheglov 5940821f4e Issue 37487. Add CompilationUnit.languageVersion override. 
Initial:  https://dart-review.googlesource.com/c/sdk/+/136802
Reverted: https://dart-review.googlesource.com/c/sdk/+/136851

Bug: https://github.com/dart-lang/sdk/issues/37487
Change-Id: Ida3bf049840e7bda32ecdd54309ea0b141aa6800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137201
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-02-26 18:08:07 +00:00
Paul Berry b0b06bff31 Revert "Issue 37487. Add CompilationUnit.languageVersion override." 
Reason for revert: it was a breaking change to the analyzer public API.

There were two breakages:

- A @required `languageVersion` parameter was added to
  AstFactory.compilationUnit, which is part of the officially
  supported analyzer public API.

- A @required `languageVersion` parameter was added to the Parser
  constructor, which is not part of the officially supported analyzer
  public API, but is part of its de facto public API due to the fact
  that it is used by dart_style.

This reverts commit ce26dfda7d.

Change-Id: I507103ea6f6ffabf915d6f56e9f24454725c3930
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136851
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-02-25 04:39:10 +00:00
Konstantin Shcheglov ce26dfda7d Issue 37487. Add CompilationUnit.languageVersion override. 
Bug: https://github.com/dart-lang/sdk/issues/37487
Change-Id: I57fbcdd6771d9004ba1fc43902c19514dab2a23d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136802
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-21 20:19:43 +00:00
Konstantin Shcheglov 8b204d477d Remove StringUtilities.startsWithChar() 
R=brianwilkerson@google.com

Change-Id: If05d2fcf0f60c3bd2b2319cf38cf463dcdc0e336
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128768
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-17 23:14:00 +00:00
Sam Rawlins 40718899fe Fix pedantic 0.9 lints around collection literals and spreads 
Change-Id: I64277c36fbeb4ea7a1bb429a8e0a40203520c883
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128380
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-14 00:15:41 +00:00
Brian Wilkerson 652926bbaf Deprecate Element.getAncestor, replacing it with methods matching those in AstNode 
Change-Id: Iebb046791c1fce57a228f997e9c5936809fbc872
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127481
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-06 18:29:02 +00:00
Konstantin Shcheglov 0bca6aaf10 Fix avoid_return_types_on_setters in analyzer. 
R=brianwilkerson@google.com

Change-Id: If7132980451d76c777d3734abbb89ece5ad3e3d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127425
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-06 01:48:48 +00:00
Konstantin Shcheglov 364dd8936b Fix unnecessary_new in analyzer. 
R=brianwilkerson@google.com

Change-Id: I70f80baa3da4b14c0a52c1f28da16a9ad26d7dda
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127424
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-06 01:11:30 +00:00
Paul Berry cdde5418e1 Rework null-shorting logic to improve robustness, add public API. 
The proper behavior of null-shorting relies on proper pairing between
FlowAnalysis.nullAwareAccess_rightBegin (called upon reaching a `?.`
during resolution) and FlowAnalysis.nullAwareAccess_end (called upon
reaching the termiation of null-shorting during resolution).
Previously, we ensured that invariant by the following mechanism: when
visiting an expression that might terminate null-shorting, we would
walk backward through the expression to try to figure out how many
outstanding `?.`s it contains, and call
FlowAnalysis.nullAwareAccess_end an appropriate number of times.  This
was fragile because we had to guarantee that the backward walk would
find exactly the correct set of `?.`s for which null-shorting was
open.

With this change, we ensure proper pairing between
FlowAnalysis.nullAwareAccess_rightBegin and
FlowAnalysis.nullAwareAccess_end by keeping a stack of the expressions
that should terminate null-shorting once we finish visiting them.

Additionally, we add an accessor to the API called
`nullShortingTermination`, allowing a client to ask when the null
shorting introduced by a `?.` will terminate.

Change-Id: I8ec99e6bad7605d50ef3a6bc6c11634ece5043a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-11-07 22:06:17 +00:00
Paul Berry 1d646866ac Sort declarations in pkg/analyzer/lib/dart/ast/ast.dart 
Change-Id: I04c120716dd663004636b357b18602a37b29b243
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-07 16:24:47 +00:00
Paul Berry 5d4cd6d589 Breaking changes for analyzer version 0.39. 
Change-Id: Ifa9ca24487f93f3eb0ec95eeb64f5bbb5aa32714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113216
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-10-21 18:23:10 +00:00
Sam Rawlins d9fa27a9ed Update ~48 doc comments to have one-sentence summaries 
From Effective Dart: Documentation:
* https://www.dartlang.org/guides/language/effective-dart/documentation#do-start-doc-comments-with-a-single-sentence-summary
* https://www.dartlang.org/guides/language/effective-dart/documentation#do-separate-the-first-sentence-of-a-doc-comment-into-its-own-paragraph

Change-Id: Ie49b2e6a2cad5c1d01a6cd625f91f89e4fcc39ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/69260
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-10-17 21:48:46 +00:00
Konstantin Shcheglov 9fe78bc9a8 Support for 'question' in FieldFormalParameter. 
So, with 'question' token in AST, we can finish fixing the issue.

Bug: https://github.com/dart-lang/sdk/issues/38811
Change-Id: I9997be57c891c99c85dbfe3ef85871043fd3bffe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121884
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-10-16 23:04:56 +00:00
Devon Carew 73d880b949 [analyzer] add a quick fix for the prefer_relative_imports lint 
Change-Id: Ic69ebe799f425fd09e002b65d66a4382f5f96ead
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120160
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2019-10-04 20:13:07 +00:00
Mike Fairhurst 5beca80bc7 [analyzer] add isNullAware to IndexExpression 
Change-Id: I3c3b1b0a38ea81fd573ec005e810eb2b000b3430
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-09-12 21:31:57 +00:00
Mike Fairhurst 2bc48ad1b6 [analyzer] add isNullAware to propertyAccess 
Change-Id: Ia785a308e7281d6d17d05b38d52337f611708206
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116685
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-12 21:29:27 +00:00
Mike Fairhurst 68bcc00d10 [analyzer] implement isNullAware for method invocations 
Change-Id: I630f94311a55b7a7fce5e47143e333abffe19c9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116681
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-12 21:21:22 +00:00
danrubel 30ea777c65 fix parsing of "?.." cascade operator 
Fix https://github.com/dart-lang/sdk/issues/37859

Change-Id: Ie29f4fd000199f0099137308603335e36af6ae26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116089
Commit-Queue: Dan Rubel <danrubel@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-10 20:36:04 +00:00