fdc8f08af9
Dartfix: add fixes, cleanup output, fix bug
...
This adds support for running the remaining lint fixes that were already
implemented but not yet supported in dartfix.
It cleans up the output by shortening the descriptions of most of the
pre-existing fixes.
It also marks the recently added fixes as not being default, because
making them default was unintentional and should be considered to be
a bug.
Change-Id: I381924144c89a8c8666d6f16009724ae0f2e1fbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132540
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-20 21:44:29 +00:00
c790eccdf4
NNBD preview: Load region details when requested; Closes #40112
...
Change-Id: Ibcda2aa18c340c070e32160a470545b99d7751f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-20 18:46:28 +00:00
407cd2bf3b
Completion metric improvement: re-map PREFIX ElementKinds to LIBRARY ElementKinds which are the kinds used by the completion engine.
...
Change-Id: I5f3b81986d993f208dea5a7df3d550bc1486de12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132445
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-20 04:54:11 +00:00
93ebbe2c7a
Enable use_function_type_syntax_for_parameters in analysis_server
...
Change-Id: I93cddc986c23e53557c647befc92d118b3d6ed43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132459
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-19 17:11:11 +00:00
31bfacfda4
Migration: change API to make use of FixBuilder's "changes" data structure.
...
The new FixBuilder component of the migration engine communicates the
changes it produces using a "changes" data structure of type Map<int,
List<AtomicEdit>>, and is not compatible with the old
SingleNullabilityFix class (which made the incorrect assumption that
each SourceEdit was associated with a single fix). This CL changes
the migration engine's instrumentation API to use this data structure,
and changes its listener API to avoid reference to the
SingleNullabilityFix class. This allows SingleNullabilityFix to be
deleted.
This required changing AtomicEditWithReason so that it can hold
multiple fix reasons, and a NullabilityFixDescription. It does so
using a new object, AtomicEditInfo, and AtomicEditWithReason is
renamed to AtomicEditWithInfo.
In addition, the old FixInfo class is removed, since it carries the
same information as the new AtomicEditWithInfo class.
This required deleting the "incremental workflow" functionality from
UnitRenderer. This functionality was disabled, and I believe it
wouldn't have worked anyway (since it, too, made the incorrect
assumption that each SourceEdit was associated with a single fix).
Change-Id: Id965cfd803b408c66f15436017b87fc3e46521c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132306
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-19 16:50:01 +00:00
d99624c748
Use available suggestions to get a more complete picture of the actual list being given to clients
...
Change-Id: I59d5a8e4bcd0dd3f8ea2337306571163d0f64405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132409
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-19 16:32:01 +00:00
87fe06a03e
stop suggesting keywords in method type argument lists
...
Fixes: https://github.com/dart-lang/sdk/issues/40213
Change-Id: I2779d445e98c9056dd15afd2de657d92087ebff1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132400
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-17 21:56:35 +00:00
819a97a0ef
type argument completions for generic method invocations
...
Fixes: https://github.com/dart-lang/sdk/issues/40190
Change-Id: Ic44dca751e08a7fdd540c96172f07cb8ee1d1850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132382
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-17 21:56:26 +00:00
8fda644e10
lambda generation for positional args
...
Fixes: https://github.com/dart-lang/sdk/issues/40202
(See issue for animation of UX.)
Change-Id: I029a7768b887fedef4873f3fa23171d21df8808f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132380
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-17 21:10:17 +00:00
c9324972e8
NNBD preview: Fix html-escaping bug in region text
...
Change-Id: Icc6e52bf6f49f92fa67cd39f3985804e533b2972
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132305
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-17 19:08:17 +00:00
c5cb20dc55
Improve the ExpectedCompletionsVisitor for the getter and setter cases, this improves the number of successful completions to 90.8% from 75.7% for analyzer_cli
...
Change-Id: I9519f0247918bbf237ce6a3fc688b9814169fdfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132301
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-17 17:30:03 +00:00
9c6e548512
Error handling in completion_metrics.dart - don't attempt to create an AnalysisContextCollection until we have determined that the included path exists on the machine.
...
Change-Id: I15e2884bfd9e243f0b01081e1c43a929ceaeae1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132222
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-17 00:37:25 +00:00
c7745a1a0d
contribute local completions for mixin members
...
Fixes: https://github.com/dart-lang/sdk/issues/39795
Change-Id: I1a186dd63e59463706d18dd484653c0bee70ba90
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132165
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-01-16 22:55:53 +00:00
93b40dc037
NNBD preview: Flip non-null reasons back on
...
Change-Id: Idaf6adfc8a9960c8e6f6f8e421a795fdb374a921
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-16 22:42:58 +00:00
81003d8147
fix extension completions in mixins
...
* ensures extension member completions get added for mixins
* restructures and adds tests
Change-Id: I525450584b05e485027e46d775423e6d6f9f8e99
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132030
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-01-16 20:48:48 +00:00
43694c3db1
NNBD preview: Move reasons/details into separate fixed panel
...
#40112 , still needs more work before closing
Change-Id: Ic963e4678ca0692ebcbf1c8cf3ab955d9ae81427
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132028
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-16 20:43:39 +00:00
f4f890ed30
Highlight null and throw keywords
...
DartUnitHighlightsComputer2 does not highlight the "null" and "throw" keywords.
This will highlight them both as keywords.
Change-Id: I38a45435f7a35e9a56f289e7797c4a5d00134f08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131071
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Simon Binder <simolus3@gmail.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 19:36:58 +00:00
ab2a484bb3
Don't include comment references by default in the completion metrics test.
...
Change-Id: I108d8caff5b1ed7c6dfbb2f7d908891fca698190
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131950
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-16 16:02:17 +00:00
05fdb62234
extension completions w/o dotTarget
...
Fixes: https://github.com/dart-lang/sdk/issues/39093
Change-Id: I9a576e4387b6a869a4779f15c16f7272f99d2acd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131848
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 14:54:01 +00:00
f689f145b1
Only call applyFileRemoved for analyzable files
...
Currently this is called for non-Dart files and may be contributing to a crash in Flutter - see https://github.com/flutter/flutter/issues/46616#issuecomment-574224525 and following comments.
Bug: https://github.com/flutter/flutter/issues/46616
Change-Id: I52fe539c265426dcd2ea978c2fbc8abfdfe4998f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131835
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <danny@tuppeny.com >
2020-01-16 14:44:06 +00:00
e08e18f369
Add edits for more fixes in the preview tool
...
Change-Id: Ice5cff20f4df1215265b75cf2b1c1fad83aec2a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131946
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 14:16:06 +00:00
b2842d9214
NNBD preview: alert user to disconnected preview server
...
Change-Id: Id6b84b5c5b948f5c562e9a4b9e10eecdb06f30a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131941
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 07:48:39 +00:00
2b573d65d8
Introduce _doExpectKeywordCompletions in ExpectedCompletionsVisitor
...
Change-Id: If5e2479eb9397dbb5a6ae6f9c3a0838841abeee9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131906
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-16 07:06:01 +00:00
8826b7e249
Improve the print output from completion_metrics.dart to match the expected input of the Files dialog in IntelliJ.
...
Change-Id: If6ff502a397a35d8937263e4b2ee9c683ed612a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 06:50:24 +00:00
9937277327
NNBD preview: Change navigation to be a tree; not interactive yet #40109
...
Change-Id: I42550b89533d4c1acba7998887f7601de2569f18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131903
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 06:37:29 +00:00
418707beb6
In completion_metrics.dart, print out line numbers instead of character offsets.
...
Change-Id: Ifc083b5a4938bdc7bbae57e42559f61d6310df33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131904
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-15 21:13:14 +00:00
74bf68a99d
Improve printPercentage(..) in pkg/analysis_server/lib/src/status/pages.dart to take an optional fractionDigits to pass to num.toStringAsFixed(..)
...
Change-Id: I641cf541626ef149663fc3f652b9f1ca1dfb02a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131847
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-15 19:56:55 +00:00
b38263736a
Rename a class in pkg/analysis_server/tool/completion_metrics/completion_metrics.dart
...
Change-Id: I6e7cbe671a1030e5a523f1c5085442cce27093a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131884
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-15 19:26:13 +00:00
b227f19168
Improve the print output from the completion_metrics.dart tool, output for collection is now:
...
Summary for /usr/local/google/home/jwren/github/collection:
Total number of completion tests = 11487
Number of successful completions = 9945 (86.6%)
Number of unsuccessful completions = 1542 (13.4%)
Change-Id: Ie53fdb3be7cac847ac1612a90b93c7eacd72f41d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-15 19:11:24 +00:00
bbec798aca
Implement the rest of the visit* methods in pkg/analysis_server/tool/completion_metrics/visitors.dart, members sorted.
...
Change-Id: I763e57740c40051c268b13222b9528f2b15eab1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131845
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-15 18:56:05 +00:00
5e42c5a4ad
Special case in completion_metrics.dart, some keyword suggestions come out of the DAS completion engine such as "import '';", instead of "import"
...
Change-Id: I6de32a6a2c770a78a2fd3e1103969b5f2f62f9e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131716
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2020-01-15 05:54:44 +00:00
c3a2ed9555
Fix failing tests on unittest-asserts-release-win after analyzer Packages change.
...
Change-Id: Iec83b5d02d10e3b93f2e1e734bd155189f9ef2d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131780
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-15 03:10:24 +00:00
8163dbea4f
completions for yield statements
...
Change-Id: I4ac28ebf4d5b2c49926a31704a81ccf2fd14106d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131718
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-01-15 00:49:24 +00:00
e0c178b38e
closure arg code completion
...
Change-Id: I99b97c967f017492a711e30fe183dba52e05d190
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131713
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-14 23:17:34 +00:00
d26b32b729
API improvement in completion_metrics.dart to introduce ExpectedCompletion.matches(CompletionSuggestion)
...
Change-Id: I7e9d042c59ad31e071d6e04438c1dfd8b700adc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131722
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-14 23:13:21 +00:00
af0b7c6444
Add completion kind and element kind assertions on matching expected completions from the analysis server in completion_metrics.dart
...
The dart:collection is currently outputting these final results:
done 9872 1615
done 85.9% 14.1%
Change-Id: Ib38c2baae7b3ed033706f26057a743b3463e3fd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131708
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2020-01-14 22:26:33 +00:00
82785b6762
This is a failing test for http://dartbug.com/37907 using the new DartCompletionManagerTest
...
Change-Id: Id852d5f2894f5e0ba12127a04fad2f9c91593cd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131702
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-14 21:11:46 +00:00
1c1d7b6178
Nit completion_metrics.dart cleanup from comments in https://dart-review.googlesource.com/c/sdk/+/131600
...
Change-Id: I58b0bc6fe1eab69b724f7a8d658fa7aa5657d785
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2020-01-14 20:08:51 +00:00
fca76dc792
Improve the String output of the double percents.
...
Change-Id: Ia2361befb8f923ab049fe88adc9503a3dc344cc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131601
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-14 17:46:06 +00:00
5a5491aa19
Split completion_metrics.dart into two files.
...
Change-Id: I4436b26e35ee7cd29c9f1babbde3d66189a5652a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131600
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-14 17:36:35 +00:00
226f0c4523
Refactor the 3 implementations of Comparator<CompletionSuggestion> down to a single implementation.
...
Change-Id: I39cde605c53dbe2dded60278bd128e7d32e2a763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131580
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
2020-01-14 07:25:25 +00:00
fe666ce592
Report unused public static members of private classes
...
Also of private mixins, enums, and extensions.
Fixes #39988
Change-Id: I646205cba64da1a9837585a5af2c4c2b8d41824c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129860
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-14 06:09:04 +00:00
04e2c97ae4
NNBD preview: Fix the position of the navigation
...
Issue #40109
Change-Id: I97a0ffc60dbb085934ea8f02dc2416b35e2cc15b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-14 03:18:04 +00:00
799716232e
Fix getHover test on Windows.
...
Change-Id: I0f9baa51c0d69935b99b01add40b650fdcea68e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-14 01:01:48 +00:00
301a3a28c7
Fix incorrect .packages files in DAS tests.
...
Change-Id: I983e57113aba7add2f5b352d04fbd3aefe6316a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131463
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-01-14 00:54:43 +00:00
c41812bf1d
Incremental work in the completion_metrics.dart file.
...
This PR addresses most of the comments from https://dart-review.googlesource.com/c/sdk/+/131425
Change-Id: If7502a949484add34444d81772610f972e753f29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131520
Reviewed-by: Jaime Wren <jwren@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
2020-01-14 00:53:44 +00:00
fd9d3f9786
relevance test re-structure
...
See: https://github.com/dart-lang/sdk/issues/40104
Change-Id: I79635831d92313f6c55c9a7c4a7b1fb0eeb41c06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131481
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-13 23:59:30 +00:00
6669849006
Initial commit with some work starting the metrics collection around code completion metrics gathering.
...
Pattern followed from https://github.com/pq/surveyor
Change-Id: I45bb7d81cfbb64ad91afc1abd522a7e0e1a51f28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131425
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Auto-Submit: Jaime Wren <jwren@google.com >
2020-01-13 22:53:49 +00:00
c6d6eed0aa
Include type arguments when converting to a stateful widget (issue 40095)
...
Change-Id: I5a4060f070cbd58165edb2515b29c9a3648d6a6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-01-13 22:09:44 +00:00
d1e11f0881
Enable prefer_final_fields in three packages
...
Other than the updates to analysis options files, these changes are all
from dartfix.
Change-Id: I517b0601e36d5456960d81be9a429cbacf711141
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131342
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-13 05:32:14 +00:00
Brian Wilkerson