dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

809 Commits

Author SHA1 Message Date
Jaime Wren d99624c748 Use available suggestions to get a more complete picture of the actual list being given to clients 
Change-Id: I59d5a8e4bcd0dd3f8ea2337306571163d0f64405
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132409
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-01-19 16:32:01 +00:00
Jaime Wren c5cb20dc55 Improve the ExpectedCompletionsVisitor for the getter and setter cases, this improves the number of successful completions to 90.8% from 75.7% for analyzer_cli 
Change-Id: I9519f0247918bbf237ce6a3fc688b9814169fdfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132301
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-17 17:30:03 +00:00
Jaime Wren 9c6e548512 Error handling in completion_metrics.dart - don't attempt to create an AnalysisContextCollection until we have determined that the included path exists on the machine. 
Change-Id: I15e2884bfd9e243f0b01081e1c43a929ceaeae1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132222
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-01-17 00:37:25 +00:00
Jaime Wren ab2a484bb3 Don't include comment references by default in the completion metrics test. 
Change-Id: I108d8caff5b1ed7c6dfbb2f7d908891fca698190
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131950
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-01-16 16:02:17 +00:00
Jaime Wren 2b573d65d8 Introduce _doExpectKeywordCompletions in ExpectedCompletionsVisitor 
Change-Id: If5e2479eb9397dbb5a6ae6f9c3a0838841abeee9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131906
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-01-16 07:06:01 +00:00
Jaime Wren 8826b7e249 Improve the print output from completion_metrics.dart to match the expected input of the Files dialog in IntelliJ. 
Change-Id: If6ff502a397a35d8937263e4b2ee9c683ed612a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-16 06:50:24 +00:00
Jaime Wren 418707beb6 In completion_metrics.dart, print out line numbers instead of character offsets. 
Change-Id: Ifc083b5a4938bdc7bbae57e42559f61d6310df33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131904
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-15 21:13:14 +00:00
Jaime Wren b38263736a Rename a class in pkg/analysis_server/tool/completion_metrics/completion_metrics.dart 
Change-Id: I6e7cbe671a1030e5a523f1c5085442cce27093a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131884
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-15 19:26:13 +00:00
Jaime Wren b227f19168 Improve the print output from the completion_metrics.dart tool, output for collection is now: 
Summary for /usr/local/google/home/jwren/github/collection:
Total number of completion tests   = 11487
Number of successful completions   = 9945 (86.6%)
Number of unsuccessful completions = 1542 (13.4%)

Change-Id: Ie53fdb3be7cac847ac1612a90b93c7eacd72f41d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131846
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-01-15 19:11:24 +00:00
Jaime Wren bbec798aca Implement the rest of the visit* methods in pkg/analysis_server/tool/completion_metrics/visitors.dart, members sorted. 
Change-Id: I763e57740c40051c268b13222b9528f2b15eab1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131845
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-01-15 18:56:05 +00:00
Jaime Wren 5e42c5a4ad Special case in completion_metrics.dart, some keyword suggestions come out of the DAS completion engine such as "import '';", instead of "import" 
Change-Id: I6de32a6a2c770a78a2fd3e1103969b5f2f62f9e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131716
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-01-15 05:54:44 +00:00
Jaime Wren d26b32b729 API improvement in completion_metrics.dart to introduce ExpectedCompletion.matches(CompletionSuggestion) 
Change-Id: I7e9d042c59ad31e071d6e04438c1dfd8b700adc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131722
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-01-14 23:13:21 +00:00
Jaime Wren af0b7c6444 Add completion kind and element kind assertions on matching expected completions from the analysis server in completion_metrics.dart 
The dart:collection is currently outputting these final results:

done 9872 1615
done 85.9% 14.1%

Change-Id: Ib38c2baae7b3ed033706f26057a743b3463e3fd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131708
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-01-14 22:26:33 +00:00
Jaime Wren 1c1d7b6178 Nit completion_metrics.dart cleanup from comments in https://dart-review.googlesource.com/c/sdk/+/131600 
Change-Id: I58b0bc6fe1eab69b724f7a8d658fa7aa5657d785
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2020-01-14 20:08:51 +00:00
Jaime Wren fca76dc792 Improve the String output of the double percents. 
Change-Id: Ia2361befb8f923ab049fe88adc9503a3dc344cc2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131601
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-14 17:46:06 +00:00
Jaime Wren 5a5491aa19 Split completion_metrics.dart into two files. 
Change-Id: I4436b26e35ee7cd29c9f1babbde3d66189a5652a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131600
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2020-01-14 17:36:35 +00:00
Jaime Wren 226f0c4523 Refactor the 3 implementations of Comparator<CompletionSuggestion> down to a single implementation. 
Change-Id: I39cde605c53dbe2dded60278bd128e7d32e2a763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131580
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
 2020-01-14 07:25:25 +00:00
Jaime Wren c41812bf1d Incremental work in the completion_metrics.dart file. 
This PR addresses most of the comments from https://dart-review.googlesource.com/c/sdk/+/131425

Change-Id: If7502a949484add34444d81772610f972e753f29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131520
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
 2020-01-14 00:53:44 +00:00
Jaime Wren 6669849006 Initial commit with some work starting the metrics collection around code completion metrics gathering. 
Pattern followed from https://github.com/pq/surveyor

Change-Id: I45bb7d81cfbb64ad91afc1abd522a7e0e1a51f28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131425
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
 2020-01-13 22:53:49 +00:00
Brian Wilkerson 5b1065ac60 Enable avoid_init_to_null in analysis_server 
Change-Id: I1909b0d8939d9b436fce772bd97dc4835f1093ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-13 00:35:34 +00:00
Brian Wilkerson 32ce9c7872 Enable prefer_collection_literals in three packages 
Other than the following changes, all of the changes were made by dartfix:
- the analysis options files
- one line to enable the fix through dartfix (missed in an earlier CL)
- three places where a bug in the fix produced invalid code (issue and fix TBD)

Change-Id: If8660700792561805f4d1c96ccecd81abcebfeb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131209
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-11 20:39:02 +00:00
Sam Rawlins 327b1eb24f analysis_server: Make private fields final where possible 
Change-Id: Ibdeb7e66f07bf81205d70ac5d1c4cb4aa5a97671
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2020-01-08 22:08:02 +00:00
Danny Tuppeny c8c367bb10 Add valueRange field to LSP Flutter Outline attributes 
Include range of values in LSP FlutterOutline notifications

Change-Id: I07cbe970d553f793dbdb4cb282807eec12720017
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-08 20:10:06 +00:00
Brian Wilkerson e5705943d8 Enable prefer_conditional_assignment in several packages 
Other than the changes to the code generators and the analysis options
files, the changes were all generated by dartfix.

Change-Id: I80055e3992452c5b40eed41ac79807cf5c932976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-06 05:19:19 +00:00
Brian Wilkerson fbadd6a832 Enable prefer_equal_for_default_value in several packages 
Other than the changes to the code generators and analysis options files,
all of these changes were produced using dartfix.

Change-Id: I24f47b9f6b929b0b5d5e08da7ef2016f4bdc4108
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-05 20:59:19 +00:00
Brian Wilkerson 8c6c27541e Disable a lint in the LSP generated code and re-run the generator 
Turns out we aren't testing to ensure that the LSP generator has been
run as part of our test suite. Ideally we'd do so and we'd update the
generator to produce code that doesn't violate lints, but that's more
work than I can do today. Hence this stop-gap CL.

Change-Id: Ia9e5a35817fc4d08e2a4b87b9c2ef64725c822b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130004
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-02 04:55:46 +00:00
Brian Wilkerson c08cdb5a78 Enable avoid_return_types_on_setters in analysis_server_client 
All changes (other than analysis_options.yaml and the change to the generator) made via dartfix.

Change-Id: I7b186371e22048ceddf6fd4407a66aba8b96480c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130003
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-02 04:55:38 +00:00
Brian Wilkerson 91d6e1a0a7 Enable annotate_overrides in several packages 
Other than analysis_server/test/analysis/notification_overrides_test.dart,
which had a naming conflict, all of the changes were made using dartfix.

Change-Id: I911dd75dcdee00420caa48724125e86d47c8857d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:31:40 +00:00
Brian Wilkerson 7d41ae7d15 Enable unnecessary_this in several packages 
Change-Id: I743066d66dbf1dff984e8f8bf5b7a472c9bc7ff7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129821
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-28 20:43:16 +00:00
Brian Wilkerson e2431d1452 Update the generators to not generate unnecessary uses of "this" 
Change-Id: I20d15e3b0f8046065906d96860073ad4cf353868
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129815
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-28 16:23:06 +00:00
Brian Wilkerson 278551426e Enable prefer_adjacent_string_concatenation in most of the packages 
Change-Id: I4d061710573c63a9db700c6156470705cf4f8548
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129762
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-27 17:03:35 +00:00
Brian Wilkerson c547f5d933 Enable prefer_generic_function_type_aliases in most of the packages 
Change-Id: I1338e731aa3f42f67fec605b20455a83fd5fce43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-27 00:43:14 +00:00
Brian Wilkerson 1fe55651cb Generate end-of-line doc comments in server and plugin packages 
Change-Id: I1d5517932e1c78744cfe43fc6a768a104e527091
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129520
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-24 00:34:30 +00:00
Brian Wilkerson 52c6620986 Enable unnecessary_const in analysis_server 
Change-Id: I44d9902cb23d005ebedd4bc37d57d3751a8ebdc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-19 17:32:52 +00:00
Brian Wilkerson de57ff3b1d Remove one missed generated use of const in analysis_server 
Change-Id: I6aac996b1cfe1c5d49d2cb68f7c7340893b79531
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-19 05:34:28 +00:00
Brian Wilkerson 4043a6fce3 Remove unnecessary uses of new in analysis_server 
Other than analysis_options.yaml, all of the changes were from running
dartfix.

Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 19:01:51 +00:00
Danny Tuppeny 0addcc0c7d Update LSP spec URI and regenerate from spec 
Change-Id: I361a7a6e10167e140bf4ba190f29a3c33c584f01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128720
Auto-Submit: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 15:08:21 +00:00
Brian Wilkerson c9d89d55a6 Stop generating unnecessary new and const in server generators 
This doesn't remove other uses of new or const, only those that are
generated. I'll get the rest in other CLs.

Change-Id: I59c296da3d2da0f45789df156a682b9c37398087
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 05:15:25 +00:00
Danny Tuppeny 62e5531e36 Add a Flutter Outline Notification to the LSP server 
Change-Id: Ifbff7d88df7e468cfba383fda89160c7d3d5ee33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128662
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-17 17:46:36 +00:00
Brian Wilkerson affd81b143 Remove preview from dartfix api in favor of opening the preview automatically 
Change-Id: I7f2dd4c97a99ec9e2d28f2a06778c247150a0632
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128286
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-13 22:42:56 +00:00
Brian Wilkerson 11049992d5 Update the server protocol to not require a port number 
Only spec_input.html was changed, the rest of the files were regenerated.

Change-Id: Ib4644f811d86c46da6d01c601107ede8537e39df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128366
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-13 18:45:41 +00:00
Danny Tuppeny 7c5d83d170 Add explicit type to generated LSP classes == operators 
Change-Id: I42f76c8d48329fed93821a17da71963eaa813d4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-12-12 18:42:20 +00:00
Danny Tuppeny 3739b80534 Add a publishOutline notification to the LSP server 
Clients can opt-in by passing "outline: true" in initializationOptions.

Fix outline name

Change-Id: I3a302178c685b49afe50370aef8360105b9676fc

Add test that outline comes through after change

Change-Id: If36344d485ea11c4b25d57e1e1fb43b575e8188f

Initial work on supplying Outline data over LSP

Change-Id: I74670b5c43a41af49195712bcc4be8e120e5b4ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128141
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-12 18:42:20 +00:00
Sam Rawlins 2c7c3a60e7 NNBD preview: Rip out static preview; only server preview 
This involved replacing PathMapper with the wrapper, PreviewPathMapper,
and MigrationInfo, with the wrapper, PreviewMigrationInfo.

Change-Id: Ie590c298bfa8c64c4765748b42ce3c9dc0dec3d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128107
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-12-12 01:48:23 +00:00
Brian Wilkerson afde51a608 Start sending urls for preview mode from server to dartfix 
Change-Id: Ice8463ec9a5d3d21b47e6250f24d093a48b11b7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127988
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-11 14:26:29 +00:00
Brian Wilkerson 4ce13659b4 Update server API to allow URLs to be returned to dartfix 
Change-Id: I252ee50b811409aa2eed7d0579c01676160acfca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127940
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-10 19:39:29 +00:00
Jaime Wren fee8c5503c Mark the completion.registerLibraryPaths as deprecated in the Dart Analysis Server. 
Change-Id: Ia0b305d9ebaf1a5416994e1fa0959a29d043a87b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125930
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
 2019-11-21 22:16:38 +00:00
????? 6546460461 chore(doc): fix typo 
Closes #39128
https://github.com/dart-lang/sdk/pull/39128

GitOrigin-RevId: f03a58d8dd0a486021eb0d5e51e01383cef48f6e
Change-Id: Iedc2caca99963b26c73b43f65e32be59e750bca7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123061
Reviewed-by: Michael Thomsen <mit@google.com>
 2019-11-20 11:27:58 +00:00
Paul Berry bbe5d38c0e Add a script to analysis_server/tool for testing out NNBD migration. 
The tool is configured with a .json file so it can access directories
specific to the user's machine without needing hardcoded paths.

Change-Id: Ifb38e1d0334628b24c50ded3a30fd12822876093
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-11-18 22:26:00 +00:00
Konstantin Shcheglov 30690b1526 Issue 39357. Catch FormatError and report FLUTTER_SET_WIDGET_PROPERTY_VALUE_INVALID_EXPRESSION. 
Bug: https://github.com/dart-lang/sdk/issues/39357
Change-Id: Ia0d5eb7907dbe16ad03dd70a4f3ede226c2edaaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125129
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-11-13 22:41:55 +00:00