Commit Graph

467 Commits

Author SHA1 Message Date
pq 82e83bb34d Experimental getDiagnostics request (#24480).
* Adds `getDiagnostics` request with *very* provisional diagnostics payload (primary goal here is to plumb this fully through and iterate).
* Updates codegenerator to skip doc generation for experimental APIs.

Additional context here: https://github.com/dart-lang/sdk/issues/24480.

BUG=24480
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1416093007 .
2015-11-05 15:05:21 -08:00
pq 7a6bf51504 Doc generator tweak to skip experimental domains.
Prevents domains flagged as experimental from having server apidocs generated.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1419793004 .
2015-11-03 13:12:00 -08:00
Konstantin Shcheglov 069ba985de Fix protocol for EXTRACT_LOCAL_VARIABLE and coveringExpressionOffsets/lengths.
Unfortunately we have to make coveringExpressionOffsets and coveringExpressionLengths optional.
Otherwise new clients cannot correctly parse responses from old servers.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1407333006 .
2015-11-03 10:19:41 -08:00
Paul Berry ac5578d03d Refactor analysis server code generation to re-use logic from analyzer.
The code generation infrastructure logic is now shared.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1431683002 .
2015-11-02 16:18:03 -08:00
Brian Wilkerson 27eb09033f Clean up wording of client usage expectations
R=paulberry@google.com

Review URL: https://codereview.chromium.org/1409353002 .
2015-10-19 07:46:49 -07:00
Konstantin Shcheglov c0d68a5437 DAS specification changes - spelling and ElementKind.FILE addition.
ElementKind.FILE will be used in search.findElementReferences

1. In the 'element' field of responce when a URI is at the given offset.

2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1409333002 .
2015-10-17 10:03:03 -07:00
Paul Berry 9767634564 Fix manual editing of integration_test_methods.dart.
In commit 9ad256cf18,
integration_test_methods.dart (an auto-generated file) was edited
manually.  The only necessary changes were to imports--the other changes
were the result of sorting declarations and running the formatter.

This CL replicates the necessary changes in the code generator and
re-runs it, un-doing the other changes.  This should fix the test
"pkg/analysis_server/tool/spec/check_all_test".

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1397353002 .
2015-10-12 06:49:02 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
Konstantin Shcheglov b107dec41a Spec change: include covering expressions into Extract Local protocol.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1388783003 .
2015-10-05 14:44:32 -07:00
pq 8697392367 AnalysisError hasFix attr (Implements #23874).
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1385523002 .
2015-10-05 09:46:17 -07:00
Konstantin Shcheglov 9d48af9ee3 Specification change for the 'libraryName' and 'partOfLibraryName' fields in Outline.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1375163003 .
2015-10-01 09:53:20 -07:00
Konstantin Shcheglov da29a447c4 New analysis.implemented notification specification.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1372623004 .
2015-09-25 09:57:29 -07:00
Konstantin Shcheglov 173cb44a85 Add '<!doctype html>' to spec.
The new task model's HTML parser reports an error otherwise.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1351323004 .
2015-09-21 10:10:57 -07:00
Brian Wilkerson 42d1d4532d Reformat code to minimize churn
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
2015-09-09 08:19:18 -07:00
Konstantin Shcheglov c67b274852 Explicitly document that NavigationRegion.targets cannot be empty.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1328273002 .
2015-09-08 13:16:43 -07:00
Konstantin Shcheglov 58f5005cb1 Add the optional 'superOnly' request parameter for 'search.getTypeHierarchy'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1325543006 .
2015-09-03 13:03:01 -07:00
Paul Berry 03a156c891 Plumb "enableSuperMixins" option through analysis server (implements DEP 34).
Partially addresses #23772.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1301533003 .
2015-08-20 09:47:26 -07:00
Guillermo López-Anglada 3193083293 remove dead code
Fixes #24037
2015-08-14 15:32:35 +02:00
Brian Wilkerson 87c7ee011f Merge pull request #23979 from guillermooo-forks/clean-up-to_html
remove unused switch case
2015-08-10 09:03:58 -07:00
Brian Wilkerson f6eb7c13a8 Merge pull request #24024 from guillermooo-forks/optional-newline-generated-doccomments
add optional param to control whether to add newline
2015-08-10 07:56:14 -07:00
guillermooo 70a0e29758 add optional param to control whether to add newline
A new parameter enables client classes to decide whether the want
a newline char added at the end of a chunk of generated doc
comment text.
2015-08-08 16:37:19 +02:00
guillermooo 0b00d198c0 add links to index in spec input file 2015-08-06 22:28:26 +02:00
guillermooo 09addad383 generate index 2015-08-06 22:17:50 +02:00
guillermooo 69a062a01f add index element to analysis server doc file 2015-08-06 21:59:56 +02:00
guillermooo c4418424ae remove unused switch case 2015-08-05 08:05:19 +02:00
Konstantin Shcheglov aa30cad380 Proposal for the 'edit.organizeDirectives' request.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23921

Review URL: https://codereview.chromium.org//1258563008 .
2015-08-03 07:59:26 -07:00
Paul Berry e93b52a66f Deprecate option "enableNullAwareOperators" in analysis server.
As of analyzer version 0.25.2, this option is no longer needed;
null-aware operators are always enabled.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1255113005 .
2015-07-28 11:31:03 -07:00
Brian Wilkerson 1487e5ad91 Merge pull request #23867 from guillermooo-forks/make-indentation-configurable
make indentation configurable for codegen tools
2015-07-22 10:27:48 -07:00
Konstantin Shcheglov c4652486b4 Fix for a copy/paste problem in GET_NAVIGATION_INVALID_FILE.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1243073004 .
2015-07-21 08:46:55 -07:00
Konstantin Shcheglov a049c5aba0 Update DAS protocol version to 1.9.0
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1241213002 .
2015-07-20 12:24:37 -07:00
Konstantin Shcheglov 55cb93b422 Add '--useAnalysisHighlight2' option to generate version 2 of semantic highlight.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1241193002 .
2015-07-20 10:37:46 -07:00
Brian Wilkerson 15a0f755e8 Improve error messages for invalid requests
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1246573002 .
2015-07-20 10:23:01 -07:00
guillermooo 5eeaf9ac07 update documentation 2015-07-19 21:26:59 +02:00
guillermooo 856aee812a make indentation configurable for codegen tools 2015-07-19 21:16:15 +02:00
Brian Wilkerson 2ffa8de794 Add notification of analyzed files
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1232393005 .
2015-07-13 15:07:33 -07:00
Brian Wilkerson 10b7db100f Revert "Update Analysis Server highlight API and implementation."
This reverts commit 739847402b.

Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1236433003 .
2015-07-13 09:49:55 -07:00
Konstantin Shcheglov d7c2f4550b Issue 23640. Implement 'analysis.getNavigation' request.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/23640

Review URL: https://codereview.chromium.org//1232683003 .
2015-07-10 15:31:25 -07:00
guillermooo 1383dd8684 typo 2015-07-09 13:52:12 -07:00
guillermooo d7d272de81 minor changes to comments and strings 2015-07-09 13:52:12 -07:00
Konstantin Shcheglov 739847402b Update Analysis Server highlight API and implementation.
I think this is a good enough compromise between the existing and IDEA granilarity.

Eclipse plugin CL will follow.

(IN)VALID_STRING_ESCAPE are not implemented yet.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1227143003 .
2015-07-09 11:19:44 -07:00
Paul Berry 9857471f8c Modify analysis server codegen check to tolerate Windows line endings.
Now that the git repository config has been modified to use CR/LF on
Windows machines, our generated files contain different contents on
Windows machines than they do on Mac/Linux machines, so they were
failing the codegen check.  This CL updates the codegen check to
tolerate those differences.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1219493007.
2015-07-01 11:12:26 -07:00
danrubel d6580fd9fb generated analysis server java client code package rename
This changes the generated package name to better reflect our new home
from com.google.dart.server.generated.types
to   org.dartlang.analysis.server.protocol

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1164683003
2015-06-04 17:29:35 -04:00
Brian Wilkerson 07dd6b7649 Add lineLength parameter to edit.format request (issue 23519)
R=jwren@google.com

Review URL: https://codereview.chromium.org//1154303005
2015-06-01 09:39:02 -07:00
paulberry@google.com de0cb1f374 Create a new home for Java code generated by analysis server.
This code used to be generated directly into
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated,
however now that editor is no longer part of this repository that
doesn't work anymore.

Fixes the test pkg/analysis_server/tool/spec/check_all_test.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//1132673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45646 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-08 16:40:04 +00:00
nweiz@google.com 70a846ad6c Update pubspecs and dependencies to get pkgbuild tests working.
This also removes the vendored copy of Angular, which was an outdated version of
an unstaffed branch.

R=pquitslund@google.com

Review URL: https://codereview.chromium.org//1058283006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45410 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-24 20:08:53 +00:00
brianwilkerson@google.com 4e0bb57118 Update specification version number
R=jwren@google.com

Review URL: https://codereview.chromium.org//1096693006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45297 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 21:07:29 +00:00
brianwilkerson@google.com 4422b7c01e Fix error handling for formatting and update the spec
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1099633004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45296 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 20:57:33 +00:00
danrubel@google.com f117f67660 add optional importUri to completion suggestion
BUG=dartbug.com/23175
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1097083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45288 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-20 15:32:54 +00:00
paulberry@google.com cd1dd1864b Fix additional cases where analysis server might send null, violating protocol.
In addition, modify the code generation so that these protocol
violations will be caught by assertions during unit tests.
Previously, they would only be caught at runtime by client code.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1083223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45211 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-16 15:41:39 +00:00
paulberry@google.com 4af80fc1e7 Add an analysis server option to enable null-aware-operator support.
The option may be enabled in editor by setting the tracing option
"experimental/nullAwareOperators" (in com.google.dart.tools.core) to
true.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1063613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44909 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-06 14:53:00 +00:00