df85f37a29
Issue 13783. Add file from missing import.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=13783
Review URL: https://codereview.chromium.org//586453003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40482 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-19 00:19:54 +00:00
3e884db043
Index and search of import prefixes.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//582453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40397 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:19:39 +00:00
c7a131a7d5
Churn only: move analysis notification tests.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//563373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40396 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:16:29 +00:00
40be584340
Remove unused code.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//569243003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40395 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 20:09:43 +00:00
70d983e570
add element to completion suggestions
...
suggest getter rather than field element
add test for function suggestions
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//580623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40366 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-17 03:50:46 +00:00
6a91be4ddf
convert engine element setter to completion element setter
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//578673002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40362 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 23:21:57 +00:00
6cc9d7d887
add element to completion suggestion API
...
BUG=
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//572373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40360 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 23:17:24 +00:00
7fde5deecc
Send final problems even if 'validateOnly'.
...
Also fix for reporting duplicate 'Rename Local' shadowing warnings.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//576703004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40332 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 17:48:19 +00:00
457050dd88
Add SourceFileEdit.time field.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//574573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40329 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 17:19:37 +00:00
620f7cf957
Rollback https://codereview.chromium.org/575613002
...
I'm sorry, but I'm going to rollback this change.
We discussed this offline with Brian and decided that while it looks
technically correct, it does not work well for our use cases, as well as
probably for our users.
R=paulberry@google.com , brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19697
Review URL: https://codereview.chromium.org//560133003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40324 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 16:31:52 +00:00
2208ce5587
Split refactoring problems into init, options and final.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//576473003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40318 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-16 15:14:51 +00:00
e823d01b65
Issue 19697. Partial fix - don't search for subclasss members.
...
I think it still worth to commit this CL, if nothing else,
it makes search a little faster by not searching for subclasses.
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19697
Review URL: https://codereview.chromium.org//575613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40290 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 23:34:15 +00:00
3d6fff5735
Issue 18926. Rename refactoring for labels.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=18926
Review URL: https://codereview.chromium.org//573803002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40259 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 17:48:09 +00:00
e5a2441aa4
Search for LabelElement and icon for LABEL in Editor.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//576443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40254 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 17:03:35 +00:00
80757f2511
Semantic highlighting for LABEL elements.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//559353003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40252 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 16:41:09 +00:00
caf4b0476e
Issue 18895. Convert an expression function body into the block function body when Extract Local.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=18895
Review URL: https://codereview.chromium.org//568333003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40250 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 15:28:31 +00:00
bab2843d3a
Issue 19696. Test for potential reference to the element defined in a subclass.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19696
Review URL: https://codereview.chromium.org//567243002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40248 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 15:07:08 +00:00
9773f61186
Add LABEL ElementKind, completion and highlighting kinds.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//567273002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40247 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 15:04:52 +00:00
3e3178ee6c
Support for searching LabelElements in SearchEngine.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//567653004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40245 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 15:03:01 +00:00
7eae998b90
Issue 13029. Quick fix to create a function for a Function typed named parameter.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=13029
Review URL: https://codereview.chromium.org//565023003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40242 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 14:53:06 +00:00
3f1f6f9e41
Issue 20892. Quick Fix 'Import Library' for type arguments.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20892
Review URL: https://codereview.chromium.org//556793007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40241 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 14:50:38 +00:00
210a4459b2
Issue 20358. Don't report referenced names of named parameters in named expressions as possible shadowing.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20358
Review URL: https://codereview.chromium.org//567083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40240 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 14:48:36 +00:00
a5ecdaffcc
fix code completion import dart exception
...
BUG=dartbug.com/20893
R=paulberry@google.com
Review URL: https://codereview.chromium.org//565793002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40238 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 12:41:41 +00:00
e7bdefffba
update error handling to send response with stack trace
...
BUG=dartbug.com/20893
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//569743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40237 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-15 12:30:07 +00:00
59eac1e533
Issue 19800. Support for inlining getters/setters.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19800
Review URL: https://codereview.chromium.org//565973006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40230 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-14 03:17:55 +00:00
4a59e13a84
Issue 19799. Merge getter/setter pairs into fields when create missing overrides.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19799
Review URL: https://codereview.chromium.org//563333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40220 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 21:29:09 +00:00
8269bc67c3
Issue 19801. Fix for inlining referenced function with an expression body.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19801
Review URL: https://codereview.chromium.org//569723004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40214 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 19:41:59 +00:00
d2d8fb708e
Issue 20894. Rename 'Class' when rename refactoring is activated on 'Class' in 'new Class.name()'.
...
To do this we need to tweak the Java version of ElementLocator and regenarate the Dart version.
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20894
Review URL: https://codereview.chromium.org//571523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40208 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 17:16:15 +00:00
b67e00a59e
Issue 20894. Improve navigation regions for 'new Class.named()' expression.
...
As we discussed offline.
Rename changes will follow.
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20894
Review URL: https://codereview.chromium.org//551143003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40207 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 15:52:08 +00:00
36dca53a87
fix path in generated comment
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//565773002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40199 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 05:03:41 +00:00
a9a2c98d53
gracefully handle internal exceptions during request
...
- new SERVER_ERROR response code
- return SERVER_ERROR response if exception when processing request before request can be sent
- send server.error notification if exception occurs anytime while processing request or future work triggered by request
BUG=dartbug.com/20893
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//570453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40198 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 05:01:46 +00:00
778536d97c
Issue 19682. New analyzer snapshot that fixes an inline refactoring problem.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19682
Review URL: https://codereview.chromium.org//561373002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40193 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 22:47:29 +00:00
3120d3632f
Issue 17024. Quick Fix to find imported library.
...
It works with both project and package libraries.
R=brianwilkerson@google.com , paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=17024
Review URL: https://codereview.chromium.org//562333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40173 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 18:36:04 +00:00
14e375418b
Issue 10355. Quick Fix to replace 'var' with 'dynamic'.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=10355
Review URL: https://codereview.chromium.org//562183003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40172 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 18:26:58 +00:00
88c1df9734
Issue 20891. Produce Quick Fixes for annotations.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20891
Review URL: https://codereview.chromium.org//562293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40167 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-11 17:36:42 +00:00
1e5e985370
Disable tests to fix the build
...
Review URL: https://codereview.chromium.org//559993003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40116 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 20:49:58 +00:00
7ac6ed2b6f
Issue 20890. Fix for NPE in the 'Add show' QA.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20890
Review URL: https://codereview.chromium.org//560913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40115 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 20:49:42 +00:00
f289a1abac
Fix exception in error processing; implement mapUri
...
R=jwren@google.com
Review URL: https://codereview.chromium.org//560103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40109 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 19:54:49 +00:00
bad1890ab3
Implement "analysis.reanalyze" in analysis server.
...
This is accomplished by instructing the context manager to remove all
contexts and recreate them from scratch.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//553193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40106 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 19:20:09 +00:00
016dc1132b
add code completion declared and return types
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//558893002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40087 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-10 13:04:11 +00:00
2c15ecefbf
Avoid false positives when searching for uses of a constructor.
...
Since constructor invocations are statically bound, there's never a
reason to search for potential matches. Since potential matching is
performed by name, this avoids an enormous number of false positives
in the case where the constructor is unnamed.
BUG=dartbug.com/20869
R=scheglov@google.com
Review URL: https://codereview.chromium.org//560553003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40058 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 21:25:15 +00:00
944174f36a
Move package_map_provider.dart from the server to the analyzer package to be used by the command line analyzer.
...
R=brianwilkerson@google.com , paulberry@google.com
Review URL: https://codereview.chromium.org//560553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40051 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 20:36:35 +00:00
65f95d89f4
Fix for List<Future> is not assignable to List.
...
Instead of pushing core.dart file, we should pre-index SDK.
R=danrubel@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//551103003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40038 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 16:24:22 +00:00
ea7f519f03
Make SdkLibrary.shortName consistently include 'dart:'
...
The documentation of SdkLibrary.shortName claimed that it didn't
include the 'dart:' prefix; however the implementation did include it.
The implementation of shortName in _MockSdkLibrary class (used only
for unit testing) did not include the 'dart:' prefix, causing some
unit tests to pass even though the functionality was wrong.
This change updates the docs and _MockSdkLibrary to correspond to the
implementation (the 'dart:' prefix is included). Additionally it
fixes one usage of shortName which was expecting the 'dart:' prefix to
be absent; this was preventing quick fixes from working correctly.
In addition, the Mock SDK is modified to add a reference from
dart:core to dart:async and from dart:async to dart:math (these
dependencies exist in the real SDK). This avoids the need for some
workarounds in unit tests.
BUG=dartbug.com/20850
R=scheglov@google.com
Review URL: https://codereview.chromium.org//556573002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40000 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 21:02:30 +00:00
19f017660a
Return a feedback for the INLINE_METHOD refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//554053002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39993 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 19:56:26 +00:00
d7f0532f29
Add feedback for INLINE_METHOD refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//551963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39992 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 19:26:52 +00:00
611e8ca216
rename completion class
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//551933003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39987 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 18:38:36 +00:00
c0c0b51188
Send feedback for the INLINE_LOCAL_VARIABLE refactoring.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//547343004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39981 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 17:33:09 +00:00
8aeace76ec
improve keyword suggestions
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//543393002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39978 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 16:32:50 +00:00
4187ed6349
Add feedback for 'Inline Local' refactoring.
...
Also fix for the Java client tests.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//542333002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39977 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 16:29:23 +00:00
scheglov@google.com