e95dcac840
support part file completions
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//815683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42541 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-20 05:15:50 +00:00
97f90d4acc
Fix for extracting from interpolated string.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21907
Review URL: https://codereview.chromium.org//820763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42528 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 22:11:13 +00:00
11bdb14559
Catch exceptions in refactorings and return them as a SERVER_ERROR.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21907
Review URL: https://codereview.chromium.org//815233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42526 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 21:51:02 +00:00
dfb35c0ea6
Add methods to mock SDK that are referenced by completion tests.
...
R=danrubel@google.com
Review URL: https://codereview.chromium.org//810063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42512 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-19 17:02:18 +00:00
523dac8d75
Print a count of total tests and expected failures in completion tests.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//806413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42441 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 16:52:25 +00:00
879984875b
Add filtering to completion tests.
...
This allows the negative completion tests to be run.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//798173004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42432 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 14:42:29 +00:00
d0c5b78efa
Add tests for AnalysisServer.getAnalysisContextForSource.
...
BUG=dartbug.com/21898
R=danrubel@google.com
Review URL: https://codereview.chromium.org//807323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42422 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-17 02:38:10 +00:00
2546490ed5
Ensure that AnalysisContext futures are completed when context disposed.
...
It's possible for the analysis server to create or destroy contexts in
the background while the user is working (as a result of changes on
the filesystem). This ensures that if any code completions are
waiting for analysis when that happens, they are aborted.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//807993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42416 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 23:41:56 +00:00
27b38e807c
Convert analysis_server_test.dart to use reflective tests.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//813563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42413 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 22:30:07 +00:00
049adb2777
refactor optype to be computed once per refactoring request
...
and hide optype computation internals
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//807743003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42412 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 22:15:38 +00:00
ddc3cae8bd
refactor duplicate code into single visitor
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//804323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42398 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 16:53:24 +00:00
8affb6c015
Upgrade unittest to be able to use isNotEmpty.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//790363006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42380 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 04:07:37 +00:00
fef0e84293
Issue 21883. Add checks if type parameters can be used.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21883
Review URL: https://codereview.chromium.org//806933002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42377 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-16 00:29:22 +00:00
a662ca1ea1
Disable 'Split && condition' if there is an 'else' statement.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//805053003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42374 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-15 20:36:13 +00:00
438aa447d4
refine when suggestions are limited to types
...
BUG=dartbug.com/18860
R=paulberry@google.com
Review URL: https://codereview.chromium.org//802233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42366 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-15 17:48:00 +00:00
cd4ec28541
fix named constructor completion
...
BUG=dartbug.com/21799
R=paulberry@google.com
Review URL: https://codereview.chromium.org//803913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42365 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-15 17:16:40 +00:00
5599bc3a5b
fix invocation completion test
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//805683002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42364 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-15 17:14:36 +00:00
7f1ac9a001
include local functions in completion suggestions
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//802163002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42363 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-15 17:11:38 +00:00
1c082a63ab
Don't send a refactoring feedback in case of a fatal initial problem.
...
R=brianwilkerson@google.com , danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//793373004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42350 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 22:55:52 +00:00
b8c70eec87
Stop sending unwanted status and fix integration tests
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//789603007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42343 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 18:32:21 +00:00
611178ee87
call dispose so completion manager can cancel pending operations
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//801863002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42341 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 18:29:31 +00:00
b09752d035
enhance code completion tracking and measurement
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//796913004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42340 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 18:27:07 +00:00
0b9ed18603
Allow completions to wait for analysis without requiring a busy wait loop.
...
Two new methods are added to the AnalysisContext which return
Futures--the futures complete with the result of analysis once it's
available, avoiding the need for a busy wait loop in the completion engine.
The futures are guaranteed to complete eventually (provided that
analysis reaches quiescence). If it is determined that the requested
analysis will never become available (e.g. because analysis was
requested for a file or file/library combination that is not subject
to analysis), the future will be completed with an
AnalysisNotScheduledError, so that the client isn't stalled forever
waiting for analysis results.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//800723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42339 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 18:22:34 +00:00
77b819cd76
Report pub status
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//800913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42328 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 17:40:04 +00:00
44b69647a3
Rework instrumentation API
...
R=danrubel@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//801543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42321 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-12 16:00:23 +00:00
956e9e41ed
Fix for exchaning comparison operators arguments.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//800593002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42299 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-11 21:07:14 +00:00
45bebf8b76
filter imported element suggestions to reduce number of results sent to client
...
BUG=
R=paulberry@google.com
Review URL: https://codereview.chromium.org//795633004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42289 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-11 17:18:13 +00:00
f58bf4dbc9
Remove old instrumentation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//784623004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42267 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 21:53:08 +00:00
6995092b9d
code completion for dynamic type elements
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//783383003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42261 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 19:09:29 +00:00
bdb6a6a61f
Instrument communications
...
R=danrubel@google.com , lukechurch@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//790063002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42250 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-10 16:48:08 +00:00
c2db2b8c0e
Fix the build
...
Review URL: https://codereview.chromium.org//792433005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42221 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 21:24:46 +00:00
0a8dc970d2
Hooks for instrumentation
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42218 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 20:14:42 +00:00
bd852d8d3e
Make completion tests handle exceptions during getSuggestions().
...
Previously, if an exception occurred during getSuggestions(), or the
future returned by it completed with an error, the completion test
would exit without calling tearDown().
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//787863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42217 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 19:34:48 +00:00
246112537b
Start running new completion tests.
...
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//781333003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42210 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 16:44:12 +00:00
495cb6d5bf
Issue 21801. Index redirecting constructor invocations.
...
R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21801
Review URL: https://codereview.chromium.org//783223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42202 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 02:21:07 +00:00
e30b2b313d
Ignore ButtonType when computing an extracted method return type.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//789543002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42201 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-09 02:19:54 +00:00
3b73b01511
Issue 21740. Allow inlining local variables declared in SwitchCase.
...
R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21740
Review URL: https://codereview.chromium.org//780653005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42191 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 22:33:07 +00:00
f0bc442ea4
cache suggestions on change in priority sources
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787663004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42189 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 22:00:16 +00:00
7cd5226565
Annotate remaining analyzer/analysis server tests with "@ReflectiveTestCase()"
...
In r42181, I failed to notice the need to annotate these tests because
they aren't currently being run under dart2js (most likely due to
slowness). I've modified runReflectiveTests() to check for the
presence of the annotation before running the tests, in order to
ensure that all the classes are properly annotated now, and so that we
won't forget to add annotations in the future.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//742273005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42185 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:35:52 +00:00
e73e5faaad
Getters should not have parameters.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//787603004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42183 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 21:04:44 +00:00
a97ad9a625
Handle "fail_" style tests in reflective tests.
...
There is one corner case we don't handle--we don't catch the case
where the test is expected to fail, but the failure comes from an
asynchronous callback invoked via expectAsync(). Fortunately
expectAsync() is rare enough that this doesn't cause a problem with
any of our existing "fail_" style tests.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//790553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42180 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 20:33:18 +00:00
d05b81598f
Ported completion tests
...
R=paulberry@google.com
Review URL: https://codereview.chromium.org//785013002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42176 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 20:00:24 +00:00
8ef4de75cd
include lower relevance suggestions only if they are already cached
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//784853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42172 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 18:56:43 +00:00
cbbcadc423
remove unused cache arguments
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787653002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42167 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 16:59:02 +00:00
c3a22ba02d
invoke computeCache when priority sources change
...
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//787553002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42160 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-08 12:04:32 +00:00
2d6a8357f3
make completion managers responsible for their own caches
...
- move cache out of CompletionDomainHandler into CompletionManager
- make CompletionManager longer lived
- move context and source fields out of DartCompletionManager and into superclass
- encapsulate information related to a specific request in new CompletionRequest rather than in the manager
- remove request specific information from CompletionManager creation
- use same ContextManager instance for consecutive requests on the same context/source pair
BUG=
R=scheglov@google.com
Review URL: https://codereview.chromium.org//723263004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42157 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-07 19:31:59 +00:00
1d4ba5fba7
Add paging support
...
R=paulberry@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//769963003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42084 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-03 15:54:20 +00:00
03346f100e
Keep full test_ method names in reflective tests.
...
If found that when a test fails, need to copy its name, open outline,
don't forget to type * (i.e. Shift+8) and then paste the name.
It would be easier to have full names ready to copy.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//749083005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42067 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-02 15:22:41 +00:00
20d82e5135
Compressed/optimized navigation notification.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review URL: https://codereview.chromium.org//766323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42049 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-01 22:21:28 +00:00
ba033a38f9
Fix the code completion timing test
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//761533006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42007 260f80e4-7a28-3924-810f-c04153c831b5
2014-11-26 20:09:17 +00:00
danrubel@google.com