dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4182 Commits

Author SHA1 Message Date
Konstantin Shcheglov d8961dc2c9 Test that rename refactoring works for non-function type aliases. 
Change-Id: I801be01b73f0e27245ec8958b0a18e521615c8e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-26 22:11:45 +00:00
Konstantin Shcheglov 64a8d2a8b8 Fix for indexing constructor references in documentation comments. 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2816
Change-Id: I4515b6887f5d8bd93fc6ba59812c5a9ec14f0d3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-26 20:15:44 +00:00
Konstantin Shcheglov d373094cbb Test that search of/in non-function type alias works. 
Change-Id: I4d750da4a706d837d626349ad4225f80d35c3f78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181140
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-26 16:08:39 +00:00
Konstantin Shcheglov 4a5ac9df57 Support for non-function type aliases in convertElement() and test navigation. 
Change-Id: Ic2dcf6ad3faaf6712fdcbbe5197f332b6ba42e78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-26 06:40:00 +00:00
Konstantin Shcheglov 3a9dc0ae9f Highlight Function/typedef as BUILT_IN, non-function TypeAliasElement as TYPE_ALIAS. 
Change-Id: Icd2375338c3b37c34b8438453d58af43e8d0dfd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180640
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-25 23:02:17 +00:00
Konstantin Shcheglov 40b9650b67 Add ElementKind.TYPE_ALIAS and HighlightRegionType.TYPE_ALIAS to the protocol. 
Change-Id: Ia4991d4f657f4bfa5e244d9c3b126e89571b9e7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180660
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-25 18:42:03 +00:00
pq 3001499c78 data driven sdk api fix support 
Change-Id: I5b05044b505fa5936d8148515c61172e443dc129
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180721
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-24 15:41:48 +00:00
Brian Wilkerson a00530b46f Remove unused support for requesting token details 
Change-Id: I9cc160d84e06b4b7be67e53962fe38c1430e74b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180762
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-24 05:11:48 +00:00
Konstantin Shcheglov 0f0c2b5e66 Fold tests with experiments into AnalysisNotificationHighlightsTest. 
R=brianwilkerson@google.com

Change-Id: Idfc8e2413eda6f2d755a24f6cad8800244bf3aa0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180621
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-22 19:32:54 +00:00
Brian Wilkerson 995b91675a Enable the use of config files when testing data-driven fixes 
Change-Id: I8e21111840275a3db65adadc465482e998fb8cbc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180385
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-21 19:47:03 +00:00
Brian Wilkerson e45665fc5f Add support for parsing a config file for a data-driven fix test 
The contents of the file are not yet being applied, so the only thing
that can be tested at this point is the parser.

Change-Id: If8579e8b7383937f47e4960c3ecd3dfe283c40bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180280
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-21 17:58:31 +00:00
Danny Tuppeny b94adb2bc2 [Analyzer] Add folding regions for comment blocks 
Change-Id: Iafe70e977065dc68230503349b8ba3abe9b4c0c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179777
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-20 16:23:45 +00:00
pq 34f9c07457 fix edits that can be applied to other libraries 
See: https://github.com/dart-lang/sdk/issues/44534


Change-Id: I24101c493faed2da7e1ce4ff01a8c652d6c5f901
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180087
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-01-20 00:25:14 +00:00
Brian Wilkerson 3621c6a02f Add a flag to the bulk fix protocol to support testing 
I think it makes more sense for the server to read the config file than
for `dart fix` to read it and then pass the data to server as part of
the protocol, which it would effectively need to be parsed a second time.

But I don't want config files to be used outside of test mode, so I
added the flag to the protocol. Let me know if you can think of a better
approach.

Change-Id: I1c53bc995272451247e84914f2cd6b75a837ee1e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180082
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-19 23:16:14 +00:00
Danny Tuppeny d901213061 [Analyzer] suggest type names in field declarations where fields may have been parsed as field names 
Change-Id: Ie31cc3bae86538ea5580627851a7b7d95571a5d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179771
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-19 22:26:14 +00:00
Danny Tuppeny 15cd98f511 [Analyzer] Add a custom semantic tokens modifier to named parameter labels 
Change-Id: I5b5e4030a17bd894872884960d11eaa748c12e5c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179769
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-19 15:51:22 +00:00
Konstantin Shcheglov e8d4569e37 Fix for ConflictingEditException in RemoveUnusedLocalVariable. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I5614e83b5b7dca720b5de09a5ee7fd457a13b2e1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-18 07:08:49 +00:00
pq 44cb6a17e9 bulk fix for avoid_relative_lib_imports 
Change-Id: I5c1d19d81f0293ef7ae2d3e67a67f9eb5f405d7c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179585
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-16 03:24:42 +00:00
Konstantin Shcheglov 5ae02ab4c3 Fix merge conflict findNodeAtString vs. FindNode. 
R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I7953b2b6e2f2201297c6ae91e36d69297a23ff15
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179580
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2021-01-15 18:48:57 +00:00
Konstantin Shcheglov 1711659823 Replace findNodeAtOffset() and findNodeAtString() with FindNode. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I7058e347d504e7017e6229e520669d45602decd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179369
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-15 17:15:42 +00:00
Brian Wilkerson 37369b310e Refactor and add tests for creating an ElementMatcher for a node 
The code that was moved contains some additional fixes. I'm happy to
break this up into two CLs if you'd prefer.

Change-Id: I4e2407d28b238ff75934fcf92a411d5fe0b94585
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179364
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-15 14:57:08 +00:00
Konstantin Shcheglov 56903e6cfb Replace findElementInUnit(), findLocalFunction(), and findLocalVariable() with FindElement. 
Change-Id: I508b63fee81dc087489055448debb495a06eff6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179361
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-14 23:15:25 +00:00
Konstantin Shcheglov cfe510ade8 Test for search of non-function type alias. 
Change-Id: Iab2fc3980563a321eec3cf4e843d487b7b2b399d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179320
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-14 21:52:13 +00:00
Konstantin Shcheglov 68025f0170 Use findNode and findElement more in DAS tests. 
Change-Id: I949f1613d6d427ef3bddb9b4ab40b7feb012985b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-14 20:50:03 +00:00
Konstantin Shcheglov 48503619f8 Replace AbstractSingleUnitTest.findElement with FindElement. 
R=brianwilkerson@google.com

Change-Id: Id0a3bc6e6d33c969432337e0a7cb198ff4d6a5c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-14 17:05:43 +00:00
Konstantin Shcheglov 353b35cc4e Suggest only either getter or setter, but not both. 
Otherwise we get two conflicting edits.

R=brianwilkerson@google.com

Change-Id: I57f69099f715ad3cfd342d65a6a80e2c34d812a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/179064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-14 01:17:55 +00:00
pq f757851fa6 add test for over-eager add_late fix 
Change-Id: I9cf7d6eda6b9ed50b87225e4a2558d2ca29b011b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178661
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-01-14 01:05:30 +00:00
pq 4a7dd03932 bulk fix for avoid_private_typedef_functions 
Change-Id: I9775a542b58948488710156652ff8960ccbbc45b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178932
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-13 23:38:27 +00:00
Danny Tuppeny f0f4f58728 [analyzer] Use generated names for extracted methods 
Change-Id: I2aeaac092bc2222d6116c2e7172e73406bfa2260
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-13 18:51:38 +00:00
Danny Tuppeny 65af2a0941 [analyzer] Add ExtractLocalVariable to LSP server 
Change-Id: I997b9914d0c451e69a914c75da0f313430ba3722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178987
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-13 18:48:52 +00:00
Danny Tuppeny a154a0dbdf [analyzer] Add new contexts to declarations tracker after rebuilding due to watcher failure 
Fixes https://github.com/dart-lang/sdk/issues/44650.

Change-Id: Ifb59268b550e69b909c15e592cf925f40ba5f7cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-13 18:06:28 +00:00
Sam Rawlins d5ab427d16 analysis_server: Add a Convert to Null-aware Spread quick fix 
Change-Id: I04dfb48e0257d8e14de81b927699b7eb063ea578
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178924
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-13 17:24:48 +00:00
pq 1d35109cc1 bulk fix for prefer_is_not_operator 
Change-Id: Ib9888b034ff4e7376d295fb15adb738451a50085
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-01-12 18:24:23 +00:00
Brian Wilkerson b25f6959a9 Do not ignore the class of the target when deciding whether a transform applies to a diagnostic site 
Change-Id: I5b3f77557ebc86c6942a57bc082d9224ebcd2401
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178420
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2021-01-12 00:51:10 +00:00
Brian Wilkerson 726d18b5f9 Add a test case for convert-to-on-type 
Change-Id: If2dd4197dcd79ea311bec4d9aec6ed9da278aec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178721
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-11 22:56:50 +00:00
Parker Lougheed f9c3c09a9e Create a quick fix and bulk fix for unnecessary_string_interpolations 
Change-Id: I8cdf98ef8e23ac6a0e5fd10d4c0605a1b0d38a85
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178340
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-10 16:24:25 +00:00
pq b29d36c559 bulk fix for use_function_type_syntax_for_parameters 
Change-Id: I3a28cea584cc98dd0dcc9b750887485a7950b7ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178264
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-09 20:45:24 +00:00
Sam Rawlins 897235204e Split use_of_nullable_value into separate codes with more friendly 
messages.

* UNCHECKED_INVOCATION_OF_NULLABLE_VALUE
* UNCHECKED_METHOD_INVOCATION_OF_NULLABLE_VALUE
* UNCHECKED_OPERATOR_INVOCATION_OF_NULLABLE_VALUE
* UNCHECKED_PROPERTY_ACCESS_OF_NULLABLE_VALUE
* UNCHECKED_USE_OF_NULLABLE_VALUE_AS_CONDITION
* UNCHECKED_USE_OF_NULLABLE_VALUE_AS_ITERATOR
* UNCHECKED_USE_OF_NULLABLE_VALUE_IN_SPREAD
* UNCHECKED_USE_OF_NULLABLE_VALUE_IN_YIELD_EACH

Additionally, improve the ADD_NULL_CHECK quick fix by supporting
expressions which need to be null-checked in a for-each, a yield-each,
and a spread.

Bug: https://github.com/dart-lang/sdk/issues/44603
Change-Id: Ie493a2dc1c05b64a16fd17c77d3468e8d562c497
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178080
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-08 21:07:02 +00:00
pq daac91856b bulk fix for always_require_non_null_named_parameters 
Change-Id: Ib91171f2f892b3a7db5e674b9b7dc884cba28d5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2021-01-08 15:22:42 +00:00
pq 63795a73e6 bulk fix for unnecessary_null_in_if_null_operators 
Change-Id: I13b9ad4ad9ecaefd41eb211ac0a0aa0ee70557a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/178040
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-07 20:24:38 +00:00
Danny Tuppeny e5ed69d04d [Analyzer] Add support for LSP semanticTokens/range 
Change-Id: Iebd0a5bfca29b51fe6bb309f71c1ee476d4ed9f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177702
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-06 17:50:11 +00:00
Danny Tuppeny ee2899ed17 [Analyzer] Update DartUnitHighlightsComputer to allow generating LSP semantic tokens directly 
This allows additional types/modifiers that cannot be mapped from highlights region (for example where the existing `keyword` region type needs to be mapped into both `keyword` and `keyword.control` to support different colours as the original textmate grammar did.

Change-Id: Ie71b165fa6e4d902c068854cbbba4039ddefe185
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177605
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-06 17:50:11 +00:00
Danny Tuppeny 28523a5e31 [Analyzer] Fix race condition in LSP semantic tokens + re-enable 
Change-Id: I52c4eb18dd09e3334f21bbf5fac9ce4e716ea234
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/176660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-06 17:50:11 +00:00
Konstantin Shcheglov abe144c30f Fix AvailableSuggestionSetsTest on Windows. 
R=brianwilkerson@google.com

Change-Id: Ief007dd6ca0431cc69181603e19f88717910e9ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177681
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-06 03:49:50 +00:00
Konstantin Shcheglov 17b43ca846 Issue 44353. Fix adding duplicate relavance tags for available declarations in parts. 
Bug: https://github.com/dart-lang/sdk/issues/44353
Bug: https://github.com/flutter/flutter-intellij/issues/5108
Change-Id: I6a5f04a7f44d12466799c10bac720189bd4b0612
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-05 22:43:38 +00:00
Brian Wilkerson 95c680e640 Enhance add_null_check to cover more cases 
Change-Id: I9817a300bc4600b72396fb1cd35463e6fa2f3953
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177420
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2021-01-03 17:39:57 +00:00
Konstantin Shcheglov 24e0fa09ce Fix RemoveUnnecessaryParenthesesTest for Windows. 
Using absolute offsets does not work well, on Windows lines endings
are `\r\n` vs. just `\n` on Mac.

R=brianwilkerson@google.com

Change-Id: Ia64e532687bcb7b197cff3ffb4514391fcc1d84e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177460
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-03 06:52:46 +00:00
Konstantin Shcheglov d407e16cff Fix for LintNames.unnecessary_parenthesis 
Change-Id: Ia31ed2b35cc93a6eab030a39705597f006fc3da4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177400
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-02 19:22:36 +00:00
Konstantin Shcheglov ea775a6a0f Migrate SearchEngineImplTest to AnalysisContextCollection. 
Change-Id: Ide259d4baf2a309a08ae74019ecb95d54d97f365
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2021-01-02 19:21:16 +00:00
Brian Wilkerson 2318119845 Support make_variable_nullable fix when variables are initialized to null 
Change-Id: I816aa5fd173816aba8c2cd0be242ca8465f2c33b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177380
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2021-01-02 16:05:36 +00:00