eb057fe495
Send the correction as part of the diagnostic message in LSP
...
Change-Id: I894c90b7a895d36c3e9bee7623d1301c8c390b69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109740
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Danny Tuppeny <dantup@google.com >
2019-07-24 16:02:13 +00:00
17e15ee9a4
Add outline support for extensions
...
Change-Id: I1b7145e899614b3d73d3fc2bfbe3dd7f773d38d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109880
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2019-07-22 21:12:40 +00:00
1e04ff86b0
Mutate Aling(...) and Padding(...) into Container().
...
R=brianwilkerson@google.com
Change-Id: I5d15b93f3262cafe6915c5681c4baede87e7699a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-22 20:09:47 +00:00
1390201177
Support for 'padding' property, and EdgeInsets type.
...
R=brianwilkerson@google.com
Change-Id: I536ee3952d6e280a56b048773a3a5696bc508b07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-22 17:15:28 +00:00
1014272f3b
Extent 'alignment' property, copy from Align, virtual Container.
...
R=brianwilkerson@google.com
Change-Id: I9bec5b32e91f3cb77c4996f0ba0e7c2dd424316b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-19 21:41:03 +00:00
c1bb024479
Basic support for Container.alignment property.
...
R=brianwilkerson@google.com
Change-Id: I509df0b9c5d97e00a2f6ec50f31db1d07396f4ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109660
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-19 14:42:36 +00:00
07e5b20ec9
Insert new named arguments sorted.
...
R=brianwilkerson@google.com
Change-Id: I56d321160f21ebe20219fcc61288a0ebde1a21f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109583
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-18 22:16:58 +00:00
d57ebb0e1c
Fix reporting FLUTTER_GET_WIDGET_DESCRIPTION_NO_WIDGET.
...
R=brianwilkerson@google.com
Change-Id: Id4d84ab6240b4eb9444201c7cb7fca5d1743dacc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109552
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-18 21:55:00 +00:00
2d4973ca17
Format the function body containing the updated property.
...
R=brianwilkerson@google.com
Change-Id: I7f4f1bfa07b663d6079b639bc9003f2828c04e13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109541
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-18 21:07:00 +00:00
89a17f218b
Make getDescription() async.
...
We need to request additional elements for editors, and this is async
operation.
R=brianwilkerson@google.com
Change-Id: I451e80e32cf00fa0070f93123b33f0ee4b0ef759
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-18 19:58:10 +00:00
ddafed27cb
Support for enum values.
...
R=brianwilkerson@google.com
Change-Id: I1f95bfb8bd469981a9a6b4444670189a6619405a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-18 17:12:15 +00:00
b4e66ed3d0
Add highlighting for extensions
...
Change-Id: Ifa790e8e0830276cd794aa903aa5b2a9c1e03a97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109464
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-17 22:03:07 +00:00
8e17249b62
Refactor Flutter property tests.
...
R=brianwilkerson@google.com
Change-Id: I8b16b8e7bc514f23ea545360db6be59d3cfef576
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109461
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-17 20:36:35 +00:00
9d204ca5d8
Start adding 'Container' properties.
...
R=brianwilkerson@google.com
Change-Id: I88c8194545dc3944318b897616e5a500c97ae4d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-17 20:03:54 +00:00
202379aaee
Implement getWidgetDescription and setPropertyValue in Flutter domain.
...
R=brianwilkerson@google.com
Change-Id: I45fdb0121bdd067856e5c9e72466d9a5c1a00e55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109313
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-16 21:32:37 +00:00
46eaf4b039
Extract PropertyDescription, support for nested properties.
...
R=brianwilkerson@google.com
Change-Id: I3bf4938136120d640aaddc64854973714db33265
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109309
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-16 20:24:06 +00:00
65f8cd4365
Start implementing widget properties.
...
Only self properties for now.
No compound properties.
No virtual Container properties.
R=brianwilkerson@google.com
Change-Id: Icd61f45ecc95c45037c3998a927eb267fd13c4cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-15 21:06:56 +00:00
11bdc5ceab
Send context messages from server and plugins
...
Change-Id: I76b5c5697ee660980f3be7d8b3d4b99c2ffa2422
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108967
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Danny Tuppeny <dantup@google.com >
2019-07-15 15:27:43 +00:00
f0b119c1b4
Add nameLocation/valueLocation to FlutterOutlineAttribute.
...
R=brianwilkerson@google.com
Change-Id: Ib73c5a01013516232f78f1ffa89bff005976e632
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109060
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-15 14:50:59 +00:00
3eb25b60d4
Convert relative Posix path to the target MemoryResourceProvider path style.
...
You fixed the issue (thank you!) that I introduced on Windows.
I think this approach is more explicit, so a bit better.
R=brianwilkerson@google.com
Change-Id: Ic27cf061e2316421ee2596dbe41829d040176fd6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109040
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-15 14:11:23 +00:00
68124e9f63
Attempt to fix the mac and windows bots
...
Change-Id: I3e37354967c15091643d91abcf3d51395bdb5dc4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108969
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-13 03:04:44 +00:00
8b012ac780
Replace package mock in strings with files in tests/mock_packages.
...
R=brianwilkerson@google.com
Change-Id: I5240fbd90c8220d14ff41d6a98069f943e56aa6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108920
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-12 17:17:33 +00:00
a917043332
APIs for editing Flutter widget properties.
...
Change-Id: I602ea1a873f17a9bf47f1a77fb3af5b206464d6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108663
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Jacob Richman <jacobr@google.com >
2019-07-11 20:38:24 +00:00
c2ff2ca16d
collection API use de-linting
...
Change-Id: I8879f48d484830ff594295b983363b7e3245f092
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108668
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-10 22:49:10 +00:00
52abcd3dd2
apply prefer_equal_for_default_values
...
Change-Id: I9b6fd3ee18ec834a5db3d0d25455b6db9ea4fbe2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108664
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2019-07-10 19:31:40 +00:00
8027d9cba4
support error code based lint fixes in dartfix
...
Lints that have associated fixes (as opposed to assists)
can now be added relatively easily to dartfix as a new fix.
* rename BasicFixLintTask to BasicFixLintAssistTask
* new BasicFixLintErrorTask class
Change-Id: I73f591e627c10ceeb076622bfc6c3bb9a5a3c022
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-07-10 16:39:22 +00:00
e3d5966b7b
Add missing child declarations to LSP completion
...
- Adds enum values
- Adds named constructors
- Avoids duplicates by using parent name for constructors/enums when checking against existing imports
- Adds parens to end of labels in completion text
Change-Id: Idab620326023a153c01c0ebd8349a2101dfae7b4
Bug: https://github.com/dart-lang/sdk/issues/37472
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108413
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-07-10 07:21:51 +00:00
8bb8a29f8b
refactor dartfix lint fixes
...
This replaces several very similar lint fixes with a single BasicFixLintTask
thereby making it easier to add new fixes for existing lints.
In addition, the dartfix test names have been normalized
to match the corresponding DartFix info and additional tests added.
Change-Id: Ia3d1e0ffcb14d34e0af5d49650888eb2c49a9b42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Dan Rubel <danrubel@google.com >
2019-07-09 21:42:55 +00:00
fc542be6b4
Issue 36682. Check that selection offset/length is valid in Extract Method refactoring.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/36682
Change-Id: I9b15983ff6a872eec14c48bdf29680e6db97a75e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108480
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-09 18:51:42 +00:00
ad6b1ebbd6
Support for 'double' fields in protocol.
...
R=brianwilkerson@google.com
Change-Id: If8dacd4578e01380f4d9e4ce1f809b9485bffc7f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-09 18:09:47 +00:00
8a1dcdae68
Graduate 'flutter' domain from experimental, remove unused methods and fields.
...
We could also remove FlutterCorrections, because right now we don't
use it, but we will restore it soon as we get new Flutter domain
methods.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I084fe5acbe5d854673c7247d734aeca1f8d721af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108364
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-08 22:03:24 +00:00
4f78ad90df
An initial and partial implementation of an element model for extensions
...
Change-Id: Id780bc64104690389a5af18f8acac8fc44536201
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108001
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-07-03 13:49:17 +00:00
a2e1434603
Breaking changes for analyzer version 0.37
...
Change-Id: I65a16ab2d2ca05de701c27f08300de85a6316b41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99880
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-07-02 03:59:49 +00:00
39b71253ce
Fix for curly_braces_in_flow_control_structures lint.
...
Quick assist for converting single line statements to blocks and
vice-versa is also sometimes useful, but separate.
R=brianwilkerson@google.com , pquitslund@google.com
Bug: https://github.com/dart-lang/sdk/issues/37084
Change-Id: I9c6b2f7c063bc339a57d991e4d675b87e1910413
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103721
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-01 18:50:49 +00:00
b6c3b2c98c
Enable 'Surround with XYZ' only for Statement(s) in Block(s).
...
R=brianwilkerson@google.com
Change-Id: I6488bd699bb2375de3aed1171f89def23068ae17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107781
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-07-01 17:50:53 +00:00
f6dfad02f4
[analyzer] add a space to the quick for for REPLACE_COLON_WITH_EQUALS
...
Change-Id: Ic8ba5a8aa44b9c3ea8c4c1d792117ddd8054c9e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2019-06-29 22:37:21 +00:00
bd9be3c4ba
Ensure opened LSP files end up in the cache when using onlyAnalyzeProjectsWithOpenFiles
...
Fixes https://github.com/dart-lang/sdk/issues/37338 .
Change-Id: Icc04e77badfce51107633f55ce5dc602d1033ca4
Bug: https://github.com/dart-lang/sdk/issues/37338
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107286
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-06-28 12:37:25 +00:00
6602764dc8
Add folding for asserts and for extensions
...
Change-Id: I9d0a3d21b441dcef967ece5fbcd6fe9ebd932e13
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107342
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-27 16:57:07 +00:00
c92af46433
Update HttpRequest and HttpClientResponse to be Stream<Uint8List>
...
Bug: https://github.com/dart-lang/sdk/issues/36900
Change-Id: I1306b2df7c789597e49d2033b660a3ea62d6c1a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104525
Commit-Queue: Todd Volkert <tvolkert@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
2019-06-27 00:21:07 +00:00
ea0e48a118
Guard against an NPE in completion code (issue 36788)
...
Change-Id: I05fc48ac7ad495820c5e3f7efdb6db2096108e54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107306
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-25 17:13:12 +00:00
89e2118009
Guard against an NPE in incomplete code (issue 37150)
...
Change-Id: Idd5a0936ccd435c12ac9b4f36151204a2b01127a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107307
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2019-06-25 17:10:12 +00:00
7a028cd924
Bug fix with file move and renames, http://dartbug.com/37121
...
Bug: dartbug.com/37121
Change-Id: I9ffc7e39a33ca36d78a123b8567261d8709b9e6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107200
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2019-06-25 15:59:12 +00:00
d563bbba27
Fix for wrong occurrences when different expression with the same prefix.
...
R=brianwilkerson@google.com
Change-Id: I6bc00e2c30a8bf7b2e761e86310ad69e22ca956c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107195
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-24 22:02:21 +00:00
a1a51072da
Add a failing "move file" refactoring test for dartbug.com/37121
...
Change-Id: I88aa52e96c09ea6eec03013bfd3c3a3e205b08e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106981
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-21 20:09:48 +00:00
88408d562b
Fix LSP refactor test on Windows
...
Removes the recently-added base class to tests (which brought more with it than we needed - and caused issues on Windows) and adds in the flutter/meta packages using helpers (inc extracting the meta package to a new helper).
Re-enable skipped LSP refactor test
Change-Id: I62f8b3e300a776cae4fbd6d15deafb5b8970eef0
Change-Id: I165b9acf75a3ec9a91feb1730be2949eb4d5e5cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106741
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-06-19 20:00:15 +00:00
b6ae6da744
Skip LSP Extract Widget test pending windows fix
...
Change-Id: I5d13f33efc90d36415fa45ef1f2ad15da0cfaf97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106700
Reviewed-by: Paul Berry <paulberry@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-06-19 17:51:26 +00:00
1aa89591e3
Add LSP support for Extract Widget
...
Change-Id: I0d7068ab48eff2a27a00fad5e821e819c816a253
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106351
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-06-19 06:56:22 +00:00
143e5ef556
Revert 'Import Library' quick fix changes.
...
This basically reverts https://dart-review.googlesource.com/c/sdk/+/103921
because internally IntelliJ does not provide module dependencies yet.
Change-Id: I7717b2841bf3d6391b991875a594c6df9e246ff1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106482
Reviewed-by: Ari Aye <ariaye@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2019-06-18 17:31:56 +00:00
e32a179922
Add LSP support for Extract Method refactor
...
Change-Id: Id5c9e0657648963d5f96469fbac9269dad4e32a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106348
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Danny Tuppeny <dantup@google.com >
2019-06-18 15:40:10 +00:00
60fa066cd7
Filter LSP completion to exclude symbols already imported via another URI
...
Change-Id: I39d807ef88b939feffcba2b333dd76595257c768
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105760
Commit-Queue: Danny Tuppeny <dantup@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2019-06-17 14:16:21 +00:00
Brian Wilkerson