dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
79,322 Commits 2 Branches 0 Tags
a5ff656da170eddcdc87f84e9d4e324ce89d00d8
Commit Graph

4182 Commits

Author SHA1 Message Date
pq e2a67723ca bulk fix for prefer_final_fields 
Change-Id: Iabfb6aae5186171f4143d23aeb18a124ceab4a0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-10 15:10:41 +00:00
pq b0d007a931 bulk fix for type_init_formals 
Change-Id: I8b79e30f2ea811b97caa8fda1297dda054bbcc05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-08 05:04:50 +00:00
Konstantin Shcheglov 940d7effbd Fix for crash in AddMissingEnumCaseClauses. 
R=brianwilkerson@google.com, pquitslund@google.com

Change-Id: I0dc8c3158eb4b46247e415ff36c33991598bce9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157861
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-08 01:22:53 +00:00
pq 06cce87374 bulk fix for unnecessary_this 
Change-Id: I61c0173c8fb1fd02d6119412bf925d08126a7a0b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157822
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-07 22:58:17 +00:00
pq 768fd39317 bulk fix for unnecessary_overrides 
Change-Id: I9cdd051d7dcde5c9a9495e04cf0e7765aac8e714
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-07 15:30:55 +00:00
pq b86f267151 bulk fix for unnecessary_lambdas 
Change-Id: Idbf116b5194c122fae59526c3fc70b8a88f1b8a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157494
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-07 03:56:05 +00:00
pq a2fdeaaa53 bump linter to 0.1.118 
Change-Id: Id8277810091fbc3431131cb4182532c335d82773
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157476
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-06 23:11:09 +00:00
Brian Wilkerson eaf94c5897 Add a quick fix to make a return type nullable 
Change-Id: I6e400a5d46f9725586cb5f24601013abf7b3ebb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157603
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-06 23:09:19 +00:00
Brian Wilkerson 3bc6345ad6 Add a new fix to replace null-aware operators with the non-null-aware version when the receiver is non-nullable 
Change-Id: Id51ae969fb7d64ca6d3dd7869bb3886417231f3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157473
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-06 20:17:52 +00:00
Konstantin Shcheglov 5276973b22 Test and fix for completion in a part. 
R=brianwilkerson@google.com, keertip@google.com

Change-Id: I7653a24a3a315b2be51e50f223284537e5830b1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157469
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-08-06 16:08:59 +00:00
Danny Tuppeny 61e0098c92 Add custom LSP method to force reanalyze 
Change-Id: I7d27654ecb68cf674d6521cd6325256a5fabf86c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-08-06 14:51:19 +00:00
Brian Wilkerson 14a6aac97b Stop testing the relevance of suggestions 
Change-Id: Ic18d329280ff995e3ed4c33d2cf124e3ce0aea8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-06 04:48:26 +00:00
Devon Carew 31335728d1 [analyzer] add a new wrap with widget for SizedBox 
Change-Id: Ib94b254ebdff82309d8761c8bb769e15e19d23ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157423
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-06 04:34:26 +00:00
Paul Berry b5a3292260 Abstract field support: add a notion of abstract fields to the AST and element model. 
In a follow-up CL I will update error reporting logic.

Change-Id: I6fd2916c24a531b1f41bd2872301ffec1fdb8722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157382
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2020-08-06 02:19:46 +00:00
pq 1bb842869f bulk fix for prefer_spread_collections 
Change-Id: I612d9286e8233fe70da8150cf0ba1fa23c9d039b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157440
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-05 22:27:19 +00:00
Brian Wilkerson 5f38d69b5e Fix a bug in ExtensionMemberContributor when the extended type is not an interface type (issue 42945) 
Change-Id: Iaa1e6d5c21ecd8d78db68d49bc624d661f23978b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157345
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-05 20:47:59 +00:00
pq 865495fd6e bulk fix for prefer_single_quotes 
Change-Id: Ida0db0118948115042ebac65b4a8a3438a1b09bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157403
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-05 20:17:39 +00:00
pq 207b68d5b4 bulk fix for prefer_if_elements_to_conditional_expressions 
Change-Id: I7b76d437d948680729150e7c5eef99efac3567d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-05 19:11:29 +00:00
Konstantin Shcheglov ebd5b622ba Add DartSdk.languageVersion 
Bug: https://github.com/dart-lang/build/issues/2763#issuecomment-666707445
Change-Id: I8232bd395abc9efea0e5c27716450d6a5442b3bb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156489
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-04 21:01:09 +00:00
pq e41b4c1357 bulk fix for prefer_is_not_empty 
Change-Id: I9188d344f03823d4ab2d7eb46f134910d271e527
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157062
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 18:24:49 +00:00
pq af8767e9c8 bulk fix for prefer_is_empty 
Change-Id: I5c4cdb5b87ccbab8e257a45c33fe78d2d41923e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 17:17:19 +00:00
pq bd65d441f5 bulk fix for prefer_conditional_assignment 
Change-Id: I45e979bc00da0d8a5a8a257ce0fbd484137c143d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-04 02:01:13 +00:00
Brian Wilkerson 0a19e8dbfe Add test requested in earlier CL 
Change-Id: I112004e06150ed913d64b77f272a4ae85c6ef61a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156926
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-03 23:53:23 +00:00
pq 43c68d782d bulk fix for prefer_adjacent_string_concatenation 
Change-Id: I873d3531307a9685dc0950aa2fc2119af5abdd0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156925
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 22:40:07 +00:00
pq 2bf777ea6e bulk fix for omit_local_variable_types 
Change-Id: I1cc6eb6c7423ded3c5694728271cec52341ff98a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 20:59:31 +00:00
pq 987c9e347c bulk fix for null_closures 
Change-Id: I20e57da5b95868551216b9b0a095e82116c3585e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 19:14:22 +00:00
Brian Wilkerson ac79402072 remove-duplicate-case should not remove statements if there are cases that fall through to them 
Change-Id: I2094335d06e62eeb184f78b14e6028fdb5341dba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156849
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-03 18:50:21 +00:00
pq d427ab510d bulk fix for no_duplicate_case_values 
Change-Id: I4925113c44d5042062ccaabea680a07eedf7bfdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156848
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-08-03 18:11:51 +00:00
Brian Wilkerson 4121cf3cb4 Add a quick fix to add a null check operator 
Change-Id: Ie85ab236015057c2cb0255cc1548605e5b01e908
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156783
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2020-08-01 01:17:11 +00:00
Konstantin Shcheglov 28c20c0861 Fix for crash in ReplaceCascadeWithDot, simplify it. 
R=brianwilkerson@google.com

Change-Id: I3243203e42856b6a4e65603aafb708473bdfe3fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156701
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-08-01 00:32:01 +00:00
pq 5553dcbea7 bulk fix for hash_and_equals 
Change-Id: Ifbca2871bbf90f8c1ea3e3ae6dd6ef9e8b5b00c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156780
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 22:28:20 +00:00
Brian Wilkerson dc908e076b Do not suggest an explicit cast when the only difference is the nullability of the type 
Change-Id: Ibb20fd5d3ced4ca13bb604bbe42eced16903de9e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156723
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
 2020-07-31 19:00:20 +00:00
Brian Wilkerson 4776ac1f89 Fix a couple of recently introduced hints 
Change-Id: I68b653ea44e548a2789f7e720d6abfddb7cfb08c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156721
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-31 17:33:58 +00:00
Konstantin Shcheglov dfb3720cda Changes to analysis_server/ to be compatible with the breaking changes to analyzer/. 
Change-Id: I606072798633601d78f38c0035b579d93875ef3e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-31 17:04:58 +00:00
pq 4894e34f1f bulk fix for empty_statements 
Change-Id: I92c2dd5333d9b505a2c37b5936199895ab928fad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 16:27:10 +00:00
pq b10f22c7f5 bulk fix for empty_constructor_bodies 
Change-Id: Iffd3b80e6316372986374dc6b66cae24bd287dfa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156604
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 14:30:00 +00:00
pq 2dca5ad318 bulk fix for empty_catches 
Change-Id: Ia1cc3aefd79968bba0ff43f7ac9016e68ee2195a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156600
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-31 01:29:45 +00:00
pq 2b51d59e69 bulk fix for use_curly_braces 
Change-Id: Ia1a9fdde3d283cab94455aa4277d26e2d09998cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156586
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-31 00:02:24 +00:00
pq f640e58e45 bulk fix for await_only_futures 
Change-Id: Ic643ef1fd0e8374ecce7fffff34fc9b6f7e8550c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-30 21:26:04 +00:00
Konstantin Shcheglov 0a06e86e57 Test that prefix based filtering in Cider does not use following identifier. 
Change-Id: Ieb37a1adce3ab2fb7bdc49fcb1d263b3940fd1e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-30 17:34:18 +00:00
Danny Tuppeny 6762f2294c Tweak parser to handle LSP 3.16 spec 
Change-Id: I53ef27f4b9dc9c4f6a8ff54e116dd3d2a9faf65c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156506
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-30 15:49:28 +00:00
Danny Tuppeny 38fa4aea17 Don't use whole identifier as completion targetPrefix if it's after the cursor 
Bug: https://github.com/Dart-Code/Dart-Code/issues/2672
Change-Id: I45ccc00990495ddd9fa8881d673a45bf6c4f82d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <danny@tuppeny.com>
 2020-07-30 13:58:28 +00:00
Konstantin Shcheglov e60a0315dd Fix for crash in RemoveEmptyConstructorBody. 
R=brianwilkerson@google.com

Change-Id: I0fe17e9fe96028c5286f509c3bf9ec16248f4841
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2020-07-29 22:01:59 +00:00
pq e12a536edb bulk fix for avoid_types_on_closure_parameters 
Change-Id: Id080559bc2a18fd8ce4c8eb59412c4461d8dac39
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2020-07-29 19:45:25 +00:00
Brian Wilkerson 15fb170ffb Enable the new code completion relevance feature 
The new feature will be enabled by default but the option still exists
so that users can disable it if they want/need to.

Change-Id: I9e001b00b5dfe132a6b7bcfdcacd3143fb24f65c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156121
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2020-07-29 17:14:44 +00:00
pq e2f0cbc4d6 bulk fix for avoid_return_types_on_setters 
Change-Id: I29465e1a33be384948015682725b3e8f8db99bb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-29 16:03:16 +00:00
pq 1324146fb4 bulk fix for avoid_redundant_argument_values 
Change-Id: Id7dacf56d72acecfbd0f862585e68d93f2c22d55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-29 15:11:13 +00:00
pq 89504b4e84 bulk fix for avoid_empty_else 
Change-Id: I5ec1f4c1223aba42e972b78a3c31cc7c2f71c23e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156141
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-29 00:43:31 +00:00
pq 1a28fb28c8 bulk fix for avoid_annotating_with_dynamic 
Change-Id: I29815825e65f51f3db8ec2320412f9926abd0a92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156123
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-28 22:10:55 +00:00
Konstantin Shcheglov 78bcab9428 Fix for NPE when REMOVE_UNUSED_PARAMETER in invalid code. 
R=brianwilkerson@google.com

Change-Id: Ida985d86e062d6c62efa2ae8a394f75a239644e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156068
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-07-28 21:24:06 +00:00